summaryrefslogtreecommitdiffstats
path: root/chromeos/network/onc
Commit message (Collapse)AuthorAgeFilesLines
* Use scoped_ptrs in JSONReader::Read functions.estade2015-05-222-2/+2
| | | | | | | | | | | | | | | | | | | | There are many callers, so all could not be updated at once. The old version is renamed to JSONReader::DeprecatedRead, and a new version of JSONReader::Read that returns scoped_ptr takes its place. Much of this patch was generated with sed. Some callsites of the form scoped_ptr<Value> value(Read()); have been updated to scoped_ptr<Value> value = Read(); but most Read() calls are simply converted to DeprecatedRead. Actually updating them is a TODO. BUG=none Review URL: https://codereview.chromium.org/1136643005 Cr-Commit-Position: refs/heads/master@{#331120}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-161-1/+1
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Add ONC property for EAP-GTC authenticationpstew2015-05-122-1/+4
| | | | | | | | | BUG=486738 R=stevenjb@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/1137633003 Cr-Commit-Position: refs/heads/master@{#329291}
* Add an ONC property for proactive key caching with documentation.mattwein2015-04-242-0/+3
| | | | | | | | | BUG=475699 TEST=None Review URL: https://codereview.chromium.org/1085703002 Cr-Commit-Position: refs/heads/master@{#326738}
* Rename USE_NSS to USE_NSS_CERTS.davidben2015-04-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | USE_NSS is confusing because it's not actually the analog of USE_OPENSSL; it's the analog to USE_OPENSSL_CERTS. This is in preparation for the chimera build which will set USE_OPENSSL and USE_NSS(_CERTS). This CL was partially done automatically by the following command: git grep -l USE_NSS | xargs sed -i -e 's/defined(USE_NSS)/defined(USE_NSS_CERTS)/' The remaining were caught by the following command and fixed manually: git grep 'USE_NSS\([^_]\|$\)' Finally, the following command verified nothing in a separate repository was sensitive to this change: find . -name '*.cc' -o -name '*.h' | xargs grep 'USE_NSS\([^_]\|$\)' For now, the old name is still defined, but not used within Chromium. A follow-up CL will remove deprecated use_nss and USE_NSS #defines together which will then cause downstream churn. Though from a grep of known downstreams, the churn seems to be fairly minimal. The removal is split from this CL so that, if we need to revert, the CL to revert is small. TBR=pneubeck@chromium.org BUG=462040 Review URL: https://codereview.chromium.org/1082123003 Cr-Commit-Position: refs/heads/master@{#325710}
* Add an ONC property for setting per-network roam thresholdsamueltan2015-04-162-0/+2
| | | | | | | | | | | This CL maps an ONC property for setting per-network roam threshold. BUG=chrome-os-partner:38681 TEST=Expanded test ONC and JSON test sets Review URL: https://codereview.chromium.org/1087353002 Cr-Commit-Position: refs/heads/master@{#325515}
* Use networkingPrivate.startConnect (Take 2)stevenjb2015-04-164-22/+48
| | | | | | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. Original CL (reverted for unrelated failure): https://codereview.chromium.org/1043343002/ BUG=430115 TBR=michaelpg, pneubeck, mpearson@chromium.org Review URL: https://codereview.chromium.org/1091043002 Cr-Commit-Position: refs/heads/master@{#325484}
* Revert of Use networkingPrivate.startConnect (patchset #12 id:240001 of ↵mpearson2015-04-144-48/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1043343002/) Reason for revert: Causes browser_test failure on Win7 bot. https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1) [ RUN ] WebNavigationApiTest.Failures [4444:4508:0414/144708:WARNING:data_reduction_proxy_config.cc(319)] SPDY proxy OFF at startup [4444:2028:0414/144708:ERROR:bluetooth_adapter_win.cc(102)] NOT IMPLEMENTED [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x5) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 2147483650, remote ID 3) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x3B01) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [4444:2028:0414/144709:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframe", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframeNavigation", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[FAIL] cancel: Received unexpected event 'onCompleted':{"frameId":0,"processId":0,"tabId":0,"timeStamp":0,"url":"chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/e.html"} Error at captureEvent (chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:194:17) at chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:219:5 at EventImpl.dispatchToListener (extensions::event_bindings:395:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistent", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\extensions\api\web_navigation\web_navigation_apitest.cc(468): error: Value of: RunExtensionTest("webnavigation/failures") Actual: false Expected: true Failed 1 of 4 tests [4444:2028:0414/144710:ERROR:browser_thread.h(263)] DeleteSoon failed on thread 0 [ FAILED ] WebNavigationApiTest.Failures, where TypeParam = and GetParam() = (2465 ms) Original issue's description: > Use networkingPrivate.startConnect > > This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. > It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. > > BUG=430115 > > Committed: https://crrev.com/e22e5bcbad2cea941993b32e6cc3b082822a42fc > Cr-Commit-Position: refs/heads/master@{#325108} TBR=armansito@chromium.org,michaelpg@chromium.org,pneubeck@chromium.org,stevenjb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=430115 Review URL: https://codereview.chromium.org/1085993002 Cr-Commit-Position: refs/heads/master@{#325145}
* Use networkingPrivate.startConnectstevenjb2015-04-144-22/+48
| | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. BUG=430115 Review URL: https://codereview.chromium.org/1043343002 Cr-Commit-Position: refs/heads/master@{#325108}
* Implement networkingPrivate.getDeviceStatesstevenjb2015-04-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | This is needed for the internet Settings UI to replace the following properites passed using chrome.send(). It will also be used in the new Settings UI to improve the UI for uninitalized and enabling technologies. cellularAvailable cellularEnabled wifiAvailable wifiEnabled wimaxAvailable wimaxEnabled BUG=465418 For chrome_browser_main_extra_parts_profiles.cc: TBR=skuhne@chromium.org Review URL: https://codereview.chromium.org/1059033002 Cr-Commit-Position: refs/heads/master@{#324643}
* Replace Settings cellular carrier and activation with networkingPrivatestevenjb2015-04-094-0/+26
| | | | | | | | | | | | This uses the recent networkingPrivate changes to support setting Cellular.Carrier in setProperties and adding startActivate in internet_details.js. BUG=430115 Review URL: https://codereview.chromium.org/1046593003 Cr-Commit-Position: refs/heads/master@{#324490}
* Add an ONC property for disabling LCP echopstew2015-04-062-6/+8
| | | | | | | | | | | | This CL maps an ONC property for disabling L2TP connection monitoring via PPP LCP frames. BUG=463602 TEST=Expanded test ONC and JSON test sets Review URL: https://codereview.chromium.org/1058973002 Cr-Commit-Position: refs/heads/master@{#323943}
* Call Device.SetCarrier when the ONC Carrier property is specified.stevenjb2015-03-312-3/+3
| | | | | | | | | | BUG=464036 For minor change to .idl: TBR=asargent@chromium.org Review URL: https://codereview.chromium.org/1028243007 Cr-Commit-Position: refs/heads/master@{#322951}
* Add NetworkTechnology types to ONCstevenjb2015-03-263-1/+21
| | | | | | | | | | This also adds the network technology 1x badge to cr_network_icon BUG=470282 Review URL: https://codereview.chromium.org/1033843003 Cr-Commit-Position: refs/heads/master@{#322409}
* Format ONC translation filesstevenjb2015-03-265-573/+565
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1031253002 Cr-Commit-Position: refs/heads/master@{#322338}
* Cleanup onc_utils.cc to current style.pneubeck2015-03-241-64/+57
| | | | | | | | | In particular use the new components/device_event_log/device_event_log.h . No functional change. Review URL: https://codereview.chromium.org/1030603002 Cr-Commit-Position: refs/heads/master@{#321958}
* Fix a case of writing an empty HexSSID to Shill.pneubeck2015-03-231-7/+12
| | | | | | | | This surfaced when trying to connect to a fake network setup by fake_shill_manager_client.cc. Review URL: https://codereview.chromium.org/1023273004 Cr-Commit-Position: refs/heads/master@{#321783}
* Add an ONC property for the third-party VPN provider extension IDbartfab2015-03-189-13/+82
| | | | | | | | | | | | This CL maps the third-party VPN provider extension ID (which is stored in shill's |Provider.Host| field) to an ONC property. BUG=460428 TEST=Extended unit tests and API test Review URL: https://codereview.chromium.org/1019033002 Cr-Commit-Position: refs/heads/master@{#321238}
* Split ValueSerializer into separate Serializer and Deserializer classes.prashhir2015-03-051-3/+3
| | | | | | | | | | | | | This CL removes the Deserializer functionality from ValueSerializer, and puts into separate class ValueDeserializer, so that class responsibility is maintained. BUG=455453 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/925783002 Cr-Commit-Position: refs/heads/master@{#319239}
* Add WiMAX to ONC validation liststevenjb2015-02-264-4/+22
| | | | | | | | | | | | | Currently type WiMAX fails ONC validation so any property changes from Settings are ignored. This also fixes the Cellular translation and adds both Cellular and WiMAX to the validation tests. BUG=460829 Review URL: https://codereview.chromium.org/949783003 Cr-Commit-Position: refs/heads/master@{#318162}
* Better support for Cellular roaming state in ONCstevenjb2015-02-253-20/+25
| | | | | | | | | | | | | | This CL does the following: * Eliminates "ProviderRequiresRoaming" from ONC * Adds a "required" state to "RoamingState" in ONC when ProviderRequiresRoaming is true * Adds "ONC State" to chrome://network for testing networkingPrivate.getState() * Adds support for shill_stub=roaming=[home|roaming|required] to facilitate testing on Linux BUG=461163 Review URL: https://codereview.chromium.org/948943003 Cr-Commit-Position: refs/heads/master@{#318113}
* Remove duplicate includes from chromeos/pneubeck2015-02-252-3/+0
| | | | | | | | | | | | This removes all includes from $X.cc files where the $X.h has the same include to conform to the style guide: "[...] However, any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes)." BUG=460988 Review URL: https://codereview.chromium.org/947173002 Cr-Commit-Position: refs/heads/master@{#318002}
* Add SignalStrength to Cellular ONCstevenjb2015-02-122-0/+2
| | | | | | | | BUG=455872 Review URL: https://codereview.chromium.org/917553002 Cr-Commit-Position: refs/heads/master@{#316005}
* Introduce NetworkState::is_captive_portal()stevenjb2015-01-271-2/+2
| | | | | | | | | | For c/b/ui/webui/chromeos/login/network_state_informer.cc TBR=nkostylov@chromium.org BUG=450364 Review URL: https://codereview.chromium.org/873713004 Cr-Commit-Position: refs/heads/master@{#313311}
* Elim device log spam when translating ONCstevenjb2015-01-231-1/+1
| | | | | | | | | | | | This also updates the logging in shiil_property_util to use device_event_log.h. TBR=isherman@chromium.org for trivial change BUG=none Review URL: https://codereview.chromium.org/819583004 Cr-Commit-Position: refs/heads/master@{#312937}
* Update {virtual,override,final} to follow C++11 style in chromeos/network.dcheng2015-01-208-47/+41
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=gauravsh@chromium.org Review URL: https://codereview.chromium.org/799753007 Cr-Commit-Position: refs/heads/master@{#312270}
* Provide GUID in ONC for all networks in ManagedNetworkConfigurationHandlerstevenjb2015-01-151-9/+11
| | | | | | | | BUG=448445 Review URL: https://codereview.chromium.org/821643005 Cr-Commit-Position: refs/heads/master@{#311747}
* Fix ONC logic errorstevenjb2015-01-131-2/+3
| | | | | | | | | | | | | | A bug in onc_translator_onc_to_shill.cc is triggering a DCHECK when a property is set in a previously non-existent dictionary. This is a trivial fix to code that is subtle but clearly incorrect by inspection. BUG=none Review URL: https://codereview.chromium.org/838043003 Cr-Commit-Position: refs/heads/master@{#311357}
* ONC: Use HexSSID instead of SSID.pneubeck2015-01-138-45/+74
| | | | | | | | | | | | | | - Comparison of a network policy with network will use HexSSID now. - Translation from ONC to Shill now copies the HexSSID instead of translating SSID. - Fix ONC validation of HexSSID/SSID to be case insensitive. - When setting an ONC: SSID will be ignored if HexSSID is present - Reading network properties reports a HexSSID in ONC. BUG=432546 Review URL: https://codereview.chromium.org/823633004 Cr-Commit-Position: refs/heads/master@{#311281}
* chromeos networking: move from security to securityclass propertyquiche2015-01-094-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Adopt shill's kSecurityClassProperty, in place of shill's kSecurityProperty. This eliminates the need for Chrome to understand the equivalence of WPA and RSN networks. This CL introduces only one functional change. Namely, NetworkState::GetSpecifier will now collapse WPA and RSN networks into one class (by virtue of using kSecurityClassProperty). The previous behavior is considered a bug. After this CL, only WifiAccessPointInfoProviderChromeOs still uses kSecurityProperty. In that one case, we want to break out WPA and RSN networks, to understand what fraction of systems are connecting through older APs. While there: remove a couple of unused files in chromeos/test/data/network/policy/. BUG=chromium:440032 TEST=ManagedNetworkConfigurationHandlerTest.* TEST=ONC* Review URL: https://codereview.chromium.org/788633003 Cr-Commit-Position: refs/heads/master@{#310840}
* Use setProperties for IP Config.stevenjb2015-01-081-4/+6
| | | | | | | | | | | | | | This changes the settings UI to use networkingPrivate.setProperties for setting IP config related properties. It is dependent on the ONC changes in https://codereview.chromium.org/749013003/. BUG=430113 For components/wifi/fake_wifi_service.cc (test expecations): TBR=mef@chromium.org Review URL: https://codereview.chromium.org/708563005 Cr-Commit-Position: refs/heads/master@{#310617}
* ONC: Add IPAddressConfigType and NameServersConfigTypestevenjb2015-01-078-4/+91
| | | | | | | | | | | | | | | This CL introdcues IPAddressConfigType and NameServersConfigType If either of these is set to 'Static', a 'StaticIPConfig' object must be provided and must specify any non-default configuration. If neither is set to 'Static', the StaticIPConfig object will be ignored. Originally uploaded as https://codereview.chromium.org/750313003/ BUG=411289 Review URL: https://codereview.chromium.org/749013003 Cr-Commit-Position: refs/heads/master@{#310325}
* ONC: Remove the top level fields NameServers and SearchDomains.pneubeck2015-01-053-15/+4
| | | | | | | | | | | These were unused and unsupported and conflict upcoming changes. Also clean up some IPConfig documentation and adapt the validation. BUG=411289 Review URL: https://codereview.chromium.org/830133003 Cr-Commit-Position: refs/heads/master@{#309942}
* ONC: add support for non-utf-8 SSIDscschuet2014-12-049-4/+154
| | | | | | | | | | | | | | ONC currently uses strings to represent SSIDs. Since JSON-Schema strings are restricted to Unicode and ONC is encoding these as UTF-8, this means that ONC cannot be used to represent SSIDs that include non-UTF-8 strings. This change adds a separate HexSSID field to the WiFi section of the ONC that expects an SSID byte sequence encoded in hex. At least one of the fields HexSSID or SSID must be present. If both HexSSID and SSID are set, the values must be consistent. BUG=432546 Review URL: https://codereview.chromium.org/759663004 Cr-Commit-Position: refs/heads/master@{#306838}
* Reland: Change to Shill's IPConfig objects.stevenjb2014-12-034-68/+37
| | | | | | | | | | | | | | | | Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty. This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary. This also makes the translation between a list of nameservers and a comma-separated string obsolete. Original Review URL: https://codereview.chromium.org/762243002 BUG=411289 TBR=pneubeck@chromium.org Review URL: https://codereview.chromium.org/778693004 Cr-Commit-Position: refs/heads/master@{#306669}
* Shill to ONC translation for thirdpartyvpnkaliamoorthi2014-12-022-2/+4
| | | | | | | | | | | | | ONC does not understand thirdpartyvpn. This results in VPN host being set to undefined during disconnect, rendering third party VPN configurations unusable after disconnect. This CL adds partial support in ONC layer for third party VPN to solve this problem. BUG=407541 Review URL: https://codereview.chromium.org/762113005 Cr-Commit-Position: refs/heads/master@{#306413}
* Revert of Change to Shill's IPConfig objects. (patchset #1 id:1 of ↵pfeldman2014-12-024-37/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/762243002/) Reason for revert: Breaks the build: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/7051 Original issue's description: > Change to Shill's IPConfig objects. > > Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty. > This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary. > > This also makes the translation between a list of nameservers and a comma-separated string obsolete. > > BUG=411289 > > Committed: https://crrev.com/ac2d359b101e4c97455125958db4a999bf26135f > Cr-Commit-Position: refs/heads/master@{#306400} TBR=stevenjb@chromium.org,pneubeck@chromium.org NOTREECHECKS=true NOTRY=true BUG=411289 Review URL: https://codereview.chromium.org/776603002 Cr-Commit-Position: refs/heads/master@{#306412}
* Change to Shill's IPConfig objects.pneubeck2014-12-024-68/+37
| | | | | | | | | | | | | Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty. This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary. This also makes the translation between a list of nameservers and a comma-separated string obsolete. BUG=411289 Review URL: https://codereview.chromium.org/762243002 Cr-Commit-Position: refs/heads/master@{#306400}
* Add 'setProperties' to InternetOptionsHandlerstevenjb2014-11-191-3/+4
| | | | | | | | | | | Replaces simple custom setters with setProperties call, matching the networkingPrivate API. BUG=430113 Review URL: https://codereview.chromium.org/694533007 Cr-Commit-Position: refs/heads/master@{#304780}
* Fix comment in ONCTranslator from ONC to Shill.pneubeck2014-11-181-4/+4
| | | | | | | | BUG=NONE Review URL: https://codereview.chromium.org/740453002 Cr-Commit-Position: refs/heads/master@{#304656}
* ONC: Don't consider missing fields a warning if explicitly requested.pneubeck2014-11-143-135/+195
| | | | | | | | BUG=430113 Review URL: https://codereview.chromium.org/724763003 Cr-Commit-Position: refs/heads/master@{#304198}
* Don't crash on empty network type.pneubeck2014-11-142-13/+12
| | | | | | | | | | Also document more clearly that a wrong type of 'Recommended' doesn't cause an error or crash. BUG=430113 Review URL: https://codereview.chromium.org/723153002 Cr-Commit-Position: refs/heads/master@{#304128}
* Cleanup: Remove unneeded path_service.h includes.thestig2014-11-061-1/+0
| | | | | | Review URL: https://codereview.chromium.org/689563002 Cr-Commit-Position: refs/heads/master@{#303095}
* Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.dcheng2014-10-161-2/+2
| | | | | | | | BUG=423621 Review URL: https://codereview.chromium.org/660663003 Cr-Commit-Position: refs/heads/master@{#299949}
* Add OpenVPN OTP and UserAuthenticationType fields to ONC.pneubeck2014-10-076-36/+101
| | | | | | | | | | | | | | Reland of https://codereview.chromium.org/560863002/ which the CQ failed to commit correctly. This does not adapt the UI to respect the policy's UserAuthenticationType, yet. BUG=347916 TBR=stevenjb@chromium.org TEST=Ensured that a previously working policy pushed OpenVPN network still works. Review URL: https://codereview.chromium.org/632223002 Cr-Commit-Position: refs/heads/master@{#298431}
* Allow option to disable link monitor for WiFi networkzqiu2014-10-073-0/+17
| | | | | | | | | | | | By default, link monitor is enabled for WiFi network. When it is enabled, it will send ARP request to default gateway periodically. This CL adds an ONC configuration option to disable the link monitor. BUG=chromium:415367 Review URL: https://codereview.chromium.org/598173002 Cr-Commit-Position: refs/heads/master@{#298327}
* replace OVERRIDE and FINAL with override and final in chromeos/mostynb2014-10-067-15/+15
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/628883002 Cr-Commit-Position: refs/heads/master@{#298229}
* Make ONCCertificateImporter async.pneubeck2014-09-246-217/+234
| | | | | | | | | | | | | | | | | | | | 2nd Reland of https://codereview.chromium.org/547553005/ after fixing memory issues. This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. Now, the import itself is asychronous and calls back on completion. While there, this also removes the GMock of the importer. BUG=413219 TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/600803002 Cr-Commit-Position: refs/heads/master@{#296405}
* Translate Wimax from Shill -> ONC, fix JS Wimax strings.stevenjb2014-09-192-0/+13
| | | | | | | | | | | | This is a follow up CL for 414417 that includes the ONC translation necessary for the Wimax UI and fixes the JS to use the new WiMAX capitalization. It also adds a WiMAX entry to the HTML doc. BUG=414417 Review URL: https://codereview.chromium.org/581213003 Cr-Commit-Position: refs/heads/master@{#295774}
* Revert of Make ONCCertificateImporter async. (patchset #1 id:1 of ↵eugenis2014-09-196-234/+217
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/582413002/) Reason for revert: Use-after-free. https://code.google.com/p/chromium/issues/detail?id=415916 Original issue's description: > Make ONCCertificateImporter async. > > This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ > Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. > Now, the import itself is asychronous and calls back on completion. > > While there, this also removes the GMock of the importer. > > This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925 > refs/heads/master@{#295534} > with the fixed destruction order in ONCCertificateImporterImplTest. > > The fix was reviewed in > https://codereview.chromium.org/589443002/ > > TBR=eroman@chromium.org > BUG=413219 > > Committed: https://crrev.com/3b4ba221657f6b27e2156818bc445c885d87fc0e > Cr-Commit-Position: refs/heads/master@{#295687} TBR=joaodasilva@chromium.org,eroman@chromium.org,pneubeck@chromium.org NOTREECHECKS=true NOTRY=true BUG=413219 Review URL: https://codereview.chromium.org/584923002 Cr-Commit-Position: refs/heads/master@{#295702}
generated by cgit v1.1 at 2024-07-05 14:21:30 +0000