summaryrefslogtreecommitdiffstats
path: root/chromeos/network/policy_applicator.cc
Commit message (Collapse)AuthorAgeFilesLines
* Use networkingPrivate.startConnect (Take 2)stevenjb2015-04-161-3/+3
| | | | | | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. Original CL (reverted for unrelated failure): https://codereview.chromium.org/1043343002/ BUG=430115 TBR=michaelpg, pneubeck, mpearson@chromium.org Review URL: https://codereview.chromium.org/1091043002 Cr-Commit-Position: refs/heads/master@{#325484}
* Revert of Use networkingPrivate.startConnect (patchset #12 id:240001 of ↵mpearson2015-04-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1043343002/) Reason for revert: Causes browser_test failure on Win7 bot. https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1) [ RUN ] WebNavigationApiTest.Failures [4444:4508:0414/144708:WARNING:data_reduction_proxy_config.cc(319)] SPDY proxy OFF at startup [4444:2028:0414/144708:ERROR:bluetooth_adapter_win.cc(102)] NOT IMPLEMENTED [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x5) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 2147483650, remote ID 3) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x3B01) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [4444:2028:0414/144709:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframe", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframeNavigation", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[FAIL] cancel: Received unexpected event 'onCompleted':{"frameId":0,"processId":0,"tabId":0,"timeStamp":0,"url":"chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/e.html"} Error at captureEvent (chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:194:17) at chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:219:5 at EventImpl.dispatchToListener (extensions::event_bindings:395:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistent", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\extensions\api\web_navigation\web_navigation_apitest.cc(468): error: Value of: RunExtensionTest("webnavigation/failures") Actual: false Expected: true Failed 1 of 4 tests [4444:2028:0414/144710:ERROR:browser_thread.h(263)] DeleteSoon failed on thread 0 [ FAILED ] WebNavigationApiTest.Failures, where TypeParam = and GetParam() = (2465 ms) Original issue's description: > Use networkingPrivate.startConnect > > This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. > It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. > > BUG=430115 > > Committed: https://crrev.com/e22e5bcbad2cea941993b32e6cc3b082822a42fc > Cr-Commit-Position: refs/heads/master@{#325108} TBR=armansito@chromium.org,michaelpg@chromium.org,pneubeck@chromium.org,stevenjb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=430115 Review URL: https://codereview.chromium.org/1085993002 Cr-Commit-Position: refs/heads/master@{#325145}
* Use networkingPrivate.startConnectstevenjb2015-04-141-3/+3
| | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. BUG=430115 Review URL: https://codereview.chromium.org/1043343002 Cr-Commit-Position: refs/heads/master@{#325108}
* Remove duplicate includes from chromeos/pneubeck2015-02-251-1/+0
| | | | | | | | | | | | This removes all includes from $X.cc files where the $X.h has the same include to conform to the style guide: "[...] However, any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes)." BUG=460988 Review URL: https://codereview.chromium.org/947173002 Cr-Commit-Position: refs/heads/master@{#318002}
* ManagedNetworkConfigurationHandler: Expose status about policy application.pneubeck2014-10-291-36/+60
| | | | | | | | | | | Before, it was hard or impossible to track whether a policy application is currently running. Now a notification (PoliciesApplied) and the current status (AnyPolicyApplicationRunning) are exposed. BUG=425049 Review URL: https://codereview.chromium.org/661803005 Cr-Commit-Position: refs/heads/master@{#301817}
* Add ONC 'Source' configuration propertySteven Bennetts2014-09-111-0/+1
| | | | | | | | | | | | This also includes a bit of JS cleanup to use ONC properties directly where possible. BUG=279351 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/552113002 Cr-Commit-Position: refs/heads/master@{#294462}
* Apply global auto connect ONC policy in GetManagedProperties.pneubeck2014-09-031-41/+18
| | | | | | | | BUG=279351 Review URL: https://codereview.chromium.org/510123004 Cr-Commit-Position: refs/heads/master@{#293091}
* Renaming CreateShillConfiguration argument for clarification.pneubeck2014-08-281-1/+2
| | | | | | | | | | Renaming from 'settings' to the more informative 'user_settings'. BUG=NONE Review URL: https://codereview.chromium.org/513143004 Cr-Commit-Position: refs/heads/master@{#292407}
* ONC: Cleanup client certificate related fields.pneubeck@chromium.org2014-07-081-1/+1
| | | | | | | | | | | | | | | | | Before, each network type had its own constants for ClientCert{Type,Pattern,Ref} which lead to duplicate implementations. These constants are now unified into the namespace onc::client_cert together with the other client certificate related constants. This leads to a clearer separation from the Certificate ONC object (has namespace onc::certificate) and simplifies some code (see network_ui_data.cc and onc_validator.cc). BUG=391292 (For trivial constant renaming:) TBR=mef@chromium.org,vitalybuka@chromium.org Review URL: https://codereview.chromium.org/368233004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281820 0039d316-1c4b-4281-b951-d872f2087c98
* Move NetworkTypePattern to its own filestevenjb@chromium.org2014-05-281-0/+1
| | | | | | | | | | | | BUG=none For trivial apps/shell/browser/ change: R=pneubeck@chromium.org TBR=derat@chromium.org Review URL: https://codereview.chromium.org/300623008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273352 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NULL pointer dereference in PolicyApplicator.pneubeck@chromium.org2014-03-111-1/+2
| | | | | | | | BUG=350586 Review URL: https://codereview.chromium.org/194603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256347 0039d316-1c4b-4281-b951-d872f2087c98
* Fix updating network lists after removal of policy from a network.pneubeck@chromium.org2014-01-151-4/+29
| | | | | | | | | | | | | If a visible network was removed from policy, the UI didn't update correctly and continued to show the old network as managed. The problem was in the favorite list not correctly updating. Additionally, there was a potential subtle bug in PolicyApplicator, if the SSID of a Wifi network is changed in policy. Now, it's ensured that at first all profile entries are removed and then the new configuration is written to Shill. BUG=278101 Review URL: https://codereview.chromium.org/107733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244943 0039d316-1c4b-4281-b951-d872f2087c98
* ONC policy: Support SSID and Security change.pneubeck@chromium.org2013-11-151-21/+28
| | | | | | | | | | | | | | | | If the SSID of a ONC policy is changed without changing the GUID, this lead to a partial policy application where everything except the SSID is changed. This happened because Shill doesn't allow changes of the SSID property after the network creation but the policy application code didn't respect that. With this change, it's ensured that the respective network configuration (profile entry), is deleted and rewritten on each SSID change. The same applies to the Security type of the network. BUG=319362 R=bartfab@chromium.org Review URL: https://codereview.chromium.org/68213018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235410 0039d316-1c4b-4281-b951-d872f2087c98
* Autoconnect policy for CrOS.pneubeck@chromium.org2013-10-211-8/+52
| | | | | | | | | | | | | | | | | | | This adds an autoconnect policy that disables autoconnect of unmanaged networks. As a device policy this applies to all shared networks. As a user policy it applies to all networks of this user. With this commit the policy is applied on each restart and login. UI lockdown is still missing. Configurations affecting several networks were not supported previously by ONC. Therefore, this commit adds the new toplevel section "GlobalNetworkConfiguration" to ONC. BUG=280146 For API change: R=bartfab@chromium.org TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/23526016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229910 0039d316-1c4b-4281-b951-d872f2087c98
* Moved onc_constants.* from chromeos/network/onc to components/onc.mef@chromium.org2013-10-081-10/+11
| | | | | | | | BUG=267667 Review URL: https://codereview.chromium.org/24600003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227495 0039d316-1c4b-4281-b951-d872f2087c98
* Add an Ethernet EAP policy.pneubeck@chromium.org2013-10-021-0/+16
| | | | | | | | | | | | This is the last change required to enable the Ethernet EAP policy on ChromeOS. BUG=126870 (For preferences_browsertest.cc) TBR=nkostylev@chromium.org Review URL: https://codereview.chromium.org/23451044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226444 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate DBus service constants from flimflam namespace to shill namespace.benchan@chromium.org2013-09-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | All shill DBus service constants have been moved from the flimflam namespace to the shill namespace. This CL makes the corresponding changes on the Chrome side. Related CLs: https://chromium-review.googlesource.com/#/c/170123/ https://chromium-review.googlesource.com/#/c/170205/ https://chromium-review.googlesource.com/#/c/170206/ https://chromium-review.googlesource.com/#/c/170207/ https://chromium-review.googlesource.com/#/c/170208/ https://chromium-review.googlesource.com/#/c/170209/ https://chromium-review.googlesource.com/#/c/170223/ https://chromium-review.googlesource.com/#/c/170230/ https://chromium-review.googlesource.com/#/c/170231/ BUG=295425 R=gspencer@chromium.org,gauravsh@chromium.org,stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/24348002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224942 0039d316-1c4b-4281-b951-d872f2087c98
* Separate PolicyApplicator from ManagedNetworkConfigurationHandler.pneubeck@chromium.org2013-09-051-0/+251
This makes the dependency between the two classes explicit and more manageable. Pure refactoring, no functional change. BUG=279268 (for chromeos/chromeos.gyp) TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/23522004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221435 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 16:07:23 +0000