| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
CashewClient has been deprecated and should be removed.
BUG=162717
Review URL: https://codereview.chromium.org/11299246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds verbose(2) logging to network_event_log
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11280199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason why I introduced two different interfaces is that CandidateWindow and Property controllers are separated in Chrome.
CandidateWindowHandler is(will be) implemented by CandidateWindowController and PropertyHandler is(will be) implemented by IBusController.
BUG=158265
TEST=ran chromeos_unittests
Review URL: https://chromiumcodereview.appspot.com/11416172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146981
TEST=compile, open Drive on Files.app, and open and copy a file in Drive. "Drive*" and "GData" in unit_test and browser_tests pass.
Review URL: https://chromiumcodereview.appspot.com/11414152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11413176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a bit of cleanup I did while working in data plans support.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11417128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This does some cleanup to allow NetworkStateHandler to use the same error callback infrastructure as NetworkConfigurationHandler.
It also adds event logging for errors.
BUG=none
Review URL: https://codereview.chromium.org/11416149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This cl depends on https://codereview.chromium.org/11411063
BUG=140186
TEST=Manually done on lumpy with sample IME.
Review URL: https://chromiumcodereview.appspot.com/11299104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes Chrome observe the SuspendStateChanged D-Bus
signal that powerm now emits when we're suspending or
resuming. The old signal from powerd_suspend stopped
working since it was being sent by an unauthorized client.
BUG=chromium-os:36503
TEST=clock updates immediately after resuming
Review URL: https://codereview.chromium.org/11421046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a RootPowerManagerClient class for communicating
over D-Bus with the powerm process. I'm also updating
Chrome to use the power button events from powerm instead of
the ones from powerd.
BUG=chromium-os:36380,chromium-os:36503
Review URL: https://chromiumcodereview.appspot.com/11421023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=161294
TEST=DiskMountManagerTest* under valgrind/heapcheck
Review URL: https://chromiumcodereview.appspot.com/11416017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:35715
TEST=None
Review URL: https://chromiumcodereview.appspot.com/11416098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also extracts about_network from about_ui for the chrome://network UI, updating it for NetworkState and NetworkEventLog.
Additionally network event logs (and a dbus summary) are added to feedback reports)
BUG=161369
For chrome/browser/ui/webui/:
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11416041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
against the testserver.
BUG=108928
Review URL: https://chromiumcodereview.appspot.com/11414007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case of power state override being created and immidiatelly destructed, we'll have a scenario in which the correct power state request won't get cancelled.
e.g.,
. User creates PowerStateOverride instance -> We call RequestPowerStateOverride
- we wait for the callback from ChromeOS to get our request ID
. User deletes PowerStateOverride instance -> We call CancelPowerStateOverride with a 0 request ID
. We destruct, invalidating our weak pointers
. Callback from RequestPowerStateOverride never lands since the weakptr is invalidated
- Power state override remains in effect for the next 10 minutes.
This has now changed to,
. User creates PowerStateOverride instance -> We call RequestPowerStateOverride, this increments our reference count to 2
- we wait for the callback from ChromeOS to get our request ID
. User releases his refernce to PowerStateOverride instance -> We decrement our reference count to 1
. RequestPowerStateOverride returns, giving us our RequestID, and decrements our refernce count to 0
. Destructor gets called, which does a CancelPowerStateOverride with the correct request ID
- The PowerStateOverride is cancelled
R=derat@chromium.org
BUG=151732
Review URL: https://codereview.chromium.org/11358222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11308103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:35715
TEST=None
Review URL: https://chromiumcodereview.appspot.com/11360191
You had a green linux_chromeos try run, but unfortunately, clang is pickier:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20%28Clang%20dbg%29/builds/24522
TBR=mnissler@chromium.org
Review URL: https://codereview.chromium.org/11308106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:35715
TEST=None
Review URL: https://chromiumcodereview.appspot.com/11360191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sorry I misunderstand the infolist spec, infolist requires title field.
I split description field into description_title and description_body.
BUG=129403
TEST=ran chromeos_unittests
Review URL: https://chromiumcodereview.appspot.com/11362111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL, IBusObjectReader/IBusObjectWriter can read/write attachment field in IBusObject header field.
BUG=140186
TEST=ran chromeos_unittests
Review URL: https://chromiumcodereview.appspot.com/11361210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r168420 "chromeos/power: Refcounted types should not have public destructors."
Broke linux_chromeos_clang.
TBR=tfarina@chromium.org,derat@chromium.org,rkc@chromium.org
BUG=123295
Review URL: https://codereview.chromium.org/11415041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was broken this CL: https://chromiumcodereview.appspot.com/11358222/
BUG=123295
TBR=derat@chromium.org,rkc@chromium.org
Review URL: https://codereview.chromium.org/11413056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case of power state override being created and immidiatelly destructed, we'll have a scenario in which the correct power state request won't get cancelled.
e.g.,
. User creates PowerStateOverride instance -> We call RequestPowerStateOverride
- we wait for the callback from ChromeOS to get our request ID
. User deletes PowerStateOverride instance -> We call CancelPowerStateOverride with a 0 request ID
. We destruct, invalidating our weak pointers
. Callback from RequestPowerStateOverride never lands since the weakptr is invalidated
- Power state override remains in effect for the next 10 minutes.
This has now changed to,
. User creates PowerStateOverride instance -> We call RequestPowerStateOverride, this increments our reference count to 2
- we wait for the callback from ChromeOS to get our request ID
. User releases his refernce to PowerStateOverride instance -> We decrement our reference count to 1
. RequestPowerStateOverride returns, giving us our RequestID, and decrements our refernce count to 0
. Destructor gets called, which does a CancelPowerStateOverride with the correct request ID
- The PowerStateOverride is cancelled
R=derat@chromium.org
BUG=151732
Review URL: https://chromiumcodereview.appspot.com/11358222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that will eventually replace the NetworkLibrary method
of configuring networks.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11260047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds static Initialize() and Shutdown() metgods for NetworkStateHandler.
BUG=none
For about_flags:
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11316032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were formerly getting notified via D-Bus signal from the
power manager whenever the lock key on external Chrome OS
keyboards (F13) was pressed or released. This change makes
Chrome instead listen for F13 directly, which will allow
apps to override the F13 key when desired.
BUG=153951
TEST=lock key still works as before
Review URL: https://chromiumcodereview.appspot.com/11420009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes Chrome listen for "LivenessRequested" D-Bus signals
sent by the session manager and respond by calling the
session manager's "HandleLivenessConfirmed" method.
BUG=chromium-os:35729
Review URL: https://codereview.chromium.org/11360252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog.
(2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format:
<Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)>
Sample gallery names:
(1) 1GB TEST_USB
(2) 4GB DCIM - RED_USB
(3) 8KB PHOTOS - (TESTCOMPANY, A101)
(4) 4GB SD Card
(5) 16MB SD Card
Original Review CL: http://codereview.chromium.org/11366144/
Reverted CL: https://codereview.chromium.org/11363236/
BUG=159671, 158600
TEST=none
TBR=oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11365258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename DiskMountManager::Observer methods to On____Event format.
* Break up DiskMountManagerEventType enum.
* Add separate observer method for formatting events.
* Pass formatting event success using bool instead of adding '!' in front of the
path (but only in events from DiskMountManager; will remove it from
CrosDisksClient events in another patch).
* Add unit tests for formatting handling in DiskMountManager.
(TODO: add more tests)
TBR:vandebo@chromium.org
(for mechanical changes in chrome/browser/system_monitor)
BUG=157587, 126815
TEST=manual: formatting works (and Formatting pending notification goes away)
chromeos_unittests::DiskMountManagerTest.*
Review URL: https://chromiumcodereview.appspot.com/11365142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intention of this is to provide low overhead detailed logging to ensure that dbus call counts remain reasonable as we migrate NetworkLibrary and other systtems from src/chrome to src/chromeos.
We already have UMA stats which provide high level numbers that we can watch, but this will make detailed debugging available for advanced users and in feedback reports.
BUG=159635
For chrome/chrome_browser_chromeos.gypi:
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11363173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11366229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog.
(2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format:
<Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)>
Sample gallery names:
(1) 1GB TEST_USB
(2) 4GB DCIM - RED_USB
(3) 8KB PHOTOS - (TESTCOMPANY, A101)
(4) 4GB SD Card
(5) 16MB SD Card
BUG=159671,158600
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11366144
TBR=kmadhusu@chromium.org
Review URL: https://codereview.chromium.org/11363236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog.
(2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format:
<Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)>
Sample gallery names:
(1) 1GB TEST_USB
(2) 4GB DCIM - RED_USB
(3) 8KB PHOTOS - (TESTCOMPANY, A101)
(4) 4GB SD Card
(5) 16MB SD Card
BUG=159671,158600
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11366144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126964
TEST=build
Review URL: https://chromiumcodereview.appspot.com/11361211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=160181
Review URL: https://chromiumcodereview.appspot.com/11364169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=131220
TEST=chromeos_unittests
TBR=oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11275231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also only shutdown initialized services in ChromeBrowserMainParts to reduce warning spam.
BUG=159854
For chrome/browser:
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11332005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch set depends on http://codereview.chromium.org/11342040/
BUG=158264
TEST=ran chromeos_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/11361005
TBR=nona@chromium.org
Review URL: https://codereview.chromium.org/11377048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Must be committed only after the corresponding service_constants.h
change goes in.
BUG=chromium-os:35900
TEST=built
Review URL: https://chromiumcodereview.appspot.com/11364089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch set depends on http://codereview.chromium.org/11342040/
BUG=158264
TEST=ran chromeos_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/11361005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=159726
TEST=ran chromeos_unittests with valgrind
Review URL: https://chromiumcodereview.appspot.com/11369113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some Thai input requires surrounding text feature.
This patch implement full-spec surrounding text feature for ibus.
BUG=158111
TEST=Ran ui_unittests and manually done on lumpy.
Review URL: https://chromiumcodereview.appspot.com/11275148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is 2nd try of http://codereview.chromium.org/11366012/
- Introudced ibus namespace for IBusPanelService which collisions original ibus's class name.
BUG=158264
TEST=ran chromeos_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/11365104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intention for this class is to provide up-to-date state information about the network for the majority of the network related UI. It should also serve as a foundation for classes monitoring the state of the active network.
This code is not designed to provide detailed information about specific network service or device properties, not should it provide the ability to set (configure) those properties.
BUG=154072
Review URL: https://chromiumcodereview.appspot.com/11192024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This also fixes the issue where external display can be off
after sign out.
- Add UMA stats for configuration failures.
BUG=159533, 159084
TEST=manual: see bugs for repro step.
Review URL: https://chromiumcodereview.appspot.com/11365102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't write unittest for these because AppendIBusText does not support attachment field.
BUG=129403
TEST=ran chromeos_unittests and manually done
Review URL: https://chromiumcodereview.appspot.com/11365105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is compiled and tested but not used in production binary at this moment.
This patch set depends http://codereview.chromium.org/11271040/.
BUG=158265
TEST=ran chromeos_unittest, unit_tests
Review URL: https://chromiumcodereview.appspot.com/11273114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of mozc dependency removal and libibus removal.
BUG=129403
TEST=ran chromeos_unittests
Review URL: https://chromiumcodereview.appspot.com/11363033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class provide IBus UI related functionality.
This class is compiled and tested but not used in production binary.
This patch set depends http://codereview.chromium.org/11343038/.
BUG=158264
TEST=ran chromeos_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/11342040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166119 0039d316-1c4b-4281-b951-d872f2087c98
|