| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change untangles some of the Shill*Stubs' implementation from the setup of a default network environment. In particular the setup function has now access to all Shill*Stubs during this setup.
This also correctly adds stub networks with status 'online' to a profile, so that the respective FavoriteState is created.
BUG=126870
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/24150004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/24327002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes callers responsible for ensuring that the returned
system salt is valid.
It also includes removal of some stale unused code.
BUG=288210
For c/b/e/aoi/music_manager_private:
TBR=asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23903051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use after free on ASAN chromiumos.
> Track active references in ShillClientHelper
> To prevent Shill Service DBus ObjectProxy instances from accumulating,
> remove them when the service becomes inactive.
>
> BUG=223483
>
> Review URL: https://chromiumcodereview.appspot.com/23658053
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/24293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To prevent Shill Service DBus ObjectProxy instances from accumulating,
remove them when the service becomes inactive.
BUG=223483
Review URL: https://chromiumcodereview.appspot.com/23658053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...in addition to Unmount method that sets dbus error on failure.
This is in preparation of changing Unmount method to return mount
status on cros-disks side.
BUG=288974
TEST=try unmounting a device both while it's busy and idle.
In the first case, unmount fails and a warningis shown.
In the second case, the device is successfully unmounted.
Review URL: https://chromiumcodereview.appspot.com/23684051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Fixed issue with temporary object in CryptohomeClientStubImpl::TpmGetPassword
that led to crash on Linux.
BUG=284831
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/23531065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
signal. When multiple NodesChanged signal are fired for a single node change, GetNodes returns stale nodes data from the later NodesChanged signal, which could overwrite the latest active audio node.
BUG=292741
Review URL: https://chromiumcodereview.appspot.com/23736008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CERT_FindCertIssuer might return NULL, which was not correctly handled before.
It's not clear if this case can ever occur in practice, but with this change we're on the safe side.
BUG=291358
R=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/23619075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added mistakenly. GetFieldSignature already resolves the base signature.
BUG=280359
Review URL: https://chromiumcodereview.appspot.com/24079009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=293117
Review URL: https://chromiumcodereview.appspot.com/24162002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an issue where mirrored mode configuration would
fail when the internal and external displays didn't share a
common resolution. A new mode would be created on the
internal display, but it wasn't added to the corresponding
OutputSnapshot struct, resulting in a later failure.
It also moves the mirror-mode-finding code from
RealOutputConfiguratorDelegate to OutputConfigurator so it
can be tested.
BUG=289159
Review URL: https://chromiumcodereview.appspot.com/24081004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126870
(for networking_private_api_nonchromeos.cc)
TBR=gspencer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23506040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=224357
TEST=new unit tests.
TEST=manually checked that remapped Search works as ESC.
TEST=keyboard help shows the correct label 'esc' when Search is remapped to ESC.
R=nona@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23866008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
device inconsistent issue caused by multiple NodesChanged signal received for the same node change.
BUG=290485
Review URL: https://chromiumcodereview.appspot.com/23620055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a utility function to NetworkState to query if a network
requires activation. All UI code should use this instead of comparing the
Cellular.ActivationState property themselves, as this utility function
handles the "unknown" case as well.
BUG=289470
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/23532065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, remove some uneeded dependencies from LoginState tests.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/23444061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes a minor change to WifiConfigView to update the 'Connect'
button enabled state after receiving wifi properties by calling
UpdateDialogButtons().
BUG=289642
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/23872021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Service.Error property is getting cleared before the notification is
displayed; we need to pass it to the notification when we detect the
error. (ErrorDetails should not be getting cleared).
BUG=291370
R=armansito@chromium.org
Review URL: https://codereview.chromium.org/23522050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the device policy file cannot be loaded on login, the device enters
a state where it allows login process to proceed only if the user logging
in is the owner. To be able to successfully determine if the user is
owner, parallel authenticator has to wait until the certificates
are loaded by CertLoader. The problem is that the CertLoader starts
loading the certificates _after_ the user actually logs in. So if the
authenticator actually waited for the owner status to be resolved, the
login would hang.
This CL adds another state to LoginState::LoggedInState enum (SAFE_MODE)
in which CertLoader will be allowed to start loading the certificates.
When the authenticator detects the policy file corruption, it changes
login state to SAFE MODE (which triggers the certificate loading) and
waits for the DeviceSettingsService to determine whether the current user
is the owner.
Also, removed LoginState::GetLoggedInState. Replaced it's pre-existing
usages with LoginState::IsUserLoggedIn; and added
LoginState::IsInSafeMode to be used here.
BUG=285450
TEST=
1. manually remove device policy file
2. try logging in to a non-owner account -> should fail
3. try logging in to the owner account -> should succeed
4. try logging in to a non-owner account again -> should succeed
Review URL: https://chromiumcodereview.appspot.com/23684033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
start unitl after EmitLoginPromptVisible. Start cras log after it, so that we don't log the dbus failure due to cras call is made before it is started . Also a few other changes that should remove all other excess log seen during rebooting.
BUG=288177
TBR=mpcomplete
Review URL: https://chromiumcodereview.appspot.com/23460038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This observer is unnecessary, confusing, and frequently misused.
See issue for background / details
BUG=288196
For chrome/browser/ui/webui/chromeos/login/
R=pneubeck@chromium.org
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/23684042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HelpApp. Add a command line switch so that we can easily fall back to the old one if necessary.
BUG=chromium:281234
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/23548023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add SAML signin support behind a flag '--eanble-saml-signin'
- Scrap passwords from password input fields during SAML flow;
- Ask user to confirm a password if SAML flow is detected;
BUG=271082
Review URL: https://chromiumcodereview.appspot.com/23067007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was careless of me, we need to bind a copy of the Callback, not the
reference in PostTaskAndReplyWithResult.
BUG=289137
Review URL: https://chromiumcodereview.appspot.com/23880009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seems this class has not been used since http://crrev.com/217184
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23709006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The major changes from IBus implementation are:
- Never fail posting keyboard event, it is now just function call.
- The dbus module is gone so there is no state "before initialized" or "initialized but connection is out".
- Also we can remove async initialize code.
- We can treat GetEngineHandler() == NULL as XKB layout.
BUG=275262
TEST=Manually checked and also confirmed all tests are passed.
Review URL: https://chromiumcodereview.appspot.com/22818008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=283772
Review URL: https://chromiumcodereview.appspot.com/23627004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since we handle this gracefully, and there is not enough data supplied to act on this information, it seems more appropriate as a warning.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23923012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, both concrete network types (like Wimax) and type patterns (like Mobile) were represented as strings. In some cases, a variable could be both a concrete type or a pattern and was compared to another pattern.
This is hard to read and operands of the comparison can easily be swapped by mistake.
Implementing the comparison of patterns didn't scale.
This change adds a new class that encapsulates network type patterns and represents them internally as a more scalable bit vector.
It's now explicit which functions accept a type pattern as an argument.
This also adds support for Shill's network type kEthernetEap.
BUG=126870
(API change, used in chrome/browser/ui/webui/{chromeos,help})
TBR=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23712002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There should be no functionality changes with this CL, it should only
eliminate unused code.
It also removes cros_network_functions and all Shill blocking dbus calls (now unused).
BUG=245494
Review URL: https://chromiumcodereview.appspot.com/23477058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FakePowerManagerClient.
Observer's callback SuspendImminent() and SystemResumed() are used by
MountedDiskMonitor. Focusing on the usage, this CL adds two methods
SendSuspendImminent() and SendSuspendStateChanged() emulating DBus's signals
for testing purpose.
These methods will be used in tests of a following CL.
BUG=279276
TEST=Ran unit_tests
Review URL: https://chromiumcodereview.appspot.com/23484021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the situation.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23556010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated InternetOptionsHandler and network_list.js to observe LoginState
updates, so that using UIAccountTweaks is not the only way to determine
whether or not the current user is owner. This is because |loadTimeData|
may not contain the current user login details if the logged in user type
updates after the UI fills in the UIAccountTweaks info.
BUG=285589
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/23466015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RestartEntd() was deprecated years ago, so calls to this method
can certainly be removed. The UnlockScreen() method has done
nothing but emit a signal that no process listens to for several
releases now.
BUG=chromium:286401
TEST=unit tests, desktopui_ScreenLocker autotest
Review URL: https://chromiumcodereview.appspot.com/23694025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
plugged in.
BUG=286029
Review URL: https://chromiumcodereview.appspot.com/23819034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=268438
TEST=hdmi output device should have maximum volume(100) be default.
Review URL: https://chromiumcodereview.appspot.com/23536034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkStateHandler.
This CL
https://codereview.chromium.org/23712002 (Cleanup network type matching.)
uncovered, that some NetworkStateHandler functions returned NetworkState objects that were not fully initialized, namely type() was empty.
BUG=126870
Review URL: https://chromiumcodereview.appspot.com/23681010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is API clean up. The mountType is being replaced by VolumeType. This CL
refactors private APIs about the flag.
Note that this is preparation to return Drive as a Volume.
BUG=279276
TEST=Ran unit_tests, browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.
R=benwells@chromium.org, kinaba@chromium.org, satorux@chromium.org, yoshiki@chromium.org
Review URL: https://codereview.chromium.org/23658009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch allows both the X11 and the Gtk message-pumps to be built
in a linux-gtk build. A subsequent patch will use the X11 message-pump
for the GPU process, while continue to use the Gtk message-pump for the
browser process.
BUG=145600
R=ccameron@chromium.org, oshima@chromium.org, piman@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/23880006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221873 0039d316-1c4b-4281-b951-d872f2087c98
|