| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
- Removed unused argument from the Validate*() methods.
- Fixed formatting.
BUG=NONE
R=dconnelly@chromium.org
Review URL: https://codereview.chromium.org/69933010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Transitions are disabled by default because of performance problems. To enable use "enable-first-run-ui-transitions" flag.
BUG=321314
Review URL: https://codereview.chromium.org/107753004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The addition of the bluetooth type is required because of the DeviceStatusCollectorNetworkInterfacesTest.NetworkInterfaces test and the GetDeviceList() function now does a match of the device's type to NetworkTypePattern::Default().
BUG=323537
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/99133016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make PowerManagerClient wait for the
org.chromium.PowerManager D-Bus name to be owned by powerd
before making method calls to it. Previously, the class
would also make method calls when it saw the name get
released. Depending on how quickly powerd restarted, those
calls may or may not have succeeded.
BUG=320340
Review URL: https://codereview.chromium.org/114173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=324005
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/101633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Certificates were ordered from early expiration to late expiration and the first matching cert was selected.
This was exactly the wrong order. This change reverses the order to select a certificate with the latest expiration date.
BUG=327389
R=dconnelly@chromium.org
Review URL: https://codereview.chromium.org/107653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=321335
TEST=manual tests on Lumpy, media_unittests:SoundsManager*
Review URL: https://codereview.chromium.org/108403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the need for a *ForTest function and friend declarations in NetworkDeviceHandler.
Fixes the tests for error_callback invocation, which weren't correctly tested before.
While there, does some other minor cleanups.
BUG=323537
Review URL: https://codereview.chromium.org/107693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322682
Review URL: https://codereview.chromium.org/102423008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=325968
TEST=Manual test with Chrome OS on Linux.
Review URL: https://codereview.chromium.org/111223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=314793
Review URL: https://codereview.chromium.org/106193008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322188
Review URL: https://codereview.chromium.org/99153005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added the basic implementation of NfcAdapterChromeOS, with no tag/peer logic.
BUG=316471
TEST=device_unittests
Review URL: https://codereview.chromium.org/100393011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add NetworkStateInformer and ErrorScreenActor to
AppLaunchSplashScreenHandler;
- AppLaunchSplashScreenHandler sends network state
to its delegate (AppLaunchController) during network
check;
- AppLaunchController decides when to show network
configure UI and call AppLaunchSplashScreenActor
to show it (via ErrorScreenActor);
- Show network config UI for enterprise kiosk;
- Add a 'Reboot' button for kiosk network error;
- Add a PromptForNetworkWhenOffline boolean field to
DeviceLocalAccountsProto to control whether to show
network config UI for enterprise managed kiosk;
BUG=314710
TEST=KioskTest.LaunchAppNetworkDown/Portal
Review URL: https://codereview.chromium.org/79113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a *possible* fix for a crash bug, although it is not clear what would cause a service to have a path of '/'. There should be no harm in adding the extra check.
BUG=324849
R=hashimoto@chromium.org, pneubeck@chromium.org
Review URL: https://codereview.chromium.org/102603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/103563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL applies the following fixes:
1. Fixed a bug in chromeos::NfcPropertySet::Set where the code didn't pass
in the property name and value to the D-Bus call.
2. Changed NfcTagClient::Write and NfcDeviceClient::Push to take in a
base::DictionaryValue instead of a map of strings for the NDEF attributes,
as the NDEF record attributes don't have string as their only possible
value type.
3. Fixed a regression in DBusThreadManager due to recent refactors that broke
the NFC client initialization code.
4. Allow users of NfcPropertySet to be notified when a call to GetAll completes.
BUG=316471
TEST=chromeos_unittests
Review URL: https://codereview.chromium.org/99903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sandbox host process
* Introduced DBThreadManager::SetInstanceForTesting to specify the instance to be used when DBThreadManager::Initialize is called in the browser setup rocess.
* Temporarily stop the thread in EmbeddedTestServer to fork/exec sandbox host process properly.
BUG=322732
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/83633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base namespace.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/100573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DBusClient interfaces shouldn't provide functionality related to testing code (like Stubs/fake implementations).
Instead fake clients are now directly created without relying on the static Create() functions. The now unused DBusClientImplementationType argument of the Create() functions could be removed.
BUG=275286
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/91413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows to create these stubs directly without routing through the static Create() function in the client's interface.
BUG=275286
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/91373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/97533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace.
Many of them just got changed to a default-constructed string when a reference was not required.
I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up.
BUG=
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/89243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:316524
TEST=Locally verified on sandbox of ChromeOS on Linux.
Review URL: https://codereview.chromium.org/91443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/94033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.open() was used to open the option page of IME extensions.
But this method can open more than one tab of the option page.
This cl change to use ExtensionTabUtil::OpenOptionsPage() to open the option
page.
In this change, ComponentExtensionIMEManager::IsComponentExtensionIMEId is moved
to extension_ime_util::IsComponentExtensionIME.
BUG=238968
TEST=ran unit_tests and chromeos_unittests and manually checked on alex
Review URL: https://codereview.chromium.org/70973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=271228
TEST=Unittests with Valgrind.
Review URL: https://codereview.chromium.org/87723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Call powerd's HandlePowerButtonAcknowledgment D-Bus method
after a power-button-down event has been handled.
BUG=298983
Review URL: https://codereview.chromium.org/88373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/85023005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Causes memory leaks, see crbug.com/323377
ISSUE=323377
TBR=yoichio@chromium.org,yukawa@chromium.org,komatsu@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/86943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/83833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move IBusMouseButton to Ibus_bridge.h.
BUG=N/A
Review URL: https://codereview.chromium.org/84943006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI could be disabled by --disable-first-run-ui flag.
Suppresed loading of "Tips & Tricks" app in case when first-run UI is enabled.
BUG=269286
TBR=finnur
for extension_constants.*
Review URL: https://codereview.chromium.org/85293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This class easily enables to manage the lifetime of objects which are used with InputMethodManager. I will make a class for Accessibility and this class manages the Accessibility class.
BUG=271228
Review URL: https://codereview.chromium.org/80633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237050 0039d316-1c4b-4281-b951-d872f2087c98
|