| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=256538
R=cpu@chromium.org, dalecurtis@chromium.org, dmichael@chromium.org, marcheu@chromium.org, wuchengli@chromium.org
Review URL: https://codereview.chromium.org/24039002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=283772
Review URL: https://codereview.chromium.org/24027006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, use lsb-release/CHROMEOS_RELEASE_NAME instead of the
USER env variable.
This CL depends on https://codereview.chromium.org/23588009/
BUG=270135
For trivial base/ changes:
R=derat@chromium.org, satorux@chromium.org, sky@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/23904025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the DCHECKS that are no longer valid and fixes the update
logic to work correctly for FavoriteState. These changes are needed for
https://codereview.chromium.org/23609047/
BUG=126870
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/24852002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread
Accessing the callback on the D-Bus thread while changing its value may result in a race condition.
Change the type of SetNameOwnerChangedCallback's argument from Signal to strings to stop worrying about on which thread the Signal gets released.
BUG=298747
TEST=dbus_unittests
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/24673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new FakeCryptohomeClient is based on CryptohomeClinentStubImpl.
The only addition is set_unmout_result().
BUG=298729
TEST=the existing tests should pass
R=hashimoto@chromium.org, stevenjb@chromium.org
Review URL: https://codereview.chromium.org/24637004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from CryptohomeLibrary
Clients should use CryptohomeClient directly.
There is no benefit of going through CryptohomeLibrary.
BUG=298592
TEST=none
Review URL: https://codereview.chromium.org/24673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=177765
Review URL: https://codereview.chromium.org/24324008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
So that clients don't need to define their own DoNothing function.
BUG=298592
TEST=none
R=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/24707003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=283772
Review URL: https://codereview.chromium.org/23455027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/24600004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/24467008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By exposing TaskRunners,
we'll be able to use utility functions like base::PostTaskAndReplyWithResult
BUG=None
TEST=git cl try
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/24554002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[[Making changes to '_toolset=="target"' section in system.gyp to fix
cros compiling.]]
The linux_aura port didn't deal with multiple monitors very well because
it was treating the X root window as one big display. When xrandr is
present, get the screen areas from it, and exposes this data back to
chrome.
This patch also factors out the EDID parser than chromeos was using into
a common directory. Like chromeos, we use it to assign stable display
IDs.
BUG=287972
TBR=brettw@chromium.org, derat@chromium.org, sky@chromium.org
First Review URL: https://codereview.chromium.org/23536057
Review URL: https://codereview.chromium.org/24459002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compiled on linux_chromeos, but doesn't compile in cros.
> linux_aura: Implement most of DesktopScreenX11.
>
> The linux_aura port didn't deal with multiple monitors very well because
> it was treating the X root window as one big display. When xrandr is
> present, get the screen areas from it, and exposes this data back to
> chrome.
>
> This patch also factors out the EDID parser than chromeos was using into
> a common directory. Like chromeos, we use it to assign stable display
> IDs.
>
> BUG=287972
> R=brettw@chromium.org, derat@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/23536057
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/24365012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The linux_aura port didn't deal with multiple monitors very well because
it was treating the X root window as one big display. When xrandr is
present, get the screen areas from it, and exposes this data back to
chrome.
This patch also factors out the EDID parser than chromeos was using into
a common directory. Like chromeos, we use it to assign stable display
IDs.
BUG=287972
R=brettw@chromium.org, derat@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23536057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=293117
Review URL: https://chromiumcodereview.appspot.com/23549033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All shill DBus service constants have been moved from the flimflam namespace to
the shill namespace. This CL makes the corresponding changes on the Chrome
side.
Related CLs:
https://chromium-review.googlesource.com/#/c/170123/
https://chromium-review.googlesource.com/#/c/170205/
https://chromium-review.googlesource.com/#/c/170206/
https://chromium-review.googlesource.com/#/c/170207/
https://chromium-review.googlesource.com/#/c/170208/
https://chromium-review.googlesource.com/#/c/170209/
https://chromium-review.googlesource.com/#/c/170223/
https://chromium-review.googlesource.com/#/c/170230/
https://chromium-review.googlesource.com/#/c/170231/
BUG=295425
R=gspencer@chromium.org,gauravsh@chromium.org,stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24348002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All shill DBus service constants have been moved from the flimflam namespace to
the shill namespace. This CL makes the corresponding changes on the Chrome
side.
Related CLs:
https://chromium-review.googlesource.com/#/c/170123/
https://chromium-review.googlesource.com/#/c/170205/
https://chromium-review.googlesource.com/#/c/170206/
https://chromium-review.googlesource.com/#/c/170207/
https://chromium-review.googlesource.com/#/c/170208/
https://chromium-review.googlesource.com/#/c/170209/
https://chromium-review.googlesource.com/#/c/170223/
https://chromium-review.googlesource.com/#/c/170230/
https://chromium-review.googlesource.com/#/c/170231/
BUG=295425
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24286008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=293117
Review URL: https://chromiumcodereview.appspot.com/23621043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
IBusPanelPropertyHandlerInterface and IBusEngineService.
Those functions are no longer used anywhere.
BUG=283772
Review URL: https://chromiumcodereview.appspot.com/23899007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates OutputConfigurator to update its cached outputs
whenever it fetches the current state via XRandR.
Previously, it only updated the cached outputs after
successfully configuring them. If an output was added and
configuration failed due to e.g. a request to enter an
invalid state, the new output wouldn't be present in the
cached list. This wasn't much of a problem before, since the
cached outputs were only used to ignore subsequent XRandR
notifications and to notify observers about changes (also,
we shouldn't be requesting invalid states), but having stale
outputs may be more of a problem if output-protection code
expects to be able to use the cached outputs as a mostly-up-
to-date snapshot of currently-connected outputs.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/23447052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change untangles some of the Shill*Stubs' implementation from the setup of a default network environment. In particular the setup function has now access to all Shill*Stubs during this setup.
This also correctly adds stub networks with status 'online' to a profile, so that the respective FavoriteState is created.
BUG=126870
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/24150004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/24327002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes callers responsible for ensuring that the returned
system salt is valid.
It also includes removal of some stale unused code.
BUG=288210
For c/b/e/aoi/music_manager_private:
TBR=asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23903051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use after free on ASAN chromiumos.
> Track active references in ShillClientHelper
> To prevent Shill Service DBus ObjectProxy instances from accumulating,
> remove them when the service becomes inactive.
>
> BUG=223483
>
> Review URL: https://chromiumcodereview.appspot.com/23658053
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/24293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To prevent Shill Service DBus ObjectProxy instances from accumulating,
remove them when the service becomes inactive.
BUG=223483
Review URL: https://chromiumcodereview.appspot.com/23658053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...in addition to Unmount method that sets dbus error on failure.
This is in preparation of changing Unmount method to return mount
status on cros-disks side.
BUG=288974
TEST=try unmounting a device both while it's busy and idle.
In the first case, unmount fails and a warningis shown.
In the second case, the device is successfully unmounted.
Review URL: https://chromiumcodereview.appspot.com/23684051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ Fixed issue with temporary object in CryptohomeClientStubImpl::TpmGetPassword
that led to crash on Linux.
BUG=284831
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/23531065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
signal. When multiple NodesChanged signal are fired for a single node change, GetNodes returns stale nodes data from the later NodesChanged signal, which could overwrite the latest active audio node.
BUG=292741
Review URL: https://chromiumcodereview.appspot.com/23736008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CERT_FindCertIssuer might return NULL, which was not correctly handled before.
It's not clear if this case can ever occur in practice, but with this change we're on the safe side.
BUG=291358
R=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/23619075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added mistakenly. GetFieldSignature already resolves the base signature.
BUG=280359
Review URL: https://chromiumcodereview.appspot.com/24079009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=293117
Review URL: https://chromiumcodereview.appspot.com/24162002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an issue where mirrored mode configuration would
fail when the internal and external displays didn't share a
common resolution. A new mode would be created on the
internal display, but it wasn't added to the corresponding
OutputSnapshot struct, resulting in a later failure.
It also moves the mirror-mode-finding code from
RealOutputConfiguratorDelegate to OutputConfigurator so it
can be tested.
BUG=289159
Review URL: https://chromiumcodereview.appspot.com/24081004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126870
(for networking_private_api_nonchromeos.cc)
TBR=gspencer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23506040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=224357
TEST=new unit tests.
TEST=manually checked that remapped Search works as ESC.
TEST=keyboard help shows the correct label 'esc' when Search is remapped to ESC.
R=nona@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23866008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
device inconsistent issue caused by multiple NodesChanged signal received for the same node change.
BUG=290485
Review URL: https://chromiumcodereview.appspot.com/23620055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a utility function to NetworkState to query if a network
requires activation. All UI code should use this instead of comparing the
Cellular.ActivationState property themselves, as this utility function
handles the "unknown" case as well.
BUG=289470
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/23532065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, remove some uneeded dependencies from LoginState tests.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/23444061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also makes a minor change to WifiConfigView to update the 'Connect'
button enabled state after receiving wifi properties by calling
UpdateDialogButtons().
BUG=289642
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/23872021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223435 0039d316-1c4b-4281-b951-d872f2087c98
|