| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed an unused member variable
* Use GetStringWithoutPathExpansion consistently except where expansion is desired
* Use kProviderTypeProperty (with expansion) instead of kTypeProperty
BUG=247104
Review URL: https://chromiumcodereview.appspot.com/17167010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Proposal:https://docs.google.com/a/chromium.org/document/d/1U_exKvPmT4AXyqFuHgVBbgBZ2RAKNBjk6MwSPcceWXw/edit
Overview
We’d like to have a set of APIs useful for diagnostics tools, and initially, an API that can be used to replicate ping and traceroute functionality.
Use cases
The sendPacket API is used by a diagnostics tool to find problems in the network configuration of an environment and determine latency issues.
BUG=250851
Review URL: https://chromiumcodereview.appspot.com/17210002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These properties (specifically related to cellular activation)
are used by MobileActivator and needed to transition it to use
the Network*Handlers.
BUG=188753
Review URL: https://chromiumcodereview.appspot.com/17091006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes sync and net compile with no "using *Value".
BUG=
Review URL: https://codereview.chromium.org/17034006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247548
R=gspencer@chromium.org
Review URL: https://codereview.chromium.org/17094011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This prepares usage of the decoding in NetworkLibrary.
While there, removed redundant namespace qualifiers from onc_utils.*.
BUG=208986
Review URL: https://chromiumcodereview.appspot.com/17471005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crrev.com/207547 breaks ibus-m17n build in Chrome OS bot.
This patch should fix it.
BUG=None
TEST=None
TBR=shuchen@chromium.org
Review URL: https://codereview.chromium.org/17524006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the code to send the device object itself to the audio devices preferences handler. The preferences handler then pulls the device name and the node_id out of the object to generate it's device identification string. The 'id' field in the AudioDevice object is really
the device_id << 32 | node_id (it is sent as one value from cras), so to get the node_id, we need to & the value out. This changes how we store our audio device list internally, using a map instead of a list, making our active node lookups more efficient too.
Reviews requested,
hshi@ overall review
stevenjb@ chromeos/* and ash/system/chromeos/* OWNERs review
dgreid@ fyi
R=dgreid@chromium.org,hshi@chromium.org,stevenjb@chromium.org
BUG=241441
TEST=Tested with switching between various devices to ensure that preferences were remembered and switched per device correctly.
Review URL: https://chromiumcodereview.appspot.com/17349003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on extension IME API.
BUG=240659
TEST=None
Review URL: https://chromiumcodereview.appspot.com/17239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> BUG=244455
> For chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
> TBR=xiyuan@chromium.org
> Review URL: https://chromiumcodereview.appspot.com/15649018
BUG=250807
TBR=pneubeck@chromium.org,rsleevi@chromium.org
Review URL: https://codereview.chromium.org/17500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this CL, legacy ibus pinyin input will not be used and new IME extension
API based one is used instead.
The changes for unit tests are mostly changing hard-coded old input method id to new input method id.
BUG=240659
TEST=ran all tests
Review URL: https://chromiumcodereview.appspot.com/17266002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unit/browser tests
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/17010003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
Reland of 206507.
Original review https://codereview.chromium.org/17078005/
TBR=sky
Review URL: https://codereview.chromium.org/16897006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because Shill routinely removes and adds network services, this was
potentially causing a not insignificant amount of memory bloat, in
addition to incorrect behavior when Shill reuses service path names
after restarting.
Also removes extra NetworkStateList typedefs.
BUG=249129
Review URL: https://chromiumcodereview.appspot.com/16854006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a case which the input method is used in multiple languages, e.g.
US international is used in many non US languages.
This is also helpful for language code variations, e.g. "zh" and "zh-CN".
BUG=249200
TEST=ran all tests.
Review URL: https://chromiumcodereview.appspot.com/16843010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the flags and the code responsible for the legacy UI which is not supported anymore.
TEST=Files.app should work fine. Also, browser_tests.
BUG=243650
R=hashimoto@chromium.org, hirono@chromium.org, jochen@chromium.org
Review URL: https://codereview.chromium.org/17202005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the profile is loaded we verify if the user has specfied any flags
or if there were flags specified per policy that differ from the user
specfied flags and in either case restart Chrome with the desired flags.
This allows non-owners to use the about:flags page and prevents policy
set flags from leaking inside user sessions.
BUG=221352
TEST=unit_tests & Manually by specifying flags in non-owner session and observing them respected.
Review URL: https://chromiumcodereview.appspot.com/16770002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add network event logging for important events to the network change
notifier. This will help in investigation of (usually hard to repro)
bugs in the change notifier.
BUG=249313
Review URL: https://chromiumcodereview.appspot.com/17116002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=244089
R=thestig@chromium.org
TBR=ben@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17200002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move message_pump to base/message_loop.
>
> This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
>
> BUG=
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/17078005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/16897005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
BUG=
R=sky@chromium.org
Review URL: https://codereview.chromium.org/17078005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the file manager.
This CL added an entry to about:flags to hide the selecting checkbox in the file
manager. The state of the flag is passed to JavaScript side as preferences, and
FileTable class handles it.
BUG=249242
TEST=manually
R=satorux@chromium.org, yoshiki@chromium.org
Review URL: https://codereview.chromium.org/16924004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/16998003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The File manager as a platform app is more stable than the old one, so there is no reason to support it anymore.
TBR=jhawkins@chromium.org
TEST=Test Files.app, browser_tests should pass.
BUG=240606
Review URL: https://chromiumcodereview.appspot.com/16617002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help debug code that appears to stop receiving network updates
e.g. networking_private_event_router.cc by logging when classes add and
remove observers.
BUG=247229
For chrome/browser/ui/webui/chromeos/login/:
TBR=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16816006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=248369
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/15679022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This appears to work, and scanning through the code I don't see any red
flags, but I'm not all that familiar with the crypto code, so I don't
know whether this might introduce any new/additional threading issues?
BUG=244455
For chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
TBR=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15649018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the result of running the rewrite_scoped_ptr_ctor_null tool
across all files built on CrOS in the chromeos/ directory.
BUG=173286
Review URL: https://chromiumcodereview.appspot.com/16966003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we'll ask the display name for all displays, but most of
internal displays don't have the name field, and actually our
caller code works for such displays.
That said, missing the display name field isn't an erroneous
case.
BUG=249058
R=derat@chromium.org
TEST=none
Review URL: https://codereview.chromium.org/16822003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xkb:cz:qwerty:cze Czech(Qwerty)
xkb:am:phonetic:arm Armenian(Phonetic)
xkb:ge::geo Georgian
xkb:by::bel Belarusian
xkb:mn::mon Mongolian
BUG=127135,229277,229281,229283,229284,229285
TEST=Build chromeos-chrome and emerge/gmerge to Chrome OS. See if the above keyboards are available for addition. Once added, try them and see if they work.
R=nona@chromium.org
Review URL: https://codereview.chromium.org/16488003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the kPowerPresentationIdleDelayFactor pref
with kPowerPresentationScreenDimDelayFactor. The former
scaled the idle delay and then adjusted the other delays;
the latter scales the screen-dim delay before adjusting
other delays.
It also updates the cros_system_api dependency to d2d441c1.
BUG=chromium:248276
Review URL: https://chromiumcodereview.appspot.com/16677007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=221813
TEST=device_unittests
Review URL: https://chromiumcodereview.appspot.com/14932007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- petermayo@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: https://chromiumcodereview.appspot.com/16512003/
The current flow does not guarantee that a configured network will have
its tpm / pkcs11 credentials configured. We need to set these
properties in order to reliably connect to networks requiring
certificates. The patch also includes some minor changes to improve
error reporting and configuration triggering for failure cases.
This patch does not introduce NetworkHandler::InitializeForTest and
instead allows NetworkConnectionHandler to Initialize correctly when
LoginState is not initialized.
BUG=247104
TBR=gspencer@chromium.org,pneubeck@chromium.org
For /wifi_data_provider_chromeos_unittest.cc:
TBR=joth@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16045010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove forwarding header
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16667019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16739011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Configure networks requiring a certificate.
>
> The current flow does not guarantee that a configured network will have
> its tpm / pkcs11 credentials configured. We need to set these
> properties in order to reliably connect to networks requiring
> certificates. The patch also includes some minor changes to improve
> error reporting and configuration triggering for failure cases.
>
> BUG=247104
> For /wifi_data_provider_chromeos_unittest.cc:
> TBR=joth@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/16512003
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/16109015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps the forwarding header, just updates all current callers.
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16514006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extracted functions to get and set per-network proxy configuration from ProxyConfigServiceImpl, UIProxyConfigService and NetworkStateInformer, and moved them to a common place (chrome/browser/chromeos/net/proxy_config_handler.h).
- The previous SetProxyConfig call to NetworkLibrary was extracted and instead ShillServiceClient is called directly.
- Now uses NetworkStateHandler and NetworkState instead of NetworkLibrary to get the current proxy config.
- This removed any dependency of proxy UI on NetworkLibrary.
BUG=234982
R=mnissler@chromium.org, nkostylev@chromium.org, stevenjb@chromium.org
Review URL: https://codereview.chromium.org/16398005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
IsUserAuthenticated == Owner|Regular|LocallyManaged, but here
we only want to allow users who are authenticated by gaia login,
which is Owner|Regular.
BUG=179285
Review URL: https://chromiumcodereview.appspot.com/15701024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205155 0039d316-1c4b-4281-b951-d872f2087c98
|