| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=471888
Review URL: https://codereview.chromium.org/1280003004
Cr-Commit-Position: refs/heads/master@{#343861}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1285373004
Cr-Commit-Position: refs/heads/master@{#343852}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#343599}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#343581}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This speculatively reverts commit fb4a4c60596d52a2f3ab26ab94399d3ebd5a64c1.
For details please see crbug.com/520311
NOTRY=true
TBR=mnissler
BUG=chromium:520311, chromium:433172
TEST=compiles
Review URL: https://codereview.chromium.org/1289393002
Cr-Commit-Position: refs/heads/master@{#343536}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#343162}
|
|
|
|
|
|
|
|
|
|
|
| |
This will simplify some of the new Settings UI, allowing us
to read onc.Type directly without parsing a managed dictionary.
BUG=none
Review URL: https://codereview.chromium.org/1284963002
Cr-Commit-Position: refs/heads/master@{#343146}
|
|
|
|
|
|
|
|
| |
TBR=zelidrag@chromium.org (chromeos)
Review URL: https://codereview.chromium.org/1284833004
Cr-Commit-Position: refs/heads/master@{#342983}
|
|
|
|
|
|
|
|
| |
BUG=516545
Review URL: https://codereview.chromium.org/1274403003
Cr-Commit-Position: refs/heads/master@{#342849}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main point is to avoid usage of select for observing process'
pseudo-terminal fd. Main problems with select is that it doesn't work
for fd > 1024, which started to be passed to ProcessOutputWatcher.
Added benefit of MessageLoopForIO::WatchFileDescriptor is that it's async,
so it enables us to do some clean up for process proxy thread management.
BUG=495165
TEST=Open a lot of crosh tabs (e.g. ~30). Crosh is started in all of them.
Review URL: https://codereview.chromium.org/1258193002
Cr-Commit-Position: refs/heads/master@{#342716}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces
base::StringToLowerASCII(string)
with
base::ToLowerASCII(string)
This form is 1:1 search and replace.
A bunch of places did something like this:
std::string foo(something_else);
base::StringToLowerASCII(&foo);
which became:
foo = base::ToLowerASCII(something_else);
A couple places really wanted in-place changing and they became:
foo = base::ToLowerASCII(foo);
There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting).
There was more cleanup in:
chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc
In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case.
NOPRESUBMIT=true
(due to touching code with wstrings)
Review URL: https://codereview.chromium.org/1279123004
Cr-Commit-Position: refs/heads/master@{#342659}
|
|
|
|
|
|
|
|
|
| |
R=oshima@chromium.org
BUG=516366
Review URL: https://codereview.chromium.org/1275773005
Cr-Commit-Position: refs/heads/master@{#342649}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is not necessary to use StringPrintf() to convert a C string to a
std::string, as std::string has a constructor which will perform the
conversion implicitly.
BUG=
TEST=compiled
Review URL: https://codereview.chromium.org/1280333002
Cr-Commit-Position: refs/heads/master@{#342624}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When resuming the device, DiskMountManager tries to remount all removable
device. However if the removable device was detached during suspend, it
encounters error when calling GetDeviceProperties and it stopps to remount the
all other devices.
The CL changes the behavior so that DiskMountManager continue to remounting even
if it fails to fetch properties of one device.
BUG=514012
TEST=None
Review URL: https://codereview.chromium.org/1281513002
Cr-Commit-Position: refs/heads/master@{#342574}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#342556}
|
|
|
|
|
|
|
|
|
|
| |
Follow up to https://codereview.chromium.org/1277693002/.
BUG=470893
Review URL: https://codereview.chromium.org/1278483003
Cr-Commit-Position: refs/heads/master@{#342301}
|
|
|
|
|
|
|
|
|
|
| |
OnlineAttempt and OnlineAttemptHost will be removed in a subsequent CL.
BUG=470893
Review URL: https://codereview.chromium.org/1277693002
Cr-Commit-Position: refs/heads/master@{#342218}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#342073}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a step towards removing URLRequestStatus::Status, stop creating FAILED
and CANCELED URLRequestStatuses without supplying an error.
IO_PENDING is left for later as that'll want a bit more careful auditing of
error() callers.
BUG=490311
Review URL: https://codereview.chromium.org/1239993004
Cr-Commit-Position: refs/heads/master@{#341913}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the interface to session_manager to pass the command line
as an array instead of a string. The previous code path would
(incorrectly) quote arguments and combine them into a string, and then
again parse and unquote them on the session_manager side, which is
unnecessary and error-prone. This changes the code to pass an array of
strings in the DBus call, which simplifies things considerably.
BUG=chromium:433172
TEST=Guest session starts successfully.
Review URL: https://codereview.chromium.org/1268973004
Cr-Commit-Position: refs/heads/master@{#341873}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#341860}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Sync loaded bluetooth devices on startup
* Sync new bluetooth devices after added by the system or another emulator client.
* Allow new bluetooth devices to require a pin or passkey when pairing.
BUG=514290
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/1258783009
Cr-Commit-Position: refs/heads/master@{#341537}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#341488}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#341476}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#341465}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds Cellular SIM functionality to the networkingPrivate API.
It also adds some functionality to the fake implementation to
better support testing.
BUG=277890
Review URL: https://codereview.chromium.org/1265513004
Cr-Commit-Position: refs/heads/master@{#341415}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last usage of this switch was removed in this CL:
https://codereview.chromium.org/1188693002/. We don't need to keep it
around.
BUG=501121
Review URL: https://codereview.chromium.org/1269793005
Cr-Commit-Position: refs/heads/master@{#341364}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
* Removes the 'Scanning' text from the network list
* When scanning starts: Starts the throbber (which fades
in), and fades the info button out. Clicking on the
Throbber is the same as clicking on the info button.
* When scanning stops: Stops the throbber (which fades out)
and fades the info button in.
BUG=490532
Review URL: https://codereview.chromium.org/1270623002
Cr-Commit-Position: refs/heads/master@{#341242}
|
|
|
|
|
|
|
|
|
|
|
|
| |
LOG(ERROR) Spam makes failing tests more difficult to debug
and obscures actual errors. This cleans up some spam that
always shows up when running on Linux with chromeos=1.
BUG=none
Review URL: https://codereview.chromium.org/1254013002
Cr-Commit-Position: refs/heads/master@{#341145}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#341064}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flakiness was caused by process output watcher sending exit output
during shutdown (if master end of watched pseudo terminal closure is
detected before write to shutdown pipe).
BUG=396496
Review URL: https://codereview.chromium.org/1254383005
Cr-Commit-Position: refs/heads/master@{#340983}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#340855}
|
|
|
|
|
|
|
|
|
| |
BUG=511996
TEST=None
Review URL: https://codereview.chromium.org/1255123002
Cr-Commit-Position: refs/heads/master@{#340828}
|
|
|
|
|
|
|
|
|
|
|
| |
up with hdmi output removed.
BUG=512601
TBR=mnissler,derat, rkc
Review URL: https://codereview.chromium.org/1262723002
Cr-Commit-Position: refs/heads/master@{#340794}
|
|
|
|
|
|
|
|
|
|
|
| |
Tests can still disable webview signing with "webview_signin_disabled"
preference.
BUG=470893
Review URL: https://codereview.chromium.org/1254283005
Cr-Commit-Position: refs/heads/master@{#340755}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#340649}
|
|
|
|
|
|
|
|
| |
BUG=419509
Review URL: https://codereview.chromium.org/1252873010
Cr-Commit-Position: refs/heads/master@{#340554}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#340419}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#340404}
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for selecting an existing Cellular APN
or specifying a custom one.
BUG=481563
Review URL: https://codereview.chromium.org/1246993004
Cr-Commit-Position: refs/heads/master@{#340312}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#340048}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#339842}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#339619}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#339415}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#339406}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#339391}
|
|
|
|
|
|
|
|
|
| |
BUG=352459
TEST=Verified on linux_chromeos.
Review URL: https://codereview.chromium.org/1237363002
Cr-Commit-Position: refs/heads/master@{#339334}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed the dependency of media to chromeos:audio.
Currently in CrasAudioManager, HasInputDevices always returns True.
We need to let HasInputDevices reflect the truth for device without
internal microphone like ChromeBox.
CrasAudioManager should gets the audio devices from CrasAudioHandler
and check if there is any input device of simple usage.
Add a property is_for_simple_usage to AudioDeviceType to indicate
that a device is for simple usage, not for special usage like
loopback, always on keyword mic, or keyboard mic.
This property can also replace the logic in audio_detailed_view.cc
to filter out the devices that we do not want to display in UI.
BUG=490851
TEST=Check audio devices in UI does not contain loopback devices.
TEST=Check virtual keyboard does not show microphone for chromebox
(Not tested yet).
TEST=Go to https://www.google.com/intl/en/chrome/demos/speech.html and
see the webpage says there is no microphone on this device.
R=dalecurtis@chromium.org, derat@chromium.org, dgreid@chromium.org, jennyz@chromium.org
Review URL: https://codereview.chromium.org/1186293003
Cr-Commit-Position: refs/heads/master@{#337791}
Review URL: https://codereview.chromium.org/1212013005
Cr-Commit-Position: refs/heads/master@{#339248}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#339226}
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change.
BUG=506255
TBR=jam
Review URL: https://codereview.chromium.org/1242023005
Cr-Commit-Position: refs/heads/master@{#339175}
|