| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#355744}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL replaces most of use of kSignInUser, kStubUser, kGuestUserName
with matching AccountIds.
This is part of transition to AccountId.
BUG=468875
TEST=manual
Review URL: https://codereview.chromium.org/1415343002
Cr-Commit-Position: refs/heads/master@{#355703}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#355504}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drop "requested statistic not found" warnings when probing for the
existance of a statistic or a flag using HasMachine*().
To that end, allow GetMachine{Statistic,Flag}() to be called with
nullptr |result| to achieve HasMachine{Statistic,Flag}() semantics
and in that case suppress the logging of warnings about non-existant
keys.
BUG=545909
Review URL: https://codereview.chromium.org/1408133005
Cr-Commit-Position: refs/heads/master@{#355502}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#355249}
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of transition to AccountId.
BUG=468875
TEST=manual
Review URL: https://codereview.chromium.org/1406023004
Cr-Commit-Position: refs/heads/master@{#355134}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#354998}
|
|
|
|
|
|
|
|
|
|
|
| |
Fix memory leak in onc_validator.cc::ReadDictionary by
using scoped_ptr.
BUG=543015
Review URL: https://codereview.chromium.org/1410733002
Cr-Commit-Position: refs/heads/master@{#354992}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#354701}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#354677}
|
|
|
|
|
|
|
|
|
| |
BUG=463221
TEST=manual
Review URL: https://codereview.chromium.org/1237023002
Cr-Commit-Position: refs/heads/master@{#354651}
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like I accidentally made this accessor return a
non-const reference long ago.
BUG=none
Review URL: https://codereview.chromium.org/1412743002
Cr-Commit-Position: refs/heads/master@{#354566}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ValueDeserializer::Deserialize return scoped_ptr
as almost all consumers already use scoped_ptr and it
is also better way to do it.
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1394993004
Cr-Commit-Position: refs/heads/master@{#354458}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#354232}
|
|
|
|
|
|
|
|
|
|
|
| |
The service currently only provides a ping method, but will
have more methods added in the near future.
BUG=b:24308453
Review URL: https://codereview.chromium.org/1403943003
Cr-Commit-Position: refs/heads/master@{#354108}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#353972}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#353697}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch renames base::MessageLoop::{Quit,QuitClosure} to
base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}.
BUG=131220
TEST=
R=oshima@chromium.org,stevenjb@chromium.org,reillyg@chromium.org
Review URL: https://codereview.chromium.org/1396083003
Cr-Commit-Position: refs/heads/master@{#353548}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#353462}
|
|
|
|
|
|
|
|
| |
BUG=538136
Review URL: https://codereview.chromium.org/1371253005
Cr-Commit-Position: refs/heads/master@{#353278}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#353240}
|
|
|
|
|
|
|
|
| |
Also adding some other overdue owners.
Review URL: https://codereview.chromium.org/1384443003
Cr-Commit-Position: refs/heads/master@{#352825}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#352790}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 5d3c8959a7aee861b6750fd734cad96bd24e1f9f.
This commit is breaking the valgrind tests.
R=rkc@chromium.org
TBR=armansito@chromium.org, stevenjb@chromium.org, sky@chromium.org
BUG=None.
Review URL: https://codereview.chromium.org/1382923003
Cr-Commit-Position: refs/heads/master@{#352581}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#352298}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#352273}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#351970}
|
|
|
|
|
|
|
|
| |
BUG=506185
Review URL: https://codereview.chromium.org/1212433006
Cr-Commit-Position: refs/heads/master@{#351579}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#351506}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#351263}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be able to reuse the bluetooth DBus clients on linux, we need to be able
to separate them out from DBusThreadManager and move them out of //chromeos.
This CL introduces no functional change but instead only refactors the code
so we now have a BluezDbusManager that handles a Bluetooth specific DBus
client bundle to create all the bluetooth related DBus clients. We will
be able to extend this code to add a Linux specific BluezDbusManager
implementation, allowing us to reuse all these DBus clients on Linux instead
of copy/pasting the code.
R=armansito@chromium.org, stevenjb@chromium.org
BUG=522663
Review URL: https://codereview.chromium.org/1347193004
Cr-Commit-Position: refs/heads/master@{#351197}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* This houses previously static methods of NetworkPortalDetector, such as Get (now GetInstance), IsInitialized, InitializeForTesting, etc.
* InitializeNetworkPortalDetector moved to cbmc
* Number of renames of NetworkPortalDetector:: to network_portal_detector::
Files with non-trivial changes:
network_portal_detector_impl.{cc|h}
network_portal_detector.{cc|h}
chrome_browser_main_chromeos.cc
Everything else is a mechanical search/replace
BUG=530485
TEST=unit tests and browser tests.
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/1358343003
Cr-Commit-Position: refs/heads/master@{#351153}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#351006}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#350988}
|
|
|
|
|
|
|
|
|
|
| |
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/1366123002
Cr-Commit-Position: refs/heads/master@{#350770}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The base class for OneShotTimer and DelayedTimer is templated but
only the Start method needs to be (which has a TODO to make it go away
entirely too).
The DelayedTimer class is also templated but only its constructor
needs to be, and the type can be inferred at the callsite, so less
typing all around.
R=thakis@chromium.org
TBR=sky,brettw
BUG=148832
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1355063004
Cr-Commit-Position: refs/heads/master@{#350496}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* NetworkPortalNotificationController directly observes network and portal changes.
* conditionally create NetworkPortalNotificationController
* move NetworkPortalDetectorStubImpl to stub files.
* make interface implementations private
* initialize data members in header
BUG=530485
TEST=unit tests and browser tests.
Review URL: https://codereview.chromium.org/1346843003
Cr-Commit-Position: refs/heads/master@{#350202}
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:34535
TEST=manual
Review URL: https://codereview.chromium.org/1352213002
Cr-Commit-Position: refs/heads/master@{#350124}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#350121}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=zelidrag@chromium.org,derat@chromium.org,gauravsh@chromium.org
Review URL: https://codereview.chromium.org/1353323002
Cr-Commit-Position: refs/heads/master@{#350078}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#349908}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#349877}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#349857}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
convenience for its only client (in the downstream CL), NetInfo.
This CL also ensures that MaxBandwidthObserver is called on every platform when the network type changes.
Upstream of https://codereview.chromium.org/1306423004/
BUG=412741
Review URL: https://codereview.chromium.org/1306653003
Cr-Commit-Position: refs/heads/master@{#349673}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#349359}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additional owners for NetworkPortalDetector
Other minor fixes.
BUG=530485
Review URL: https://codereview.chromium.org/1346763002
Cr-Commit-Position: refs/heads/master@{#349077}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#348846}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#348585}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#348537}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#348349}
|