summaryrefslogtreecommitdiffstats
path: root/cloud_print/service/win
Commit message (Collapse)AuthorAgeFilesLines
* win: Work on reducing style plugin warnings in content/, cloud_print/thakis2015-05-041-0/+4
| | | | | | | | | BUG=123295,467287 TBR=vitalybuka Review URL: https://codereview.chromium.org/1119243002 Cr-Commit-Position: refs/heads/master@{#328088}
* Update {virtual,override} to follow C++11 style in cloud_print.nick2015-04-274-10/+11
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1100633004 Cr-Commit-Position: refs/heads/master@{#327154}
* Remove uses of KillProcess()rvargas2015-03-181-12/+18
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/999033003 Cr-Commit-Position: refs/heads/master@{#321045}
* Refactor chrome_launcher_support::GetAnyChromePath.mgiuca2015-01-142-4/+7
| | | | | | | | | | | | Combined GetAnyChromePath and GetChromeSxSPath into one function that takes a bool |is_sxs|. Avoids the need to have a wrapper function that conditionally calls GetAnyChromePath or GetAnyChromeSxsPath. BUG=428600 Review URL: https://codereview.chromium.org/685103004 Cr-Commit-Position: refs/heads/master@{#311384}
* Remove implicit conversions from scoped_refptr to T* in cloud_print/dcheng2014-11-211-1/+1
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Review URL: https://codereview.chromium.org/745323002 Cr-Commit-Position: refs/heads/master@{#305255}
* Enable MSVC warning for unused locals.Peter Kasting2014-11-201-3/+7
| | | | | | | | | | | | | | There is seemingly a bug in the compiler where it occasionally claims a local is unused when it isn't. This forces a few places to either inline such locals or mark them ALLOW_UNUSED_LOCAL. BUG=81439 TEST=none R=brettw@chromium.org, cpu@chromium.org, jamesr@chromium.org, rvargas@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, wolenetz@chromium.org Review URL: https://codereview.chromium.org/731373002 Cr-Commit-Position: refs/heads/master@{#305108}
* Prefix CommandLine usage with base namespace (Part 7: cloud_print/)pgal.u-szeged2014-11-196-16/+19
| | | | | | | | | | | | Prefix all CommandLine usage in the cloud_print/ directory with the base:: namespace. R=vitalybuka@chromium.org BUG=422426 Review URL: https://codereview.chromium.org/735053002 Cr-Commit-Position: refs/heads/master@{#304744}
* Replacing the OVERRIDE with override and FINAL with final in cloud_printmohan.reddy2014-10-064-6/+6
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/630753002 Cr-Commit-Position: refs/heads/master@{#298210}
* Remove implicit HANDLE conversions from cloud_print.rvargas2014-09-254-21/+23
| | | | | | | | | BUG=416722 R=gene@chromium.org Review URL: https://codereview.chromium.org/606443003 Cr-Commit-Position: refs/heads/master@{#296582}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, ↵thestig2014-09-106-6/+6
| | | | | | | | | | chromecast/, cloud_print/, mojo/, and win8/ TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/559743002 Cr-Commit-Position: refs/heads/master@{#294139}
* Revert of Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-311-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/) Reason for revert: Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.) Original issue's description: > Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) > > Reason for revert: > Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 > > InstallerStateTest.InitializeTwice (run #1): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) > > InstallerStateTest.InitializeTwice (run #2): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) > > > Original issue's description: > > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > > > Also don't use "default" as a variable name, as it's a keyword. > > Also fix a bug where a wstring was passed to %ls. > > > > No real behavior change. > > > > BUG=82385 > > R=hans@chromium.org > > TBR=cpu, vitalybuka > > > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 > > TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=82385 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/525013003 Cr-Commit-Position: refs/heads/master@{#292818}
* Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-301-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) Reason for revert: Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 InstallerStateTest.InitializeTwice (run #1): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) InstallerStateTest.InitializeTwice (run #2): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) Original issue's description: > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > Also don't use "default" as a variable name, as it's a keyword. > Also fix a bug where a wstring was passed to %ls. > > No real behavior change. > > BUG=82385 > R=hans@chromium.org > TBR=cpu, vitalybuka > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/519463003 Cr-Commit-Position: refs/heads/master@{#292809}
* clang/win: Fix a few warnings in targets not in chromium_builder_tests.Nico Weber2014-08-291-4/+5
| | | | | | | | | | | | | | | Also don't use "default" as a variable name, as it's a keyword. Also fix a bug where a wstring was passed to %ls. No real behavior change. BUG=82385 R=hans@chromium.org TBR=cpu, vitalybuka Review URL: https://codereview.chromium.org/526513002 Cr-Commit-Position: refs/heads/master@{#292699}
* Don't pass const strings to CreateProcess.thakis@chromium.org2014-08-201-1/+3
| | | | | | | | | | | | | | The documentation says that CreateProcess() can modify its second parameter in UNICODE builds. BUG=396705 R=scottmg@chromium.org, vitalybuka@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/487303004 Cr-Commit-Position: refs/heads/master@{#290890} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98
* Removed --disable-background-mode/restore-background-contents flags.atwilson@chromium.org2014-06-071-3/+0
| | | | | | | | BUG=350898 Review URL: https://codereview.chromium.org/317203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275698 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce IPC::Channel::Create*() to ensure it being heap-allocated.morrita@chromium.org2014-05-302-4/+4
| | | | | | | | | | | | | | | | | | | | | This change introduces IPC::Channel::Create*() API to turn IPC::Channel into a heap allocated object. This will allow us to make Channel a polymorphic class. This change also tries to hide Channel::Mode from public API so that we can simplify channel creation code paths cleaner in following changes. ChannelProxy has to follow same pattern to finish this cleanup. Such changes will follow. TEST=none BUG=377980 R=darin@chromium.org,cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273575 Review URL: https://codereview.chromium.org/307653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273713 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed url to manage specific cloud printers.vitalybuka@chromium.org2014-04-241-1/+1
| | | | | | | | | | Device id is ref string, not relative path. BUG=366575 Review URL: https://codereview.chromium.org/258623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266043 0039d316-1c4b-4281-b951-d872f2087c98
* Moved CloudPrintUrl to components/cloud_devices/cloud_devices_urls.h.vitalybuka@chromium.org2014-04-202-23/+5
| | | | | | | | | | Removed unused cloud print prefs. TBR=jochen, rogerta Review URL: https://codereview.chromium.org/240283010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264945 0039d316-1c4b-4281-b951-d872f2087c98
* Added --cloud-print-xmpp-endpoint to make possible test with non-default ↵vitalybuka@chromium.org2014-04-151-0/+1
| | | | | | | | XMPP server. Review URL: https://codereview.chromium.org/231913004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702), misc. edition.pkasting@chromium.org2014-03-181-17/+12
| | | | | | | | | | | | This CL covers top-level directories that only had one or two modified files. BUG=346399 TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/203043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257705 0039d316-1c4b-4281-b951-d872f2087c98
* Move CommandLine to base namespace.brettw@chromium.org2014-03-173-6/+6
| | | | | | | | | | | | Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Review URL: https://codereview.chromium.org/196413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
* Move WriteFile and WriteFileDescriptor from file_util to base namespace.brettw@chromium.org2014-03-063-5/+5
| | | | | | | | | R=viettrungluu@chromium.org TBR=viettrungluu Review URL: https://codereview.chromium.org/184563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
* Enable CDD in cloud print connector on windows by default.vitalybuka@chromium.org2014-02-251-0/+1
| | | | | | | | | | | Added flag to switch back to XPS if needed. BUG=317027, 281494 NOTRY=true Review URL: https://codereview.chromium.org/179363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253273 0039d316-1c4b-4281-b951-d872f2087c98
* message-pump: Change how MessagePumpDispatchers process events.sadrul@chromium.org2014-02-081-6/+5
| | | | | | | | | | | | | | | | | | This patch allows a MessagePumpDispatcher to invoke the default handling of the message in the message-pump by setting the DISPATCH_DEFAULT flag on the return value from the ::Dispatch() callback. As before, the dispatcher can still request a termination of the current message-loop, but setting the DISPATCH_QUIT flag on the return value (instead of returning false). The callback can set both flags, in which case the message-loop will perform the default action, and also terminate the current loop. As a result of this, we can remove duplicate code, namely aura::DispatcherWin, and aura::Env::GetDispatcher(), that performs the same action as the default message pump. R=darin@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/152083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249860 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter""yukawa@chromium.org2014-02-071-11/+15
| | | | | | | | | | | This reverts commit 33c0f57d77e38a009034fb7d0e905755d9620035 with a trivial modification to corp with a recent refactoring committed as r249105. BUG=330735, 319122 Review URL: https://codereview.chromium.org/143503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249650 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 249234 "Use MessagePumpDispatcher instead of MessageFilter"vitalybuka@chromium.org2014-02-061-16/+11
| | | | | | | | | | | | | | | | | | | Failed non-Aura build. > Use MessagePumpDispatcher instead of MessageFilter > > This is a preparation to remove base::MessageLoopForUI::MessageFilter. > > BUG=330735, 319122 > TEST=done by manually executing cloud_print_service_config.exe > > Review URL: https://codereview.chromium.org/152033005 TBR=yukawa@chromium.org Review URL: https://codereview.chromium.org/150283005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249268 0039d316-1c4b-4281-b951-d872f2087c98
* Use MessagePumpDispatcher instead of MessageFilteryukawa@chromium.org2014-02-061-11/+16
| | | | | | | | | | | This is a preparation to remove base::MessageLoopForUI::MessageFilter. BUG=330735, 319122 TEST=done by manually executing cloud_print_service_config.exe Review URL: https://codereview.chromium.org/152033005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249234 0039d316-1c4b-4281-b951-d872f2087c98
* Removes MessageLoop::Type checks in favor of IsCurrent on MessageLoops.sky@chromium.org2014-01-201-10/+10
| | | | | | | | | | | | This is part of removing the MessageLoop::Type enum. BUG=none TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/141683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245882 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of char16 to use the base:: namespace.avi@chromium.org2013-12-251-1/+1
| | | | | | | | | | BUG=329295 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/113403006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242503 0039d316-1c4b-4281-b951-d872f2087c98
* Use base namespace for string16 in components and cloud_print.brettw@chromium.org2013-12-0611-69/+73
| | | | | | | | | R=scottbyer@chromium.org TBR=scottbyer Review URL: https://codereview.chromium.org/107383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239255 0039d316-1c4b-4281-b951-d872f2087c98
* Move directory creation functions to base namespace.brettw@chromium.org2013-12-032-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/100573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
* Move temp file functions to base namespace.brettw@chromium.org2013-12-031-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/99923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-281-6/+7
| | | | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459 Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/71013004/hashimoto@chromium.org2013-11-271-7/+6
| | | | | | | | | | | | Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803 TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/90963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-271-6/+7
| | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed serial number, service name and firmware version of GCP 2.0 prototype.vitalybuka@chromium.org2013-11-211-1/+1
| | | | | | Review URL: https://codereview.chromium.org/77343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert https://src.chromium.org/viewvc/chrome?view=rev&revision=231330bbudge@chromium.org2013-11-041-1/+1
| | | | | | | | | | This is a speculative revert to see if it's the cause of hanging renderers. BUG=313112 Review URL: https://codereview.chromium.org/57783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232819 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused IPC::Message priority.bbudge@chromium.org2013-10-281-1/+1
| | | | | | | | | | | | | | | | | Removes the PriorityValue enum and field from IPC::Message. This doesn't appear to be used anywhere. Changes the data message ctor to take a size_t data_len parameter. This works around an ambiguity problem with the main ctor, which has a similar signature and would require lots of futzing with our test code to fix. To make this work, the matching Pickle constructor is also changed to take a size_t data_len parameter. BUG=194304 Review URL: https://codereview.chromium.org/35643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
* test IWYU fixups for basemostynb@opera.com2013-09-031-0/+3
| | | | | | | | | | | | | These are some of the suggestions from running include-what-you-use[1] on the base target. [1] https://code.google.com/p/include-what-you-use/ BUG=259043 Review URL: https://chromiumcodereview.appspot.com/23540009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221067 0039d316-1c4b-4281-b951-d872f2087c98
* Move ReadFileToString to the base namespace.brettw@chromium.org2013-08-303-3/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/19579005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98
* Move ScopedClosureRunner to callback_helpers, add Reset.avi@chromium.org2013-08-302-0/+2
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/23514018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220473 0039d316-1c4b-4281-b951-d872f2087c98
* Make element removal methods in DictionaryValue and ListValue take ↵bauerb@chromium.org2013-08-061-2/+2
| | | | | | | | | | | scoped_ptr's as outparams. TBR=pneubeck@chromium.org,scottbyer@chromium.org BUG=263894 Review URL: https://chromiumcodereview.appspot.com/21030009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215885 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in cloud_print for base/process changes.rsesek@chromium.org2013-07-241-2/+2
| | | | | | | | | BUG=242290 TBR=abodenha@chromium.org Review URL: https://chromiumcodereview.appspot.com/19525006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213455 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in cc/, chrome_frame/, ↵avi@chromium.org2013-07-171-1/+1
| | | | | | | | | | | | cloud_print/, components. BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212143 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base::Delete to base::DeleteFilebrettw@chromium.org2013-07-162-5/+5
| | | | | | | | | | | Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Review URL: https://codereview.chromium.org/18584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211822 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate from googleurl/ includes to url/ ones in the remaining top-level ↵tfarina@chromium.org2013-07-131-1/+1
| | | | | | | | | | | directories. BUG=229660 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/18919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-112-3/+3
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util::Delete to the base namespacebrettw@chromium.org2013-07-012-5/+5
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/16950028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209475 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome_frame/, chromeos/, ↵avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | | | cloud_print/, components/. BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/18054007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209068 0039d316-1c4b-4281-b951-d872f2087c98
* Define a LoggingSettings struct to use for InitLogging()akalin@chromium.org2013-06-211-5/+3
| | | | | | | | | | | | | | | | | | Update all callers of InitLogging() to use LoggingSettings, only setting fields that need a non-default value. Turn LoggingDestination enum into a bit field and define add LOG_DEFAULT and LOG_ALL constants. Fix erroneous comment saying that the default was to not lock the log file. BUG=247594 TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/16519003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-23 13:52:02 +0000