| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/14509007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/14260007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/14260010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use SUBSYSTEM:WINDOWS to avoid console shows up.
TBR=gene, need official build by tomorrow.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14328054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Close chrome if service state is ready.
- Better service display name and description.
- Removed argument from ServiceController constructor.
BUG=168692
Review URL: https://chromiumcodereview.appspot.com/14333022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=gene
Review URL: https://chromiumcodereview.appspot.com/14098008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added Google Update integration.
R=gene
BUG=229183
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14358019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=gene
Review URL: https://chromiumcodereview.appspot.com/14417005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=gene
Review URL: https://chromiumcodereview.appspot.com/14358018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
avoid Windows installer detector.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14225025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ATL::CSid::LoadAccount can't lookup .\ names.
R=gene
Review URL: https://chromiumcodereview.appspot.com/14272004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=gene
Review URL: https://chromiumcodereview.appspot.com/14107007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13991009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XP bots are still red, and it's still whining about URL.DLL
> Lets try this again.
>
> Revert 193983 "Revert 193968 "Roll the DEPS for google-url.""
>
> > Revert 193968 "Roll the DEPS for google-url."
> >
> > > Roll the DEPS for google-url.
> > >
> > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
> > >
> > > This also changes googleurl.gyp to reference the files under url/, so that we
> > > don't break the Blink tree.
> > >
> > > BUG=229660
> > > R=brettw@chromium.org
> > > TBR=brettw@chromium.org
> > >
> > > Review URL: https://chromiumcodereview.appspot.com/14089011
> >
> > TBR=tfarina@chromium.org
> > Review URL: https://codereview.chromium.org/14028012
>
> TBR=michaeln@google.com
> Review URL: https://codereview.chromium.org/14109014
TBR=michaeln@google.com
Review URL: https://codereview.chromium.org/14263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 193983 "Revert 193968 "Roll the DEPS for google-url.""
> Revert 193968 "Roll the DEPS for google-url."
>
> > Roll the DEPS for google-url.
> >
> > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
> >
> > This also changes googleurl.gyp to reference the files under url/, so that we
> > don't break the Blink tree.
> >
> > BUG=229660
> > R=brettw@chromium.org
> > TBR=brettw@chromium.org
> >
> > Review URL: https://chromiumcodereview.appspot.com/14089011
>
> TBR=tfarina@chromium.org
> Review URL: https://codereview.chromium.org/14028012
TBR=michaeln@google.com
Review URL: https://codereview.chromium.org/14109014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Roll the DEPS for google-url.
>
> And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
>
> This also changes googleurl.gyp to reference the files under url/, so that we
> don't break the Blink tree.
>
> BUG=229660
> R=brettw@chromium.org
> TBR=brettw@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/14089011
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/14028012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
This also changes googleurl.gyp to reference the files under url/, so that we
don't break the Blink tree.
BUG=229660
R=brettw@chromium.org
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14089011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it.
I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this.
After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK.
BUG=
Review URL: https://codereview.chromium.org/13196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a manual cleanup pass using sed for files which are not built on
Linux.
BUG=171111
Review URL: https://chromiumcodereview.appspot.com/13842004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=229183
Review URL: https://chromiumcodereview.appspot.com/13912002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two Install methods to distinguish between different install cases.
Methods to query service status.
BUG=229183
Review URL: https://chromiumcodereview.appspot.com/13845002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AbsolutePath convert empty values to abs path to current dir.
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/13901003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13770012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13800005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13771017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Shorter target names.
Review URL: https://chromiumcodereview.appspot.com/13637008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=143234
Review URL: https://chromiumcodereview.appspot.com/13151003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=224219
Review URL: https://chromiumcodereview.appspot.com/13042016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 224219
Review URL: https://chromiumcodereview.appspot.com/13119004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=223485
Review URL: https://chromiumcodereview.appspot.com/12521031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13003005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12924005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/13054003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows to avoid asking user to create
BUG=223485
Review URL: https://chromiumcodereview.appspot.com/13039002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=gene
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12989026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=gene
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12676018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=gene
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189064
Review URL: https://chromiumcodereview.appspot.com/12929008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=gene
Review URL: https://codereview.chromium.org/12929008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12797003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12471009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/12745003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=0
Review URL: https://chromiumcodereview.appspot.com/12729003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
Review URL: https://chromiumcodereview.appspot.com/12702004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like caused the following "compile error".
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/1363/steps/compile/logs/stdio
FAILED: C:\b\depot_tools\python_bin\python.exe gyp-win-tool rc-wrapper environment.x64 rc.exe ... ..\..\cloud_print\service\win\cloud_print_service.rc
..\..\cloud_print\service\win\cloud_print_service.rc(13) : fatal error RC1015: cannot open include file 'version.h'.
BUG=0
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12412017
TBR=vitalybuka@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12412017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12545012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
monitor.
Driver and port monitor both check for XPS presence, but only driver set Google Update error string on fail.
Better logging.
BUG=179290
Review URL: https://chromiumcodereview.appspot.com/12416007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=179290
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12389088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unpack dependencies from cache and system directory.
Don't use Low Integrity App Data.
TBR=gene
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12347004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|