| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/689563002
Cr-Commit-Position: refs/heads/master@{#303095}
|
|
|
|
|
|
|
|
|
|
|
| |
enable_printing and printing_mode replaced with
enable_basic_printing and enable_print_preview.
BUG=430281
Review URL: https://codereview.chromium.org/702023002
Cr-Commit-Position: refs/heads/master@{#302905}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppresses 4 warnings that look like
In file included from ..\..\cloud_print\service\win\cloud_print_service.cc:32:
..\..\cloud_print/service/win/service_controller.h(28,3) : warning(clang): ISO C++11 does not allow conversion from string literal to 'TCHAR *' (aka 'wchar_t *') [-Wwritable-strings]
DECLARE_REGISTRY_APPID_RESOURCEID(IDR_CLOUDPRINTSERVICE,
^
C:\b\depot_tools\win_toolchain\vs2013_files/VC/atlmfc/include\atlbase.h(3086,10) : note(clang): expanded from macro 'DECLARE_REGISTRY_APPID_RESOURCEID'
return _T(appid); \
^
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\tchar.h(2498,21) : note(clang): expanded from macro '_T'
^
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\tchar.h(206,21) : note(clang): expanded from macro '__T'
^
<scratch space>(20,1) : note(clang): expanded from here
L"{8013FB7C-2E3E-4992-B8BD-05C0C4AB0627}"
^
1 warning generated.
BUG=82385
Review URL: https://codereview.chromium.org/686683004
Cr-Commit-Position: refs/heads/master@{#302471}
|
|
|
|
|
|
|
|
|
|
|
| |
Not used except for cloud print.
BUG=426573
TBR=rvargas
Review URL: https://codereview.chromium.org/681533002
Cr-Commit-Position: refs/heads/master@{#301473}
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/657313004
Cr-Commit-Position: refs/heads/master@{#300140}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into two classes - one for chunked uploads, one for non-chunked uploads.
This refactoring is aimed at allowing Cronet to add another
implementation for use on Android.
Splitting the logic for the chunked and non-chunked uploads isn't
necessary for that, but the two paths didn't share much code, and
keeping them as one class seems ugly.
BUG=412942
Review URL: https://codereview.chromium.org/560893004
Cr-Commit-Position: refs/heads/master@{#298966}
|
|
|
|
|
|
|
|
|
|
|
| |
This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.
BUG=417463
Review URL: https://codereview.chromium.org/630753002
Cr-Commit-Position: refs/heads/master@{#298210}
|
|
|
|
|
|
|
|
|
|
| |
buffer sizes to 100 MB
BUG=
Review URL: https://codereview.chromium.org/594393002
Cr-Commit-Position: refs/heads/master@{#296881}
|
|
|
|
|
|
|
|
|
| |
BUG=416722
R=gene@chromium.org
Review URL: https://codereview.chromium.org/606443003
Cr-Commit-Position: refs/heads/master@{#296582}
|
|
|
|
|
|
|
|
|
|
| |
By default both enabled.
TBR=gene@chromium.org
Review URL: https://codereview.chromium.org/598433002
Cr-Commit-Position: refs/heads/master@{#296150}
|
|
|
|
|
|
|
|
| |
TBR=gene@chromium.org
Review URL: https://codereview.chromium.org/587103002
Cr-Commit-Position: refs/heads/master@{#295925}
|
|
|
|
|
|
|
|
|
|
| |
chromecast/, cloud_print/, mojo/, and win8/
TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org
Review URL: https://codereview.chromium.org/559743002
Cr-Commit-Position: refs/heads/master@{#294139}
|
|
|
|
|
|
|
|
| |
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/542973002
Cr-Commit-Position: refs/heads/master@{#293440}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We recently switched from building chromium_builder_tests to building
everything, this fixes almost all warnings in the ~1000 translation units
we weren't compiling before.
No behavior change.
BUG=82385
R=scottmg@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/543923002
Cr-Commit-Position: refs/heads/master@{#293393}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/)
Reason for revert:
Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.)
Original issue's description:
> Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)
>
> Reason for revert:
> Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
>
> InstallerStateTest.InitializeTwice (run #1):
> [ RUN ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
> Actual: false
> Expected: true
> [ FAILED ] InstallerStateTest.InitializeTwice (219 ms)
>
> InstallerStateTest.InitializeTwice (run #2):
> [ RUN ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
> Actual: false
> Expected: true
> [ FAILED ] InstallerStateTest.InitializeTwice (109 ms)
>
>
> Original issue's description:
> > clang/win: Fix a few warnings in targets not in chromium_builder_tests.
> >
> > Also don't use "default" as a variable name, as it's a keyword.
> > Also fix a bug where a wstring was passed to %ls.
> >
> > No real behavior change.
> >
> > BUG=82385
> > R=hans@chromium.org
> > TBR=cpu, vitalybuka
> >
> > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09
>
> TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=82385
>
> Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23
TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385
Review URL: https://codereview.chromium.org/525013003
Cr-Commit-Position: refs/heads/master@{#292818}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)
Reason for revert:
Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
InstallerStateTest.InitializeTwice (run #1):
[ RUN ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
Actual: false
Expected: true
[ FAILED ] InstallerStateTest.InitializeTwice (219 ms)
InstallerStateTest.InitializeTwice (run #2):
[ RUN ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
Actual: false
Expected: true
[ FAILED ] InstallerStateTest.InitializeTwice (109 ms)
Original issue's description:
> clang/win: Fix a few warnings in targets not in chromium_builder_tests.
>
> Also don't use "default" as a variable name, as it's a keyword.
> Also fix a bug where a wstring was passed to %ls.
>
> No real behavior change.
>
> BUG=82385
> R=hans@chromium.org
> TBR=cpu, vitalybuka
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09
TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385
Review URL: https://codereview.chromium.org/519463003
Cr-Commit-Position: refs/heads/master@{#292809}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also don't use "default" as a variable name, as it's a keyword.
Also fix a bug where a wstring was passed to %ls.
No real behavior change.
BUG=82385
R=hans@chromium.org
TBR=cpu, vitalybuka
Review URL: https://codereview.chromium.org/526513002
Cr-Commit-Position: refs/heads/master@{#292699}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/513503002
Cr-Commit-Position: refs/heads/master@{#292076}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpServer. (patchset #29 of https://codereview.chromium.org/296053012/)"
This reverts commit 0b2f33f4a88efbd203b0623324ad4114e3bb9d23.
This is relanding CL of https://codereview.chromium.org/296053012/, which broke http server unittests because http server doesn't send response synchronously any more.
This CL fixes unittests by reading responses completely.
Patch set #1 is same to the original CL.
Patch set #2 is the diff.
BUG=371906
TBR=pfeldman@chromium.org,darin@chromium.org,gunsch@chromium.org,mnaganov@chromium.org
Review URL: https://codereview.chromium.org/487013003
Cr-Commit-Position: refs/heads/master@{#291784}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #29 of https://codereview.chromium.org/296053012/)
Reason for revert:
looks like it caused net_unittests failures: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/44610/steps/net_unittests/logs/MultipleRequestsOnSameConnection
Original issue's description:
> Replace StreamListenSocket with StreamSocket in HttpServer.
>
> 1) HttpServer gets ServerSocket instead of StreamListenSocket.
> 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers.
> 3) HttpServer handles data buffering and asynchronous read/write.
> 4) HttpConnection has limit in data buffering, up to 1Mbytes by default.
> 5) For devtools, send buffer limit is 100Mbytes.
> 6) Unittests for buffer handling in HttpConnection.
>
> BUG=371906
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291447
NOTREECHECKS=true
NOTRY=true
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/497223003
Cr-Commit-Position: refs/heads/master@{#291521}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) HttpServer gets ServerSocket instead of StreamListenSocket.
2) HttpConnection is just a container for socket, websocket, and pending read/write buffers.
3) HttpServer handles data buffering and asynchronous read/write.
4) HttpConnection has limit in data buffering, up to 1Mbytes by default.
5) For devtools, send buffer limit is 100Mbytes.
6) Unittests for buffer handling in HttpConnection.
BUG=371906
Review URL: https://codereview.chromium.org/296053012
Cr-Commit-Position: refs/heads/master@{#291447}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite to allowing a URLRequestJob to transparently wrap
a URLRequest, so AppCache can override the response for failing and
redirected requests without the NetworkDelegate or URLRequest::Delegate
being aware of the underlying request.
Also consolidate the URLRequest constructors, and make most code create
URLRequests through the URLRequestContext's CreateRequest function,
rather than through its constructor.
TBR=battre@chromium.org
BUG=161547
Review URL: https://codereview.chromium.org/407093011
Cr-Commit-Position: refs/heads/master@{#291090}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The documentation says that CreateProcess() can modify its second parameter
in UNICODE builds.
BUG=396705
R=scottmg@chromium.org, vitalybuka@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/487303004
Cr-Commit-Position: refs/heads/master@{#290890}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/448853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many win32 APIs take non-const string pointers. I checked that MSDN documents
them as _In_ and says that they are inputs, and then added const_cast<>s at
the calling sites. (In one test, I introduced a helper struct so that there
can be fewer casts.)
This wasn't just busywork, I found one function that we were handing string
literals where the documentation explicitly said that that's not valid
(filed http://crbug.com/396705).
I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print;
it sounds like that'll fix itself when we update to the 2014 sdk:
http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013
BUG=396705,82385
R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/413763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Removed temp variables to avoid other confusions.
Review URL: https://codereview.chromium.org/413553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Taking the address of a temporary
* Octal escape sequence terminated by decimal number
* Signedness mismatch
* Possibly-uninitialized local variable
This also contains a small number of cleanups to nearby code (e.g. no else after return).
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/382673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=350898
Review URL: https://codereview.chromium.org/317203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces IPC::Channel::Create*() API to turn
IPC::Channel into a heap allocated object. This will allow us to
make Channel a polymorphic class.
This change also tries to hide Channel::Mode from public API
so that we can simplify channel creation code paths cleaner in
following changes. ChannelProxy has to follow same pattern to
finish this cleanup. Such changes will follow.
TEST=none
BUG=377980
R=darin@chromium.org,cpu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273575
Review URL: https://codereview.chromium.org/307653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Device id is ref string, not relative path.
BUG=366575
Review URL: https://codereview.chromium.org/258623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removed unused cloud print prefs.
TBR=jochen, rogerta
Review URL: https://codereview.chromium.org/240283010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a large number of other files that were depending on this
include.
BUG=none
TBR=gene@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/235333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
XMPP server.
Review URL: https://codereview.chromium.org/231913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL covers top-level directories that only had one or two modified files.
BUG=346399
TEST=none
R=darin@chromium.org
Review URL: https://codereview.chromium.org/203043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all forward-declares and header files referencing CommandLine.
This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up.
TBR=sky
Review URL: https://codereview.chromium.org/196413016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=350118
Review URL: https://codereview.chromium.org/196863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the base namespace
This function is only used in a few places and can trivially be implemented by passing the whitespace constant to the existing ContainsOnlyChars function.
This changes the ContainsOnlyChars function signature to take a StringPiece to avoid a copy from a literal to a standard string in the above-mentioned use-base.
Re-implement ContainsOnlyChars to use the find_first_not_of function on StringPiece.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/183683024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TBR=viettrungluu
Review URL: https://codereview.chromium.org/184563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=noamsml
NOTRY=true
Review URL: https://codereview.chromium.org/183803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Defines some papers supported by Cloud Print.
BUG=345159
NOTRY=true
Review URL: https://codereview.chromium.org/184363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=344741
Review URL: https://codereview.chromium.org/183273008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To remove this dependency we ended up moving big_endian* to base/, since besides ui/,
big_endian is also used by other top-level modules: chrome/utility/, cloud_print, media/cast
This way we removed one more net dependency from ui/base/.
BUG=299841
TEST=ui_unittests
R=tony@chromium.org,mark@chromium.org,hclam@chromium.org,vitalybuka@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/145873006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added flag to switch back to XPS if needed.
BUG=317027, 281494
NOTRY=true
Review URL: https://codereview.chromium.org/179363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=343792
OK, it's been almost a week now, with regular pings to OWNERs, so I guess it's OK to TBR... It's only Gyp/script changes anyway... Feel free to uncheck the CQ box if you disagree...
TBR=beng@chromium.org, darin@chromium.org
Review URL: https://codereview.chromium.org/165893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Shortened service name.
Added AAAA response.
Review URL: https://codereview.chromium.org/131103028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/159343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch allows a MessagePumpDispatcher to invoke the default handling of the message
in the message-pump by setting the DISPATCH_DEFAULT flag on the return value from the
::Dispatch() callback. As before, the dispatcher can still request a termination of the
current message-loop, but setting the DISPATCH_QUIT flag on the return value (instead of
returning false). The callback can set both flags, in which case the message-loop will
perform the default action, and also terminate the current loop.
As a result of this, we can remove duplicate code, namely aura::DispatcherWin, and
aura::Env::GetDispatcher(), that performs the same action as the default message pump.
R=darin@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/152083004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 33c0f57d77e38a009034fb7d0e905755d9620035 with a trivial
modification to corp with a recent refactoring committed as r249105.
BUG=330735, 319122
Review URL: https://codereview.chromium.org/143503004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249650 0039d316-1c4b-4281-b951-d872f2087c98
|