summaryrefslogtreecommitdiffstats
path: root/cloud_print
Commit message (Collapse)AuthorAgeFilesLines
* Replace ToLower calls to the new formatbrettw2015-08-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Review URL: https://codereview.chromium.org/1279123004 Cr-Commit-Position: refs/heads/master@{#342659}
* Update cloud_print for attachment brokering.erikchen2015-07-301-2/+5
| | | | | | | | | | | The windows cloud print service doesn't attempt to send or receive brokerable attachments, so it doesn't need to create or set up an attachment broker. BUG=493414 Review URL: https://codereview.chromium.org/1258313003 Cr-Commit-Position: refs/heads/master@{#341157}
* Fix -Wswitch warnings in //cloud_printdcheng2015-07-242-0/+4
| | | | | | | | BUG=505308 Review URL: https://codereview.chromium.org/1256953002 Cr-Commit-Position: refs/heads/master@{#340334}
* Revert "Preliminary support for Windows manifests in the GN build."Nico Weber2015-07-212-1/+9
| | | | | | | | | | | This reverts https://codereview.chromium.org/1240893004/ , it broke building remoting in the gyp build (see comment on the review). TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1249723002. Cr-Commit-Position: refs/heads/master@{#339669}
* Preliminary support for Windows manifests in the GN build.brettw2015-07-212-9/+1
| | | | | | | | | | | | | | Adds manifest data for content shell. The result matches the GYP build. Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome. Moved the common control compat files that were duplicated to a shared place in build/win, update cloud_print and remoting which had their own copies to use this shared one. BUG=510612 Review URL: https://codereview.chromium.org/1240893004 Cr-Commit-Position: refs/heads/master@{#339663}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+2
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+2
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* Move ReplaceStringPlaceholders to base namespace.brettw2015-07-151-1/+2
| | | | | | | | | | | | Removes most unnecessary base:: qualifications from string_util. Updates ReplaceStringPlaceholders implementation to use C++11 features for the loop iterators. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1227413007 Cr-Commit-Position: refs/heads/master@{#338826}
* Move JoinString to the base namespace.brettw2015-07-151-1/+1
| | | | | | | | | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 Cr-Commit-Position: refs/heads/master@{#338762} patch from issue 1223153003 at patchset 160001 (http://crrev.com/1223153003#ps160001) BUG= Review URL: https://codereview.chromium.org/1230243005 Cr-Commit-Position: refs/heads/master@{#338819}
* Revert of Move JoinString to the base namespace (patchset #9 id:160001 of ↵hongchan2015-07-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1237873004 Cr-Commit-Position: refs/heads/master@{#338770}
* Move JoinString to the base namespace.brettw2015-07-141-1/+1
| | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Review URL: https://codereview.chromium.org/1223153003 Cr-Commit-Position: refs/heads/master@{#338762}
* Remove mojo::ErrorHandler usage from the mojo/ folder.yzshen2015-07-131-1/+1
| | | | | | | | | | The interface is deprecated. BUG=None Review URL: https://codereview.chromium.org/1236473004 Cr-Commit-Position: refs/heads/master@{#338524}
* Fix remaining warnings for -Wmissing-braces and enable on win clang.dcheng2015-07-081-6/+4
| | | | | | | | | | | | Missing braces have been located and restored to their rightful positions. BUG=505297 TBR=aboxhall,ananta,atwilson,hajimehoshi,jamiewalch,vitalybuka Review URL: https://codereview.chromium.org/1216413002 Cr-Commit-Position: refs/heads/master@{#337781}
* Fixed all unused-variable Clang warnings on Windows.mgiuca2015-07-082-3/+0
| | | | | | | | | | | | | | Usually, fixed by removing the unused variables. Some variables had to be guarded by #ifs. Some variables could be used instead. Also removed unused test file sweep02_16b_mono_16KHz.raw. BUG=505319 TBR=rpaquay@chromium.org Review URL: https://codereview.chromium.org/1220133003 Cr-Commit-Position: refs/heads/master@{#337767}
* clang/win: Fix warnings to prepare for building without -Wno-reorder.sammc2015-07-023-5/+10
| | | | | | | | | | | | | This changes constructor initializer list ordering to match field declaration ordering, except for gtest and breakpad, where the warning is disabled. BUG=505304 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1210013007 Cr-Commit-Position: refs/heads/master@{#337152}
* Add local suppresion for -Wparentheses and enable everywhere on Windows.dcheng2015-07-012-2/+10
| | | | | | | | | | | | | The Cloud Print Windows service uses WTL, and one of the headers uses an assignment inside a conditional (atlgdi.h), which triggers this clang warning. BUG=505302 TBR=scottbyer@chromium.org,vitalybuka@chromium.org Review URL: https://codereview.chromium.org/1214113010 Cr-Commit-Position: refs/heads/master@{#336964}
* Replace more Tokenize calls with base::SplitStringbrettw2015-06-291-5/+8
| | | | | | | | | | | This also replaces a few StartsWithASCII calls with the new StartsWith in cases where the deprecated ASCII version appeared in code I was changing. NOPRESUBMIT=true (due to weird include ordering of _kde.cc file which a comment in the file says is required) Review URL: https://codereview.chromium.org/1202963003 Cr-Commit-Position: refs/heads/master@{#336670}
* Add more string_util functions to base namespace.brettw2015-06-241-5/+6
| | | | | | | | | | Moves ReplaceFirstSubstringAfterOffset. It also changes the find/replace arguments to be string pieces (normally these are constants). TBR=gauravsh@chromium.org for chromeos/network Review URL: https://codereview.chromium.org/1200393002 Cr-Commit-Position: refs/heads/master@{#335999}
* Only create cloud_print targets for Windows on Windows.bungeman2015-06-194-88/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | In cloud_print/service/service.gyp the targets: cloud_print_service cloud_print_service_config cloud_print_service_setup are only useful on Windows but are defined on all platforms. Attempting to build any of these targets on other platforms will result in a build error as the 'win/*' sources are removed by glob meaning that cloud_print_resources.gyp:cloud_print_version_resources has no sources, resulting in cloud_print_service_exe_version.rc not being created, causing this source not to be found. This also explicitly calls out the dependency of these three targets on the cloud_print_version_resources target to create the cloud_print_service_exe_version.rc file. TBR=dpranke@chromium.org The gn_migration.gypi change just updates where the targets are. Review URL: https://codereview.chromium.org/1153263002 Cr-Commit-Position: refs/heads/master@{#335254}
* Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-171-1/+1
| | | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/1179163002 Cr-Commit-Position: refs/heads/master@{#334840}
* Remove useless use of StringPrintf("%s", ...)ricea2015-06-151-1/+1
| | | | | | | | | | | | | | | | In PrintJobHandler::CompleteLocalPrintJob(), job_id is passed to SavePrintJob() as StringPrintf("%s", job_id.c_str()). However, this is equivalent to std::string(job_id.c_str()). Since job_id cannot contain NUL bytes, this is equivalent to std::string(job_id). Since SavePrintJob() takes the argument by const reference and doesn't need a fresh object, it is sufficient just to pass job_id as-is. BUG= TEST=cloud_print_unittests Review URL: https://codereview.chromium.org/1185103002 Cr-Commit-Position: refs/heads/master@{#334408}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-122-2/+2
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* vs2015: fix const warning in cloud_print_service.ccscottmg2015-06-091-1/+1
| | | | | | | | | | | | | FAILED: ninja -t msvc -e environment.x86 -- "d:\src\depot_tools\win_toolchain\vs_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\cloud_print\service\win\cloud_print_service.cloud_print_service.obj.rsp /c ..\..\cloud_print\service\win\cloud_print_service.cc /Foobj\cloud_print\service\win\cloud_print_service.cloud_print_service.obj /Fdobj\cloud_print\service\cloud_print_service.cc.pdb d:\src\cr3\src\cloud_print\service\win\cloud_print_service.cc(151): error C2440: 'return': cannot convert from 'const TCHAR *' to 'wchar_t *' d:\src\cr3\src\cloud_print\service\win\cloud_print_service.cc(151): note: Conversion loses qualifiers R=vitalybuka@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1165303003 Cr-Commit-Position: refs/heads/master@{#333503}
* Allow the cloud print driver to launch external process other than chrome.weitaosu2015-06-044-40/+148
| | | | | | | | | | | | | | | | | The print command is specified in the PrintCommand value in the cloud print registry key. The print command specified may contain the following place holders will will be filled by the printer driver: 1. %%Document_Path%% 2. %%Document_Type%% 3. %%Job_Title%% Please let me know if a different escape sequence for the place holder is preferred. If a print command is not specified in the cloud print key, the chrome cloud print dialog will be launched by default. BUG=496788 Review URL: https://codereview.chromium.org/1162043006 Cr-Commit-Position: refs/heads/master@{#332865}
* Change most uses of Pickle to base::Picklebrettw2015-06-031-1/+1
| | | | | | | | | | There should be no behavior change. TBR=jschuh (IPC messages) Review URL: https://codereview.chromium.org/1154283003 Cr-Commit-Position: refs/heads/master@{#332552}
* Removing unused constant.weitaosu2015-05-281-1/+0
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1159973004 Cr-Commit-Position: refs/heads/master@{#331876}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-167-14/+12
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Cleanup: Simplify some checks in tests.thestig2015-05-111-1/+1
| | | | | | Review URL: https://codereview.chromium.org/1123703005 Cr-Commit-Position: refs/heads/master@{#329200}
* win: Add override I forgot in https://codereview.chromium.org/1119243002thakis2015-05-071-1/+1
| | | | | | | | | | | No behavior change. BUG=467287 TBR=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/1124273003 Cr-Commit-Position: refs/heads/master@{#328711}
* win: Work on reducing style plugin warnings in content/, cloud_print/thakis2015-05-041-0/+4
| | | | | | | | | BUG=123295,467287 TBR=vitalybuka Review URL: https://codereview.chromium.org/1119243002 Cr-Commit-Position: refs/heads/master@{#328088}
* Apply automated fixits for Chrome clang plugin to cloud_print.dcheng2015-04-292-7/+3
| | | | | | | | | | | Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=vitalybuka Review URL: https://codereview.chromium.org/1115763002 Cr-Commit-Position: refs/heads/master@{#327561}
* simplify brandinggburanov2015-04-281-22/+2
| | | | | | | | | | | | | Please take look at https://codereview.chromium.org/1090213002/patch/40001/50001 for details BUG= Review URL: https://codereview.chromium.org/1059333004 Cr-Commit-Position: refs/heads/master@{#327270}
* Update {virtual,override} to follow C++11 style in cloud_print.nick2015-04-2710-75/+74
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1100633004 Cr-Commit-Position: refs/heads/master@{#327154}
* Add cloud_print_unittests to the GN build.dpranke2015-04-012-0/+79
| | | | | | | | | | BUG=461019 R=brettw@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1047463003 Cr-Commit-Position: refs/heads/master@{#323262}
* Remove prerender cookie store, part 4.davidben2015-03-231-1/+1
| | | | | | | | | | | | | | | | This removes the ability to pass in a custom CookieStore to a URLRequest. It's a small change to net/url_request which then balloons to everything in the project that ever makes a URLRequest. This reverts the rest of https://codereview.chromium.org/188693003 (and then does a whole lot more because URLRequest constructors were unified recently to always require passing in the fourth argument). BUG=457344 Review URL: https://codereview.chromium.org/1003953008 Cr-Commit-Position: refs/heads/master@{#321820}
* Remove uses of KillProcess()rvargas2015-03-181-12/+18
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/999033003 Cr-Commit-Position: refs/heads/master@{#321045}
* Move GetProcessIntegrityLevel to file_info.h and remove the handle argument.rvargas2015-02-131-7/+2
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/921913002 Cr-Commit-Position: refs/heads/master@{#316242}
* Refactor chrome_launcher_support::GetAnyChromePath.mgiuca2015-01-143-5/+8
| | | | | | | | | | | | Combined GetAnyChromePath and GetChromeSxSPath into one function that takes a bool |is_sxs|. Avoids the need to have a wrapper function that conditionally calls GetAnyChromePath or GetAnyChromeSxsPath. BUG=428600 Review URL: https://codereview.chromium.org/685103004 Cr-Commit-Position: refs/heads/master@{#311384}
* Standardize usage of virtual/override/final specifiers in printing code.dcheng2014-12-221-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/795043004 Cr-Commit-Position: refs/heads/master@{#309487}
* Update cloud_print and chrome/service to use the new version of LaunchProcess.rvargas2014-12-133-5/+4
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/785353003 Cr-Commit-Position: refs/heads/master@{#308206}
* Fixing error checking of PathService::Get.brucedawson2014-12-081-1/+1
| | | | | | | | | | | | | | | | | | | | | The return value of PathService::Get was being checked with the FAILED() macro which is intended for use with HRESULT return types. Because PathService::Get returns a bool and FAILED treats all non-negative numbers as success, failures will never be detected. This was found by VC++'s /analyze which said: src\cloud_print\virtual_driver\win\install\setup.cc(510) : warning C6215: Cast between semantically different integer types: a Boolean type to HRESULT. The original bug was introduced by https://chromiumcodereview.appspot.com/11876005 BUG=427616 Review URL: https://codereview.chromium.org/740463006 Cr-Commit-Position: refs/heads/master@{#307280}
* Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer ↵hidehiko2014-12-082-10/+4
| | | | | | | | | | | | | | | options from UDPSocket. Currently, we have timing limitation to set these options. This CL splits Open() from Connect() and Bind(), so that those options can be set anytime after Open(). This is the preparation to remove the same limitation from PPAPI's socket APIs. BUG=425563, 420697 TEST=Ran trybots. Review URL: https://codereview.chromium.org/721273002 Cr-Commit-Position: refs/heads/master@{#307204}
* Upgrade the windows specific version of LaunchProcess to avoid raw handles.rvargas2014-12-051-4/+4
| | | | | | | | | | | | | | | | | This change implies that extensions::LaunchNativeProcess also changes to return base::Process, and that requires base::EnsureProcessTerminated to deal with base:Process (as it basically claims ownership of the process). This CL fixes some leaks all around. BUG=417532 Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38 Cr-Commit-Position: refs/heads/master@{#306687} Review URL: https://codereview.chromium.org/759903002 Cr-Commit-Position: refs/heads/master@{#306963}
* Revert of Upgrade the windows specific version of LaunchProcess to avoid raw ↵rfevang2014-12-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | handles. (patchset #3 id:40001 of https://codereview.chromium.org/759903002/) Reason for revert: Looks like it broke the 'Google Chrome Win' builder: FAILED: ninja -t msvc -e environment.x86 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\win8\delegate_execute\delegate_execute.chrome_util.obj.rsp /c ..\..\win8\delegate_execute\chrome_util.cc /Foobj\win8\delegate_execute\delegate_execute.chrome_util.obj /Fdobj\win8\delegate_execute\delegate_execute.cc.pdb c:\b\build\slave\google-chrome-rel-win\build\src\win8\delegate_execute\chrome_util.cc(119) : error C2665: 'base::LaunchProcess' : none of the 3 overloads could convert all the argument types c:\b\build\slave\google-chrome-rel-win\build\src\base\process\launch.h(161): could be 'bool base::LaunchProcess(const base::CommandLine &,const base::LaunchOptions &,base::ProcessHandle *)' while trying to match the argument list '(base::string16, base::LaunchOptions, base::win::ScopedHandle *)' Original issue's description: > Upgrade the windows specific version of LaunchProcess to avoid raw handles. > > This change implies that extensions::LaunchNativeProcess also changes to > return base::Process, and that requires base::EnsureProcessTerminated to > deal with base:Process (as it basically claims ownership of the process). > > This CL fixes some leaks all around. > > BUG=417532 > > Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38 > Cr-Commit-Position: refs/heads/master@{#306687} TBR=cpu@chromium.org,finnur@chromium.org,gab@chromium.org,sergeyu@chromium.org,wez@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true BUG=417532 Review URL: https://codereview.chromium.org/780653003 Cr-Commit-Position: refs/heads/master@{#306712}
* Upgrade the windows specific version of LaunchProcess to avoid raw handles.rvargas2014-12-031-4/+4
| | | | | | | | | | | | | | This change implies that extensions::LaunchNativeProcess also changes to return base::Process, and that requires base::EnsureProcessTerminated to deal with base:Process (as it basically claims ownership of the process). This CL fixes some leaks all around. BUG=417532 Review URL: https://codereview.chromium.org/759903002 Cr-Commit-Position: refs/heads/master@{#306687}
* Remove implicit conversions from scoped_refptr to T* in cloud_print/dcheng2014-11-211-1/+1
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Review URL: https://codereview.chromium.org/745323002 Cr-Commit-Position: refs/heads/master@{#305255}
* Enable MSVC warning for unused locals.Peter Kasting2014-11-201-3/+7
| | | | | | | | | | | | | | There is seemingly a bug in the compiler where it occasionally claims a local is unused when it isn't. This forces a few places to either inline such locals or mark them ALLOW_UNUSED_LOCAL. BUG=81439 TEST=none R=brettw@chromium.org, cpu@chromium.org, jamesr@chromium.org, rvargas@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, wolenetz@chromium.org Review URL: https://codereview.chromium.org/731373002 Cr-Commit-Position: refs/heads/master@{#305108}
* Prefix CommandLine usage with base namespace (Part 7: cloud_print/)pgal.u-szeged2014-11-1915-43/+55
| | | | | | | | | | | | Prefix all CommandLine usage in the cloud_print/ directory with the base:: namespace. R=vitalybuka@chromium.org BUG=422426 Review URL: https://codereview.chromium.org/735053002 Cr-Commit-Position: refs/heads/master@{#304744}
* Cleanup: Remove unneeded path_service.h includes.thestig2014-11-061-1/+0
| | | | | | Review URL: https://codereview.chromium.org/689563002 Cr-Commit-Position: refs/heads/master@{#303095}
generated by cgit v1.1 at 2024-09-23 12:34:31 +0000