summaryrefslogtreecommitdiffstats
path: root/cloud_print
Commit message (Collapse)AuthorAgeFilesLines
* Move GetProcessIntegrityLevel to file_info.h and remove the handle argument.rvargas2015-02-131-7/+2
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/921913002 Cr-Commit-Position: refs/heads/master@{#316242}
* Refactor chrome_launcher_support::GetAnyChromePath.mgiuca2015-01-143-5/+8
| | | | | | | | | | | | Combined GetAnyChromePath and GetChromeSxSPath into one function that takes a bool |is_sxs|. Avoids the need to have a wrapper function that conditionally calls GetAnyChromePath or GetAnyChromeSxsPath. BUG=428600 Review URL: https://codereview.chromium.org/685103004 Cr-Commit-Position: refs/heads/master@{#311384}
* Standardize usage of virtual/override/final specifiers in printing code.dcheng2014-12-221-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/795043004 Cr-Commit-Position: refs/heads/master@{#309487}
* Update cloud_print and chrome/service to use the new version of LaunchProcess.rvargas2014-12-133-5/+4
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/785353003 Cr-Commit-Position: refs/heads/master@{#308206}
* Fixing error checking of PathService::Get.brucedawson2014-12-081-1/+1
| | | | | | | | | | | | | | | | | | | | | The return value of PathService::Get was being checked with the FAILED() macro which is intended for use with HRESULT return types. Because PathService::Get returns a bool and FAILED treats all non-negative numbers as success, failures will never be detected. This was found by VC++'s /analyze which said: src\cloud_print\virtual_driver\win\install\setup.cc(510) : warning C6215: Cast between semantically different integer types: a Boolean type to HRESULT. The original bug was introduced by https://chromiumcodereview.appspot.com/11876005 BUG=427616 Review URL: https://codereview.chromium.org/740463006 Cr-Commit-Position: refs/heads/master@{#307280}
* Remove timing limitation to set Broadcast, ReceiveBuffer, and SendBuffer ↵hidehiko2014-12-082-10/+4
| | | | | | | | | | | | | | | options from UDPSocket. Currently, we have timing limitation to set these options. This CL splits Open() from Connect() and Bind(), so that those options can be set anytime after Open(). This is the preparation to remove the same limitation from PPAPI's socket APIs. BUG=425563, 420697 TEST=Ran trybots. Review URL: https://codereview.chromium.org/721273002 Cr-Commit-Position: refs/heads/master@{#307204}
* Upgrade the windows specific version of LaunchProcess to avoid raw handles.rvargas2014-12-051-4/+4
| | | | | | | | | | | | | | | | | This change implies that extensions::LaunchNativeProcess also changes to return base::Process, and that requires base::EnsureProcessTerminated to deal with base:Process (as it basically claims ownership of the process). This CL fixes some leaks all around. BUG=417532 Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38 Cr-Commit-Position: refs/heads/master@{#306687} Review URL: https://codereview.chromium.org/759903002 Cr-Commit-Position: refs/heads/master@{#306963}
* Revert of Upgrade the windows specific version of LaunchProcess to avoid raw ↵rfevang2014-12-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | handles. (patchset #3 id:40001 of https://codereview.chromium.org/759903002/) Reason for revert: Looks like it broke the 'Google Chrome Win' builder: FAILED: ninja -t msvc -e environment.x86 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\win8\delegate_execute\delegate_execute.chrome_util.obj.rsp /c ..\..\win8\delegate_execute\chrome_util.cc /Foobj\win8\delegate_execute\delegate_execute.chrome_util.obj /Fdobj\win8\delegate_execute\delegate_execute.cc.pdb c:\b\build\slave\google-chrome-rel-win\build\src\win8\delegate_execute\chrome_util.cc(119) : error C2665: 'base::LaunchProcess' : none of the 3 overloads could convert all the argument types c:\b\build\slave\google-chrome-rel-win\build\src\base\process\launch.h(161): could be 'bool base::LaunchProcess(const base::CommandLine &,const base::LaunchOptions &,base::ProcessHandle *)' while trying to match the argument list '(base::string16, base::LaunchOptions, base::win::ScopedHandle *)' Original issue's description: > Upgrade the windows specific version of LaunchProcess to avoid raw handles. > > This change implies that extensions::LaunchNativeProcess also changes to > return base::Process, and that requires base::EnsureProcessTerminated to > deal with base:Process (as it basically claims ownership of the process). > > This CL fixes some leaks all around. > > BUG=417532 > > Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38 > Cr-Commit-Position: refs/heads/master@{#306687} TBR=cpu@chromium.org,finnur@chromium.org,gab@chromium.org,sergeyu@chromium.org,wez@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true BUG=417532 Review URL: https://codereview.chromium.org/780653003 Cr-Commit-Position: refs/heads/master@{#306712}
* Upgrade the windows specific version of LaunchProcess to avoid raw handles.rvargas2014-12-031-4/+4
| | | | | | | | | | | | | | This change implies that extensions::LaunchNativeProcess also changes to return base::Process, and that requires base::EnsureProcessTerminated to deal with base:Process (as it basically claims ownership of the process). This CL fixes some leaks all around. BUG=417532 Review URL: https://codereview.chromium.org/759903002 Cr-Commit-Position: refs/heads/master@{#306687}
* Remove implicit conversions from scoped_refptr to T* in cloud_print/dcheng2014-11-211-1/+1
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Review URL: https://codereview.chromium.org/745323002 Cr-Commit-Position: refs/heads/master@{#305255}
* Enable MSVC warning for unused locals.Peter Kasting2014-11-201-3/+7
| | | | | | | | | | | | | | There is seemingly a bug in the compiler where it occasionally claims a local is unused when it isn't. This forces a few places to either inline such locals or mark them ALLOW_UNUSED_LOCAL. BUG=81439 TEST=none R=brettw@chromium.org, cpu@chromium.org, jamesr@chromium.org, rvargas@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, wolenetz@chromium.org Review URL: https://codereview.chromium.org/731373002 Cr-Commit-Position: refs/heads/master@{#305108}
* Prefix CommandLine usage with base namespace (Part 7: cloud_print/)pgal.u-szeged2014-11-1915-43/+55
| | | | | | | | | | | | Prefix all CommandLine usage in the cloud_print/ directory with the base:: namespace. R=vitalybuka@chromium.org BUG=422426 Review URL: https://codereview.chromium.org/735053002 Cr-Commit-Position: refs/heads/master@{#304744}
* Cleanup: Remove unneeded path_service.h includes.thestig2014-11-061-1/+0
| | | | | | Review URL: https://codereview.chromium.org/689563002 Cr-Commit-Position: refs/heads/master@{#303095}
* Renamed enable_printing and printing_mode in *.gyp* and .*gn* files.vitalybuka2014-11-051-1/+1
| | | | | | | | | | | enable_printing and printing_mode replaced with enable_basic_printing and enable_print_preview. BUG=430281 Review URL: https://codereview.chromium.org/702023002 Cr-Commit-Position: refs/heads/master@{#302905}
* clang/win: Disable -Wwritable-strings for most cloud_print service targets.thakis2014-11-031-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | Suppresses 4 warnings that look like In file included from ..\..\cloud_print\service\win\cloud_print_service.cc:32: ..\..\cloud_print/service/win/service_controller.h(28,3) : warning(clang): ISO C++11 does not allow conversion from string literal to 'TCHAR *' (aka 'wchar_t *') [-Wwritable-strings] DECLARE_REGISTRY_APPID_RESOURCEID(IDR_CLOUDPRINTSERVICE, ^ C:\b\depot_tools\win_toolchain\vs2013_files/VC/atlmfc/include\atlbase.h(3086,10) : note(clang): expanded from macro 'DECLARE_REGISTRY_APPID_RESOURCEID' return _T(appid); \ ^ C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\tchar.h(2498,21) : note(clang): expanded from macro '_T' ^ C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\tchar.h(206,21) : note(clang): expanded from macro '__T' ^ <scratch space>(20,1) : note(clang): expanded from here L"{8013FB7C-2E3E-4992-B8BD-05C0C4AB0627}" ^ 1 warning generated. BUG=82385 Review URL: https://codereview.chromium.org/686683004 Cr-Commit-Position: refs/heads/master@{#302471}
* remove DIR_LOCAL_APP_DATA_LOW from base.cpu2014-10-271-6/+14
| | | | | | | | | | | Not used except for cloud print. BUG=426573 TBR=rvargas Review URL: https://codereview.chromium.org/681533002 Cr-Commit-Position: refs/heads/master@{#301473}
* Cleanup: Remove trailing whitespaces in gyp files.thestig2014-10-173-6/+6
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/657313004 Cr-Commit-Position: refs/heads/master@{#300140}
* Turn UploadDataStream into an abstract class, and split the implentationmmenke2014-10-091-3/+3
| | | | | | | | | | | | | | | | | into two classes - one for chunked uploads, one for non-chunked uploads. This refactoring is aimed at allowing Cronet to add another implementation for use on Android. Splitting the logic for the chunked and non-chunked uploads isn't necessary for that, but the two paths didn't share much code, and keeping them as one class seems ugly. BUG=412942 Review URL: https://codereview.chromium.org/560893004 Cr-Commit-Position: refs/heads/master@{#298966}
* Replacing the OVERRIDE with override and FINAL with final in cloud_printmohan.reddy2014-10-0611-61/+61
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/630753002 Cr-Commit-Position: refs/heads/master@{#298210}
* Add net::HttpServer::Delegate::OnConnect() function and set ChromeDriver ↵samuong2014-09-261-0/+1
| | | | | | | | | | buffer sizes to 100 MB BUG= Review URL: https://codereview.chromium.org/594393002 Cr-Commit-Position: refs/heads/master@{#296881}
* Remove implicit HANDLE conversions from cloud_print.rvargas2014-09-256-25/+27
| | | | | | | | | BUG=416722 R=gene@chromium.org Review URL: https://codereview.chromium.org/606443003 Cr-Commit-Position: refs/heads/master@{#296582}
* Added --disable-ipv4 and --disable-ipv6 switches.vitalybuka2014-09-235-15/+44
| | | | | | | | | | By default both enabled. TBR=gene@chromium.org Review URL: https://codereview.chromium.org/598433002 Cr-Commit-Position: refs/heads/master@{#296150}
* GCP 2.0 prototype switches code cleanup.vitalybuka2014-09-228-50/+120
| | | | | | | | TBR=gene@chromium.org Review URL: https://codereview.chromium.org/587103002 Cr-Commit-Position: refs/heads/master@{#295925}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in cc/, ↵thestig2014-09-1016-23/+25
| | | | | | | | | | chromecast/, cloud_print/, mojo/, and win8/ TBR=enne@chromium.org,lcwu@chromium.org,vitalybuka@chromium.org,viettrunglluu@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/559743002 Cr-Commit-Position: refs/heads/master@{#294139}
* Fix problems in r293393.Nico Weber2014-09-051-10/+10
| | | | | | | | TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/542973002 Cr-Commit-Position: refs/heads/master@{#293440}
* win/clang: Fix all remaining -Wformat warnings.Nico Weber2014-09-052-1/+11
| | | | | | | | | | | | | | | We recently switched from building chromium_builder_tests to building everything, this fixes almost all warnings in the ~1000 translation units we weren't compiling before. No behavior change. BUG=82385 R=scottmg@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/543923002 Cr-Commit-Position: refs/heads/master@{#293393}
* Revert of Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-312-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/) Reason for revert: Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.) Original issue's description: > Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) > > Reason for revert: > Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 > > InstallerStateTest.InitializeTwice (run #1): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) > > InstallerStateTest.InitializeTwice (run #2): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) > > > Original issue's description: > > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > > > Also don't use "default" as a variable name, as it's a keyword. > > Also fix a bug where a wstring was passed to %ls. > > > > No real behavior change. > > > > BUG=82385 > > R=hans@chromium.org > > TBR=cpu, vitalybuka > > > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 > > TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=82385 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/525013003 Cr-Commit-Position: refs/heads/master@{#292818}
* Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-302-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) Reason for revert: Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 InstallerStateTest.InitializeTwice (run #1): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) InstallerStateTest.InitializeTwice (run #2): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) Original issue's description: > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > Also don't use "default" as a variable name, as it's a keyword. > Also fix a bug where a wstring was passed to %ls. > > No real behavior change. > > BUG=82385 > R=hans@chromium.org > TBR=cpu, vitalybuka > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/519463003 Cr-Commit-Position: refs/heads/master@{#292809}
* clang/win: Fix a few warnings in targets not in chromium_builder_tests.Nico Weber2014-08-292-5/+6
| | | | | | | | | | | | | | | Also don't use "default" as a variable name, as it's a keyword. Also fix a bug where a wstring was passed to %ls. No real behavior change. BUG=82385 R=hans@chromium.org TBR=cpu, vitalybuka Review URL: https://codereview.chromium.org/526513002 Cr-Commit-Position: refs/heads/master@{#292699}
* Remove implicit conversions from scoped_refptr to T* in cloud_print/dcheng2014-08-272-2/+2
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/513503002 Cr-Commit-Position: refs/heads/master@{#292076}
* Revert "Revert of Replace StreamListenSocket with StreamSocket in ↵byungchul2014-08-252-7/+8
| | | | | | | | | | | | | | | | | | | HttpServer. (patchset #29 of https://codereview.chromium.org/296053012/)" This reverts commit 0b2f33f4a88efbd203b0623324ad4114e3bb9d23. This is relanding CL of https://codereview.chromium.org/296053012/, which broke http server unittests because http server doesn't send response synchronously any more. This CL fixes unittests by reading responses completely. Patch set #1 is same to the original CL. Patch set #2 is the diff. BUG=371906 TBR=pfeldman@chromium.org,darin@chromium.org,gunsch@chromium.org,mnaganov@chromium.org Review URL: https://codereview.chromium.org/487013003 Cr-Commit-Position: refs/heads/master@{#291784}
* Revert of Replace StreamListenSocket with StreamSocket in HttpServer. ↵estade@chromium.org2014-08-222-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #29 of https://codereview.chromium.org/296053012/) Reason for revert: looks like it caused net_unittests failures: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/44610/steps/net_unittests/logs/MultipleRequestsOnSameConnection Original issue's description: > Replace StreamListenSocket with StreamSocket in HttpServer. > > 1) HttpServer gets ServerSocket instead of StreamListenSocket. > 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers. > 3) HttpServer handles data buffering and asynchronous read/write. > 4) HttpConnection has limit in data buffering, up to 1Mbytes by default. > 5) For devtools, send buffer limit is 100Mbytes. > 6) Unittests for buffer handling in HttpConnection. > > BUG=371906 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291447 NOTREECHECKS=true NOTRY=true TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/497223003 Cr-Commit-Position: refs/heads/master@{#291521} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291521 0039d316-1c4b-4281-b951-d872f2087c98
* Replace StreamListenSocket with StreamSocket in HttpServer.byungchul@chromium.org2014-08-222-7/+8
| | | | | | | | | | | | | | | | 1) HttpServer gets ServerSocket instead of StreamListenSocket. 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers. 3) HttpServer handles data buffering and asynchronous read/write. 4) HttpConnection has limit in data buffering, up to 1Mbytes by default. 5) For devtools, send buffer limit is 100Mbytes. 6) Unittests for buffer handling in HttpConnection. BUG=371906 Review URL: https://codereview.chromium.org/296053012 Cr-Commit-Position: refs/heads/master@{#291447} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291447 0039d316-1c4b-4281-b951-d872f2087c98
* Allow URLRequests from one context to have different NetworkDelegates.mmenke@chromium.org2014-08-211-8/+8
| | | | | | | | | | | | | | | | | | | This is a prerequisite to allowing a URLRequestJob to transparently wrap a URLRequest, so AppCache can override the response for failing and redirected requests without the NetworkDelegate or URLRequest::Delegate being aware of the underlying request. Also consolidate the URLRequest constructors, and make most code create URLRequests through the URLRequestContext's CreateRequest function, rather than through its constructor. TBR=battre@chromium.org BUG=161547 Review URL: https://codereview.chromium.org/407093011 Cr-Commit-Position: refs/heads/master@{#291090} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291090 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pass const strings to CreateProcess.thakis@chromium.org2014-08-201-1/+3
| | | | | | | | | | | | | | The documentation says that CreateProcess() can modify its second parameter in UNICODE builds. BUG=396705 R=scottmg@chromium.org, vitalybuka@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/487303004 Cr-Commit-Position: refs/heads/master@{#290890} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToLowerASCII to base namespacebrettw@chromium.org2014-08-071-1/+1
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/448853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
* clang/win: Fix most -Wwriteable-strings warnings.thakis@chromium.org2014-07-231-2/+4
| | | | | | | | | | | | | | | | | | | | | | Many win32 APIs take non-const string pointers. I checked that MSDN documents them as _In_ and says that they are inputs, and then added const_cast<>s at the calling sites. (In one test, I introduced a helper struct so that there can be fewer casts.) This wasn't just busywork, I found one function that we were handing string literals where the documentation explicitly said that that's not valid (filed http://crbug.com/396705). I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print; it sounds like that'll fix itself when we update to the 2014 sdk: http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013 BUG=396705,82385 R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org Review URL: https://codereview.chromium.org/413763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed MonitorData deletion in Monitor2Shutdown.vitalybuka@chromium.org2014-07-221-7/+3
| | | | | | | | Removed temp variables to avoid other confusions. Review URL: https://codereview.chromium.org/413553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284812 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: misc edition #2pkasting@chromium.org2014-07-181-3/+3
| | | | | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Assignment inside conditional * Taking the address of a temporary * Octal escape sequence terminated by decimal number * Signedness mismatch * Possibly-uninitialized local variable This also contains a small number of cleanups to nearby code (e.g. no else after return). BUG=81439 TEST=none Review URL: https://codereview.chromium.org/382673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
* Removed --disable-background-mode/restore-background-contents flags.atwilson@chromium.org2014-06-071-3/+0
| | | | | | | | BUG=350898 Review URL: https://codereview.chromium.org/317203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275698 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce IPC::Channel::Create*() to ensure it being heap-allocated.morrita@chromium.org2014-05-302-4/+4
| | | | | | | | | | | | | | | | | | | | | This change introduces IPC::Channel::Create*() API to turn IPC::Channel into a heap allocated object. This will allow us to make Channel a polymorphic class. This change also tries to hide Channel::Mode from public API so that we can simplify channel creation code paths cleaner in following changes. ChannelProxy has to follow same pattern to finish this cleanup. Such changes will follow. TEST=none BUG=377980 R=darin@chromium.org,cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273575 Review URL: https://codereview.chromium.org/307653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273713 0039d316-1c4b-4281-b951-d872f2087c98
* Remove {linux|android}_use_tcmalloc and switch to use_allocator in Chromium.dmikurube@chromium.org2014-05-071-2/+1
| | | | | | | | | | | | | | If this change breaks some bots, please try restarting the bot before reverting it. http://crrev.com/264460 may not be effective yet until restarting. See the bug and http://crrev.com/255129 for the details. BUG=345554 Review URL: https://codereview.chromium.org/258433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed url to manage specific cloud printers.vitalybuka@chromium.org2014-04-241-1/+1
| | | | | | | | | | Device id is ref string, not relative path. BUG=366575 Review URL: https://codereview.chromium.org/258623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266043 0039d316-1c4b-4281-b951-d872f2087c98
* Moved CloudPrintUrl to components/cloud_devices/cloud_devices_urls.h.vitalybuka@chromium.org2014-04-204-23/+7
| | | | | | | | | | Removed unused cloud print prefs. TBR=jochen, rogerta Review URL: https://codereview.chromium.org/240283010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264945 0039d316-1c4b-4281-b951-d872f2087c98
* Remove net_log.h from net_util, as it's no longer needed by net_log.h.mmenke@chromium.org2014-04-162-0/+3
| | | | | | | | | | | | Also fix a large number of other files that were depending on this include. BUG=none TBR=gene@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/235333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264062 0039d316-1c4b-4281-b951-d872f2087c98
* Added --cloud-print-xmpp-endpoint to make possible test with non-default ↵vitalybuka@chromium.org2014-04-151-0/+1
| | | | | | | | XMPP server. Review URL: https://codereview.chromium.org/231913004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702), misc. edition.pkasting@chromium.org2014-03-181-17/+12
| | | | | | | | | | | | This CL covers top-level directories that only had one or two modified files. BUG=346399 TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/203043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257705 0039d316-1c4b-4281-b951-d872f2087c98
* Move CommandLine to base namespace.brettw@chromium.org2014-03-173-6/+6
| | | | | | | | | | | | Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Review URL: https://codereview.chromium.org/196413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
* Removes --cloud-print-delete-file.vitalybuka@chromium.org2014-03-131-9/+4
| | | | | | | | BUG=350118 Review URL: https://codereview.chromium.org/196863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256725 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ContainsOnlyWhitespace from string_util and CollapseWhitespace into ↵brettw@chromium.org2014-03-111-2/+2
| | | | | | | | | | | | | | | | | to the base namespace This function is only used in a few places and can trivially be implemented by passing the whitespace constant to the existing ContainsOnlyChars function. This changes the ContainsOnlyChars function signature to take a StringPiece to avoid a copy from a literal to a standard string in the above-mentioned use-base. Re-implement ContainsOnlyChars to use the find_first_not_of function on StringPiece. BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/183683024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256354 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 03:54:15 +0000