summaryrefslogtreecommitdiffstats
path: root/components/app_modal/BUILD.gn
Commit message (Collapse)AuthorAgeFilesLines
* Move net::FormatUrl and friends outside of //net and into //componentsrsleevi2015-08-071-0/+1
| | | | | | | | | | | | | | | | | | | | | net::FormatUrl and related are specifically concerned with display policies of URLs, which is not something that //net needs to be aware of, as that's a UX question. This folds in net::FormatURL along with the existing //components/url_fixer and //components/secure_display into a common component, //components/url_formatter, that handles reformatting URLs for user-friendly or data storage (url_formatter), for use in security prompts (elide_url), or for reformatting URLs from user input (url_fixer) (Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups) BUG=486979 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1171333003 Cr-Commit-Position: refs/heads/master@{#342445}
* Revert of Move net::FormatUrl and friends outside of //net and into ↵jochen2015-08-041-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | //components (patchset #16 id:290001 of https://codereview.chromium.org/1171333003/ ) Reason for revert: breaks gn_check on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/28796/steps/gn_check/logs/stdio Original issue's description: > Move net::FormatUrl and friends outside of //net and into //components > > net::FormatUrl and related are specifically concerned with display > policies of URLs, which is not something that //net needs to be aware > of, as that's a UX question. > > This folds in net::FormatURL along with the existing //components/url_fixer > and //components/secure_display into a common component, > //components/url_formatter, that handles reformatting URLs for user-friendly > or data storage (url_formatter), for use in security prompts (elide_url), > or for reformatting URLs from user input (url_fixer) > > (Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups) > > BUG=486979 > NOPRESUBMIT=true > > Committed: https://crrev.com/1659865c3eb47166c82378bb840801135b057a09 > Cr-Commit-Position: refs/heads/master@{#341605} TBR=droger@chromium.org,jam@chromium.org,mkwst@chromium.org,pkasting@chromium.org,sky@chromium.org,stuartmorgan@chromium.org,felt@chromium.org,rsleevi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486979 Review URL: https://codereview.chromium.org/1260033005 Cr-Commit-Position: refs/heads/master@{#341691}
* Move net::FormatUrl and friends outside of //net and into //componentsrsleevi2015-08-031-0/+1
| | | | | | | | | | | | | | | | | | | | | net::FormatUrl and related are specifically concerned with display policies of URLs, which is not something that //net needs to be aware of, as that's a UX question. This folds in net::FormatURL along with the existing //components/url_fixer and //components/secure_display into a common component, //components/url_formatter, that handles reformatting URLs for user-friendly or data storage (url_formatter), for use in security prompts (elide_url), or for reformatting URLs from user input (url_fixer) (Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups) BUG=486979 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1171333003 Cr-Commit-Position: refs/heads/master@{#341605}
* components: Fix 'gn check' errors for app_modal.tfarina2015-07-021-1/+10
| | | | | | | | | | | | | | | | Tested on Linux with the following command lines: $ gn gen out-gn/Debug $ gn check out-gn/Debug //components/app_modal/* BUG=367595, 376000 TEST=see above R=brettw@chromium.org,avi@chromium.org TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1215193008 Cr-Commit-Position: refs/heads/master@{#337219}
* MacViews: Don't exclude app_modal views files on Macandresantoso2015-03-311-1/+1
| | | | | | | | | | | | MacViews browser wants to link with JavaScriptAppModalDialogViews, include these files on Mac. They are only used when mac_views_browser==1, and will be pruned out at link time otherwise. BUG=425229 Review URL: https://codereview.chromium.org/1044253002 Cr-Commit-Position: refs/heads/master@{#323101}
* Sort GN files under componentssatorux2015-02-161-1/+1
| | | | | | | | | | | | For tools/sort_sources.py to be useful, existing GN files should be sorted. BUG=456014 TEST=everything should build as before Review URL: https://codereview.chromium.org/934483002 Cr-Commit-Position: refs/heads/master@{#316447}
* gn format //componentsscottmg2014-12-031-1/+1
| | | | | | | | | | | No intended functionality change. R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/780633002 Cr-Commit-Position: refs/heads/master@{#306640}
* Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.hoshima2014-11-191-2/+0
| | | | | | | | | | | | | | * Renamed JavaScriptDialgoManagerImpl to JavaScriptDialogManager. * Add namespace app_modal_dialogs * Add namespace javascript_dialog_extensions_client * Shortened InstallJavaScriptDialogExtensionsClient to InstallClient to fit the 80 chars limit. BUG=410499 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/688853005 Cr-Commit-Position: refs/heads/master@{#304903}
* Rename app_modal_dialogs dir to app_modaloshima2014-11-181-0/+41
BUG=410499 TBR=benwells@chromium.org, jochen@chromium.org, agl@chromium.org Review URL: https://codereview.chromium.org/735473002 Cr-Commit-Position: refs/heads/master@{#304697}
generated by cgit v1.1 at 2024-09-14 14:38:24 +0000