| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This updates GN's app_list_unittests, base_unittests, cast_unittests, cc_unittests, components_unittests, crypto_unittests, events_unittests, and gl_unittests to match the GYP build (with the exception of some NaCl-specific ones).
The printing component is now hooked up to all components, and the printing names were fixed to be GN-style and to be source sets instead of shared libraries.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1295233003
Cr-Commit-Position: refs/heads/master@{#344024}
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files are shared with iOS. They have no problematic dependencies, so
componentization is straightforward.
BUG=516660
TBR=phajdan.jr
Review URL: https://codereview.chromium.org/1283443002
Cr-Commit-Position: refs/heads/master@{#343684}
|
|
|
|
|
|
|
|
|
|
|
| |
This ports most of the code, with a few TODOs remaining for future CLs.
BUG=501626
R=tengs@chromium.org
Review URL: https://codereview.chromium.org/1239193005
Cr-Commit-Position: refs/heads/master@{#343537}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move both chrome/common/experiment_labels.{cc,h} and the corresponding
unit tests into components/variations as they only depends on //base
and the component.
BUG=520070
Review URL: https://codereview.chromium.org/1290173004
Cr-Commit-Position: refs/heads/master@{#343391}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the --enable-proximity-auth-bluetooth-low-energy-discovery flag is set, the
user now can click the user pod to unlock the lock screen rather than
automatically unlocking.
This CL also refactors ProximityAuthBleSystem now that ScreenlockBridge is part
of the proximity_auth component.
BUG=517641
TEST=manual
Review URL: https://codereview.chromium.org/1273153004
Cr-Commit-Position: refs/heads/master@{#343065}
|
|
|
|
|
|
|
|
| |
These were generated and referenced in a few places but seem not to be used. In the GN build such generated .rc files are always compiled and linked, which resulted in duplicate resources.
Review URL: https://codereview.chromium.org/1289883002
Cr-Commit-Position: refs/heads/master@{#343045}
|
|
|
|
|
|
|
|
|
|
|
| |
Move tab_node_pool to the sync_driver component.
Updated gn and gyp file.
BUG=512073
Review URL: https://codereview.chromium.org/1275003003
Cr-Commit-Position: refs/heads/master@{#343000}
|
|
|
|
|
|
|
|
|
|
| |
Most grit-generated .rc files are bitrooted and the ones removed in this patch seem not to be used.
This removes the uses of blink_resources.rc. I will remove the generator for this in the WebKit repo in a follow-up.
Review URL: https://codereview.chromium.org/1286023002
Cr-Commit-Position: refs/heads/master@{#342968}
|
|
|
|
|
|
|
|
| |
This seems to not be used.
Review URL: https://codereview.chromium.org/1281483012
Cr-Commit-Position: refs/heads/master@{#342895}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move ClipboardURLProvider with the other AutocompleteProvider into
//components/omnibox to simplify the construction of the provider
and break circular dependency of open_from_clipboard and omnibox
components.
Introduce a new AutocompleteProvider::Type for this new provider
(AutocompleteProvider::TYPE_CLIPBOARD_URL) with the corresponding
value in OmniboxEventProto enumeration.
Pass the AutocompleteProviderClient to the ClipboardURLProvider
and remove another layer of indirection for the construction of
the AutocompleteMatch.
Add AutocompleteProvider::TYPE_CLIPBOARD_URL to the default list
of providers and construct, if ClipboardRecentContent singleton
exists (currently only implemented on iOS), a ClipboardURLProvider.
Add unit tests for ClipboardURLProvider.
BUG=517134,517017,514225
Review URL: https://codereview.chromium.org/1273013002
Cr-Commit-Position: refs/heads/master@{#342806}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Componentize //chrome/browser/prefs/tracked and
updated corresponding .gypi files for same.
Moved the files from //chrome/browser/prefs/tracked
to //components/user_prefs/tracked.
Also added new //components/user_prefs/pref_names.* file and added BUILD.gn for same
BUG=507660
Review URL: https://codereview.chromium.org/1227973003
Cr-Commit-Position: refs/heads/master@{#342588}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::FormatUrl and related are specifically concerned with display
policies of URLs, which is not something that //net needs to be aware
of, as that's a UX question.
This folds in net::FormatURL along with the existing //components/url_fixer
and //components/secure_display into a common component,
//components/url_formatter, that handles reformatting URLs for user-friendly
or data storage (url_formatter), for use in security prompts (elide_url),
or for reformatting URLs from user input (url_fixer)
(Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
BUG=486979
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1171333003
Cr-Commit-Position: refs/heads/master@{#342445}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PasswordManager
The goal is to put as much of the platform-independent logic to the shared code, and leave the CPMC just a dumb redirector to the embedding system. This is one of many steps.
Also, this CL removes IsPasswordManagementEnabledForCurrentPage() from the client mock in the client unit test. It is dangerous to mix mocking methods with testing the real implementations, and none of the tests actually needs this method mocked.
BUG=474577, 515108
Review URL: https://codereview.chromium.org/1260263002
Cr-Commit-Position: refs/heads/master@{#342332}
|
|
|
|
|
|
|
|
|
| |
BUG=512484
TBR=bartfab@chromium.org
Review URL: https://codereview.chromium.org/1265893002
Cr-Commit-Position: refs/heads/master@{#342165}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Componentize upload_list.{h,cc} and crash_upload_list.{h,cc} so
that the code can be shared with iOS. Do not move the factory
function into the component (as it depends on //content) nor
the system specific sub-classes of CrashUploadList (as they depends
on //components/crash that cannot be used on iOS).
Remove the dependency on content::BrowserThread by injecting the
base::SequencedWorkerPool, passing the base::SequencedTaskRunner
to LoadUploadListAndInformDelegateOfCompletion and checking the
thread using base::ThreadChecker.
BUG=516343
Review URL: https://codereview.chromium.org/1269073002
Cr-Commit-Position: refs/heads/master@{#342079}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//components (patchset #16 id:290001 of https://codereview.chromium.org/1171333003/ )
Reason for revert:
breaks gn_check on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/28796/steps/gn_check/logs/stdio
Original issue's description:
> Move net::FormatUrl and friends outside of //net and into //components
>
> net::FormatUrl and related are specifically concerned with display
> policies of URLs, which is not something that //net needs to be aware
> of, as that's a UX question.
>
> This folds in net::FormatURL along with the existing //components/url_fixer
> and //components/secure_display into a common component,
> //components/url_formatter, that handles reformatting URLs for user-friendly
> or data storage (url_formatter), for use in security prompts (elide_url),
> or for reformatting URLs from user input (url_fixer)
>
> (Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
>
> BUG=486979
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/1659865c3eb47166c82378bb840801135b057a09
> Cr-Commit-Position: refs/heads/master@{#341605}
TBR=droger@chromium.org,jam@chromium.org,mkwst@chromium.org,pkasting@chromium.org,sky@chromium.org,stuartmorgan@chromium.org,felt@chromium.org,rsleevi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=486979
Review URL: https://codereview.chromium.org/1260033005
Cr-Commit-Position: refs/heads/master@{#341691}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::FormatUrl and related are specifically concerned with display
policies of URLs, which is not something that //net needs to be aware
of, as that's a UX question.
This folds in net::FormatURL along with the existing //components/url_fixer
and //components/secure_display into a common component,
//components/url_formatter, that handles reformatting URLs for user-friendly
or data storage (url_formatter), for use in security prompts (elide_url),
or for reformatting URLs from user input (url_fixer)
(Disabling presubmit since this is intentionally not fixing a legacy API, just moving it for future cleanups)
BUG=486979
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1171333003
Cr-Commit-Position: refs/heads/master@{#341605}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Finch test 'CDL1VsCLD2' is a test to make sure that CLD2 is not
worse than CLD1 in terms of performance or accuracy. This test is no
longer executed on any platforms. Let's remove this for code health.
CLD version '0' is used to represent to use the Finch trial, and this
CL removes the cases of version 0 from gn, gypi and C++ files.
BUG=515358
Review URL: https://codereview.chromium.org/1259883007
Cr-Commit-Position: refs/heads/master@{#341496}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This metrics provider is used on iOS, so to enable clean integration on iOS
this CL componentizes it and injects its //chrome-level dependencies from the
embedder.
BUG=512426
Review URL: https://codereview.chromium.org/1254983003
Cr-Commit-Position: refs/heads/master@{#341183}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was found by Control Flow Integrity check, see
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
FeedbackUploaderTest initializes prefs registry with PrefRegistrySimple,
which then could be incorrectly casted to its subclass PrefRegistrySyncable.
The solution is to initialize prefs registry with PrefRegistrySyncable.
See more details in http://crbug.com/513953
BUG=chromium:513953, chromium:457523
Review URL: https://codereview.chromium.org/1259703003
Cr-Commit-Position: refs/heads/master@{#340969}
|
|
|
|
|
|
|
|
|
|
| |
Currently, password_manager_core_browser is mentioned twice, this CL deletes the redundant line.
BUG=474577
Review URL: https://codereview.chromium.org/1259473009
Cr-Commit-Position: refs/heads/master@{#340890}
|
|
|
|
|
|
|
|
|
|
|
|
| |
AccountManager.
Based on http://crrev.com/1224643007
BUG=508054
Review URL: https://codereview.chromium.org/1231653007
Cr-Commit-Position: refs/heads/master@{#340774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL finishes implementing propagation of the "curve25519dh" attribute
of the PushSubscription interface of the Push API. The public key will be
provided by the GCM Driver, which internally uses the (new) GCMKeyStore.
Encrypted messages cannot yet be received by GCM - that work remains. The
functionality introduced in this CL is also still guarded behind the
"--enable-push-message-payload" command line flag.
BUG=486040
Review URL: https://codereview.chromium.org/1231613005
Cr-Commit-Position: refs/heads/master@{#340697}
|
|
|
|
|
|
|
|
|
|
| |
Also do a necessary reformatting to pass the presubmit test.
BUG=514209
Review URL: https://codereview.chromium.org/1254273002
Cr-Commit-Position: refs/heads/master@{#340660}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now we have a bunch of arrays lying around the codebase which map
ContentSettingsTypes to various properties of website settings. When a user
adds a new setting, they have to modify each of these maps. We should
consolidate these into a single object which is registered on startup and
contains all properties of website settings.
This CL introduces a WebsiteSettingsRegistry to where website settings are
registered with these properties in WebsiteSettingsInfo objects. Currently
only the ContentSettingsType and string name of the setting are stored.
Two locations in the codebase which previously had separate arrays listing
the string names for each content setting have been changed to use the
WebsiteSettingsRegistry instead.
In followup CLs more properties will be moved into WebsiteSettingsInfo.
BUG=512683
Review URL: https://codereview.chromium.org/1247253003
Cr-Commit-Position: refs/heads/master@{#340651}
|
|
|
|
|
|
|
|
|
|
|
| |
to authenticate the phone.
BUG=508761
TEST=unit test
Review URL: https://codereview.chromium.org/1252843003
Cr-Commit-Position: refs/heads/master@{#340573}
|
|
|
|
|
|
|
|
|
| |
BUG=508761
TEST=unit test
Review URL: https://codereview.chromium.org/1251643002
Cr-Commit-Position: refs/heads/master@{#340534}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The IO thread constructor reads preferences that are set from policies, so Chrome
should read the policies before the IO thread constructor is called.
Two parts to this:
1 - create a persistant policy cache and read it cache synchronously
2 - reorder various things so that the Android PolicyManager and PolicyProviders
are created earlier in startup.
Also merge (C++) PolicyProviderAndroid into PolicyManager and add Junit tests
for the Java PolicyManager.
TBR=nyquist
BUG=510813
Review URL: https://codereview.chromium.org/1239323002
Cr-Commit-Position: refs/heads/master@{#340265}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DeviceToDevice is used by Smart Lock to provide mutual authentication between the
PC and mobile phone.
Although Chrome only runs the initiator side of this protocol, we also implement
the responder side to test that the ledgers match.
BUG=508761
TEST=unit test
Review URL: https://codereview.chromium.org/1238633003
Cr-Commit-Position: refs/heads/master@{#340170}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we where doing a linear scan of all task queues registered
with a particular priority. This is fine when the number of task
queues is low. However we are anticiapting having dozens or even
hundreds of task queues, so a faster selection algorithm is needed.
This patch uses a std::map to accellerate the finding of the oldest
task in a particular set (priority). Insert and removal is O(lg n)
and begin(), which points to the lowest key, is O(1).
In addtion the TaskQueueManager now supports dynamic creation of task queues.
For performance we now address queues by pointer rather than
by index inside the scheduler.
BUG=510398
Review URL: https://codereview.chromium.org/1231743003
Cr-Commit-Position: refs/heads/master@{#340073}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So it can be used for elements in the ui/ directory for example.
In particular there will be a follow up to use it from
https://codereview.chromium.org/1235253009/
TBR=cbenzel,danakj
BUG=509834
Review URL: https://codereview.chromium.org/1233313005
Cr-Commit-Position: refs/heads/master@{#340068}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1242323004/)
Reason for revert:
It looks to me like this broke the iOS_Device builder starting at https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/14003, despite the green trybots.
=== BUILD TARGET osmesa OF PROJECT mesa WITH CONFIGURATION Release ===
Check dependencies
CodeSign error: code signing is required for product type 'Dynamic Library' in SDK 'iOS 8.3'
** BUILD FAILED **
The following build commands failed:
Check dependencies
(1 failure)
Original issue's description:
> Add missing runtime dependencies to *_run targets.
>
> A follow up CL removes dynamic libraries that would be fetched automatically via
> implicit dependencies. The target hierarchy needs to be there in the first
> place for this to work.
>
> R=jam@chromium.org
> BUG=98637
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/d7b8df80cd5ce2a882bbf35482dc21cee34934f9
> Cr-Commit-Position: refs/heads/master@{#339994}
TBR=jam@chromium.org,danakj@chromium.org,marcheu@chromium.org,maruel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637
Review URL: https://codereview.chromium.org/1247533003
Cr-Commit-Position: refs/heads/master@{#340015}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A follow up CL removes dynamic libraries that would be fetched automatically via
implicit dependencies. The target hierarchy needs to be there in the first
place for this to work.
R=jam@chromium.org
BUG=98637
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1242323004
Cr-Commit-Position: refs/heads/master@{#339994}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the files in the root content folder to a new
browser folder. This is to help differentiate future code that
will run on the renderer.
BUG=
Review URL: https://codereview.chromium.org/1227123002
Cr-Commit-Position: refs/heads/master@{#339927}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Componentize offline_page_metadata_store_impl.[cc/h], unittest and offline_pages.proto file.
Updated BUILD.gn and corresponding .gypi files for the same.
BUG=507284
Review URL: https://codereview.chromium.org/1226173004
Cr-Commit-Position: refs/heads/master@{#339852}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class implements the encryption guts of the following drafts:
https://tools.ietf.org/html/draft-thomson-webpush-encryption-01
https://tools.ietf.org/html/draft-thomson-http-encryption-01
In short, given an input, key, salt and record size, this class will
calculate a content encryption key using the HKDF and apply
AEAD_AES_128_GCM over it, using an authentication tag size of 16
octets. Both encrypting and decrypting routines have been implemented.
Following draft-thomson-webpush-encryption-01, only messages existing
of a single record are supported. The record may be prepended by some
padding, a maximum of 255 bytes, to hide the length of the message.
The first and primary customer of this will be the Push Messaging
feature, which will mandate encryption for payloads associated with
received push messages. Chrome will decrypt incoming messages.
This patch does not introduce the additional functionalities required
for the entire feature - generation and storage of the keys, plumbing
required to expose this to JavaScript and infrastructure within the
rest of the GCM Driver to discover and use the necessary keys.
This CL is dependent on the following ones:
https://codereview.chromium.org/1199033006/
https://codereview.chromium.org/1226033002/
BUG=486040
Review URL: https://codereview.chromium.org/1198533003
Cr-Commit-Position: refs/heads/master@{#339250}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements a GCMKeyStore class, backed by a ProtoDatabase<>, that
enables us to store public/private key-pairs for association with
encrypted GCM messages.
TBR=sdefresne (+2 lines in BUILD.gn)
BUG=486040
Review URL: https://codereview.chromium.org/1226033002
Cr-Commit-Position: refs/heads/master@{#339242}
|
|
|
|
|
|
|
|
|
|
| |
Configure MessageLoop::task_runner() to post tasks through the scheduler to ensure consistent task ordering.
BUG=465354
Review URL: https://codereview.chromium.org/987193002
Cr-Commit-Position: refs/heads/master@{#339052}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Commit-Position: refs/heads/master@{#339002}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch extracts the code related to transforming the Java
objects coming from the AppRestrictionProvider to a PolicyBundle
in the native code.
It now lives in a new class in the policy components.
BUG=506809
Review URL: https://codereview.chromium.org/1220683008
Cr-Commit-Position: refs/heads/master@{#338859}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the file from //ios/public/provider/components/signin/browser
to //components/signin/browser/core where it belongs.
BUG=358544
Review URL: https://codereview.chromium.org/1218073006
Cr-Commit-Position: refs/heads/master@{#338834}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #11 id:220001 of https://codereview.chromium.org/987193002/)
Reason for revert:
Speculatively reverting. It seems to be causing flakiness on the decodeOnOtherThread test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=decodeOnOtherThread
Original issue's description:
> Redirect the MessageLoop's task runner to the renderer scheduler
>
> Configure MessageLoop::task_runner() to post tasks through the scheduler to ensure consistent task ordering.
>
> BUG=465354
>
> Committed: https://crrev.com/f14dd762c01730a81d4a94b64ceba42eaad2d5f2
> Cr-Commit-Position: refs/heads/master@{#338706}
TBR=alexclarke@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465354
Review URL: https://codereview.chromium.org/1238483003
Cr-Commit-Position: refs/heads/master@{#338736}
|
|
|
|
|
|
|
|
|
|
| |
Configure MessageLoop::task_runner() to post tasks through the scheduler to ensure consistent task ordering.
BUG=465354
Review URL: https://codereview.chromium.org/987193002
Cr-Commit-Position: refs/heads/master@{#338706}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With present implementation autofill/autocomplete suggestions are matched for
prefix for what user has typed.
This patch brings in suggestions with substring matching (i.e. substring
matching to the beginning of suggestion tokens) instead of prefix matching.
This patch keeps the feature behind a command line switch
--enable-suggestions-with-substring-match.
BUG=77194
Review URL: https://codereview.chromium.org/962673004
Cr-Commit-Position: refs/heads/master@{#338677}
|
|
|
|
|
|
|
|
| |
BUG=504644,484806
Review URL: https://codereview.chromium.org/1232573006
Cr-Commit-Position: refs/heads/master@{#338556}
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, the JSON sanitizer parses the untrusted JSON in Java and checks it for wellformedness before serializing it again. On desktop platforms it uses SafeJsonParser to parse the JSON out of process, then serializes it again.
Also, on Android (where JsonSanitizer is not implemented in terms of the SafeJsonParser) the SafeJsonParser now uses the JsonSanitizer to sanitize its input before parsing it directly in process, instead of starting a new process, which is very costly on Android.
BUG=501333
Review URL: https://codereview.chromium.org/1203083002
Cr-Commit-Position: refs/heads/master@{#338495}
|
|
|
|
|
|
|
|
|
| |
BUG=420315
TEST=unit test
Review URL: https://codereview.chromium.org/1228763002
Cr-Commit-Position: refs/heads/master@{#338427}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 311a46585ee5b77486ef42d947bc7cc7566558b1 / #338040,
https://codereview.chromium.org/1212163011/. The change broke tests in official
builds (http://crbug.com/508659).
BUG=504841, 508148, 508659
TBR=sdefresne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1229933005 .
Cr-Commit-Position: refs/heads/master@{#338150}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Commit-Position: refs/heads/master@{#338040}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//chrome/common/omnibox_focus_state.h needs to be componentized, as it is used
by //chrome/browser/ui/omnibox code. As it's also used by //chrome/renderer, it
needs to be componentized into //components/omnibox/common so that DEPS
allowances/build dependencies have the expected structure (i.e., don't allow
for bleed between renderer and browser code).
BUG=371536
TBR=sky
Review URL: https://codereview.chromium.org/1229613004
Cr-Commit-Position: refs/heads/master@{#338007}
|