| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The start and completion of the config retrieval requests will be logged,
and made available to the chrome://net-internals/#bandwidth page.
BUG=466753
Review URL: https://codereview.chromium.org/1105443003
Cr-Commit-Position: refs/heads/master@{#327389}
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the removal using the DataReductionProxyService class to perform the secure proxy check, there is no longer a need to post tasks to the UI thread.
This effectively makes DataReductionProxyConfig an IO thread only class, and does not need to have pointers to task runners.
BUG=472290
Review URL: https://codereview.chromium.org/1052583005
Cr-Commit-Position: refs/heads/master@{#327360}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now ScopedPtrHashMap expect the 2nd parameter is scoped_ptr<T>. For example, old usage
ScopedPtrHashMap<int, Value>
new usage
ScopedPtrHashMap<int, scoped_ptr<Value>>
With this change, ScopedPtrHashMap support scoped_ptr's custom deleter.
R=danakj@chromium.org, tzik@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1099383002
Cr-Commit-Position: refs/heads/master@{#327341}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.
This patch was manually generated using a regex and a text editor.
BUG=417463
Review URL: https://codereview.chromium.org/1056633004
Cr-Commit-Position: refs/heads/master@{#327312}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classifier. (patchset #35 id:680001 of https://codereview.chromium.org/1002803002/)
Reason for revert:
Very flaky on ChromeOS debug bots. See crbug.com/481910
Original issue's description:
> Classify navigations without page id in parallel to the existing classifier.
>
> For now, this only happens in debug builds.
>
> BUG=369661
> TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
> TEST=Every other test on the planet.
>
> Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
> Cr-Commit-Position: refs/heads/master@{#327122}
>
> Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc
> Cr-Revert-Position: refs/heads/master@{#327152}
>
> Committed: https://crrev.com/5671403d44971669e4d81aecf3f002188ce0e95f
> Cr-Commit-Position: refs/heads/master@{#327214}
TBR=phajdan.jr@chromium.org,clamy@chromium.org,creis@chromium.org,hajimehoshi@chromium.org,isherman@chromium.org,jeremyim@chromium.org,mattm@chromium.org,mnaganov@chromium.org,mvanouwerkerk@chromium.org,nasko@chromium.org,stevenjb@chromium.org,bengr@chromium.org,cpu@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661
Review URL: https://codereview.chromium.org/1110943003
Cr-Commit-Position: refs/heads/master@{#327269}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, this only happens in debug builds.
BUG=369661
TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
TEST=Every other test on the planet.
Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
Cr-Commit-Position: refs/heads/master@{#327122}
Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc
Cr-Revert-Position: refs/heads/master@{#327152}
Review URL: https://codereview.chromium.org/1002803002
Cr-Commit-Position: refs/heads/master@{#327214}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classifier. (patchset #34 id:660001 of https://codereview.chromium.org/1002803002/)
Reason for revert:
Caused compile error in "Google Chrome Mac" bot:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/726
Original issue's description:
> Classify navigations without page id in parallel to the existing classifier.
>
> For now, this only happens in debug builds.
>
> BUG=369661
> TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
> TEST=Every other test on the planet.
>
> Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
> Cr-Commit-Position: refs/heads/master@{#327122}
TBR=phajdan.jr@chromium.org,clamy@chromium.org,creis@chromium.org,hajimehoshi@chromium.org,isherman@chromium.org,jeremyim@chromium.org,mattm@chromium.org,mnaganov@chromium.org,mvanouwerkerk@chromium.org,nasko@chromium.org,stevenjb@chromium.org,bengr@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661
Review URL: https://codereview.chromium.org/1104403002
Cr-Commit-Position: refs/heads/master@{#327152}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UI objects (specifically DataReductionProxySettings) already creates
a BooleanPrefMember for kDataReductionProxyEnabled and checks for changes
on it, then propagates this information to DataReductionProxyIOData via
DataReductionProxyIOData::SetProxyPrefs.
It also negates the need to pass a BooleanPrefMember to BypassStats when
ultimately all we care about is the boolean value.
BUG=472290
Review URL: https://codereview.chromium.org/1057473003
Cr-Commit-Position: refs/heads/master@{#327138}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1111493002
Cr-Commit-Position: refs/heads/master@{#327123}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now, this only happens in debug builds.
BUG=369661
TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
TEST=Every other test on the planet.
Review URL: https://codereview.chromium.org/1002803002
Cr-Commit-Position: refs/heads/master@{#327122}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch modifies all tests to have a more realistic threading set-up by either:
a) adding a TestBrowserThreadBundle
b) constructing any existing TestBrowserThreadBundle earlier or
c) adding a MessageLoop as appropriate.
This makes it possible to later migrate base/ from MessageLoopProxy over to
ThreadTaskRunnerHandle, which requires an active task runner on the current thread.
BUG=465354
Review URL: https://codereview.chromium.org/1086733002
Cr-Commit-Position: refs/heads/master@{#327067}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we have added PrefRegistry registration functions that do not need to
accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is
redundant and we can remove it altogether.
Ran the following command:
for x in $(git ls-files | grep -E "\.(cc|h|mm)$") ; do perl -0777 -i -pe 's/,[ \n]*(user_prefs::)+PrefRegistrySyncable::UNSYNCABLE_PREF//igs' $x ; done && git cl format
There are still some occurences that need to be manually fixed.
BUG=476800
Review URL: https://codereview.chromium.org/1102733002
Cr-Commit-Position: refs/heads/master@{#326993}
|
|
|
|
|
|
|
|
|
|
|
| |
Replace them with CapturedNetLogEntry.
BUG=none
TBR=bengr@chromium.org
Review URL: https://codereview.chromium.org/1109473003
Cr-Commit-Position: refs/heads/master@{#326924}
|
|
|
|
|
|
|
|
| |
BUG=466848
Review URL: https://codereview.chromium.org/1043013002
Cr-Commit-Position: refs/heads/master@{#326483}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Report numbers of responses that have tamper detection fingerprints added and
those fingerprints are valid (have not modified by intermediaries). The report
contains a total count (same to before), as well as separated counts for different
MIME types, including JavaScript, CSS, and image (GIF, JPG, PNG and WEBP).
BUG=381907
Review URL: https://codereview.chromium.org/1073313002
Cr-Commit-Position: refs/heads/master@{#326457}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is both a rename, and a functional change.
Before LogLevel was an enum, and consumers would compare its numeric value, or use it for serialization purposes. Whereas NetLogCaptureMode is a class that encapsulates the various capabilities for a logging level.
BUG=472710
TBR=asanka@chromium.org,sergeyu@chromium.org,yurys@chromium.org,bengr@chromium.org,asargent@chromium.org,zea@chromium.org,scherkus@chromium.org
Review URL: https://codereview.chromium.org/1059843002
Cr-Commit-Position: refs/heads/master@{#326440}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the storage portion lives on the UI thread (to be read from
net_internals_ui.cc), but all calls for adding events occurs on the IO
thread. In order to maintain thread safety, it used to PostTask to
itself, but that introduces a lifetime problem per bug 472290.
The solution is to split the IO and UI thread portions (in this case
event collection and event storage) and use the existing DRP IO and
DRP Service classes to ensure posted tasks respect the lifetime of
the objects.
BUG=472290
Review URL: https://codereview.chromium.org/1075283004
Cr-Commit-Position: refs/heads/master@{#326396}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, only the net_error was stored - unfortunately, depending on
how a carrier and/or transparent proxy enforces the secure proxy check,
getting a net_error of success while getting a non-200 HTTP response code
is acceptable.
BUG=475267
Review URL: https://codereview.chromium.org/1089733002
Cr-Commit-Position: refs/heads/master@{#326204}
|
|
|
|
|
|
|
|
|
|
|
| |
- Add support for a new header field for the secure session ID
- Add flag to control the server from which the configuration is retrieved
BUG=466753
Review URL: https://codereview.chromium.org/1032943002
Cr-Commit-Position: refs/heads/master@{#326203}
|
|
|
|
|
|
|
|
| |
BUG=478610
Review URL: https://codereview.chromium.org/1066513005
Cr-Commit-Position: refs/heads/master@{#326138}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this patch, net::BackoffEntry had a virtual ImplGetTimeNow method
that tests etc would override to change what time is considered "now".
As suggested by rsleevi in https://codereview.chromium.org/1023473003,
this patch removes that method, and instead makes net::BackoffEntry
accept a base::TickClock in the constructor, to allow overriding the
time without subclassing.
(this will allow future changes to net::BackoffEntry without the
fragile base class problem)
Accordingly, I've removed all subclasses of BackoffEntry, and made them
pass TickClocks instead; in most cases this has been a nice
simplification.
BUG=465399
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/1076853003
Cr-Commit-Position: refs/heads/master@{#325865}
|
|
|
|
|
|
|
|
|
|
|
| |
R=phajdan.jr@chromium.org
TBR=jeremyim@chromium.org
BUG=none
TEST=less code
Review URL: https://codereview.chromium.org/1050863004
Cr-Commit-Position: refs/heads/master@{#325755}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.
Also, secure proxy check is now done on IO thread.
BUG=437080
Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
Cr-Commit-Position: refs/heads/master@{#325302}
Committed: https://crrev.com/afc53166cb6a0ed561f416403ab68261eae4427b
Cr-Commit-Position: refs/heads/master@{#325464}
Review URL: https://codereview.chromium.org/981633002
Cr-Commit-Position: refs/heads/master@{#325674}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renaming two classes
CapturingNetLog --> TestNetLog
NetLogLogger --> WriteToFileNetLogObserver
BUG=473252
TBR=jam,mmenke
Review URL: https://codereview.chromium.org/1084533002
Cr-Commit-Position: refs/heads/master@{#325611}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:380001 of https://codereview.chromium.org/981633002/)
Reason for revert:
This is breaking all the tests again:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27288/
Original issue's description:
> Created new URLRequestContext for secure proxy check.
>
> The new URLRequestContext disables alternate protocols
> to ensure that the Data Reduction Proxy secure proxy check
> request goes out over vanilla HTTP so that it can be
> intercepted by middleboxes.
>
> Also, secure proxy check is now done on IO thread.
>
> BUG=437080
>
> Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
> Cr-Commit-Position: refs/heads/master@{#325302}
>
> Committed: https://crrev.com/afc53166cb6a0ed561f416403ab68261eae4427b
> Cr-Commit-Position: refs/heads/master@{#325464}
TBR=sclittle@chromium.org,rch@chromium.org,bengr@chromium.org,mmenke@chromium.org,sgurun@chromium.org,jeremyim@chromium.org,tbansal@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437080
Review URL: https://codereview.chromium.org/1089443003
Cr-Commit-Position: refs/heads/master@{#325526}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.
Also, secure proxy check is now done on IO thread.
BUG=437080
Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
Cr-Commit-Position: refs/heads/master@{#325302}
Review URL: https://codereview.chromium.org/981633002
Cr-Commit-Position: refs/heads/master@{#325464}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 652eabf1141c00594aa6e9ed81beb980aec89198.
The CL appears to have broken the Android Tests (dbg) bot:
http://build.chromium.org/p/chromium.linux/builders/
Android%20Tests%20%28dbg%29/builds/27276
BUG=437080
TEST=None
TBR=tbansal@chromium.org
Cr-Commit-Position: refs/heads/master@{#325413}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 919dce4400651813d5ff6e8a85b944a5987adcb7.
BUG=None
TBR=akuegel
Review URL: https://codereview.chromium.org/1094553002
Cr-Commit-Position: refs/heads/master@{#325412}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I am reverting all CLs that could have caused this failure:
http://build.chromium.org/p/chromium.linux/builders/
Android%20Tests%20%28dbg%29/builds/27276
I will start re-landing vindicated CLs shortly.
Revert "Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information."
This reverts commit eb48d65705e44b80d1d7a3b4f21c567802c102bb.
Revert "Supply build properties to run-bisect-perf regression for android bisects."
This reverts commit 9d70bb94984b02c17678ccf482d1a7b7c760a43f.
Revert "[cros New-GAIA] Webview login and new GAIA endpoint enabled by default"
This reverts commit 29061783f8b59f1e78286a87a3bb7d18129f639a.
Revert "Prime the landing pad for the new video rendering pipeline."
This reverts commit 45a3c93f745eabf6c1b1cbdac87ed4350a919e76.
Revert "Implement separate error dialog for cws widget container"
This reverts commit 7ed1f876f6f4d79ac074b25f2066d514603aa18d.
Revert "Create device_bluetooth watchlist; add scheib."
This reverts commit 40514c99cd45d1c8e9caef3245d42533d9810179.
Revert "Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information."
This reverts commit a687f31a786645508622482e9033f497364a43cd.
Revert "Created new URLRequestContext for secure proxy check."
This reverts commit 652eabf1141c00594aa6e9ed81beb980aec89198.
Revert "Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/)"
This reverts commit 488846cd562f444831982d82ef0bc9ca0dd79028.
Revert "Sync: Add Android test for downloading a bookmark"
This reverts commit 9c052713563111ac3d6cc64d4b5cfdfa27c202f4.
Revert "ScreenOrientationController to start observing even without an internal display."
This reverts commit 31fed68a524d49f99cebf02dca6ad49019e9900c.
Revert "Fix MB configurations for Mac and Win GN bots."
This reverts commit 31a66f3e705d20a39033a7b7d7f09a60517e6b9d.
Revert "Add tool/perf/measurements path to check for CQ jobs."
This reverts commit 99e1ac1d217174dad7a862f6a0fc44950d503737.
Revert "Implement Notification.data for persistent notifications."
This reverts commit 539f51d6af62097059c34b1c19dfbc4352413ad7.
Revert "Fix playback rate calculations for WallClockTimeSource."
This reverts commit 3ec02d642465872d9ab7d7db600d0480a57b3cab.
Revert "Roll src/third_party/pdfium eddab44:b330016"
This reverts commit 81d51e253cfacd5648cca9f12b605e63971a9ab1.
Revert "cc: Make DisplayItemList::Append replay into an SkPicture"
This reverts commit ec7c07e57bc5f91e3ba0bdeba8b6f534978615b0.
Revert "Clean up URLFetcher unit tests, part 5."
This reverts commit 8eeb3bf4a02be612cacb3cdbb5c223d909939527.
BUG=None
TBR=akuegel
Review URL: https://codereview.chromium.org/1083683003
Cr-Commit-Position: refs/heads/master@{#325411}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.
Also, secure proxy check is now done on IO thread.
BUG=437080
Review URL: https://codereview.chromium.org/981633002
Cr-Commit-Position: refs/heads/master@{#325302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContextGetter
- The URLRequestContextGetter is read in DRPIOData::SetDataReductionProxyService on the UI thread
- The URLRequestContextGetter is passed to DRPConfig in DRPIOData::InitializeOnIOThread on the IO thread
- InitializeOnIOThread isn't executed until SetDataReductionProxyService completes, so the read is safe
BUG=472290
Review URL: https://codereview.chromium.org/1080083006
Cr-Commit-Position: refs/heads/master@{#325085}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- DataReductionProxyIOData::InitializeOnIOThread should be the single
place for IO objects to initialize, instead of having each class post
to the IO thread.
- IO objects should only be used on the IO thread (outside of construction)
and shouldn't need to check that they are only being used on the IO
thread.
BUG=472290
Review URL: https://codereview.chromium.org/1082883002
Cr-Commit-Position: refs/heads/master@{#324962}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the reported size of responses larger than max int32 would
overflow, and these overflowed sizes were even surfaced to UI for the
Data Reduction Proxy.
Verified by building Chrome with and without this patch, and using the
Data Saver Chrome extension to download a 2.6 GB file. Without this
patch, a negative number is shown in the Data Saver stats. With this
patch, 2.6 GB is shown in the Data Saver stats.
BUG=475081
Review URL: https://codereview.chromium.org/1074293003
Cr-Commit-Position: refs/heads/master@{#324738}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
task runner safety.
- Config is no longer exposed to Settings for purposes of posting the
"Update Config" task when the UI setting is enabled; instead the call is
proxied through DRPService to post to DRPIOData on a weak pointer
- Initialization logic updated to ensure DRPService has a weak pointer to
DRPIOData (initialized on the IO thread), which takes place after DRPIOData
receives a weak pointer to DRPService (initialized on the UI thread).
- Add DRPService observer so that DRPSettings is notified when DRPService
receives the DRPIOData weak pointer (so that calls to DRP IO classes will
not be silently dropped due to the weak pointer not being set).
BUG=472290
Review URL: https://codereview.chromium.org/1075743002
Cr-Commit-Position: refs/heads/master@{#324693}
|
|
|
|
|
|
|
|
|
|
|
| |
Added a presubmit script to enforce that all future changes in the
data_reduction_proxy component are formatted with git cl format.
BUG=476041
Review URL: https://codereview.chromium.org/1078033003
Cr-Commit-Position: refs/heads/master@{#324682}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- DRP NetworkDelegate/BypassStats are no longer aware of the UI thread.
- Add thread hopping functionality to DRP IOData/Service, using the
correct WeakPtr to post tasks safely.
- Construct BypassStats in the IOData constructor.
BUG=472290
Review URL: https://codereview.chromium.org/1054363002
Cr-Commit-Position: refs/heads/master@{#324375}
|
|
|
|
|
|
|
|
|
|
| |
Added new histograms to break down Current bypasses (i.e. "Chrome-Proxy: block-once") by audio/video content types, as well as "content-type: application/octet-stream".
BUG=473763
Review URL: https://codereview.chromium.org/1048303004
Cr-Commit-Position: refs/heads/master@{#324075}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl changes the protocol between Chrome and data reduction proxy to
always retry a request without using data reduction proxy if header
specifies "Chrome-Proxy: block-once", even if the request is not
idempotent. Going forward, the data reduction proxy will issue a
block-once only if it is known to be safe to retry.
BUG=433901
Review URL: https://codereview.chromium.org/1047653005
Cr-Commit-Position: refs/heads/master@{#323642}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This API is for use by the Data Saver extension to clear the data
savings metrics including the data savings graph displayed by the
extension.
BUG=461022
Review URL: https://codereview.chromium.org/1026143002
Cr-Commit-Position: refs/heads/master@{#323590}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
than net/base.
(Some files in net/base got moved to net/log)
BUG=434856
TBR=armansito@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/1050923005
Cr-Commit-Position: refs/heads/master@{#323525}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As the comment in data_reduction_proxy_statistics_prefs.h by bengr@,
rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats
and related class. Rename the files also.
BUG=462845
R=bengr@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/949533004
Cr-Commit-Position: refs/heads/master@{#323421}
|
|
|
|
|
|
|
|
|
|
| |
Avoid unnecessary conversions.
BUG=467024
Review URL: https://codereview.chromium.org/1056683002
Cr-Commit-Position: refs/heads/master@{#323358}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As the comment in data_reduction_proxy_usage_stats.h by bengr@,
rename DataReductionProxyUsageStats to DataReductionProxyBypassStats
and related class. Rename the files also.
BUG=462846
R=bengr@chromium.org
Review URL: https://codereview.chromium.org/956223002
Cr-Commit-Position: refs/heads/master@{#323191}
|
|
|
|
|
|
|
|
| |
BUG=470660
Review URL: https://codereview.chromium.org/1036853004
Cr-Commit-Position: refs/heads/master@{#322481}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DataReductionProxyConfigServiceClient.
- Permit DRP RequestOptions to take auth credentials instead of always internally
generating them.
- Permit DRP Config to perform a reload of the configuration
- Create a new DRP MutableConfigValues class which can have its underlying values
updated.
- Add a configuration refresh timer to DRP ConfigServiceClient, along with
backoff logic.
BUG=466753
Review URL: https://codereview.chromium.org/1024553009
Cr-Commit-Position: refs/heads/master@{#322217}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add the ClientConfig proto definition corresponding to the response
coming from the service.
- Create a means of generating a pseudo response from the built in
params and request options.
- Create a class to parse the JSON response.
- Add necessary helper classes for the ProxyScheme and time values
coming from the service.
BUG=466753
Committed: https://crrev.com/97652ebe50c4be712aa976776bee9694cbce1178
Cr-Commit-Position: refs/heads/master@{#321931}
Review URL: https://codereview.chromium.org/1017853003
Cr-Commit-Position: refs/heads/master@{#322021}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:100001 of https://codereview.chromium.org/1017853003/)
Reason for revert:
Seems that some of the tests introduced in this CL are failing on builders:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/11450/steps/components_unittests/logs/stdio
Value of: config_parser::TimeToISO8601(test.time)
Actual: "2009-04-22T19:24:48.000Z"
Expected: test.expected
Which is: "1601-01-01T00:00:00.000Z"
[ FAILED ] ClientConfigParserTest.TimeToISO8601 (0 ms)
Value of: config_parser::TimestampToTime(ts)
Actual: 1964-11-24 17:31:43.000 UTC
Expected: test.expected_time
Which is: 2038-01-19 03:14:07.999 UTC
[ FAILED ] ClientConfigParserTest.TimestampToTime (0 ms)
No idea why they are failing there, or why they passed on the trybots.
Original issue's description:
> Add ClientConfig proto, and JSON generation/parsing.
>
> - Add the ClientConfig proto definition corresponding to the response
> coming from the service.
> - Create a means of generating a pseudo response from the built in
> params and request options.
> - Create a class to parse the JSON response.
> - Add necessary helper classes for the ProxyScheme and time values
> coming from the service.
>
> BUG=466753
>
> Committed: https://crrev.com/97652ebe50c4be712aa976776bee9694cbce1178
> Cr-Commit-Position: refs/heads/master@{#321931}
TBR=bengr@chromium.org,sclittle@chromium.org,jeremyim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466753
Review URL: https://codereview.chromium.org/1020863009
Cr-Commit-Position: refs/heads/master@{#321936}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add the ClientConfig proto definition corresponding to the response
coming from the service.
- Create a means of generating a pseudo response from the built in
params and request options.
- Create a class to parse the JSON response.
- Add necessary helper classes for the ProxyScheme and time values
coming from the service.
BUG=466753
Review URL: https://codereview.chromium.org/1017853003
Cr-Commit-Position: refs/heads/master@{#321931}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the ability to pass in a custom CookieStore to a URLRequest. It's
a small change to net/url_request which then balloons to everything in the
project that ever makes a URLRequest.
This reverts the rest of https://codereview.chromium.org/188693003 (and then
does a whole lot more because URLRequest constructors were unified recently to
always require passing in the fourth argument).
BUG=457344
Review URL: https://codereview.chromium.org/1003953008
Cr-Commit-Position: refs/heads/master@{#321820}
|
|
|
|
|
|
|
|
|
|
|
| |
Add a "clear-data-reduction-proxy-data-savings" flag, which when
enabled will clear out data savings statistics on startup.
BUG=461022
Review URL: https://codereview.chromium.org/1010083002
Cr-Commit-Position: refs/heads/master@{#320936}
|