| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enhanced bookmarks and the DOM distiller are (or will be) used on
iOS and android. Move the function checking whether the features
are enabled into the respective component to allow sharing the code.
Move IsEnhancedBookmarksEnabled() function to the enhanced_bookmarks
component with supporting switches.
Move IsEnableDomDistillerSet() and IsEnableSyncArticlesSet() functions
to the dom_distiller component with supporting switches.
BUG=359565
Review URL: https://codereview.chromium.org/1253953002
Cr-Commit-Position: refs/heads/master@{#340526}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change cleans up some of the includes in distiller
core and moves the ExternalFeedbackReporter into content
so that core does not depend on content; obeying the rules
of a layered component.
BUG=512850
Review URL: https://codereview.chromium.org/1249023004
Cr-Commit-Position: refs/heads/master@{#339996}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the files in the root content folder to a new
browser folder. This is to help differentiate future code that
will run on the renderer.
BUG=
Review URL: https://codereview.chromium.org/1227123002
Cr-Commit-Position: refs/heads/master@{#339927}
|
|
|
|
|
|
|
|
|
|
|
| |
This change runs the dom distiller in an isolated world instead of
the main world.
BUG=484843
Review URL: https://codereview.chromium.org/1124973002
Cr-Commit-Position: refs/heads/master@{#334954}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change allows content to be shown on the page prior to the
distillation of the first page of an article having completed.
The template HTML and the loading animation will show while the
distillation completes.
BUG=
Review URL: https://codereview.chromium.org/1130703003
Cr-Commit-Position: refs/heads/master@{#331852}
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves any code related to JavaScript and HTML generation
in dom distiller to a superclass that all platforms can use.
BUG=472797
Review URL: https://codereview.chromium.org/1101993003
Cr-Commit-Position: refs/heads/master@{#327055}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change starts the Google feedback form when a user chooses
the 'NO' option on the feedback form on android. A new interface
has been created to facilitate similar functionality on different
platforms.
This change depends on:
https://codereview.chromium.org/1043263004/
BUG=472890
Review URL: https://codereview.chromium.org/1054803002
Cr-Commit-Position: refs/heads/master@{#325078}
|
|
|
|
|
|
|
|
| |
BUG=471439
Review URL: https://codereview.chromium.org/1049873004
Cr-Commit-Position: refs/heads/master@{#324740}
|
|
|
|
|
|
|
|
| |
BUG=454477,471439
Review URL: https://codereview.chromium.org/1051673002
Cr-Commit-Position: refs/heads/master@{#323875}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the trained model, the javascript core feature extraction, and simple
functions to apply the old or new heuristics to a web_contents*.
BUG=471439
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/1047223003
Cr-Commit-Position: refs/heads/master@{#323805}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is initialized with a proto containing the trained model. Then has
a simple Classify() function that takes a set of features (these must be
of the same length, calculated the same way, and in the same order as
the features that the model was trained on).
BUG=471439
Review URL: https://codereview.chromium.org/1041063002
Cr-Commit-Position: refs/heads/master@{#323623}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've trained a simple model for detecting non-mobile distillable pages
based on a set of features derived from a webpage. This change adds the
main part of deriving those features (a bunch of values are calculated
based on some core features of the web page). It does not add the
extraction of those core features from a page.
A test is added that uses json-formatted core features and then
json-formatted output of the training pipelines derived feature
calculation. It then ensures that the calculation here matches that in
the training pipeline.
BUG=471439
Review URL: https://codereview.chromium.org/1042053003
Cr-Commit-Position: refs/heads/master@{#323554}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove references to android_webview_build now that we no longer support
that build configuration. Fold conditions into their parents where
appropriate. This CL only handles the "easy" cases, I'll do the
nontrivial ones separately.
BUG=440793
Review URL: https://codereview.chromium.org/1041673002
Cr-Commit-Position: refs/heads/master@{#323490}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provides an implementation of DistillerPage that use the web API to
inject the distiller JavaScript code into the page.
Introduce an iOS specific implementation of domdistiller.js to work
around a crash in UIWebView when creating a local "window" object.
BUG=459678
Review URL: https://codereview.chromium.org/936843002
Cr-Commit-Position: refs/heads/master@{#317813}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/929883002
Cr-Commit-Position: refs/heads/master@{#316519}
|
|
|
|
|
|
|
|
| |
Add lots of missing dependencies identified by "gn check" in both the GN and GYP builds.
Review URL: https://codereview.chromium.org/756233002
Cr-Commit-Position: refs/heads/master@{#305841}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DomDistillerStore now provides simple, asynchronous Get and Update
for attachments. When an update is requested, we add the attachments to
the attachment store, and when that succeeds update the model/sync/db
entry. So, while non-attachment updates are applied asynchronously, that
is not the case for attachment updates.
Most of the mapping between the ids stored in the specifics and the actual
attachment objects is handled by ArticleAttachmentsData.
BUG=430552
Review URL: https://codereview.chromium.org/717793007
Cr-Commit-Position: refs/heads/master@{#304917}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mostly just adds the chrome_shell_apk build definition and those of
a whole bunch of targets.
Adds a simple check that when DEPRECATED_java_in_dir is used, it
actually includes the "src" at the end (GYP just assumes that you really
meant that java files are in <(java_in_dir)/src).
Makes the call to process_resources only generate R.java for extra
packages when being run as part of the apk step (otherwise, for
example, both chrome resources and content resources would contain
an R.java for net resources and compilation would fail).
Depends on https://codereview.chromium.org/581273004/
Adds the following targets -- and enables ~300 more (550 counting
template-generated inner targets):
//chrome:chrome_android_core
//chrome/android:chrome_strings_grd
//chrome/android:chrome_java
//chrome/android:activity_type_ids_javagen
//chrome/android:app_banner_metrics_ids_javagen
//chrome/android:resource_id_javagen
//chrome/android:profile_account_management_metrics_javagen
//chrome/android:profile_sync_service_model_type_selection_javagen
//chrome/android:toolbar_model_security_levels_javagen
//chrome/android:tab_load_status_javagen
//chrome/android:chrome_shell_base
//chrome/android:chrome_shell
//chrome/android:chrome_sync_shell
//chrome/android:chrome_shell_resources
//chrome/android:chrome_shell_java
//chrome/android:chrome_shell_assets
//chrome/android:chrome_shell_apk
//chrome/android:chrome_sync_shell_apk
//components/bookmarks:bookmarks_java
//components/bookmarks:bookmarks_jni_headers
//components/bookmarks:bookmark_type_javagen
//components/dom_distiller/android:dom_distiller_core_java
//components/dom_distiller/android:dom_distiller_core_font_family_javagen
//components/dom_distiller/android:dom_distiller_core_theme_javagen
//components/enhanced_bookmarks:jni_headers
//components/enhanced_bookmarks/android:enhanced_bookmarks_java
//components/gcm_driver:gcm_driver_java
//components/gcm_driver:jni_headers
//components/navigation_interception/android:navigation_interception_java
//components/variations:variations_java
//components/web_contents_delegate_android:web_contents_delegate_android
//components/web_contents_delegate_android:web_contents_delegate_android_java
//components/web_contents_delegate_android:web_contents_delegate_android_jni_headers
//printing:printing_java
//sync:fake_server_jni
//sync:sync_java_test_support
//sync:test_support_sync_fake_server_android
//sync:sync_unit_tests_apk
//sync/android:sync_java
//sync/android:sync_javatests
BUG=359249
TBR=ben
Review URL: https://codereview.chromium.org/570203002
Cr-Commit-Position: refs/heads/master@{#299381}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, Windows Release incremental links fail with:
dom_distiller_core.distilled_page_prefs.obj : error LNK2019: unresolved external symbol "public: void __thiscall user_prefs::PrefRegistrySyncable::RegisterIntegerPref(char const *,int,enum user_prefs::PrefRegistrySyncable::PrefSyncStatus)" (?RegisterIntegerPref@PrefRegistrySyncable@user_prefs@@QAEXPBDHW4PrefSyncStatus@12@@Z) referenced in function "public: static void __cdecl dom_distiller::DistilledPagePrefs::RegisterProfilePrefs(class user_prefs::PrefRegistrySyncable *)" (?RegisterProfilePrefs@DistilledPagePrefs@dom_distiller@@SAXPAVPrefRegistrySyncable@user_prefs@@@Z)
R=nyquist@chromium.org
BUG=404809
Review URL: https://codereview.chromium.org/496323003
Cr-Commit-Position: refs/heads/master@{#291513}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds backend support for Font Family preferences
within DistilledPagePrefs. The font families supported are
sans-serif (default), serif, and monospace. Serif and
monospace fonts are set by the browser, while sans-serif is
defined as Open Sans, and then the browser default sans-serif
font.
BUG=383630
Review URL: https://codereview.chromium.org/430473007
Cr-Commit-Position: refs/heads/master@{#289801}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds Java version of DomDistillerService and
DistilledPagePrefs with support for setting and retrieving
the current Theme.
The DomDistillerService can be retrieved by using the
DomDistillerServiceFactory, which maps a profile to an
instance of the service.
BUG=383630
Review URL: https://codereview.chromium.org/340403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds support for allowing users to change the appearance of
distilled pages to different themes. The current themes are
light, dark and sepia.
The theme of the page is controlled by the CSS class of the
body element. When the page is loaded, this CSS class is set
by inserting the CSS class into the HTML. When a setting is
changed while a distilled page is open, the CSS class is set
by calling the JavaScript function useTheme which then updates
the body element's CSS class.
BUG=383630
Review URL: https://codereview.chromium.org/341563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These deps are some of those required to compile chrome/browser (so mostly those containing resources and protobufs that have generated headers). chrome/browser still has some dependencies left.
Add third_party libs libaddressinput and dom_distiller_js.
Add components dom_distiller and policy.
Separate the generate_library_loader into a separate .gni file.
Rename components_strings to just strings.
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/362583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code extracted from components/dom_distiller/core/dom_distiller_database.*
Slight API change: callers to UpdateEntries now have to pass a vector of (string, proto) as key and value, instead of just a vector of protos where key is derived.
Ran clang-format on the files I touched so you may see some diffs.
Note: Implementations are in proto_database_impl.h and fake_db.h for proper linking.
BUG=385747
TBR=jochen,dgrogan
TEST=DomDistiller*,ProtoDatabaseImplTest
Review URL: https://codereview.chromium.org/330833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the utilities needed for using the current WebContents when
distilling web pages.
BUG=361939
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272611
Review URL: https://codereview.chromium.org/266073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test added in this CL DomDistillerTabUtilsBrowserTest.TestSwapWebContents
consistently fails on some bots, e.g.
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/41414
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/27225
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/48492
> Add support for distilling current WebContents
>
> This CL adds the utilities needed for using the current WebContents when
> distilling web pages.
>
> BUG=361939
>
> Review URL: https://codereview.chromium.org/266073003
TBR=nyquist@chromium.org
Review URL: https://codereview.chromium.org/297163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the utilities needed for using the current WebContents when
distilling web pages.
BUG=361939
Review URL: https://codereview.chromium.org/266073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows the creator of the DistillerFactory to set the
DomDistillerOptions for all pages distilled by Distillers from that
factory.
Add an option to the content_extractor to extract just the text from the
page.
DEPENDSON= https://codereview.chromium.org/270663005/ https://codereview.chromium.org/286453002/
Review URL: https://codereview.chromium.org/286583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the distiller_page to use the proto-based
DomDistiller.applyWithOptions().
To provide options, domdistiller.js contains a $$OPTIONS placeholder
that is replaced with the json-serialized DomDistillerOptions at
runtime.
Review URL: https://codereview.chromium.org/270663005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The DomDistillerService now requires callers to pass in DistillerPage.
This enables callers to more closely control how the page is distilled.
BUG=361939
Review URL: https://codereview.chromium.org/254483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the interface to whatever is used for storing and fetching
distilled content. In the future, this should be provided by sync
attachments. For now, we need something.
The interface is a very simple pair of functions, SaveContent and
LoadContent, both asynchronous.
There is a simple in-memory implementation that just stores saved
content in a map.
The DomDistillerService creates the store and uses a save callback on
the TaskTracker to save content to it. The TaskTracker receives a
pointer to the store and uses it when StartBlobFetcher is called.
BUG=288015
Review URL: https://codereview.chromium.org/189833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the logic for creating HTML content, and retrieving resources
from the content/ subfolder of the component to core/.
It also provides a helper method for calling the right method on the
DomDistillerService based on a URL.
BUG=319881
TBR=jochen@chromium.org
TBR=jshin@chromium.org
Review URL: https://codereview.chromium.org/235833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PageDistiller adds an extra layer between the Distiller and the
underlying code which in fact distills the content.
This CL simplifies the distillation process by removing this class and
the delegate used for communcation. More of the logic is now moved into
the DistillerPage class.
BUG=361939
Review URL: https://codereview.chromium.org/231933005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix the inconsistency that we have between: components.gyp,
components_tests.gyp, components_unittests.isolate and
component_resources.gyp, component_strings.grd, component_strings.gyp.
This should also please my OCD of auto completion in the command line,
with this it is just a single tab to auto complete all the files
that start with components*.
BUG=None
TEST=gyp
R=blundell@chromium.org
TBR=thestig
Review URL: https://codereview.chromium.org/198783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for reporting whether the perceived quality of the
distillation of a web page is good. The user choice is recorded as
UMA stats.
This CL only implements a UI for Android.
BUG=319881
R=jar@chromium.org, newt@chromium.org, shashishekhar@chromium.org
Review URL: https://codereview.chromium.org/197473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates targets that use blink public API headers to depend on the
blink_headers target, which sets up include paths so the headers can function
without needing relative path hacks. Targets that expose #includes of public
blink headers export the dependent settings from blink_headers to their
dependents.
BUG=350097
Review URL: https://codereview.chromium.org/189713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for providing incremental updates for multipage
distillation. Updates are now broadcasted to the viewers, whenever a new
page in the article finishes distillation. This allows viewer to show
data to the user, before the distillation of the entire article is
completed.
This change required changing management of pages in distiller to be
refcounted.
BUG=288015
NOTRY=true
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/178303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the Java hooks needed and a menu option to distill the current
web page in the test shell.
Original CL: https://codereview.chromium.org/185113002/
BUG=319881
Review URL: https://codereview.chromium.org/183893029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add UI hook for distilling web pages for test shell.
>
> This adds the Java hooks needed and a menu option to distill the current
> web page in the test shell.
>
> BUG=319881
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/185113002
TBR=nyquist@chromium.org
Review URL: https://codereview.chromium.org/187453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the Java hooks needed and a menu option to distill the current
web page in the test shell.
BUG=319881
NOTRY=true
Review URL: https://codereview.chromium.org/185113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for requesting to view arbitrary URLs in the DOM
Distiller viewer. Previously, an entry first had to be added to the
list of articles.
Also fixes the CSP for the viewer to be in the correct format.
BUG=319881
TBR=rsleevi@chromium.org,joi@chromium.org
Review URL: https://codereview.chromium.org/151003006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the TranslateScript class and the translate.js script.
A new translate_resources target is created.
BUG=335074
TBR=jochen
Review URL: https://codereview.chromium.org/138933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for distilling multiple pages, currently support is really
basic and just distills pages sequentially.
BUG=288015
TEST=included
NOTRY=true
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/146843010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds support in the content::URLDataSource for DOM Distiller for displaying
distilled articles.
Also adds preliminary error handling.
Depends on https://codereview.chromium.org/105723002/
BUG=319881
Review URL: https://codereview.chromium.org/134873008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the scheme chrome-distiller:// and has a minimal implementation
of a data source which should be loaded when a URL with the new scheme is
loaded.
The chrome-distiller:// scheme will be used for displaying distilled
articles, which is extracted content of web pages with long form articles.
Chrome will maintain a list of such articles, and in addition, the user
will be able to display such distilled content on demand for a given URL.
BUG=319881
Review URL: https://codereview.chromium.org/105723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For experimentation with the dom distiller component, this provides a minimal API wrapping the functions of DomDistillerService.
Sketch proposal:
https://docs.google.com/a/google.com/document/d/1zLTKNAOkTyFpgeJqWg3Jn17Ayc-sYafyftBE6KUldV4/edit
BUG=288015
TBR=joi
Review URL: https://codereview.chromium.org/116553005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
distilled_page_proto generates a header that dom_distiller_core includes in its
public headers. Thus, dom_distiller_core needs to export distilled_page_proto's
hard dependency to any target depending on dom_distiller_core; otherwise, those
targets are subject to flaky build failures.
Review URL: https://codereview.chromium.org/111503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Define an observer that allows clients to listen to article updates.
In a subsequent CL, I will hook the webui to observe article changes.
BUG=288015
Review URL: https://codereview.chromium.org/100463005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds functionality to trigger distillation of web pages from the
debug UI and also lists the current set of articles.
BUG=319881
Review URL: https://codereview.chromium.org/105623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Treat the concept of "how to get the DomDistillerService to use for the given
browsing context" as an embedder-level concept rather than a concept within the
dom_distiller component.
Review URL: https://codereview.chromium.org/100623006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238958 0039d316-1c4b-4281-b951-d872f2087c98
|