summaryrefslogtreecommitdiffstats
path: root/components/dom_distiller/android
Commit message (Collapse)AuthorAgeFilesLines
* Add support for hooking up external feedback mechanism for DOM Distillernyquist@chromium.org2014-04-041-1/+11
| | | | | | | | | | | | | | | This adds support for injecting an external feedback reporting library for the DOM Distiller. By default, a no-op version is used. For feedback, it is reasonable to assume that the original URL which was distilled is needed, and this CL also adds support for retrieving that from Java. BUG=319881 Review URL: https://codereview.chromium.org/222883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem that FeedbackReportingView is stacked infinitely whenever ↵sungmann.cho@navercorp.com2014-04-021-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | navigating to chrome-distiller://. FeedbackReporter creates FeedbackReportingView when a given url is reportable and otherwise delete it. Everything is fine in normal flows, but if we navigate to a reportable url continuously, FeedbackReportingView is created and stacked as much as we did. The current call flows are as follows. A-1. navigating to http:// FeedbackReporter.TabObserver.onUpdateUrl() FeedbackReporter.dismissOverlay() FeedbackReporterAndroid::DidNavigateMainFrame() FeedbackReporter.dismissOverlay() B-1. navigating to chrome-distiller:// FeedbackReporter.TabObserver.onUpdateUrl() FeedbackReporter.showOverlay() FeedbackReporterAndroid::DidNavigateMainFrame() As we can see, there is no FeedbackReporter.dismissOverlay() call in the 2nd case. This patch changes the above call flows as follows. A-2. navigating to http:// FeedbackReporterAndroid::DidNavigateMainFrame() FeedbackReporter.dismissOverlay() B-2. navigating to chrome-distiller:// FeedbackReporterAndroid::DidNavigateMainFrame() FeedbackReporter.dismissOverlay() FeedbackReporter.showOverlay() Review URL: https://codereview.chromium.org/208263010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261053 0039d316-1c4b-4281-b951-d872f2087c98
* Make the distiller cancellable.shashishekhar@chromium.org2014-03-121-3/+3
| | | | | | | | | | | | | Makes the distiller cancellable, it is now safe to delete the distiller even when distillation is in progress. On deleting the distiller any callbacks posted by ongoing tasks are now cancelled. BUG=340431 TEST=Included. Review URL: https://codereview.chromium.org/189543005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256463 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI hook for distilling web pages for test shell (relanding)nyquist@chromium.org2014-03-063-0/+80
| | | | | | | | | | | | | This adds the Java hooks needed and a menu option to distill the current web page in the test shell. Original CL: https://codereview.chromium.org/185113002/ BUG=319881 Review URL: https://codereview.chromium.org/183893029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 254929 "Add UI hook for distilling web pages for test shell."nyquist@google.com2014-03-053-80/+0
| | | | | | | | | | | | | | | | | | > Add UI hook for distilling web pages for test shell. > > This adds the Java hooks needed and a menu option to distill the current > web page in the test shell. > > BUG=319881 > NOTRY=true > > Review URL: https://codereview.chromium.org/185113002 TBR=nyquist@chromium.org Review URL: https://codereview.chromium.org/187453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254958 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI hook for distilling web pages for test shell.nyquist@chromium.org2014-03-053-0/+80
This adds the Java hooks needed and a menu option to distill the current web page in the test shell. BUG=319881 NOTRY=true Review URL: https://codereview.chromium.org/185113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254929 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-05 21:39:58 +0000