| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enhanced bookmarks and the DOM distiller are (or will be) used on
iOS and android. Move the function checking whether the features
are enabled into the respective component to allow sharing the code.
Move IsEnhancedBookmarksEnabled() function to the enhanced_bookmarks
component with supporting switches.
Move IsEnableDomDistillerSet() and IsEnableSyncArticlesSet() functions
to the dom_distiller component with supporting switches.
BUG=359565
Review URL: https://codereview.chromium.org/1253953002
Cr-Commit-Position: refs/heads/master@{#340526}
|
|
|
|
|
|
|
|
| |
BUG=499415
Review URL: https://codereview.chromium.org/1192433009
Cr-Commit-Position: refs/heads/master@{#335629}
|
|
|
|
|
|
|
|
| |
BUG=490717
Review URL: https://codereview.chromium.org/1143153010
Cr-Commit-Position: refs/heads/master@{#332957}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that sync_driver::SyncService is available in //components/sync_driver
we can merge ChromeBookmarksServerClusterService with its super class since
child class was only there to abstract this problematic dependency.
Rename the factory as ChromeBookmarkServerClusterService no longer exists.
BUG=429756
Review URL: https://codereview.chromium.org/1162043005
Cr-Commit-Position: refs/heads/master@{#332356}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a column in the bookmarks images database.
It contains the dominant color extracted from the image.
Since this computation can be lengthy, it is done in the background, when the
image is stored in the database.
For old databases, a migration path is provided and the dominant color is
computed and stored upon querying the image for the first time.
BUG=448443
Review URL: https://codereview.chromium.org/875463003
Cr-Commit-Position: refs/heads/master@{#312916}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This service retrieves the cluster of bookmarks from the bookmark
server.
BUG=None
Committed: https://crrev.com/6bb374fc58bfeeb7966b6a548b1c7b41af9c8e47
Cr-Commit-Position: refs/heads/master@{#298582}
Review URL: https://codereview.chromium.org/539173004
Cr-Commit-Position: refs/heads/master@{#298682}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:320001 of https://codereview.chromium.org/539173004/)
Reason for revert:
This CL added static initializers which broke the sizes bots on Mac, Linux, and Linux x64.
Before the change:
# Static initializers in src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump_static_initializers.py
# HINT: diff against the log from the last run to see what changed
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x65
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xaa
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x6b
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xc2
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x65
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xaa
# atomicops_internals_x86_gcc.cc v8::base::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# debugallocation_shim.cc module_enter_exit_hook
# debugallocation_shim.cc (anonymous namespace)::large_alloc_threshold
# debugallocation_shim.cc TCMallocGuard::TCMallocGuard()
# debugallocation_shim.cc __cxa_atexit@plt [registers a dtor to run at exit]
# debugallocation_shim.cc __init_array_end+0x3538
# debugallocation_shim.cc __init_array_end+0x3540
# debugallocation_shim.cc __init_array_end+0x3548
# memory_region_map.cc libpthread_initialized
# spinlock.cc _GLOBAL__sub_I_spinlock.cc+0x12
# spinlock.cc NumCPUs()
# spinlock.cc adaptive_spin_count
# spinlock_internal.cc _GLOBAL__sub_I_spinlock_internal.cc+0x79
# spinlock_internal.cc have_futex
# spinlock_internal.cc futex_private_flag
# spinlock_internal.cc syscall@plt
# Found 34 static initializers in 7 files.
After the change:
# Static initializers in src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump_static_initializers.py
# HINT: diff against the log from the last run to see what changed
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x65
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xaa
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x6b
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xc2
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x65
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xaa
# atomicops_internals_x86_gcc.cc v8::base::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# bookmark_server_cluster_service.cc .L.str
# bookmark_server_cluster_service.cc (anonymous namespace)::kClusterUrl
# bookmark_server_cluster_service.cc std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&)@plt
# bookmark_server_cluster_service.cc __cxa_atexit@plt [registers a dtor to run at exit]
# bookmark_server_cluster_service.cc __init_array_end+0x3540
# bookmark_server_cluster_service.cc __init_array_end+0xe220
# debugallocation_shim.cc module_enter_exit_hook
# debugallocation_shim.cc (anonymous namespace)::large_alloc_threshold
# debugallocation_shim.cc TCMallocGuard::TCMallocGuard()
# debugallocation_shim.cc __cxa_atexit@plt [registers a dtor to run at exit]
# debugallocation_shim.cc __init_array_end+0x3538
# debugallocation_shim.cc __init_array_end+0x3540
# debugallocation_shim.cc __init_array_end+0x3548
# memory_region_map.cc libpthread_initialized
# spinlock.cc _GLOBAL__sub_I_spinlock.cc+0x12
# spinlock.cc NumCPUs()
# spinlock.cc adaptive_spin_count
# spinlock_internal.cc _GLOBAL__sub_I_spinlock_internal.cc+0x79
# spinlock_internal.cc have_futex
# spinlock_internal.cc futex_private_flag
# spinlock_internal.cc syscall@plt
# Found 40 static initializers in 8 files.
See this bot, as an example: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/71728/steps/sizes/logs/stdio
In addition to this, the CL declares a static instance of std::string which is not allowed. The S string constants also should be declared as const char kPrefServiceVersionKey[] = "version" for example.
Original issue's description:
> Bring up of the enhanced bookmarks cluster service.
>
> This service retrieves the cluster of bookmarks from the bookmark
> server.
>
> BUG=None
>
> Committed: https://crrev.com/6bb374fc58bfeeb7966b6a548b1c7b41af9c8e47
> Cr-Commit-Position: refs/heads/master@{#298582}
TBR=blundell@chromium.org,yfriedman@chromium.org,mcolbert@chromium.org,kkimlabs@chromium.org,battre@chromium.org,zea@chromium.org,sky@chromium.org,noyau@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/641473002
Cr-Commit-Position: refs/heads/master@{#298629}
|
|
|
|
|
|
|
|
|
|
|
| |
This service retrieves the cluster of bookmarks from the bookmark
server.
BUG=None
Review URL: https://codereview.chromium.org/539173004
Cr-Commit-Position: refs/heads/master@{#298582}
|
|
|
|
|
|
|
|
|
|
| |
This class is used to perform a full text search on bookmarks, powered by the server side. The superclass will be used for other services in subsequent CLs.
BUG=None
Review URL: https://codereview.chromium.org/538903003
Cr-Commit-Position: refs/heads/master@{#294571}
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageService is an abstract superclass that will have subclasses
for each mobile platform. This class stores a salient image for
a bookmark which is removed when the bookmark node is deleted.
BUG=None
Review URL: https://codereview.chromium.org/513793002
Cr-Commit-Position: refs/heads/master@{#292596}
|
|
|
|
|
|
|
|
|
|
|
| |
Also moved BookmarksBridge#BookmarkItem to bookmarks component.
BUG=386785
Review URL: https://codereview.chromium.org/459973004
Cr-Commit-Position: refs/heads/master@{#289695}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will limit the enhanced bookmark image store database size
to ensure that the db file size is reasonable. So add a function
to query the actual file size.
BUG=378853
Review URL: https://codereview.chromium.org/305963004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bookmarks is not a layered component, so there is no need for the two level deep
hierarchy, switch code from components/bookmarks/core/... to components/bookmarks/...
BUG=370434
TEST=components_unittests --gtest_filter=Bookmark*
R=blundell@chromium.org,sdefresne@chromium.org
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/284893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=368034
Review URL: https://codereview.chromium.org/259863007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269703 0039d316-1c4b-4281-b951-d872f2087c98
|