| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
1. makes EnhancedBookmarkModel a subclass of
EnhancedBookmarksBridge, which frees us from boilerplating. Also
EnhancedBookmarksBridge is removed, both for java and native.
2. removes enhanced_bookmarks java package and all class are
unified in enhancedbookmarks package.
3. adds ianwen@ to enhancedbookmark folder's owner list.
BUG=513509
Review URL: https://codereview.chromium.org/1247033009
Cr-Commit-Position: refs/heads/master@{#340491}
|
|
|
|
|
|
|
|
| |
BUG=499415
Review URL: https://codereview.chromium.org/1192433009
Cr-Commit-Position: refs/heads/master@{#335629}
|
|
|
|
|
|
|
|
| |
BUG=490717
Review URL: https://codereview.chromium.org/1143153010
Cr-Commit-Position: refs/heads/master@{#332957}
|
|
|
|
|
|
|
|
|
|
| |
Remove unused constant and dead code in these files.
BUG=473606
Review URL: https://codereview.chromium.org/1067703004
Cr-Commit-Position: refs/heads/master@{#324049}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the data layer of enhanced bookmark. There is no reason why
this class should live in private repository.
BUG=428832
Previously landed in:
https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261
Reverted in: https://crrev.com/f40cb64710a333da6d554e98dfcc432cd6cf8f1f
Review URL: https://codereview.chromium.org/923653002
Cr-Commit-Position: refs/heads/master@{#316085}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/899403002/)
Reason for revert:
This is blocking downstream and people are complaining. I tried to land the downstream fix but there was a compile problem.
Sorry, hope you can fix the problems and re-land.
Original issue's description:
> Upstream Enhanced Bookmark Model
>
> This is the data layout of enhanced bookmark. There is no reason why
> this class should live in private repository.
>
> BUG=428832
>
> Committed: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261
> Cr-Commit-Position: refs/heads/master@{#315939}
TBR=kkimlabs@chromium.org,newt@chromium.org,cjhopman@chromium.org,ianwen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428832
Review URL: https://codereview.chromium.org/920043003
Cr-Commit-Position: refs/heads/master@{#315976}
|
|
|
|
|
|
|
|
|
|
|
| |
This is the data layout of enhanced bookmark. There is no reason why
this class should live in private repository.
BUG=428832
Review URL: https://codereview.chromium.org/899403002
Cr-Commit-Position: refs/heads/master@{#315939}
|
|
|
|
|
|
|
|
|
|
|
| |
There are some UMA strings, enum constants in iOS repository
that can be shared with Android, so moved to components.
BUG=452254
Review URL: https://codereview.chromium.org/891493003
Cr-Commit-Position: refs/heads/master@{#314707}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=370433
TEST=unit_tests, components_unittests
R=sky@chromium.org
TBR=joaodasilva@chromium.org (for policy)
Review URL: https://codereview.chromium.org/865163003
Cr-Commit-Position: refs/heads/master@{#314653}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per
https://docs.google.com/document/d/1aerLjBm5jc7OILH0BDZmDX8npqop38zfnSO824LnH00,
all permanent nodes are treated equally.
BUG=453024
Review URL: https://codereview.chromium.org/884933002
Cr-Commit-Position: refs/heads/master@{#313918}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=370433
TEST=unit_tests, components_unittests
R=sky@chromium.org
TBR=joaodasilva@chromium.org (for components/policy)
Review URL: https://codereview.chromium.org/820603005
Cr-Commit-Position: refs/heads/master@{#311074}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/775353002
Cr-Commit-Position: refs/heads/master@{#306894}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/456793002
Cr-Commit-Position: refs/heads/master@{#292150}
|
|
These utility functions are used on iOS and Android.
BUG=None
Review URL: https://codereview.chromium.org/452913002
Cr-Commit-Position: refs/heads/master@{#288408}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288408 0039d316-1c4b-4281-b951-d872f2087c98
|