summaryrefslogtreecommitdiffstats
path: root/components/error_page
Commit message (Collapse)AuthorAgeFilesLines
* Improvements to the offline intersitial and easter eggedwardjung2015-04-033-0/+7
| | | | | | | | | | | | | | - Fix right click restart bug. - Switched image assets to use sprite sheets. - Fix resizing whilst jumping causes delays bug. - Add UMA counter for easter egg. - Gameplay tweaks. BUG=464330,453853 Review URL: https://codereview.chromium.org/1051433002 Cr-Commit-Position: refs/heads/master@{#323703}
* autoreload: don't reload non-http/https pagesellyjones2015-03-312-6/+28
| | | | | | | | | | | Pages with other schemes are not necessarily reloadable, and reloading them could have security implications. BUG=471713 Review URL: https://codereview.chromium.org/1048773003 Cr-Commit-Position: refs/heads/master@{#323077}
* UMA for the "Show saved copy" experimentmegjablon2015-03-132-0/+18
| | | | | | | | | | | Adds UMA to track when both the "Reload" and "Show Saved Copy" buttons are displayed on a page and which one was clicked. BUG=368049 Review URL: https://codereview.chromium.org/985103003 Cr-Commit-Position: refs/heads/master@{#320420}
* Three way experiment for "Show saved copy" button.megjablon2015-03-114-35/+36
| | | | | | | | BUG=368049 Review URL: https://codereview.chromium.org/961443002 Cr-Commit-Position: refs/heads/master@{#320113}
* gn format //componentsscottmg2014-12-032-2/+2
| | | | | | | | | | | No intended functionality change. R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/780633002 Cr-Commit-Position: refs/heads/master@{#306640}
* autoreload: don't suppress manual error pagesellyjones2014-12-013-35/+39
| | | | | | | | | | | | | | | Simplify the ShouldSuppressErrorPage logic to *know* whether to suppress an error page instead of guessing with heuristics. This avoids the situation where a manual reload causes an OnStartLoading(NON_ERROR), which causes a CancelPendingRequests(), which causes SuppressErrorPage() to falsely think autoreload caused this load. The new unit test in NetErrorHelperCoreAutoReloadTest demonstrates this sequence of events. BUG=413606 Review URL: https://codereview.chromium.org/582243002 Cr-Commit-Position: refs/heads/master@{#306230}
* Cleanup: Use http/https constants in components.thestig2014-11-191-1/+2
| | | | | | Review URL: https://codereview.chromium.org/726923004 Cr-Commit-Position: refs/heads/master@{#304851}
* Don't trigger auto-reload on client auth failures.davidben2014-11-072-0/+13
| | | | | | | | | | Otherwise the user gets repeatedly prompted. BUG=431387 Review URL: https://codereview.chromium.org/707193005 Cr-Commit-Position: refs/heads/master@{#303319}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-291-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Review URL: https://codereview.chromium.org/684513002 Cr-Commit-Position: refs/heads/master@{#301931}
* Do not reload a url which has unknown schemejaekyun2014-10-232-1/+16
| | | | | | | | BUG=423757 Review URL: https://codereview.chromium.org/658003002 Cr-Commit-Position: refs/heads/master@{#300815}
* Standardize usage of virtual/override/final in components/dcheng2014-10-211-20/+16
| | | | | | | | | BUG=417463 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/666133002 Cr-Commit-Position: refs/heads/master@{#300456}
* Componentize NetErrorHelperCorehashimoto2014-10-1511-0/+3909
Create a new component error_page which will host NetErrorHelper to make it usable from binaries other than chrome. Move NetErrorHelperCore and net_error_info.{cc,h} to components/error_page. Split LocalizedError::ErrorPageParams to components/error_page/common/error_page_params. Move string resources to error_page_strings.grdp Fix GYP, GN, DEPS. Copy OWNERS from chrome/renderer/net to components/error_page. BUG=398173 TEST=build TBR=sky@chromium.org for +ui/base in DEPS Review URL: https://codereview.chromium.org/570253002 Cr-Commit-Position: refs/heads/master@{#299647}