| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mechanical change. either:
- turn 2 parameter version (bitmap, rect) into 3 (bitmap, rect, NULL)
or
- change &srcRect into srcRect
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=
NOTRY=True
-- win_chromium_rel_ng failure is not related to this CL
Review URL: https://codereview.chromium.org/1278013002
Cr-Commit-Position: refs/heads/master@{#342479}
|
|
|
|
|
|
|
|
| |
This converts calls from the old form to the new form. Some calls that iterated over the results were changed to a range-based for loop with an inline call to SplitString. Some places were changed to use StringPieces when it was safe to do so.
Review URL: https://codereview.chromium.org/1234973004
Cr-Commit-Position: refs/heads/master@{#340209}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
drawBItmapRect has a long history of tweaks to its api (intrect, floatrects, flags -> constraints, etc.). This CL brings these call-sites up2date, allowing Skia (later) to remove a swath of legacy compatibility methods/types.
https://codereview.chromium.org/1237233007/ has already landed in Blink.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/1224263006
Cr-Commit-Position: refs/heads/master@{#339274}
|
|
|
|
|
|
|
|
|
|
| |
This code is used by iOS; move it into //components/favicon_base.
TBR=sky, rdsmith
Review URL: https://codereview.chromium.org/1223603002
Cr-Commit-Position: refs/heads/master@{#337794}
|
|
|
|
|
|
|
|
| |
BUG=467712
Review URL: https://codereview.chromium.org/1124803005
Cr-Commit-Position: refs/heads/master@{#328933}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For chrome://large-icon, if no large icon is found then we get the small
favicon to extract the dominant color for fallback background. If the
favicon is missing we're supposed to have a gray background. This behavior
was broken and this CL fixes it.
BUG=467712
Review URL: https://codereview.chromium.org/1108833002
Cr-Commit-Position: refs/heads/master@{#327119}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
desktop and Android to a new large_icon_service.
This is required since the Android implementation of the icon-based NTP will rely on custom Java code to render the fallback. As a result we want to share the logic needed to retrieve large icons and to compute the fallback style without needing them to go through the full-featured chrome://large-icon that performs the rendering of fallback icons. The Java code will hook directly into the large_icon_service.
This CL also fixes a bug, making sure only non-square icons can be returned as large icons.
Besides this, this CL doesn't change the behavior but will make it possible to add the large icon selection logic to large_icon_service where it can be shared with the Android code.
BUG=467712
Review URL: https://codereview.chromium.org/1092873002
Cr-Commit-Position: refs/heads/master@{#326325}
|
|
|
|
|
|
|
|
|
|
|
| |
R=pkotwicz@chromium.org
TBR=pkotwicz@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1096133002
Cr-Commit-Position: refs/heads/master@{#325935}
|
|
|
|
|
|
|
|
|
|
|
| |
The class used to be in components\favicon_base. The DEP changes arise
due to movement of fallback icon drawing code.
BUG=467712
Review URL: https://codereview.chromium.org/1032683002
Cr-Commit-Position: refs/heads/master@{#322157}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design: go/chrome-fallback-icons
We're chrome://fallback-icon host, managed by FallbackIconSource, so we can
specify URLs such as
chrome://fallback-icon/128,#f00,black,0.8,0.1/http://www.google.com
to render a fallback icon. This is useful for testing fallback icons.
This CL is sliced off from https://codereview.chromium.org/835903005/ .
BUG=455063
Review URL: https://codereview.chromium.org/973883002
Cr-Commit-Position: refs/heads/master@{#319333}
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy_component doesn't need to depend on autofill_core_browser. Also
added dependency on gfx_geometry in favicon_base. policy_component was
failing to compile without it.
BUG=458581
Review URL: https://codereview.chromium.org/926093002
Cr-Commit-Position: refs/heads/master@{#317118}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design: go/chrome-fallback-icons
This implements
- FallbackIconStyle: A struct to specify fallback data.
- FallbackIconService: Helper class to render the fallback icon as a
filled rounded square with a single letter from the URL.
- Extra dependencies are needed to convert URL to the icon letter.
This CL is sliced off from https://codereview.chromium.org/835903005/ .
BUG=455063
Review URL: https://codereview.chromium.org/886163003
Cr-Commit-Position: refs/heads/master@{#315854}
|
|
|
|
|
|
|
|
|
|
|
| |
ImportedFaviconUsage is part of importer.
Rename it to FaviconUsageData and move it to favicons_base.
BUG=453952
Review URL: https://codereview.chromium.org/902333002
Cr-Commit-Position: refs/heads/master@{#315803}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add sdefresne as temporary OWNERS of favicon & favicon_base
for the duration of the componentization effort of favicon.
Add OWNERS file to //components/favicon_base with the same
OWNERS as //components/favicon since this component is there
to help split functionality shared by history and favicon
components.
Remove blundell@ as temporary OWNERS of //components/favicon*
since he is already OWNERS of //components.
BUG=359513
Review URL: https://codereview.chromium.org/821903003
Cr-Commit-Position: refs/heads/master@{#311441}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move select_favicon_frames_unittest.cc into the favicon_base
with the code that it is testing.
Add the unit_test to the components_unittests, including when
using gn build system.
BUG=359513
Review URL: https://codereview.chromium.org/851693003
Cr-Commit-Position: refs/heads/master@{#311437}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=compiles
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/832953002
Cr-Commit-Position: refs/heads/master@{#309873}
|
|
|
|
|
|
|
|
|
| |
BUG=417463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/666133002
Cr-Commit-Position: refs/heads/master@{#300456}
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly to fix MSVC warnings about possible value truncation.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/656363002
Cr-Commit-Position: refs/heads/master@{#300134}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623133002
Cr-Commit-Position: refs/heads/master@{#298237}
|
|
|
|
|
|
|
|
|
|
|
| |
kPMColor_SkColorType -> kN32_SkColorType
TBR=scherkus@chromium.org,benwells@chromium.org
BUG=skia:2706
Review URL: https://codereview.chromium.org/357213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource scales.
Replaces SelectFaviconFrames with new function because new ImageSkia instance should be able to handle all cases.
This depends on https://codereview.chromium.org/335233003/.
BUG=376367,381601
TEST=WIP
Review URL: https://codereview.chromium.org/346013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This depends on https://codereview.chromium.org/335233003/.
BUG=None
R=pkotwicz@chromium.org
Review URL: https://codereview.chromium.org/335243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First stop to fix favicon for fractional scale factor.
I'll convert the rest of ui::ScaleFactor in 38
BUG=376367,381601
R=pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/335233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of a desired size in DIP and a set of desired scale factors.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/336423006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/333803010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* FaviconBitmapXxx to FaviconRawBitmapXxx
* FaviconRawCallback to FaviconRawBitmapCallback
* FaviconService::GetXXXForPage to FaviconService::GetXxxcForPageURL
BUG=None
R=pkotwicz@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/330603004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch converts the following gyp targets to GN:
- favicon_base
- query_parser
- metro_viewer_messages -> metro_viewer
- native_theme
BUG=None
TEST=None
R=scottmg@chromium.org
TBR=ben@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/294423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changes here are replacing usage of
the ui::GetImageScale function with ui::GetScaleForScaleFactor.
The patch to remove the HiDPI switch and enable it by default will follow. This patch has been incorporated from
girard's patch ( https://codereview.chromium.org/232483005/)
BUG=149881, 362245
Review URL: https://codereview.chromium.org/294863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move FaviconImageCallback, FaviconResultsCallback and FaviconRawCallback
to favicon_base, those types are shared between favicon and history
components (methods are declared in FaviconService, but it delegates the
work to HistoryService) and only uses types from base:: and
favicon_base:: namespaces.
Also BookmarkClient::FaviconImageCallback is a copy of
FaviconService::FaviconImageCallback, replace it with favicon_base::
version.
BUG=372321
TBR=thakis for //chrome outside of //chrome/browser/history,
//chrome/browser/favicon
Review URL: https://codereview.chromium.org/291643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to create a favicon component, we are removing dependencies on chrome/.
TBR=bsalomon1
BUG=359592
NOTRY=true
Review URL: https://codereview.chromium.org/246893004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
The move caused includes, DEPS, and gyp to change.
This CL also adds droger as a temporary owner to the favicon and favicon_base components.
Reasoning behind the creation of a favicon_base component:
Bookmarks and History code do not fundamentally depend on the Favicon code, so we should be able to build those components without building the Favicon code.
Deep inside the Bookmarks and History code base there's usage of certain favicon types. Those typedefs are moved to a separate component to break the dependency between the Bookmark/History components and the Favicon component.
BUG=362481
Review URL: https://codereview.chromium.org/234893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264555 0039d316-1c4b-4281-b951-d872f2087c98
|