| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
No intended functionality change.
R=brettw@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/780633002
Cr-Commit-Position: refs/heads/master@{#306640}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mostly just adds the chrome_shell_apk build definition and those of
a whole bunch of targets.
Adds a simple check that when DEPRECATED_java_in_dir is used, it
actually includes the "src" at the end (GYP just assumes that you really
meant that java files are in <(java_in_dir)/src).
Makes the call to process_resources only generate R.java for extra
packages when being run as part of the apk step (otherwise, for
example, both chrome resources and content resources would contain
an R.java for net resources and compilation would fail).
Depends on https://codereview.chromium.org/581273004/
Adds the following targets -- and enables ~300 more (550 counting
template-generated inner targets):
//chrome:chrome_android_core
//chrome/android:chrome_strings_grd
//chrome/android:chrome_java
//chrome/android:activity_type_ids_javagen
//chrome/android:app_banner_metrics_ids_javagen
//chrome/android:resource_id_javagen
//chrome/android:profile_account_management_metrics_javagen
//chrome/android:profile_sync_service_model_type_selection_javagen
//chrome/android:toolbar_model_security_levels_javagen
//chrome/android:tab_load_status_javagen
//chrome/android:chrome_shell_base
//chrome/android:chrome_shell
//chrome/android:chrome_sync_shell
//chrome/android:chrome_shell_resources
//chrome/android:chrome_shell_java
//chrome/android:chrome_shell_assets
//chrome/android:chrome_shell_apk
//chrome/android:chrome_sync_shell_apk
//components/bookmarks:bookmarks_java
//components/bookmarks:bookmarks_jni_headers
//components/bookmarks:bookmark_type_javagen
//components/dom_distiller/android:dom_distiller_core_java
//components/dom_distiller/android:dom_distiller_core_font_family_javagen
//components/dom_distiller/android:dom_distiller_core_theme_javagen
//components/enhanced_bookmarks:jni_headers
//components/enhanced_bookmarks/android:enhanced_bookmarks_java
//components/gcm_driver:gcm_driver_java
//components/gcm_driver:jni_headers
//components/navigation_interception/android:navigation_interception_java
//components/variations:variations_java
//components/web_contents_delegate_android:web_contents_delegate_android
//components/web_contents_delegate_android:web_contents_delegate_android_java
//components/web_contents_delegate_android:web_contents_delegate_android_jni_headers
//printing:printing_java
//sync:fake_server_jni
//sync:sync_java_test_support
//sync:test_support_sync_fake_server_android
//sync:sync_unit_tests_apk
//sync/android:sync_java
//sync/android:sync_javatests
BUG=359249
TBR=ben
Review URL: https://codereview.chromium.org/570203002
Cr-Commit-Position: refs/heads/master@{#299381}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want the invalidations code to exist as a component
independent of sync (see bug). This CL seeks to move toward
that for the Android invalidations codebase.
Generally, things moved from //chrome/browser/invalidation
to //components/invalidation, even if git didn't mark them
as moves.
To accomplish this, I had to unify where the JNI occurred.
In Java, InvalidationService was renamed to
InvalidationClientService as the class that communicates
with GCM.
A new InvalidationService class was introduced to handle JNI
and other Java entry points to the component. Several
methods from ProfileSyncService and InvalidationController
moved to it.
InvalidationController is now the bridge between sync and
the invalidation component, and has no JNI nor C++
counterpart.
InvalidationServiceFactory was added to assist in the
creation and management of InvalidationService objects
across the JNI boundary.
BUG=259559
Review URL: https://codereview.chromium.org/459513002
Cr-Commit-Position: refs/heads/master@{#297202}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
| |
Instead of putting all the files in a bit test_support target, I made separate smaller test support targets for the various sub-projects (browser, common, etc.) and linked those in. This helps distribute the complexity.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/559543003
Cr-Commit-Position: refs/heads/master@{#294641}
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the targets that depend on these to also be test-only.
BUG=http://crbug.com/412064
R=jamesr@chromium.org, tfarina@chromium.org
Review URL: https://codereview.chromium.org/551933002
Cr-Commit-Position: refs/heads/master@{#293808}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reimplements parts of //third_party/libjingle's build in GN.
The new build is much less flexible than the original. No
configuration variables have been ported. Some windows-specific configs
have been left out and annotated with TODOs. Most signifcantly, the
entirety of the 'if (enable_webrtc)' block has been omitted, because the
GN build for webrtc isn't working yet.
Despite these limitations, it is an adequate replacement for the
'stub' libjingle target in most situations.
Note, this CL is a near direct copy of rlarocque's work at
https://codereview.chromium.org/455583002/
BUG=none
TBR=sky,pavely,rlarocque
Review URL: https://codereview.chromium.org/498603002
Cr-Commit-Position: refs/heads/master@{#291587}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the use of WeakHandle with combinations of WeakPtr and
SingleThreadTaskRunner. The WeakHandle encapsulates both of these
concepts, so the replacment is not much different from the original.
The removal makes the code a bit uglier. However, the WeakHandle is not
widely used outside of sync and has no chance of making it to base/.
Its use in new code is discouraged. Moving components/invalidation/ to
WeakPtr and SingeThreadTaskRunner will make it more future proof, and
allow us to remove its dependency on libsync.
TBR=dcheng
BUG=394925
Review URL: https://codereview.chromium.org/446223002
Cr-Commit-Position: refs/heads/master@{#288523}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was originally committed at r286362 and reverted in r286467.
BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn
R=scottmg@chromium.org,brettw@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/427293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ports most of the sync GYP targets to GN. Adds comments in the original
GYP files pointing to the new GN targets. Fixes some TODOs in other
files that were blocked on sync GN support.
Adds several new linkable targets to the GN build.
The android-specific parts of sync have not been converted yet.
TBR=nyquist,rogerta
BUG=
Review URL: https://codereview.chromium.org/439533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Supports GN build of //jingle, though its targets won't be linkable
until its dependency //third_party/libjingle is properly supported.
TBR=ajwong
BUG=
Review URL: https://codereview.chromium.org/431423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/420113003/)
Reason for revert:
Likely caused build falure:
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\components\invalidation\invalidation_test_support.invalidator_test_template.obj.rsp /c ..\..\components\invalidation\invalidator_test_template.cc /Foobj\components\invalidation\invalidation_test_support.invalidator_test_template.obj /Fdobj\components\invalidation_test_support.cc.pdb
c:\b\build\slave\win\build\src\components\invalidation\invalidator_test_template.h(87) : fatalerror C1083: Cannot open include file: 'google/cacheinvalidation/types.pb.h': No such file or directory
ninja: build stopped: subcommand failed.
http://build.chromium.org/p/chromium/builders/Win/builds/22963/steps/compile/logs/stdio
Original issue's description:
> components: Fix a couple of the TODO(GYP) todos.
>
> BUG=None
> TEST=gn gen out/Debug_gn + build the effected targets with ninja.
> R=brettw@chromium.org
> TBR=jochen@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286362
TBR=brettw@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/428123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=gn gen out/Debug_gn + build the effected targets with ninja.
R=brettw@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/420113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves the remaining invalidations code from
sync/internal_api/public/base/ to components/invalidation/.
TBR=atwilson
BUG=259559
Review URL: https://codereview.chromium.org/400073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves all code remaining in sync/notifier to components/invalidation.
Updates gyp files, DEPS, and #includes accordingly.
In terms of program behavior, this should be one big no-op. This CL
contains no non-trivial code changes.
In terms of the build system, this is a significant change. Symbols
that were previously exported through sync_notifier and related targets
have moved into the components/invalidation related targets. Some
SYNC_EXPORT macros have been replaced with INVALIDATION_EXPORT, which is
significant since INVALIDATION_EXPORT is currently a no-op but
SYNC_EXPORT has meaning under some build configurations.
Unlike most other files in sync/notifier, invalidation_util.{cc,h} was
moved to sync/internal_api/public/base. This is so it could be
referenced from sync/internal_api/public/base/invalidation.cc. This is
a slight regression, but it should be fixed in the next CL when we move
all invalidations-related code out of sync/internal_api.
TBR=rogerta,benwells
BUG=259559
Review URL: https://codereview.chromium.org/387733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
google
infobars
invalidation
navigation_intercaption
network_time
password_manager
plugins
search_provider_logos
sessions
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/397953005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283521 0039d316-1c4b-4281-b951-d872f2087c98
|