summaryrefslogtreecommitdiffstats
path: root/components/nacl/renderer
Commit message (Collapse)AuthorAgeFilesLines
* NaCl cleanup: Remove unused #includes of portability*.h and nacl_base.hmseaborn2016-01-166-10/+0
| | | | | | | | | BUG=302078 TEST=build Review URL: https://codereview.chromium.org/1594463003 Cr-Commit-Position: refs/heads/master@{#369899}
* NaCl cleanup: Remove/convert #includes of nacl_macros.hmseaborn2016-01-1511-24/+14
| | | | | | | | | | | | Convert to using DISALLOW_COPY_AND_ASSIGN from base/macros.h instead of NACL_DISALLOW_COPY_AND_ASSIGN. BUG=302078 TEST=build Review URL: https://codereview.chromium.org/1581933003 Cr-Commit-Position: refs/heads/master@{#369843}
* NaCl cleanup: Remove unused function, IsValidIdentifierString()mseaborn2016-01-152-49/+0
| | | | | | | | | | | This was only used by the SrpcClient class, which I removed recently. BUG=302078 TEST=none Review URL: https://codereview.chromium.org/1583853004 Cr-Commit-Position: refs/heads/master@{#369802}
* NaCl cleanup: Use base's scoped_ptr instead of nacl::scoped_ptrmseaborn2016-01-138-12/+11
| | | | | | | | | | | This removes a dependency on headers in native_client/. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1582003002 Cr-Commit-Position: refs/heads/master@{#369248}
* NaCl cleanup: Remove now-unneeded use of SelLdrLaunchermseaborn2016-01-138-94/+1
| | | | | | | | | | | | | | | | | | | | | | | SelLdrLauncher used to be used for establishing an SRPC connection, but we no longer use SRPC. This means that we can remove the derived class, SelLdrLauncherChrome. This leaves ServiceRuntime::ReportLoadError() unused, so we can remove that too. Note that ServiceRuntime::Shutdown() has been a no-op since I removed use of the SRPC trusted command channel in https://crrev.com/334097 -- its comments were out of date. (Terminating the NaCl process is done by other means.) It now becomes more obviously a no-op. I can remove it in a later change, since that allows further cleanups. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1579783002 Cr-Commit-Position: refs/heads/master@{#369198}
* NaCl cleanup: Remove use of the IMC bootstrap channelmseaborn2016-01-134-20/+2
| | | | | | | | | | | | | | | | | | | | | This channel was used for establishing further NaCl IMC connections across which we sent SRPC messages. This is no longer needed now that we don't use SRPC. * Stop creating the channel in the browser process (nacl_process_host.cc). * Remove the handle/FD fields from IPC messages. * Stop propagating the renderer-side handle through renderer code (service_runtime.cc and LaunchSelLdr()). BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1579043002 Cr-Commit-Position: refs/heads/master@{#369042}
* NaCl: Fix a recently-introduced handle/FD leak in the renderer processmseaborn2016-01-122-5/+7
| | | | | | | | | | | | | | | | | | | I accidentally introduced a leak of bootstrap_channel_ (a handle/FD) in my recent change https://crrev.com/368662, because I removed code that would take ownership of this handle/FD and eventually close it. For now, this small change fixes the leak by closing the handle. We also need to remove the use of the handle's other endpoint in nacl_listener.cc (which is unneeded since we removed use of SRPC), otherwise sending on that NaCl-side endpoint produces an error on Windows since the renderer-side endpoint has been closed. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (though I haven't tested for the leak) Review URL: https://codereview.chromium.org/1574293002 Cr-Commit-Position: refs/heads/master@{#368928}
* PNaCl cleanup: Remove now-unused kMaxTranslatorObjectFilesmseaborn2016-01-111-3/+0
| | | | | | | | | | | | | Since switching this code from using SRPC to using Chrome IPC, there is no hard limit on the number of object file FDs, so this constant is no longer used. BUG=302078 TEST=compile Review URL: https://codereview.chromium.org/1570343004 Cr-Commit-Position: refs/heads/master@{#368711}
* NaCl cleanup: Remove now-unneeded uses of BrokerDuplicateHandle()mseaborn2016-01-113-32/+0
| | | | | | | | | | | | Now that we no longer use SRPC, we no longer need to supply an implementation of BrokerDuplicateHandle() for SRPC/IMC to use. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1575453004 Cr-Commit-Position: refs/heads/master@{#368695}
* NaCl cleanup: Remove remaining references to nacl::DescWrappermseaborn2016-01-119-32/+1
| | | | | | | | | | | | Now that we no longer use SRPC, the references to nacl::DescWrapper are no longer used. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1575573004 Cr-Commit-Position: refs/heads/master@{#368689}
* NaCl cleanup: Remove now-unneeded SetupCommandChannel() and StartNexe()mseaborn2016-01-114-80/+10
| | | | | | | | | | | | | | | | | Since we no longer use SRPC, it's no longer necessary to call ConnectBootstrapSocket() and RetrieveSockAddr(). So we can remove ServiceRuntime's SetupCommandChannel() and StartNexe() (which no longer started the nexe anyway). This means we can remove Plugin's StartNexe() and StartHelperNexe() too. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1570343002 Cr-Commit-Position: refs/heads/master@{#368662}
* PNaCl: Remove now-unneeded use of nacl::DescWrapper in TempFilemseaborn2016-01-083-48/+7
| | | | | | | | | | | | | | | | read_wrapper() and write_wrapper() are no longer used now that the PNaCl code doesn't use SRPC. Open() had the side effect of checking the validity of the handle/descriptor before, so preserve that, but rename it to CheckValidity() to clarify what it does. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1575573002 Cr-Commit-Position: refs/heads/master@{#368467}
* NaCl cleanup: Remove SrpcParams and SrpcClient, which are unused nowmseaborn2016-01-0816-592/+6
| | | | | | | | | | | | | | | * Remove the NaClSrpcModuleInit() call. Since we no longer use SRPC, we don't need to initialise it. * NaClSubprocess: Remove SrpcClient field and constructor argument, since the SrpcClient object is no longer used. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1569283002 Cr-Commit-Position: refs/heads/master@{#368440}
* PNaCl: Use Chrome IPC to talk to the translator process, instead of SRPCmseaborn2016-01-082-94/+79
| | | | | | | | | | | | | | | | | | | | | | This is the last remaining use of SRPC. (I'll remove the remaining SRPC plumbing in follow-up changes.) Change pnacl_translate_thread.cc to send its request using Chrome IPC instead of SRPC. Similarly, change irt_pnacl_translator_compile.cc to receive its request this way. * Generalise GetHandleForSubprocess() to work for this other process. * Use std::string instead of std::vector<char> to avoid needing to make an extra copy when creating PpapiMsg_PnaclTranslatorCompileChunk. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1564903002 Cr-Commit-Position: refs/heads/master@{#368312}
* PNaCl cleanup: Remove some uses of NaClDesc/nacl::DescWrappermseaborn2016-01-073-13/+12
| | | | | | | | | | | | | | Use base::File methods instead. This removes some dependencies on NaCl-side headers and is a step towards removing nacl::DescWrapper. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1568613003 Cr-Commit-Position: refs/heads/master@{#368182}
* PNaCl: Factor out some duplicated args-list conversion codemseaborn2016-01-061-27/+17
| | | | | | | | | | | This will simplify a later change. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1561923002 Cr-Commit-Position: refs/heads/master@{#367823}
* PNaCl: Use Chrome IPC to talk to the linker process, instead of SRPCmseaborn2016-01-049-46/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the second-to-last remaining use of SRPC. * Change pnacl_translate_thread.cc to send its request using Chrome IPC instead of SRPC. Similarly, change irt_pnacl_translator_link.cc to receive its request this way. * Add plumbing so that pnacl_translate_thread.cc can acquire a Chrome IPC channel object. Change LaunchSelLdr() (in ppb_nacl_private.h) to return this channel, and plumb it through service_runtime.h too. * Extend nacl_message_scanner.cc to handle a couple of things our new IPC message needs: * File handles inside of std::vector<>s. * File handles inside of sync messages. (Previously, only sync replies were handled.) * Change a BUILD.gn to account for #includes of content/public/common/sandbox_init.h and ppapi/proxy/{serialized_handle.h,ppapi_messages.h}. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1512733003 Cr-Commit-Position: refs/heads/master@{#367369}
* Prepare for -Wall for third-party code, -Wextra for chromium_codethakis2015-12-311-3/+0
| | | | | | | | | | | | | | | | This lands patch set 16 of https://codereview.chromium.org/1551753002/ (reviewed there), except for the changes to build/common.gypi and build/config/compiler/BUILD.gn. The changes to these two files are likely to break some bot I don't know about, and I don't want to keep reverting and relanding all these files. So this lands the parts that are hopefully harmless separately. BUG=573250 TBR=thestig Review URL: https://codereview.chromium.org/1557733002 Cr-Commit-Position: refs/heads/master@{#367252}
* Convert Pass()→std::move() in //components/[n-z]*dcheng2015-12-266-37/+37
| | | | | | | | | | BUG=557422 R=avi@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1548203002 Cr-Commit-Position: refs/heads/master@{#366914}
* Clean up header files.avi2015-12-261-0/+1
| | | | | | | | | | BUG=138542 TBR=ben@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1544283002 Cr-Commit-Position: refs/heads/master@{#366903}
* Switch to standard integer types in components/, part 2 of 4.avi2015-12-2632-2/+66
| | | | | | | | | BUG=138542 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/1548113002 Cr-Commit-Position: refs/heads/master@{#366877}
* Move nacl targets to subdirectories.brettw2015-12-161-0/+50
| | | | | | | | | | | | | | | This clarifies the structure a bit and is the format recommended by GN style. Adds annotations to the GYP files for the corresponding GN targets. Removes some dead code in extensions/shell. R=dpranke@chromium.org TBR=thestig@chromium.org (chrome/linux/installer) Reland of https://codereview.chromium.org/1523503002 Review URL: https://codereview.chromium.org/1530663002 Cr-Commit-Position: refs/heads/master@{#365406}
* Revert of Move nacl targets to subdirectories. (patchset #6 id:100001 of ↵yoichio2015-12-151-50/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1523503002/ ) Reason for revert: This might cause errors in the generate_build_files step. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/6471 Original issue's description: > Move nacl targets to subdirectories. > > This clarifies the structure a bit and is the format recommended by GN style. > > Adds annotations to the GYP files for the corresponding GN targets. Removes some dead code in extensions/shell. > > R=dpranke@chromium.org > > Committed: https://crrev.com/263435ba08cd291d9a0534719a599ad11098090a > Cr-Commit-Position: refs/heads/master@{#365139} TBR=dpranke@chromium.org,mcgrathr@chromium.org,phosek@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1522173003 Cr-Commit-Position: refs/heads/master@{#365146}
* Move nacl targets to subdirectories.brettw2015-12-151-0/+50
| | | | | | | | | | | | This clarifies the structure a bit and is the format recommended by GN style. Adds annotations to the GYP files for the corresponding GN targets. Removes some dead code in extensions/shell. R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1523503002 Cr-Commit-Position: refs/heads/master@{#365139}
* PNaCl: Clean up object/FD lifetimes inside TempFile objectmseaborn2015-12-142-42/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | Before this change, the management of the lifetimes of objects and FDs/HANDLEs in the TempFile object was messy and leaky: The TakeFileHandle() method was returning an FD/HANDLE that was still owned by a nacl::DescWrapper object (by a NaClDesc object that the nacl::DescWrapper wraps). This was safe but leaky, because the nacl::DescWrapper and NaClDesc never get freed. They were leaked by the release() calls. Also, the FD that is DUP()'d by Open() was leaked. Fix this by having read_wrapper_, write_wrapper_ and file_handle_ each own their own FD/HANDLE. We use base::File's Duplicate() method to do the dup()/DuplicateHandle() calls on Unix/Windows. Use base's scoped_ptr instead of nacl::scoped_ptr since the former is preferred in Chromium code and it lets us do "if (p)" rather than "if (p.get())". BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Review URL: https://codereview.chromium.org/1517983004 Cr-Commit-Position: refs/heads/master@{#365124}
* NaCl: Remove/convert NaClLog() calls in components/nacl/mseaborn2015-12-101-22/+4
| | | | | | | | | | | | | | | nacl_log.h conflicts with base/logging.h (and hence with other Chromium headers) because it #defines LOG_INFO. This change removes non-error logging calls, following the Chromium style. I've converted the remaining calls to use LOG(ERROR). BUG=302078 TEST=build Review URL: https://codereview.chromium.org/1513573007 Cr-Commit-Position: refs/heads/master@{#364402}
* NaCl: Remove last #include of nacl_check.h; use base/logging.h insteadmseaborn2015-12-091-1/+1
| | | | | | | | | | | | | | | Both provide CHECK and DCHECK macros, but nacl_check.h conflicts with base/logging.h and hence with other Chromium headers. A recent DEPS roll makes this change possible now that nacl_sync_raii.h no longer conflicts with base/logging.h. BUG=302078 TEST=build Review URL: https://codereview.chromium.org/1514493002 Cr-Commit-Position: refs/heads/master@{#363940}
* NaCl: Remove #includes of nacl_check.h, and use base/logging.h insteadmseaborn2015-12-049-17/+9
| | | | | | | | | | | | | | | | | | | | Both provide CHECK and DCHECK macros. Removing use of nacl_check.h removes a big source of conflict with various Chromium-side headers (because nacl_check.h #includes nacl_log.h, which defines LOG_INFO, which conflicts with base/logging.h). Note that #including nacl_sync_raii.h still conflicts (until I do a NaCl DEPS roll), but we can reduce that by moving the #include closer to where it's needed. BUG=302078 TEST=build Review URL: https://codereview.chromium.org/1494083004 Cr-Commit-Position: refs/heads/master@{#363114}
* NaCl: Fix a file descriptor leak on Unixmseaborn2015-12-011-0/+15
| | | | | | | | | | | | | | | | | Before this change, the renderer process leaks a file descriptor every time a PNaCl translator process is launched or a (P)NaCl process runs without calling the ppapi_start() API. There was no leak on Windows, because client-side IPC::ChannelHandles fill out the "name" field rather than the "pipe.handle" field. BUG=302078 TEST=Run an invalid pexe repeatedly and manually inspect /proc/PID/fd of the renderer process. Review URL: https://codereview.chromium.org/1473513005 Cr-Commit-Position: refs/heads/master@{#362440}
* PNaCl: Enable the Subzero translator for x86-32 without a flag.stichnot2015-11-301-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Tweaks the logic from https://codereview.chromium.org/1005173006/ so that the Subzero translator is always used for O0 translation on x86-32, regardless of the --enable-pnacl-subzero flag. Updates validation cache testing to reflect the use of the Subzero translator nexe. Disables the error handling test under Windows due to http://crbug.com/499878 because the O0 manifest tests now use Subzero. The flag is retained so that it can be used in the future to phase in Subzero for other targets, such as x86-64, arm32, and mips32, in the same way as was done for x86-32. This is a retry of https://codereview.chromium.org/1457183002/ . BUG=532718 TEST= git cl try -b linux_chromium_dbg_32_ng TEST= git cl try -b win_chromium_xp_rel_ng Review URL: https://codereview.chromium.org/1488543004 Cr-Commit-Position: refs/heads/master@{#362272}
* Revert "PNaCl: Enable the Subzero translator for x86-32 without a flag."stichnot2015-11-291-8/+3
| | | | | | | | | | | | | This reverts commit bcfc0fcc956c7523eb3788dcb8f855f5b912690f. XP tests for PNaCl error tests are failing. Subzero's error handling is apparently different in some respect from llc's error handling. See http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/41379 BUG=532718 TBR=mseaborn Review URL: https://codereview.chromium.org/1486453002 Cr-Commit-Position: refs/heads/master@{#362070}
* PNaCl: Enable the Subzero translator for x86-32 without a flag.stichnot2015-11-281-3/+8
| | | | | | | | | | | | Tweaks the logic from https://codereview.chromium.org/1005173006/ so that the Subzero translator is always used for O0 translation on x86-32, regardless of the --enable-pnacl-subzero flag. The flag is retained so that it can be used in the future to phase in Subzero for other targets, such as x86-64, arm32, and mips32, in the same way as was done for x86-32. BUG=532718 Review URL: https://codereview.chromium.org/1457183002 Cr-Commit-Position: refs/heads/master@{#362047}
* Use std::default_delete as the default deleter for scoped_ptr.dcheng2015-11-191-0/+2
| | | | | | | | | | | The aim is to make scoped_ptr and std::unique_ptr functionally identical so scoped_ptr can simply be a typedef. BUG=554298 Review URL: https://codereview.chromium.org/1445003002 Cr-Commit-Position: refs/heads/master@{#360539}
* Simplify PPAPI progress event logic and move it into Blink.esprehn2015-11-171-47/+22
| | | | | | | | | | | | | | | | | | | | There's no reason to put a v8::Context on the stack to dispatch an event, this seems to date way back to when this code was first added because the early patches (which were never landed) added an expando "url" property [1] [2] to the JS ProgressEvent object. That code was never landed though, and instead the DOMResourceProgresssEvent object was added, but the v8 logic was left behind. This patch removes this unnecessary code and moves the logic for deciding which event should be dispatched into the WebPluginContainer object. This allows removing the non-standard WebDOMResourceProgressEvent interface from the public API and generally simplifying the code. [1] https://codereview.chromium.org/14588009/diff/2001/chrome/renderer/nacl/ppb_nacl_private_impl.cc [2] https://chromiumcodereview.appspot.com/14773025 Review URL: https://codereview.chromium.org/1447853002 Cr-Commit-Position: refs/heads/master@{#360101}
* Fix MSVC warning nits in components/naclmcgrathr2015-11-123-4/+9
| | | | | | | | | | | | The GN build runs the MSVC compiler at a higher warning level. Tweak the components/nacl code to make it happy. BUG= 512869 R=bbudge@chromium.org Review URL: https://codereview.chromium.org/1434143002 Cr-Commit-Position: refs/heads/master@{#359219}
* Mark functions overriding Blink with "override" in components/.avi2015-09-282-24/+24
| | | | | | | | | BUG=535367 TEST=it all stays working Review URL: https://codereview.chromium.org/1361223003 Cr-Commit-Position: refs/heads/master@{#351032}
* Fix header guard ifdefs in components.thestig2015-09-151-3/+3
| | | | | | | | | Many headers have the wrong guard from when they were moved into components/ Review URL: https://codereview.chromium.org/1340173002 Cr-Commit-Position: refs/heads/master@{#348851}
* Sync NaCl plugin.gyp and BUILD.gn (remove weak_ref).jvoung2015-08-261-1/+1
| | | | | | | | | | | | | | | | | | Weak ref dependency was removed from gyp earlier: https://codereview.chromium.org/870923004/diff/20001/ppapi/native_client/src/trusted/plugin/plugin.gyp so remove from GN too. We may be able to delete weak_ref from NaCl completely now: https://codereview.chromium.org/1317853002/ The gyp file mentioned "//native_client/src/shared/srpc:nonnacl_srpc" so add that to BUILD.gn too. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3864 Review URL: https://codereview.chromium.org/1313363002 Cr-Commit-Position: refs/heads/master@{#345613}
* Replace ToLower calls to the new formatbrettw2015-08-102-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Review URL: https://codereview.chromium.org/1279123004 Cr-Commit-Position: refs/heads/master@{#342659}
* Make the WebURLLoaderClients in the pepper code destroy (or have some guard) ↵tyoshino2015-08-063-19/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the loader in didFail() Currently Blink's ThreadableLoader calls didFinishLoading() after didFail() when both of the following conditions are met: - ThreadableLoader is not canceled (or destroyed) in didFail() - The response to cross-origin request (simple CORS request or preflight request) fails CORS check We plan to change ThreadableLoader not to call didFinishLoading() after didFail() call. But ManifestDownloader and PexeDownloader assumes the old behavior. This CL copies the things done in didFinishLoading() to didFail() of these classes and thus make a didFinishLoading() call after didFail() unnecessary to prepare for the change. ---- I wondered if PepperURLLoaderHost is expecting both didFinishLoading() and didFail() to be called. But it's only exposed via PepperPluginInstanceImpl::document_loader(), and to which only PluginDocumentParser::finish() delivers a notification. PluginDocumentParser never call both of didFinishLoading() and didFailLoading() on a PluginView. So, we don't have to worry about breakage, I think. ---- R=hiroshige,bbudge BUG=515850 Review URL: https://codereview.chromium.org/1267713003 Cr-Commit-Position: refs/heads/master@{#342061}
* Remove dmichael/teravest from OWNERSraymes2015-08-041-2/+0
| | | | | | | | | | They're no longer working on chrome. I've checked with them about this. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1268023004 Cr-Commit-Position: refs/heads/master@{#341666}
* Remove a use of third_party/jsoncpp in components/nacl/renderer.jvoung2015-07-283-158/+211
| | | | | | | | | | | | | | | | | One remaining use is for NaCl's json_manifest. Use base/values and base/json/ instead. Did not remove references to jsoncpp in DEPS, build/linux/unbundle/, or other gyp files (remoting) etc. BUG=476671 Committed: https://crrev.com/3d7774c521d716ee91d2f41a1d2df53c1dbbe566 Cr-Commit-Position: refs/heads/master@{#340565} Review URL: https://codereview.chromium.org/1259803002 Cr-Commit-Position: refs/heads/master@{#340693}
* Revert of Remove a use of third_party/jsoncpp in components/nacl/renderer. ↵jvoung2015-07-273-210/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #6 id:90001 of https://codereview.chromium.org/1259803002/) Reason for revert: More badly placed DCHECKS not caught by trybots, only caught by buildbots. Original issue's description: > Remove a use of third_party/jsoncpp in components/nacl/renderer. > > One remaining use is for NaCl's json_manifest. Use > base/values and base/json/ instead. > > Did not remove references to jsoncpp in DEPS, > build/linux/unbundle/, or other gyp files (remoting) etc. > > BUG=476671 > > Committed: https://crrev.com/3d7774c521d716ee91d2f41a1d2df53c1dbbe566 > Cr-Commit-Position: refs/heads/master@{#340565} TBR=bradnelson@chromium.org,bbudge@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476671 Review URL: https://codereview.chromium.org/1258073007 Cr-Commit-Position: refs/heads/master@{#340587}
* Remove a use of third_party/jsoncpp in components/nacl/renderer.jvoung2015-07-273-158/+210
| | | | | | | | | | | | | | One remaining use is for NaCl's json_manifest. Use base/values and base/json/ instead. Did not remove references to jsoncpp in DEPS, build/linux/unbundle/, or other gyp files (remoting) etc. BUG=476671 Review URL: https://codereview.chromium.org/1259803002 Cr-Commit-Position: refs/heads/master@{#340565}
* Update SplitString calls in componentsbrettw2015-07-231-6/+3
| | | | | | | | This converts calls from the old form to the new form. Some calls that iterated over the results were changed to a range-based for loop with an inline call to SplitString. Some places were changed to use StringPieces when it was safe to do so. Review URL: https://codereview.chromium.org/1234973004 Cr-Commit-Position: refs/heads/master@{#340209}
* Remove legacy StartsWithASCII function.brettw2015-07-161-1/+2
| | | | | | | | | | | This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1242023005 Cr-Commit-Position: refs/heads/master@{#339175}
* Remove fallback code for getting pnacl-subzero tool name.jvoung2015-07-151-7/+1
| | | | | | | | | | | The pnacl.json file should have gotten the name after the M43 push, and we are on M46 now. BUG=none Review URL: https://codereview.chromium.org/1234293002 Cr-Commit-Position: refs/heads/master@{#338928}
* Move JoinString to the base namespace.brettw2015-07-151-1/+1
| | | | | | | | | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 Cr-Commit-Position: refs/heads/master@{#338762} patch from issue 1223153003 at patchset 160001 (http://crrev.com/1223153003#ps160001) BUG= Review URL: https://codereview.chromium.org/1230243005 Cr-Commit-Position: refs/heads/master@{#338819}
* Revert of Move JoinString to the base namespace (patchset #9 id:160001 of ↵hongchan2015-07-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1237873004 Cr-Commit-Position: refs/heads/master@{#338770}
* Move JoinString to the base namespace.brettw2015-07-141-1/+1
| | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Review URL: https://codereview.chromium.org/1223153003 Cr-Commit-Position: refs/heads/master@{#338762}
generated by cgit v1.1 at 2025-03-19 07:13:16 +0000