| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were mostly due to blind copy-paste. read_only:1 is the default so there's
no point in specifying it.
As per crbug.com/342913, only unit_tests has issue with running from read only
files.
R=jam@chromium.org
BUG=116251
Review URL: https://codereview.chromium.org/1240303002
Cr-Commit-Position: refs/heads/master@{#339490}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements a test launcher customized for nacl_helper_nonsfi_unittests.
- Existing nacl_helper_nonsfi_unittests is renamed to nacl_helper_nonsfi_unittests_main.
- The new test launcher is built with a toolchain for the target architecture rather than PNaCl toolchain.
- XmlUnitTestResultPrinter is now extracted into a separate file.
TEST=Ran bots (with and without editing testing/buildbots scripts). Run locally.
BUG=358465
Review URL: https://codereview.chromium.org/1154313003
Cr-Commit-Position: refs/heads/master@{#333430}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit aad01297ee28c48a3021339568cacaf16f37fdc0.
The original CL crrev.com/1137553003 was reverted unfortunately due to the build breakage on lsan bots.
PNaCl toolchain does not support sanitizers, so this CL disables building nacl_helper_nonsfi_unittests on sanitizer-enabled config.
TEST=Ran bots. Made sure nacl_helper_nonsfi_unittests is not a target with asan=1 or msan=1 or tsan=1 or lsan=1.
BUG=358465
Review URL: https://codereview.chromium.org/1145503003
Cr-Commit-Position: refs/heads/master@{#331277}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:80001 of https://codereview.chromium.org/1137553003/)
Reason for revert:
This breaks the asan build. See comments on the original CL.
Original issue's description:
> Non-SFI mode: Build nacl_helper_nonsfi_unittests
>
> This CL starts to build nacl_helper_nonsfi_unittests.
> The binary is not yet enabled to run on bots. It will be done in a following CL.
>
> TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
> BUG=358465
>
> Committed: https://crrev.com/72c418b09bbf90505f54df2b76285650acd97960
> Cr-Commit-Position: refs/heads/master@{#330069}
TBR=mseaborn@chromium.org,mdempsky@chromium.org,thakis@chromium.org,jln@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=358465
Review URL: https://codereview.chromium.org/1145593002
Cr-Commit-Position: refs/heads/master@{#330147}
|
|
This CL starts to build nacl_helper_nonsfi_unittests.
The binary is not yet enabled to run on bots. It will be done in a following CL.
TEST=Ran locally. Ran build bots. Ran build bots with editing configuration to include nacl_helper_nonsfi_unittests.
BUG=358465
Review URL: https://codereview.chromium.org/1137553003
Cr-Commit-Position: refs/heads/master@{#330069}
|