| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1289723004
Cr-Commit-Position: refs/heads/master@{#343514}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
* Adding delete page functionality to the offline bridge,
* Adding callback for delete page in OfflinePageCallback
* Updating the offline page model to enable deleting pages by
bookmark ID,
* Adding appropriate tests for the bridge and model
* Changing the model to not use a weak pointer when calling
DeleteArchiveFile, as it was causing a DCHECK in IsValid of the ptr.
The call was replaced with a function in an anonymous namespace, to
avoid a this pointer altogether (alternative was to pass unretained)
BUG=491352
R=jianli@chromium.org,mariakhomenko@chromium.org
Review URL: https://codereview.chromium.org/1286143008
Cr-Commit-Position: refs/heads/master@{#343117}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding capability to get page by bookmark Id in offline page model,
Exposing that capability in offline page bridge,
Adding tests to the offline page model and bridge.
BUG=491352
R=jianli@chromium.org,mariakhomenko@chromium.org
Review URL: https://codereview.chromium.org/1275633005
Cr-Commit-Position: refs/heads/master@{#343014}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Exposing synchronous way to get offline pages
* Adding offline page model observer interface, with a listener for
model being loaded
* Propagating changes through the bridge
* Updating test to the new model
R=jianli@chromium.org,mariakhomenko@chromium.org
BUG=491352
Review URL: https://codereview.chromium.org/1276423002
Cr-Commit-Position: refs/heads/master@{#342840}
|
|
|
|
|
|
|
|
|
|
|
| |
This change is necessary, as title is already stored by the bookmark, while bookmark ID is how all the filtering and matching is done by the model and UI.
Without this update any filtering logic will be very inefficient.
BUG=491352
Review URL: https://codereview.chromium.org/1262743006
Cr-Commit-Position: refs/heads/master@{#342206}
|
|
|
|
|
|
|
|
| |
BUG=491352
Review URL: https://codereview.chromium.org/1260403004
Cr-Commit-Position: refs/heads/master@{#341967}
|
|
|
|
|
|
|
|
|
| |
BUG=491352
TEST=none
Review URL: https://codereview.chromium.org/1257103005
Cr-Commit-Position: refs/heads/master@{#341661}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding capability to load the bookmarks to OfflinePageBridge.java
Adding capability to pass the result back to java from C++ side of the
Offline Page Bridge.
Adding a test for loading empty list of bookmarks in
OfflinePageBridgeTest.java
Adding definition of OfflinePageItem
BUG=491352
R=mariakhomenko@chromium.org
Review URL: https://codereview.chromium.org/1255973002
Cr-Commit-Position: refs/heads/master@{#340645}
|
|
|
|
|
|
|
|
|
| |
BUG=491352
R=nyquist@chromium.org
Review URL: https://codereview.chromium.org/1250473009
Cr-Commit-Position: refs/heads/master@{#339876}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Componentize offline_page_metadata_store_impl.[cc/h], unittest and offline_pages.proto file.
Updated BUILD.gn and corresponding .gypi files for the same.
BUG=507284
Review URL: https://codereview.chromium.org/1226173004
Cr-Commit-Position: refs/heads/master@{#339852}
|
|
|
|
|
|
|
|
| |
BUG=491352
Review URL: https://codereview.chromium.org/1231013003
Cr-Commit-Position: refs/heads/master@{#339485}
|
|
|
|
|
|
|
|
|
| |
BUG=491352
TEST=new tests
Review URL: https://codereview.chromium.org/1241583005
Cr-Commit-Position: refs/heads/master@{#339194}
|
|
|
|
|
|
|
|
|
| |
BUG=491352
R=jianli@chromium.org
Review URL: https://codereview.chromium.org/1227093011
Cr-Commit-Position: refs/heads/master@{#338817}
|
|
|
|
|
|
|
|
|
|
|
| |
Added implementation of OfflinePageModel.LoadAllPages with tests.
BUG=491352
R=jianli@chromium.org
Review URL: https://codereview.chromium.org/1238723003
Cr-Commit-Position: refs/heads/master@{#338815}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing the OfflinePageModel::Client interface and replacing it with
callback specific to the call made.
Updates to test.
BUG=491352
R=jianli@chromium.org
Review URL: https://codereview.chromium.org/1237183002
Cr-Commit-Position: refs/heads/master@{#338807}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Implementation of the Save functionality for OfflinePageModel.
* Implementation of tests for save functionality.
* Handling of multiple requests at the same time.
BUG=491352
R=jianli@chromium.org,dimich@chromium.org
Review URL: https://codereview.chromium.org/1232093004
Cr-Commit-Position: refs/heads/master@{#338783}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding OfflinePageMHTMLArchiver with tests, with capability to:
* relate a url to a pending web contents
* Create MHTML archive base on that the two above
BUG=491352
Review URL: https://codereview.chromium.org/1203503003
Cr-Commit-Position: refs/heads/master@{#338178}
|
|
|
|
|
|
|
|
|
|
| |
This is done, because web page titles actually come in string16.
BUG=491352
Review URL: https://codereview.chromium.org/1214543002
Cr-Commit-Position: refs/heads/master@{#337856}
|
|
|
|
|
|
|
|
| |
BUG=491352
Review URL: https://codereview.chromium.org/1180263002
Cr-Commit-Position: refs/heads/master@{#334881}
|
|
|
|
|
|
|
|
| |
BUG=491352
Review URL: https://codereview.chromium.org/1174803002
Cr-Commit-Position: refs/heads/master@{#334608}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Offline pages metadata store:
* Creates interface for the store
* The following actions are available on the store:
- AddOfflinePage,
- RemoveOfflinePage,
- Load,
* Updates to the components_unittests to include offline
pages
BUG=491352
Review URL: https://codereview.chromium.org/1160283003
Cr-Commit-Position: refs/heads/master@{#333697}
|
|
* Creates OfflinePageModel (not implemented) and basic OfflinePageItem
* Adds components/offline_pages with OWNERS and DEPS
* Creates components/offline_pages.gypi
* Includes offline pages across gyp files
BUG=491352
Review URL: https://codereview.chromium.org/1147983005
Cr-Commit-Position: refs/heads/master@{#332508}
|