| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
LOG(ERROR) Spam makes failing tests more difficult to debug
and obscures actual errors. This cleans up some spam that
always shows up when running on Linux with chromeos=1.
BUG=none
Review URL: https://codereview.chromium.org/1254013002
Cr-Commit-Position: refs/heads/master@{#341145}
|
|
|
|
|
|
|
|
|
|
|
| |
We can no longer rely on other subsystems to initialize NSS. In this case, the
offending function was MockOwnerKeyUtil::SetPrivateKey.
BUG=462040
Review URL: https://codereview.chromium.org/1208993005
Cr-Commit-Position: refs/heads/master@{#337216}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is everything but the chrome directory
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=zelidrag@chromium.org (chromeos)
TBR=keybuk@chromium.org (device/bluetooth)
Review URL: https://codereview.chromium.org/1162943002
Cr-Commit-Position: refs/heads/master@{#332626}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We'll later want to make this code use CHAPS directly, possibly with some
interface abstracting NSS and CHAPS. But RSAPrivateKey won't work as that
interface as it can't abstract between multiple private key implementations at
runtime. So switch it to SECKEYPrivateKey and NSS functions directly.
With this, the chimera build should be functional on Linux and CrOS apart from
client certificates.
This tightens the build so that components/ownership is only build on CrOS.
It's currently unused on other platforms, but still built as a test, with
NSS pieces #ifdef'd out.
BUG=478777
Review URL: https://codereview.chromium.org/1145613002
Cr-Commit-Position: refs/heads/master@{#331421}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1106103003/ with fixes to
ensure callers never pass in a null slot.
Currently some NSS platform integration logic transits private keys through
RSAPrivateKey on CrOS. This prevents incrementally switching RSAPrivateKey to
BoringSSL while keeping platform integrations on NSS.
The intent of this change is to clarify RSAPrivateKey as a BoringSSL vs NSS
internal crypto library (use_openssl=0 vs use_openssl=1) abstraction. It's
primarily to be used with SignatureCreator. Code which uses NSS based on
use_nss_certs rather than use_openssl because the underlying platform is NSS
should call NSS routines directly, or introduce different abstractions.
Remove the problematic RSAPrivateKey methods and instead add
crypto/nss_key_util.h which contains some helper functions for manipulating NSS
keys. This is sufficient to allow consumers of the removed methods to use NSS
directly with about as much code. (This should not set back migrating that
logic to NSS as that code was already very NSS-specific; those APIs assumed
PK11SlotInfo.)
nss_key_util.h, like nss_util.h, is built whenever NSS is used either
internally or for platform integrations. This is so rsa_private_key_nss.cc can
continue to use the helper functions to implement the NSS-agnostic interface.
With this, the chimera CrOS configuration should build. The RSAPrivateKey logic
is functional with the exception of some logic in components/ownership. That
will be resolved in a future CL.
BUG=478777,483606
Review URL: https://codereview.chromium.org/1128153003
Cr-Commit-Position: refs/heads/master@{#329227}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:100001 of https://codereview.chromium.org/1106103003/)
Reason for revert:
Causes SEGV during login on Chrome OS
BUG=483606
Original issue's description:
> Don't use RSAPrivateKey in NSS integration code.
>
> Currently some NSS platform integration logic transits private keys through
> RSAPrivateKey on CrOS. This prevents incrementally switching RSAPrivateKey to
> BoringSSL while keeping platform integrations on NSS.
>
> The intent of this change is to clarify RSAPrivateKey as a BoringSSL vs NSS
> internal crypto library (use_openssl=0 vs use_openssl=1) abstraction. It's
> primarily to be used with SignatureCreator. Code which uses NSS based on
> use_nss_certs rather than use_openssl because the underlying platform is NSS
> should call NSS routines directly, or introduce different abstractions.
>
> Remove the problematic RSAPrivateKey methods and instead add
> crypto/nss_key_util.h which contains some helper functions for manipulating NSS
> keys. This is sufficient to allow consumers of the removed methods to use NSS
> directly with about as much code. (This should not set back migrating that
> logic to NSS as that code was already very NSS-specific; those APIs assumed
> PK11SlotInfo.)
>
> nss_key_util.h, like nss_util.h, is built whenever NSS is used either
> internally or for platform integrations. This is so rsa_private_key_nss.cc can
> continue to use the helper functions to implement the NSS-agnostic interface.
>
> With this, the chimera CrOS configuration should build. The RSAPrivateKey logic
> is functional with the exception of some logic in components/ownership. That
> will be resolved in a future CL.
>
> BUG=478777
>
> Committed: https://crrev.com/a46a990b2ccae2b66e87b5f76d2866044dc3182e
> Cr-Commit-Position: refs/heads/master@{#327909}
TBR=rsleevi@chromium.org,pneubeck@chromium.org,dpolukhin@chromium.org,caitkp@chromium.org,davidben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=483606
Review URL: https://codereview.chromium.org/1118263003
Cr-Commit-Position: refs/heads/master@{#327978}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently some NSS platform integration logic transits private keys through
RSAPrivateKey on CrOS. This prevents incrementally switching RSAPrivateKey to
BoringSSL while keeping platform integrations on NSS.
The intent of this change is to clarify RSAPrivateKey as a BoringSSL vs NSS
internal crypto library (use_openssl=0 vs use_openssl=1) abstraction. It's
primarily to be used with SignatureCreator. Code which uses NSS based on
use_nss_certs rather than use_openssl because the underlying platform is NSS
should call NSS routines directly, or introduce different abstractions.
Remove the problematic RSAPrivateKey methods and instead add
crypto/nss_key_util.h which contains some helper functions for manipulating NSS
keys. This is sufficient to allow consumers of the removed methods to use NSS
directly with about as much code. (This should not set back migrating that
logic to NSS as that code was already very NSS-specific; those APIs assumed
PK11SlotInfo.)
nss_key_util.h, like nss_util.h, is built whenever NSS is used either
internally or for platform integrations. This is so rsa_private_key_nss.cc can
continue to use the helper functions to implement the NSS-agnostic interface.
With this, the chimera CrOS configuration should build. The RSAPrivateKey logic
is functional with the exception of some logic in components/ownership. That
will be resolved in a future CL.
BUG=478777
Review URL: https://codereview.chromium.org/1106103003
Cr-Commit-Position: refs/heads/master@{#327909}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
USE_NSS is confusing because it's not actually the analog of USE_OPENSSL; it's
the analog to USE_OPENSSL_CERTS. This is in preparation for the chimera build
which will set USE_OPENSSL and USE_NSS(_CERTS).
This CL was partially done automatically by the following command:
git grep -l USE_NSS | xargs sed -i -e 's/defined(USE_NSS)/defined(USE_NSS_CERTS)/'
The remaining were caught by the following command and fixed manually:
git grep 'USE_NSS\([^_]\|$\)'
Finally, the following command verified nothing in a separate repository was
sensitive to this change:
find . -name '*.cc' -o -name '*.h' | xargs grep 'USE_NSS\([^_]\|$\)'
For now, the old name is still defined, but not used within Chromium.
A follow-up CL will remove deprecated use_nss and USE_NSS #defines
together which will then cause downstream churn. Though from a grep
of known downstreams, the churn seems to be fairly minimal. The
removal is split from this CL so that, if we need to revert, the
CL to revert is small.
TBR=pneubeck@chromium.org
BUG=462040
Review URL: https://codereview.chromium.org/1082123003
Cr-Commit-Position: refs/heads/master@{#325710}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/952163002
Cr-Commit-Position: refs/heads/master@{#318246}
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/941863002
Cr-Commit-Position: refs/heads/master@{#317439}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove ygorshenin@ from OWNERS/TODOs, replace with
alemate/antrim/dpolukhin/bartfab
BUG=None
TBR=stevenjb@chromium.org,isherman@chromium.org
Review URL: https://codereview.chromium.org/925963002
Cr-Commit-Position: refs/heads/master@{#316554}
|
|
|
|
|
|
|
|
|
| |
BUG=433840
TEST=manual tests on Falco device
Review URL: https://codereview.chromium.org/826703002
Cr-Commit-Position: refs/heads/master@{#309646}
|
|
|
|
|
|
|
|
|
|
|
| |
No intended functionality change.
R=brettw@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/780633002
Cr-Commit-Position: refs/heads/master@{#306640}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is an alternative to the https://codereview.chromium.org/709763002/.
BUG=430042
TEST=manual tests on a falco device
Review URL: https://codereview.chromium.org/695193004
Cr-Commit-Position: refs/heads/master@{#303465}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=caitkp@chromium.org
Review URL: https://codereview.chromium.org/684513002
Cr-Commit-Position: refs/heads/master@{#301931}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=230018
TEST=unit_tests:OwnerSettingsServiceChromeOSTest.*
Committed: https://crrev.com/5fa0ee22683b92d67e07c060e8c7a3c4cced51ee
Cr-Commit-Position: refs/heads/master@{#301132}
Review URL: https://codereview.chromium.org/654263003
Cr-Commit-Position: refs/heads/master@{#301328}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:160001 of https://codereview.chromium.org/654263003/)
Reason for revert:
ASAN bot unhappy
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/3731
Original issue's description:
> Implemented OwnerSettingsService::Set() method.
>
> BUG=230018
> TEST=unit_tests:OwnerSettingsServiceChromeOSTest.*
>
> Committed: https://crrev.com/5fa0ee22683b92d67e07c060e8c7a3c4cced51ee
> Cr-Commit-Position: refs/heads/master@{#301132}
TBR=mnissler@chromium.org,pastarmovj@chromium.org,ygorshenin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=230018
Review URL: https://codereview.chromium.org/640063008
Cr-Commit-Position: refs/heads/master@{#301161}
|
|
|
|
|
|
|
|
|
| |
BUG=230018
TEST=unit_tests:OwnerSettingsServiceChromeOSTest.*
Review URL: https://codereview.chromium.org/654263003
Cr-Commit-Position: refs/heads/master@{#301132}
|
|
|
|
|
|
|
|
|
| |
R=cmasone@chromium.org
BUG=424337
Review URL: https://codereview.chromium.org/652893004
Cr-Commit-Position: refs/heads/master@{#300863}
|
|
|
|
|
|
|
|
|
| |
BUG=417463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/666133002
Cr-Commit-Position: refs/heads/master@{#300456}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623133002
Cr-Commit-Position: refs/heads/master@{#298237}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to support SHA256 (not just SHA1).
BUG=412531
R=rsleevi@chromium.org,davidben@chromium.org
TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/560583002
Cr-Commit-Position: refs/heads/master@{#295747}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/ownership/*.
BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c
Committed: https://chromium.googlesource.com/chromium/src/+/40979bf265c3ffbe1736a87935418da72be5d1f1
Review URL: https://codereview.chromium.org/548323003
Cr-Commit-Position: refs/heads/master@{#294810}
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/ownership/*."
This reverts commit 40979bf265c3ffbe1736a87935418da72be5d1f1.
BUG=398856
Review URL: https://codereview.chromium.org/570053002
Cr-Commit-Position: refs/heads/master@{#294794}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/ownership/*.
BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c
Review URL: https://codereview.chromium.org/548323003
Cr-Commit-Position: refs/heads/master@{#294793}
|
|
|
|
|
|
|
|
|
|
| |
Instead of putting all the files in a bit test_support target, I made separate smaller test support targets for the various sub-projects (browser, common, etc.) and linked those in. This helps distribute the complexity.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/559543003
Cr-Commit-Position: refs/heads/master@{#294641}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/ownership/*. (patchset #4 id:60001 of https://codereview.chromium.org/548323003/)
Reason for revert:
Breaks compile on multiple bots:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/3134
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/73424
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Win%20Builder%20%28dbg%29/builds/13365
Original issue's description:
> Non-plafrom-specific part of an OwnerSettingsService is moved to components/ownership/*.
>
> BUG=398856
> TEST=existing browser_tests and unit_tests
> R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/46a58bffbe303d3484d7cc288b47bfae5388109c
TBR=jochen@chromium.org,erg@chromium.org,nkostylev@chromium.org,pastarmovj@chromium.org,ygorshenin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398856
Review URL: https://codereview.chromium.org/565293003
Cr-Commit-Position: refs/heads/master@{#294618}
|
|
|
|
|
|
|
|
|
|
|
|
| |
components/ownership/*.
BUG=398856
TEST=existing browser_tests and unit_tests
R=erg@chromium.org, jochen@chromium.org, nkostylev@chromium.org, pastarmovj@chromium.org
Review URL: https://codereview.chromium.org/548323003
Cr-Commit-Position: refs/heads/master@{#294609}
|
|
|
|
|
|
|
|
|
|
| |
and components/
Also fix the formatting of chrome_elf/OWNERS
Review URL: https://codereview.chromium.org/546733002
Cr-Commit-Position: refs/heads/master@{#294245}
|
|
|
|
|
|
|
|
|
|
|
| |
as we're going to move as much as possible from OwnerSettingsService to components/ownership/* and because OwnerSettingsServiceFactory should do all platform-specific business.
BUG=398856
TEST=existing browser_tests and unit_tests
Review URL: https://codereview.chromium.org/516243002
Cr-Commit-Position: refs/heads/master@{#293486}
|
|
BUG=398856
TEST=existing browser_tests
Review URL: https://codereview.chromium.org/494093002
Cr-Commit-Position: refs/heads/master@{#292616}
|