summaryrefslogtreecommitdiffstats
path: root/components/pairing
Commit message (Collapse)AuthorAgeFilesLines
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+1
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+1
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* Replace more Tokenize calls with base::SplitStringbrettw2015-06-291-3/+4
| | | | | | | | | | | This also replaces a few StartsWithASCII calls with the new StartsWith in cases where the deprecated ASCII version appeared in code I was changing. NOPRESUBMIT=true (due to weird include ordering of _kde.cc file which a comment in the file says is required) Review URL: https://codereview.chromium.org/1202963003 Cr-Commit-Position: refs/heads/master@{#336670}
* Fix bluetooth crash after hotrod enrollment.achuith2015-06-241-0/+1
| | | | | | | | BUG=503246 Review URL: https://codereview.chromium.org/1200083002 Cr-Commit-Position: refs/heads/master@{#335980}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-121-2/+2
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Replace more ObserverList with base::ObserverList.brettw2015-06-034-4/+4
| | | | | | | | | | | | This is everything but the chrome directory CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=zelidrag@chromium.org (chromeos) TBR=keybuk@chromium.org (device/bluetooth) Review URL: https://codereview.chromium.org/1162943002 Cr-Commit-Position: refs/heads/master@{#332626}
* Add permanent_id to pairing protocol.zork2015-05-016-0/+18
| | | | | | | | BUG=483304 Review URL: https://codereview.chromium.org/1118173002 Cr-Commit-Position: refs/heads/master@{#327873}
* Add AddNetwork message to pairing API.zork2015-04-2212-49/+51
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1090483002 Cr-Commit-Position: refs/heads/master@{#326206}
* components: Cleanup - remove unused private fields.tfarina2015-02-202-2/+0
| | | | | | | | | | BUG=447445 TEST=cc_unittests R=blundell@chromium.org Review URL: https://codereview.chromium.org/929883004 Cr-Commit-Position: refs/heads/master@{#317296}
* Update {virtual,override,final} to follow C++11 style in components, round 2.dcheng2015-01-235-121/+105
| | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Review URL: https://codereview.chromium.org/865973003 Cr-Commit-Position: refs/heads/master@{#312855}
* Enable -Wunused-local-typedefthakis2014-11-121-2/+0
| | | | | | | | | BUG=321833 TBR=brettw Review URL: https://codereview.chromium.org/722513003 Cr-Commit-Position: refs/heads/master@{#303892}
* Clear the bluetooth discoverable bit when OOBE is finished on Remora.zork2014-10-281-3/+6
| | | | | | | | BUG=427089 Review URL: https://codereview.chromium.org/681903002 Cr-Commit-Position: refs/heads/master@{#301543}
* Rewind the current stage when setting the confirmation code, if needed.zork2014-10-231-0/+5
| | | | | | | | BUG=426234 Review URL: https://codereview.chromium.org/664853004 Cr-Commit-Position: refs/heads/master@{#300807}
* Set the proper stage on pairing connection errorzork2014-10-221-0/+3
| | | | | | | | BUG=426225 Review URL: https://codereview.chromium.org/669263002 Cr-Commit-Position: refs/heads/master@{#300800}
* Support for host configuration.achuith2014-10-225-8/+5
| | | | | | | | | | | | | | | * Introduce STAGE_PAIRING_DONE, which is when we initiate host configuration from the pairing screen. * Get rid of STAGE_UPDATING. Instead exit the host_pairing_screen in ConfigureHost. * Add ConfigureHost and SetConfigureHost to ScreenObserver. * NetworkScreenActor now handles setting and getting of locale, language, and keyboard_layout. * Move MarkEulaAccepted to the right place. BUG=417690 TEST=manual Review URL: https://codereview.chromium.org/668663005 Cr-Commit-Position: refs/heads/master@{#300754}
* Replace STAGE_PAIRING_DONE with STAGE_HOST_ENROLLMENT_SUCCESS.achuith2014-10-204-7/+6
| | | | | | | | | | | Handle STAGE_INITIALIZATION_ERROR with a logging message BUG=420111 TEST=manual Review URL: https://codereview.chromium.org/656503005 Cr-Commit-Position: refs/heads/master@{#300337}
* Rename STAGE_PAIRING_DONE to STAGE_ENROLLMENT_SUCCESSachuith2014-10-153-7/+7
| | | | | | | | | | | | | STAGE_PAIRING_DONE is not handled by HostPairingScreen. Change generic controller to shark_controller or remora_controller as appropriate. BUG=418061 TEST=compiles. Review URL: https://codereview.chromium.org/651303004 Cr-Commit-Position: refs/heads/master@{#299608}
* * Transition host to STAGE_UPDATING after pairing.achuith2014-10-148-54/+126
| | | | | | | | | | | | | | * Add enrollment status to proto * Remove stages not handled by HostPairingController, and ControllerPairingController. * UpdateScreen sends update status via remora_controller. * EnrollmentScreen sends enrollment status via remora_controller. * Remove auth_token_ from EnrollmentScreen. * Rename to shark_controller and remora_controller in WizardController. * Remove get_initial_status_ from BluetoothControllerPairingController. Review URL: https://codereview.chromium.org/652743003 Cr-Commit-Position: refs/heads/master@{#299422}
* Fixes components/pairing/BUILD.gnmukai2014-10-101-18/+21
| | | | | | | | | | BUG=None R=cmasone@chromium.org, achuith@chromium.org TEST=manually Review URL: https://codereview.chromium.org/639253002 Cr-Commit-Position: refs/heads/master@{#299041}
* replace OVERRIDE and FINAL with override and final in components/mostynb2014-10-065-77/+77
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623133002 Cr-Commit-Position: refs/heads/master@{#298237}
* Convert a couple loops to range based iterators.zork2014-10-022-10/+5
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/626633002 Cr-Commit-Position: refs/heads/master@{#297940}
* Update comments and logging.achuith2014-10-012-1/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/608753002 Cr-Commit-Position: refs/heads/master@{#297707}
* Add testonly=true to components/pairing:unit_testsmukai2014-10-011-0/+1
| | | | | | | | | BUG=None TBR=cmasone@chromium.org, zork@chromium.org Review URL: https://codereview.chromium.org/620913002 Cr-Commit-Position: refs/heads/master@{#297690}
* Host pairing OOBE starts at the right time.dzhioev2014-09-192-0/+94
| | | | | | | | | | | | | | | | | | The following behaviour implmented: * If "new-remora-oobe" switch is not set, OOBE starts with with the regular "remora" UI. At the same time wizard controller we start to listen for incoming connection from shark controller. If connection is established, we switch UI to the new one. * Otherwise, we launch the new UI from the beginning of OOBE. Several small issues fixed as well. BUG=405150 TEST=manually Review URL: https://codereview.chromium.org/528803002 Cr-Commit-Position: refs/heads/master@{#295721}
* Clean up protocol for Bluetooth Pairing.zork2014-09-193-29/+46
| | | | | | | | | | | | - Add helper buffer for sending IOBuffer - Add initialization error states. - Make the device name more human-readable. BUG=405744,405774 Review URL: https://codereview.chromium.org/575273002 Cr-Commit-Position: refs/heads/master@{#295629}
* Wait for the Bluetooth adapter to be present before starting pairing.zork2014-09-172-1/+31
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/552983003 Cr-Commit-Position: refs/heads/master@{#295207}
* Remove implicit conversions from scoped_refptr to T* in components/pairingdcheng2014-09-152-7/+7
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/574513002 Cr-Commit-Position: refs/heads/master@{#294890}
* Redirect to the enterprise enrollment screen during remora and shark pairing.zork2014-09-101-3/+0
| | | | | | | | BUG=381007 Review URL: https://codereview.chromium.org/547503002 Cr-Commit-Position: refs/heads/master@{#294232}
* GN: Fix some breakage for os==chromeos buildcmasone2014-09-091-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | build/config/linux/BUILD.gn: * Usage of generate_library_loader for libbrlapi was incorrect; there * was nothing provided for "functions". This is now an empty list. chrome/chrome_common.gypi chrome/common/BUILD.gn * Reference to a removed file, chrome_version_info_linux.cc chromeos/BUILD.gn components/pairing/BUILD.gn * Usage of removed proto_{in,out}_dir in proto_library rules. content/gpu/BUILD.gn * Typo in reference to third_party/libva:libva_config ui/views/BUILD.gn * Attempt to filter source files out of * gypi_values.views_unittests_sources by subdirectory path. Fortunately * that variable already doesn't include the files that were supposed * to be filtered out, so the rule is simply removed. BUG=388412 TEST=Create a target that builds //mojo/public, build with os==chromeos R=brettw@chromium.org Review URL: https://codereview.chromium.org/550423002 Cr-Commit-Position: refs/heads/master@{#293964}
* Add method for telling the Pairing API that enrollment is completezork2014-09-097-3/+23
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/555003002 Cr-Commit-Position: refs/heads/master@{#293879}
* Update the pairing API to include configuration and enrollment.zork2014-08-2810-86/+122
| | | | | | | | BUG=405744 Review URL: https://codereview.chromium.org/491943004 Cr-Commit-Position: refs/heads/master@{#292309}
* Add bluetooth host and controller delegates for pairing.zork2014-08-267-2/+1127
| | | | | | | | BUG=380961, 380962 Review URL: https://codereview.chromium.org/469613002 Cr-Commit-Position: refs/heads/master@{#292005}
* Add ProtoDecoder for sending messages between Host and Controller when pairingzork@chromium.org2014-08-123-0/+294
| | | | | | | | | BUG=380961, 380962 Review URL: https://codereview.chromium.org/448273002 Cr-Commit-Position: refs/heads/master@{#289097} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289097 0039d316-1c4b-4281-b951-d872f2087c98
* Add MessageBuffer class, which will manage the data received from azork@chromium.org2014-08-094-0/+206
| | | | | | | | | | | bluetooth socket. BUG=380961,380962 Review URL: https://codereview.chromium.org/448753004 Cr-Commit-Position: refs/heads/master@{#288524} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288524 0039d316-1c4b-4281-b951-d872f2087c98
* Add pairing API protocol definition.zork@chromium.org2014-08-062-0/+90
| | | | | | | | | BUG=None R=achuith@chromium.org Review URL: https://codereview.chromium.org/406033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287796 0039d316-1c4b-4281-b951-d872f2087c98
* Add net to pairing DEPSzork@chromium.org2014-08-061-0/+1
| | | | | | | | | BUG=None R=wtc@chromium.org Review URL: https://codereview.chromium.org/429453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287794 0039d316-1c4b-4281-b951-d872f2087c98
* Move Chrome OS pairing interface to chrome/browser/chromeoszork@chromium.org2014-07-2211-0/+961
BUG=393413 Review URL: https://codereview.chromium.org/387163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284549 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-08-30 19:07:33 +0000