summaryrefslogtreecommitdiffstats
path: root/components/plugins
Commit message (Collapse)AuthorAgeFilesLines
* Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..."brettw@chromium.org2014-08-131-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace > > Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is > generally a NOP but will allow me to delete the other 4 variants in a followup > (wanted to do that separately since that will require more review, since > callsites will be changed in nontrivial ways). > > In some cases, LowerCaseEqualsASCII is called with a WebString, which no > longer is implicitly converted. I added base::string16(...) around such > calls to force the right conversion. It happened in these files: > window_container_type.cc > savable_resources.cc > render_view_impl.cc > blink_ax_tree_source.cc > password_form_conversion_utils.cc > translate_helper.cc > chrome_render_view_observer.cc > dom_serializer_browsertest.cc > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/448143008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/474483002 Cr-Commit-Position: refs/heads/master@{#289320} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespacebrettw@chromium.org2014-08-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is generally a NOP but will allow me to delete the other 4 variants in a followup (wanted to do that separately since that will require more review, since callsites will be changed in nontrivial ways). In some cases, LowerCaseEqualsASCII is called with a WebString, which no longer is implicitly converted. I added base::string16(...) around such calls to force the right conversion. It happened in these files: window_container_type.cc savable_resources.cc render_view_impl.cc blink_ax_tree_source.cc password_form_conversion_utils.cc translate_helper.cc chrome_render_view_observer.cc dom_serializer_browsertest.cc R=jamesr@chromium.org Review URL: https://codereview.chromium.org/448143008 Cr-Commit-Position: refs/heads/master@{#289312} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToLowerASCII to base namespacebrettw@chromium.org2014-08-071-1/+1
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/448853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
* Add more components to the GN build.brettw@chromium.org2014-07-161-0/+26
| | | | | | | | | | | | | | | | | | google infobars invalidation navigation_intercaption network_time password_manager plugins search_provider_logos sessions R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/397953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283521 0039d316-1c4b-4281-b951-d872f2087c98
* Move webpreferences.* from webkit/ to content/tfarina@chromium.org2014-07-092-7/+11
| | | | | | | | | | | | | BUG=338338 TEST=None R=jam@chromium.org TBR=boliu@chromium.org # for android_webview TBR=bauerb@chromium.org # for components/plugins TBR=dmichael@chromium.org # for ppapi Review URL: https://codereview.chromium.org/357203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281978 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK() crash in PluginPlaceholder.xrenishere@gmail.com2014-06-261-1/+1
| | | | | | | | | | | Change ASCIIToUTF16 to UTF8ToUTF16. messge_ is string16. It might contain non ascii. BUG=389004 Review URL: https://codereview.chromium.org/350963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280013 0039d316-1c4b-4281-b951-d872f2087c98
* WebViewPlugin: Apply Prefs to WebSettings before creating WebLocalFramedanakj@chromium.org2014-05-232-8/+9
| | | | | | | | | | | | | | | | | | | | | | | If we create a WebLocalFrame and then set blink's settings, the frame gets an inconsistent view of the settings when they change out from underneath it. Concretely, this leads to us doing WebViewImpl::setRootGraphicsLayer(A) with pinch virtual viewport disabled (the default in WebSettings), when we attach the document to the tree, then we apply the prefs to enable pinch virtual viewport, and later setRootGraphicsLayer(NULL) to detach the document. This causes a crash because the viewport code expects a matching attach before the detach. With this CL, https://codereview.chromium.org/261143003 is able to pass on the print preview and prerender browser tests. R=bauerb@chromium.org BUG=376531,361729 Review URL: https://codereview.chromium.org/296983017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272628 0039d316-1c4b-4281-b951-d872f2087c98
* Update didClearWindowObject API in webview pluginjochen@chromium.org2014-05-162-2/+2
| | | | | | | | | | | We now only call this method for the main world (world_id == 0) BUG=none R=bauerb@chromium.org Review URL: https://codereview.chromium.org/292493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270998 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WebViewClient subclasses that return a null layerTreeView.ojan@chromium.org2014-04-222-0/+8
| | | | | | | | | | | | | | | | In a followup blink-side patch, returning a null layerTreeView without returning true from allowsBrokenNullLayerTreeView will assert. Soon, we'll delete the null layerTreeView codepath entirely. This is to make sure we have all the cases identified and so that new ones don't get added. Remove the null-check in RenderWidget::initializeLayerTreeView. It never sets compositor_ to null and on the blink side we assert as such. Review URL: https://codereview.chromium.org/242953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265252 0039d316-1c4b-4281-b951-d872f2087c98
* Revert teporary include hacks for WebLocalFrame and use forward declaresdcheng@chromium.org2014-04-181-0/+1
| | | | | | | | BUG=346764 Review URL: https://codereview.chromium.org/238033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264720 0039d316-1c4b-4281-b951-d872f2087c98
* Final (?) set of changes to unblock WebLocalFrame in blink.dcheng@chromium.org2014-04-124-9/+8
| | | | | | | | | | | | | Mostly mechanical like several other proceeding CLs. This is to unblock https://codereview.chromium.org/232133004/ so it can land in Blink and roll into Chrome. BUG=346764 R=bauerb@chromium.org, jam@chromium.org, mkosiba@chromium.org Review URL: https://codereview.chromium.org/234263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263449 0039d316-1c4b-4281-b951-d872f2087c98
* Update a few more references to WebFrame to use WebLocalFrame.dcheng@chromium.org2014-04-101-3/+2
| | | | | | | | | | | | I've also updated the most straightforward changes to just remove references to WebFrame altogether. Code that uses a mixture of both throughout hasn't changed. BUG=346764 Review URL: https://codereview.chromium.org/231793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263035 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Chrome usages of WebFrame to WebLocalFrame.dcheng@chromium.org2014-04-082-6/+7
| | | | | | | | | | | This is a mechanical change to followup on Blink and content changes to change parameter types to WebLocalFrame where appropriate. BUG=346764 Review URL: https://codereview.chromium.org/226093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262320 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-2/+2
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Use the single argument overload of WebFrame::create().dcheng@chromium.org2014-02-231-1/+1
| | | | | | | | | | | | | | As of r252664, we no longer depend on storing the frame ID in Blink, so we can simply use the one-argument version of WebFrame::create() and delete the two argument overload once this lands. BUG=314791 R=creis@chromium.org TBR=bauerb@chromium.org, boliu@chromium.org, vitalybuka@chromium.org Review URL: https://codereview.chromium.org/175543005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252831 0039d316-1c4b-4281-b951-d872f2087c98
* Unify frame IDs with RenderFrameHost routing IDs.creis@chromium.org2014-02-201-1/+1
| | | | | | | | | | This eliminates a lot of unnecessary code around FrameTreeNode::frame_id_, which was also incorrect if two frames had the same frame ID in different processes. BUG=314791 Review URL: https://codereview.chromium.org/172063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252370 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue that IME can't be enabled when set Plugin mode to "Click to play".luoruiyi2008@gmail.com2014-02-142-2/+12
| | | | | | | | | | | | | | In normal mode, the plugin is created at the moment the page is loaded. Then when the first time the plugin is clicked. It will set the flag "has_webkit_focus_" true in real plugin instance. Then, send out the focus change notification in PepperPluginInstanceImpl::SetWebKitFocus, which will finally affect the IME stuff. However, at "Click to play" mode, WebViewPlugin is created at first, which will be replaced by real plugin. When the first time we click, the real plugin is created, loaded. But no focus is set in real plugin, which cause the IME stuff can't be enabled. In solution, we transfer the |focused_| in WebViewPlugin to new plugin after it loaded. BUG=336740 Review URL: https://codereview.chromium.org/144803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251303 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor base/safe_numerics.hjschuh@chromium.org2014-01-171-4/+4
| | | | | | | | | | | | | | | * Move into base/numerics subdirectory. * Rename files for clarity. * Add owners. * Rename checked_numeric_cast to checked_cast. * Fixup callsites and include paths. BUG=332611 R=brettw@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/141113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245418 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to load a plugin after the webview plugin is gonejochen@chromium.org2014-01-141-0/+2
| | | | | | | | | BUG=334082 R=bauerb@chromium.org,inferno@chromium.org Review URL: https://codereview.chromium.org/134773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244754 0039d316-1c4b-4281-b951-d872f2087c98
* Move the guts of user_metrics to a new static lib in //base/metrics.ben@chromium.org2014-01-131-2/+2
| | | | | | | | | | | I retained a couple of wrapper functions in content that post back to the UI thread if they are called from another thread. All existing code will continue to use these wrappers. The intent is that some code that I don't want to depend on content that only lives on the UI thread can now call //base/metrics code directly. R=isherman@chromium.org, jam@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/129223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244580 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly cut link between WebViewPlugin and PluginPlaceholderjochen@chromium.org2014-01-134-3/+11
| | | | | | | | | BUG=332675 R=bauerb@chromium.org,inferno@chromium.org Review URL: https://codereview.chromium.org/135543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244487 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebFrameClient::didClearWindowObject signature.jochen@chromium.org2014-01-132-2/+2
| | | | | | | | | | | | The callback is called both for the main and isolated worlds, the new API indicates in which world the window object was cleared BUG=none R=abarth@chromium.org Review URL: https://codereview.chromium.org/133123008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244485 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to access the plugin_ after we deleted in the in plugin placeholderjochen@chromium.org2014-01-091-0/+4
| | | | | | | | | BUG=332675 R=bauerb@chromium.org,inferno@chromium.org Review URL: https://codereview.chromium.org/131073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243851 0039d316-1c4b-4281-b951-d872f2087c98
* Move the plugin placeholder from CppBoundClass to gin::Wrappablejochen@chromium.org2014-01-087-55/+70
| | | | | | | | | BUG=297480 R=aa@chromium.org,bauerb@chromium.org Review URL: https://codereview.chromium.org/116163008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243682 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in chrome_frame/, chromeos/, components/ to ↵avi@chromium.org2013-12-251-1/+1
| | | | | | | | | | | | use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/112433004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242493 0039d316-1c4b-4281-b951-d872f2087c98
* Convert remaining uses of WebView::initializeMainFrame to setMainFrame.dcheng@chromium.org2013-12-202-4/+12
| | | | | | | | | | | | This is the Chrome-side change. Fixing this makes inverting the owning relationship between WebFrame and Frame easier. BUG=329266 R=ajwong@chromium.org, bauerb@chromium.org, boliu@chromium.org, ddorwin@chromium.org, scottbyer@chromium.org Review URL: https://codereview.chromium.org/114773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242016 0039d316-1c4b-4281-b951-d872f2087c98
* Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.rsesek@chromium.org2013-12-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The JSONReader only accepts UTF-8 input strings and converts \uXXXX sequences back into UTF-8. However, the JSONWriter converts all non-ASCII characters to UTF-16 escape sequences. This round-tripping is sub-optimal, as noted in a TODO from r54359. One reason for this may be that JsonDoubleQuote(), used by JSONWriter, does not handle UTF-8 bytes correctly, interpreting them as code points and writing them out as \u00XX sequences. If this were read back through a RFC-compliant JSON parser, the result would be an invalid encoding error. JsonDoubleQuote() does handle UTF-16 correctly, though. This rewrites the base/json/string_escape.h API and fixes the above UTF-8 issue by dividing callers up into three groups: 1. Those that pass valid UTF-8 to be escaped. Prior to this change, very few callers used this variant. Those that did were likely using ASCII, otherwise the output would be mangled due to the above issue. Now, valid UTF-8 will be passed through to the output unescaped. Invalid UTF-8 sequences are replaced with U+FFFD. 2. Those that pass valid UTF-16 to be escaped. This function now validates that the input is valid UTF-16, and then converts it to unescaped UTF-8 sequences for the output. 3. Those that pass arbitrary byte arrays as std::string and expect a non-RFC- compliant encoding of the binary data using \uXXXX escapes. This behavior is now in the EscapeBytesAsInvalidJSONString() function. It is only used by callers who want a "debug string" but do not expect to actually parse the output as valid JSON, since it is not. Additionally, this removes the JSONWriter::OPTIONS_DO_NOT_ESCAPE flag, since the writer can now handle UTF-8 appropriately. BUG=15466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239800 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=240082 R=asanka@chromium.org, bauerb@chromium.org, mark@chromium.org, thakis@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/100823007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240190 0039d316-1c4b-4281-b951-d872f2087c98
* Make ContentRendererClient's OverrideCreatePlugin and ↵jam@chromium.org2013-12-114-28/+14
| | | | | | | | | | | | | CreatePluginReplacement take only a RenderFrame. In two places I called the temporary method render_frame->GetRenderView() because ContentSettingsObserver still has to be switched to be a RenderFrameObserver. BUG=304341 R=bauerb@chromium.org, nasko@chromium.org Review URL: https://codereview.chromium.org/106973012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/100823007/antrim@chromium.org2013-12-111-1/+1
| | | | | | | | | | | | Reason for revert: This patchset breaks at least displayment of Russian localized strings on Chromeos login screen. TBR=mark@chromium.org,jshin@chromium.org,thakis@chromium.org,asanka@chromium.org,zea@chromium.org,bauerb@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/106793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240082 0039d316-1c4b-4281-b951-d872f2087c98
* Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.rsesek@chromium.org2013-12-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The JSONReader only accepts UTF-8 input strings and converts \uXXXX sequences back into UTF-8. However, the JSONWriter converts all non-ASCII characters to UTF-16 escape sequences. This round-tripping is sub-optimal, as noted in a TODO from r54359. One reason for this may be that JsonDoubleQuote(), used by JSONWriter, does not handle UTF-8 bytes correctly, interpreting them as code points and writing them out as \u00XX sequences. If this were read back through a RFC-compliant JSON parser, the result would be an invalid encoding error. JsonDoubleQuote() does handle UTF-16 correctly, though. This rewrites the base/json/string_escape.h API and fixes the above UTF-8 issue by dividing callers up into three groups: 1. Those that pass valid UTF-8 to be escaped. Prior to this change, very few callers used this variant. Those that did were likely using ASCII, otherwise the output would be mangled due to the above issue. Now, valid UTF-8 will be passed through to the output unescaped. Invalid UTF-8 sequences are replaced with U+FFFD. 2. Those that pass valid UTF-16 to be escaped. This function now validates that the input is valid UTF-16, and then converts it to unescaped UTF-8 sequences for the output. 3. Those that pass arbitrary byte arrays as std::string and expect a non-RFC- compliant encoding of the binary data using \uXXXX escapes. This behavior is now in the EscapeBytesAsInvalidJSONString() function. It is only used by callers who want a "debug string" but do not expect to actually parse the output as valid JSON, since it is not. Additionally, this removes the JSONWriter::OPTIONS_DO_NOT_ESCAPE flag, since the writer can now handle UTF-8 appropriately. BUG=15466 Review URL: https://codereview.chromium.org/100823007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239800 0039d316-1c4b-4281-b951-d872f2087c98
* Use base namespace for string16 in components and cloud_print.brettw@chromium.org2013-12-062-3/+3
| | | | | | | | | R=scottbyer@chromium.org TBR=scottbyer Review URL: https://codereview.chromium.org/107383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239255 0039d316-1c4b-4281-b951-d872f2087c98
* Switch plugin creation to use RenderFrame instead of RenderViewjam@chromium.org2013-12-044-4/+18
| | | | | | | | | BUG=245126 R=bauerb@chromium.org, nasko@chromium.org Review URL: https://codereview.chromium.org/104973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238799 0039d316-1c4b-4281-b951-d872f2087c98
* Use UserMetricsAction for renderer user metrics.xhwang@chromium.org2013-12-041-3/+4
| | | | | | | | | | | | | | | | | | | | | Benefits of this change: - Unified action recording. We don't need special renderer treatment in extract_actions.py. - UserMetricsAction() is shorter than RenderThread::Get()->RecordAction(). So that we can have longer action names (since the action name must be on the same line and we have 80 chars limit). - Rename RecordUserMetrics() to RecordAction() to be consistent. - Separate RecordComputedAction() from RecordAction() so that we can catch unhandled computed actions. TBR=bauerb@chromium.org R=isherman@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/102073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238621 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed webview_plugin placeholders not rendering.bokan@chromium.org2013-11-221-1/+3
| | | | | | | | | | | | | The plugin placeholder was loading into a WebView, which had viewport enabled so the placeholder was loading the page at the 980px layout width. For some reason this caused it not to render at all. Setting the plugin WebView to use the FixedLayoutSize pegged to the WebView size fixes the problem. BUG=320621 Review URL: https://codereview.chromium.org/81373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236645 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235336 "Bind plugin placeholder directly to v8 instead of..."rockot@google.com2013-11-155-125/+44
| | | | | | | | | | | | | | | | | | | | This appears to have broken some things. e.g. http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%283%29&number=18282 > Bind plugin placeholder directly to v8 instead of over CppBoundClass > > BUG=297480 > R=bauerb@chromium.org, svenpanne@chromium.org > TBR=svenpanne@chromium.org > > Review URL: https://codereview.chromium.org/69953006 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/74143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235363 0039d316-1c4b-4281-b951-d872f2087c98
* Bind plugin placeholder directly to v8 instead of over CppBoundClassjochen@chromium.org2013-11-155-44/+125
| | | | | | | | | | BUG=297480 R=bauerb@chromium.org, svenpanne@chromium.org TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/69953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235336 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite include paths for Blink public/ headers that have movedphilipj@opera.com2013-11-142-2/+1
| | | | | | | | | | | | | This is a prerequisite for removing the old (redirected) headers. In a few DEPS and in webview_plugin.cc the include was redundant and just removed instead. BUG=none Review URL: https://codereview.chromium.org/68683009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235116 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebKit namespace to blink (part 4)abarth@chromium.org2013-11-076-91/+91
| | | | | | | | | | | | This CL updates all references to the WebKit namespace in chrome and components. TBR=darin@chromium.org BUG=295096 Review URL: https://codereview.chromium.org/63273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233464 0039d316-1c4b-4281-b951-d872f2087c98
* Move renderer plugin code into a new component (re-land)aberent@chromium.org2013-10-168-0/+909
| | | | | | | | | | | | | | | | | | | | Android Webview needs to use some of the renderer plugin code, however this code is currently in chrome. This commit moves the parts of this code that don't depend on the rest of chrome into a new component. This is a new commit of https://codereview.chromium.org/23606022 which had to be reverted due to a use after free problem, now fixed. The only change from the previous CL is to chrome_plugin_placeholder.cc so TBR'ing owners of other files. TBR=darin@chromium.org, joi@chromium.org BUG=283713, 306815, 306803 Review URL: https://codereview.chromium.org/27197004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228900 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 228211 "Move renderer plugin code into a new component."aberent@google.com2013-10-148-909/+0
| | | | | | | | | | | | | | | | | | | | | | | There is an error in the ChromePluginPlaceholder destructor causing pointers to it to be left around after it is freed. Fix will follow, but reverting for now. BUG=306815,306803 > Move renderer plugin code into a new component. > > Android Webview needs to use some of the renderer plugin code, however > this code is currently in chrome. This commit moves the parts of this > code that don't depend on the rest of chrome into a new component. > > BUG=283713 > > Review URL: https://codereview.chromium.org/23606022 TBR=aberent@chromium.org Review URL: https://codereview.chromium.org/26781004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228456 0039d316-1c4b-4281-b951-d872f2087c98
* Move renderer plugin code into a new component.aberent@chromium.org2013-10-118-0/+909
Android Webview needs to use some of the renderer plugin code, however this code is currently in chrome. This commit moves the parts of this code that don't depend on the rest of chrome into a new component. BUG=283713 Review URL: https://codereview.chromium.org/23606022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228211 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 05:27:46 +0000