| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added components are:
bitmap_uploader
browser_sync
dom_distiller
exp
proxy_config
query_parser
rappor
renderer_context_menu
resource_provider
resources
rlz
safe_browsing_db
safe_json
scheduler
search
The dom distiller GN build was a little messed up. The JNI registrar files were in core but referenced files in content. I moved the registrar files to content/browser which is where they're needed and matches some other components. There were also some other duplicated java targets, and I split out the content build file into separate subdirectories and renamed the targets to match.
TBR=dpranke@chromium.org
BUG=562773
Review URL: https://codereview.chromium.org/1487433002
Cr-Commit-Position: refs/heads/master@{#362234}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::android::GetApplicationContext is now defined in context_utils.h.
Update includes for files that use this, and stop including it in
jni_android.h.
BUG=552419
TBR=jochen@chromium.org,sky@chromium.org,xhwang@chromium.org,davidben@chromium.org,tedchoc@chromium.org,scheib@chromium.org,qinmin@chromium.org,halliwell@chromium.org,thakis@chromium.org
Review URL: https://codereview.chromium.org/1475773002
Cr-Commit-Position: refs/heads/master@{#361701}
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1455833005
Cr-Commit-Position: refs/heads/master@{#360954}
|
|
|
|
|
|
|
|
|
|
| |
Android didn't like our magic to automatically include a connection to mojo:tracing in ApplicationImpl. This does things the explicit way: including a mojo:TracingImpl in each and every mojo application package.
BUG=534895
Review URL: https://codereview.chromium.org/1459453003
Cr-Commit-Position: refs/heads/master@{#360434}
|
|
|
|
|
|
|
|
|
| |
BUG=None
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1410053006
Cr-Commit-Position: refs/heads/master@{#359461}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to complete the initialization of ICU before we raise the
sandbox. That means we can't pass a file descriptor to the ICU data file
across mojo pipes. Due to how Android handles resources files, we also
can't pass a file descriptor around inside the same process. So pass a
raw pointer to a memory mapped file during the sandbox warm-up phase,
and make a new option to initialize ICU from this raw pointer.
But that just uncovers a bigger issue: we don't always call what was the
sandbox warming code. If it's general initialization that needs to be
called before we run MojoMain(), we need to include initialization code
in most all main.cc implementations. This bakes a base initialize call
into the mojo application library.
This fixes a crash in the page cycler set, which happens when a page
tries to do date operations, which fail because of missing locale data.
This fixes several crashes in local runs.
[[This reland disables the sandbox on the page cycler bots because they
don't have a new enough kernel to be sandboxed(!). It also includes the
icu data in the mojo runner unittests.]]
BUG=546644
First Review URL: https://codereview.chromium.org/1425853003
TBR=jam@chromium.org,sky@chromium.org
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/1431133003
Cr-Commit-Position: refs/heads/master@{#359349}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1425853003/ )
Reason for revert:
Failures on Chromium Mojo Linux Perf which appears to be because the perf bots don't have an up to date kernel and on Chromium Mojo Android which has some weird crash.
Original issue's description:
> mandoline: Fix ICU initialization.
>
> We need to complete the initialization of ICU before we raise the
> sandbox. That means we can't pass a file descriptor to the ICU data file
> across mojo pipes. Due to how Android handles resources files, we also
> can't pass a file descriptor around inside the same process. So pass a
> raw pointer to a memory mapped file during the sandbox warm-up phase,
> and make a new option to initialize ICU from this raw pointer.
>
> But that just uncovers a bigger issue: we don't always call what was the
> sandbox warming code. If it's general initialization that needs to be
> called before we run MojoMain(), we need to include initialization code
> in most all main.cc implementations. This bakes a base initialize call
> into the mojo application library.
>
> This fixes a crash in the page cycler set, which happens when a page
> tries to do date operations, which fail because of missing locale data.
> This should let us raise the sandbox on the page cycler.
>
> BUG=546644
>
> Committed: https://crrev.com/e5735ff0a8ddb61672d964a44ebc8a8ebe2b6242
> Cr-Commit-Position: refs/heads/master@{#358904}
TBR=sky@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=546644
Review URL: https://codereview.chromium.org/1429263005
Cr-Commit-Position: refs/heads/master@{#358955}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to complete the initialization of ICU before we raise the
sandbox. That means we can't pass a file descriptor to the ICU data file
across mojo pipes. Due to how Android handles resources files, we also
can't pass a file descriptor around inside the same process. So pass a
raw pointer to a memory mapped file during the sandbox warm-up phase,
and make a new option to initialize ICU from this raw pointer.
But that just uncovers a bigger issue: we don't always call what was the
sandbox warming code. If it's general initialization that needs to be
called before we run MojoMain(), we need to include initialization code
in most all main.cc implementations. This bakes a base initialize call
into the mojo application library.
This fixes a crash in the page cycler set, which happens when a page
tries to do date operations, which fail because of missing locale data.
This should let us raise the sandbox on the page cycler.
BUG=546644
Review URL: https://codereview.chromium.org/1425853003
Cr-Commit-Position: refs/heads/master@{#358904}
|
|
|
|
|
|
|
|
|
|
| |
The problem was that the thunks were being loaded into window_type_launcher executable, instead of the implementation.
BUG=550498
Review URL: https://codereview.chromium.org/1429363002
Cr-Commit-Position: refs/heads/master@{#358462}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resource provider expects to find resources in directories named after
the mojo app followed by resources. If the name doesn't match
resources aren't found.
BUG=none
TEST=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/1426583013
Cr-Commit-Position: refs/heads/master@{#358436}
|
|
|
|
|
|
|
|
|
|
| |
Since state is now shared between apps and the shell, there could be bugs that don't exist in static builds. Running in multi-process (default for Mandoline now) makes this less of an issue, since no apps will share state. There's very little code that runs in the shell in a child process. --single-process works for now, but that could have more issues down the line. For now, this is really a developer productivity feature, just like component build in Chrome.
BUG=550498
Review URL: https://codereview.chromium.org/1410693004
Cr-Commit-Position: refs/heads/master@{#358343}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When run in child process mode, mojo_runner sets thunks in .mojo DLLs that allow various mojo system calls to work. These thunks are only needed for .DLLs loaded in this manner. When the mojo runner launches a standalone executable, the executable should statically link the real implementations of the system calls, not the thunks.
The problem was that there were a couple of client libs that implicitly depended on the thunks. The fix was to make this not be the case and instead:
- standalone executable targets statically link the real implementations (e.g. //mojo/gles2 and //mojo/runner:platform_handle)
- .mojo targets statically link the thunk targets, these dependencies are added automatically by the mojo_application gn target.
R=jam@chromium.org
http://crbug.com/548694
Review URL: https://codereview.chromium.org/1409393008
Cr-Commit-Position: refs/heads/master@{#357646}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated using the following command line:
$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh
BUG=None
R=dpranke@chromium.org,scottmg@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1415753003
Cr-Commit-Position: refs/heads/master@{#357493}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And removes hacks that were necessitated without it.
I also added a converter from a std::string to a URLRequestPtr as I
got tired of creating the URLRequestPtr, then setting url.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1407073002
Cr-Commit-Position: refs/heads/master@{#354392}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for html viewer so that it can know which html_viewer is servicing the request.
BUG=479172,490221
TEST=covered by tests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1311353005
Cr-Commit-Position: refs/heads/master@{#346541}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection.
All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up.
Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency.
I moved a config out of a target in yasm, and sorted a fews deps on other targets.
TBR=xhwang@chromium.org (widevine)
TBR=achuith@chromium.org (tools/perf, tools/telemetry)
Review URL: https://codereview.chromium.org/1318343003
Cr-Commit-Position: refs/heads/master@{#346490}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toolchain.gni introduces:
root_shlib_dir, shlib_prefix, and shlib_extension
The original goal of this change was to put shlibs under lib/ for Linux / Android, since that's where GYP puts them. However, the lack of support for loadable_module (or more specifically - per target output directory) in GN makes this infeasible at the moment.
This change also mitigates a subtle bug where on Android the unstripped .so is used mistakenly instead of the lib.stripped/ version. It also fixes shlib's link_output being set to the unstripped .so rather than the stripped .so (on Android).
BUG=509771
Review URL: https://codereview.chromium.org/1236503002
Cr-Commit-Position: refs/heads/master@{#342697}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The rest of the annotations already live in this package,
so this CL moves CalledByNative, NativeCall, JNIAdditionalImport,
NativeClassQualifiedName and JNINamespace to the same package.
BUG=None
TBR=armansito@chromium.org,asvitkine@chromium.org,atwilson@chromium.org,avayvod@chromium.org,bauerb@chromium.org,boliu@chromium.org,brettw@chromium.org,dtrainor@chromium.org,gunsch@chromium.org,lambroslambrou@chromium.org,mef@chromium.org,mnaganov@chromium.org,mnissler@chromium.org,peter@chromium.org,qinmin@chromium.org,sky@chromium.org,yfriedman@chromium.org,yukawa@chromium.org,zea@chromium.org
Review URL: https://codereview.chromium.org/1263053002
Cr-Commit-Position: refs/heads/master@{#341175}
|
|
|
|
|
|
|
|
|
| |
R=yzshen@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1262613005
Cr-Commit-Position: refs/heads/master@{#340921}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whitelisted applications and interfaces.
Currently, filters are not inherited when a restricted application starts a new application. If I did that immediately there is an opportunity for races if a restricted app starts a trusted app before the trusted broker can. I need to think through that in more detail. For now, any filters must be explicitly specified with every call to ConnectToApplication.
I'm not handling content handlers properly yet in this round. TBD.
http://crbug.com/510210
Review URL: https://codereview.chromium.org/1244233002
Cr-Commit-Position: refs/heads/master@{#340352}
|
|
|
|
|
|
|
|
|
|
| |
ResourceProvider could should use the current module's path instead of deriving it from mojo::resource_provider, since that doesn't work with core_services. This regressed in r338926.
BUG=477435
Review URL: https://codereview.chromium.org/1235393006
Cr-Commit-Position: refs/heads/master@{#339132}
|
|
|
|
|
|
|
|
|
|
| |
This brings the stripped release Linux binary size from 81.2MB to 71.4MB. For comparison, content shell is 75.2MB.
BUG=477435
Review URL: https://codereview.chromium.org/1240493003
Cr-Commit-Position: refs/heads/master@{#338926}
|
|
|
|
|
|
|
|
|
|
| |
With this, ChromePublic now launches with is_component_build = true
BUG=500882
Review URL: https://codereview.chromium.org/1236543004
Cr-Commit-Position: refs/heads/master@{#338612}
|
|
|
|
|
|
|
|
|
|
|
| |
This also replaces a few StartsWithASCII calls with the new StartsWith in cases where the deprecated ASCII version appeared in code I was changing.
NOPRESUBMIT=true
(due to weird include ordering of _kde.cc file which a comment in the file says is required)
Review URL: https://codereview.chromium.org/1202963003
Cr-Commit-Position: refs/heads/master@{#336670}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace).
De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline.
Remove some redundant base:: qualifications in base.
TBR=sky
Review URL: https://codereview.chromium.org/1200053004
Cr-Commit-Position: refs/heads/master@{#335827}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original CL broke the bot with this compile error:
ninja:error: unknown target 'html_viewer_unittests_apk'
This CL also renames the targets to their output names.
(we could also fix *_apk target names, but this seems okay)
Also add mojo_view_manager_lib_unittests to the list.
Description from https://codereview.chromium.org/1145343005
Run Mojo additional unit tests on the "Android GN" bot:
http://build.chromium.org/p/chromium.linux/builders/Android%20GN
(No CQ yet; need Android GN testing support/devices there...)
Add the necessary target mappings to ninja_to_gn.pyl
Similar tests already run on Linux GN and our chromium.mojo FYI:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android
BUG=478244,359249
TEST=Steps run and pass on the bot.
R=dpranke@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/1195623002
Cr-Commit-Position: refs/heads/master@{#335293}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clearly we need a constant somewhere.
BUG=none
TEST=none
R=msw@chromium.org
TBR=msw@chromium.org
Review URL: https://codereview.chromium.org/1186953003
Cr-Commit-Position: refs/heads/master@{#334833}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland https://codereview.chromium.org/1189703004/
Also fix ShellTestBase for mojo_runner_unittests, etc.
Share and copy asset caching code used by ShellMain.java.
Original description (still correct):
Build Mojo apps in subdirectories, like application packages.
Build all <foo>.mojo targets in a <foo> sub-directory.
Support resources bundled in mojo_native_application.
Remove mojo_application_package (now redundant).
Update hard-coded paths and simplify URL resolution code.
Remove apps bundled in core_services from Mandoline.apk
(network service, surfaces service, view manager)
This would help NetworkFetcher resolve app locations.
(Android apptests host the build dir on a local server)
(but apptests should instead bundle apps in an apk)
BUG=498020
TEST=Mojo runner and Mandoline still work (as much as they currently do :-/)
R=scottmg@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/1189703004
Cr-Commit-Position: refs/heads/master@{#334547}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #8 id:160001 of https://codereview.chromium.org/1180653002/)
Reason for revert:
This makes mojo_runner_unittests fail:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/3099/steps/mojo_runner_unittests/logs/stdio
First failure repro steps and output:
build/android/test_runner.py gtest -s mojo_runner_unittests --output-directory=/work/chrome-git/src/out/android_Debug --gtest_filter=ShellTestBaseTest.ConnectBasic
[==========] Running 20 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 7 tests from ShellTestBaseTest
[ RUN ] ShellTestBaseTest.ConnectBasic
[ERROR:application_manager.cc(409)] Library not started because library path '/data/app/org.chromium.native_test-1/lib/arm/tracing/tracing.mojo' does not exist.
[ERROR:application_manager.cc(409)] Library not started because library path '/data/data/org.chromium.native_test/app_test_apps/test_app/test_app.mojo' does not exist.
../../mojo/runner/shell_test_base_unittest.cc:96: Failure
Value of: was_run
Actual: false
Expected: true
../../mojo/runner/shell_test_base_unittest.cc:97: Failure
Value of: service.encountered_error()
Actual: true
Expected: false
E 254.854s 6d40 Test terminated after 120 second timeout.
Original issue's description:
> Build Mojo apps in subdirectories, like application packages.
>
> Build all <foo>.mojo targets in a <foo> sub-directory.
> Support resources bundled in mojo_native_application.
> Remove mojo_application_package (now redundant).
> Update hard-coded paths and simplify URL resolution code.
>
> Remove apps bundled in core_services from Mandoline.apk
> (network service, surfaces service, view manager)
>
> This would help NetworkFetcher resolve app locations.
> (Android apptests host the build dir on a local server)
> (but apptests should instead bundle apps in an apk)
>
> BUG=498020
> TEST=Mojo runner and Mandoline still work (as much as they currently do :-/)
> R=scottmg@chromium.org,sky@chromium.org
>
> Committed: https://crrev.com/e6439a2c956a2f09f40f10e8394a53437ad269ed
> Cr-Commit-Position: refs/heads/master@{#334455}
TBR=scottmg@chromium.org,sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498020
Review URL: https://codereview.chromium.org/1186683008
Cr-Commit-Position: refs/heads/master@{#334478}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build all <foo>.mojo targets in a <foo> sub-directory.
Support resources bundled in mojo_native_application.
Remove mojo_application_package (now redundant).
Update hard-coded paths and simplify URL resolution code.
Remove apps bundled in core_services from Mandoline.apk
(network service, surfaces service, view manager)
This would help NetworkFetcher resolve app locations.
(Android apptests host the build dir on a local server)
(but apptests should instead bundle apps in an apk)
BUG=498020
TEST=Mojo runner and Mandoline still work (as much as they currently do :-/)
R=scottmg@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/1180653002
Cr-Commit-Position: refs/heads/master@{#334455}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused mojo/public/mojo_sdk.gni.
(we use third_party/mojo's version instead)
Update, use mojo/public/ mojo.gni and mojo_application.gni
(to define Chromium's mojo_root, mojo_native_application)
(we'll need a custom mojo_native_application for 498020)
Remove unnecessary imports of related gni files.
BUG=498020
TEST=Build still works as expected; no regressions.
R=sky@chromium.org
TBR=jochen@chromium.org,xhwang@chromium.org
Review URL: https://codereview.chromium.org/1175693002
Cr-Commit-Position: refs/heads/master@{#333600}
|
|
|
|
|
|
|
|
|
|
| |
This makes the inputs and outputs of various Android targets match the dependency tree. There are still 565 errors remaining.
Renames datadeps -> data_deps in some places.
Review URL: https://codereview.chromium.org/1149893018
Cr-Commit-Position: refs/heads/master@{#332424}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GN will soon check inputs and outputs for scripts follow the dependency graph. This fixes some Mojo targets that do not follow this rule.
The checkin to third_party/mojo is a local landing of the upstream patch:
https://github.com/domokit/mojo/commit/55ddc6aed64ba059bd36f598686bd946d56c3334
TBR=cjhopman
This is a separated-out version of files from this patch:
https://codereview.chromium.org/1153183003/#ps20001
which were already reviewed, plus the mojo change which has already been reviewed and landed upstream.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1160343004
Cr-Commit-Position: refs/heads/master@{#332226}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding this. Was reverted due to some type conversion errors
on Win x64 GN dbg (guess because MSVS 2012?)
Just noticed the revert. Will upstream the Mojo fix later.
BUG=None
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1157843002
Cr-Commit-Position: refs/heads/master@{#331246}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This appears to cause build failure.
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/1908
This reverts commit 8ddc364fd10bcfe1a4332f0f66be4e5db84e39b6.
TBR=rockot,jam
BUG=
Review URL: https://codereview.chromium.org/1157573002
Cr-Commit-Position: refs/heads/master@{#331047}
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1142043005
Cr-Commit-Position: refs/heads/master@{#331044}
|
|
|
|
|
|
|
|
|
|
| |
BlockUntilLoaded was called.
I'm seeing this happen in html_viewer when using multiple instances.
Review URL: https://codereview.chromium.org/1152453003
Cr-Commit-Position: refs/heads/master@{#330957}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we were doing them inside html_viewer because NavigatorHost was throwing out that extra data before it got to the network service. The fix is to pass through this url request information.
Also:
-add support for netlog to make debugging network issues easier. Use --log-net-log=file_path
-ensure that mojo shell uses the same user agent as html_viewer. since this UA is sent to websites, they need to match or else there are bugs with Gmail (since it sees different UAs when logging in)
BUG=481153
Review URL: https://codereview.chromium.org/1121783003
Cr-Commit-Position: refs/heads/master@{#330864}
|
|
|
|
|
|
|
|
| |
Some of these files were forked in the initial Mandoline landing. After we forked the application code, we now had two implementations of some of these files. We only need one.
Review URL: https://codereview.chromium.org/1142323003
Cr-Commit-Position: refs/heads/master@{#330690}
|
|
|
|
|
|
|
|
|
|
| |
of application.
That way other targets that depend on it don't have to specify ":application".
Review URL: https://codereview.chromium.org/1136763003
Cr-Commit-Position: refs/heads/master@{#330020}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per in-person discussions, as long as we have a fork of mojo shell we'll fork the interfaces.
I'll do third_party/mojo/src/mojo/public/java/application in a followup.
TBR=tsepez
Review URL: https://codereview.chromium.org/1139123006
Cr-Commit-Position: refs/heads/master@{#329965}
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the resource provider into the main core service process,
too, eliminating one of the processes.
BUG=477435
Review URL: https://codereview.chromium.org/1137223002
Cr-Commit-Position: refs/heads/master@{#329706}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way it won't leak if destroyed. Also cleaned up html_viewer's use
of ResourceLoader.
R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1132083003
Cr-Commit-Position: refs/heads/master@{#329295}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This better matches how html_viewer (and others) will use it.
R=ben@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1130413004
Cr-Commit-Position: refs/heads/master@{#329069}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added support for Android test target output_name in:
https://codereview.chromium.org/1127053003/
BUG=482679
TEST=Android test apks use output_name; work as expected.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1135633002
Cr-Commit-Position: refs/heads/master@{#328852}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
common isn't used here.
R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1128263003
Cr-Commit-Position: refs/heads/master@{#328831}
|
|
|
|
|
|
|
|
|
|
|
|
| |
html_viewer will need this and I suspect others will too.
R=jam@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1125383003
Cr-Commit-Position: refs/heads/master@{#328828}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are only building and running the apptests.
The service wasn't bring built, so the tests would hang.
BUG=NONE
TEST=Clobber; build mandoline:all; mojo_runner mojo:resource_provider_apptests passes.
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/1123363004
Cr-Commit-Position: refs/heads/master@{#328626}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Distribute explicit component data_deps among targets.
Add related test targets to mandoline:tests and mojo:tests.
Remove redundant main waterfall and CQ build targets.
Add mojo/services/test_service meta-target, add to parent.
Rename vm and resource_provider unittests.
Nix obsolete valgrind exception.
BUG=416621
TEST=Building 'mandoline' builds everything needed to run mandoline (no tests). Building mandoline:tests builds all related tests.
R=sky@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1113223002
Cr-Commit-Position: refs/heads/master@{#328619}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessitated by path information on android requiring jni.
R=jam@chromium.org
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1130823002
Cr-Commit-Position: refs/heads/master@{#328597}
|