summaryrefslogtreecommitdiffstats
path: root/components/search
Commit message (Collapse)AuthorAgeFilesLines
* Turn off query in the omnibox.mariakhomenko2015-08-102-82/+3
| | | | | | | | | | Turns off the functionality for Android and iOS. BUG=517297 Review URL: https://codereview.chromium.org/1270343005 Cr-Commit-Position: refs/heads/master@{#342620}
* Partially componentize //chrome/browser/search/search.{h,cc}sdefresne2015-08-038-7/+382
| | | | | | | | | | | | | | | | | | | | | | | | | | Move functions from //chrome/browser/search/search.{h,cc} to the search component //components/search/search.{h,cc} so that they can be shared with iOS. Move all the code in those two files (and supporting unittests) from the "chrome" to the "search" namespace. Move unittests that do not depends on non-componentized functions into the search component. Implements GetSearchTerms() on iOS that uses a web::WebState* instead of content::WebContents and simplify the code to remove unsupported features. Directly use //components/search on iOS instead of the SearchProvider when possible. BUG=514239 TBR=sky,droger,benwells Review URL: https://codereview.chromium.org/1260033003 Cr-Commit-Position: refs/heads/master@{#341525}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+2
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-1/+2
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* Move EndsWith to base namespace.brettw2015-06-121-1/+1
| | | | | | | | TBR=jschuh@chromium.org Review URL: https://codereview.chromium.org/1182183003 Cr-Commit-Position: refs/heads/master@{#334284}
* Remove ShouldHideTopMatchdschuyler2015-06-103-45/+0
| | | | | | | | BUG=492452 Review URL: https://codereview.chromium.org/1154063003 Cr-Commit-Position: refs/heads/master@{#333772}
* Make callers of CommandLine use it via the base:: namespace.avi2014-12-222-3/+3
| | | | | | | | | | | | Covers cloud_print/ and components/. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/818103002 Cr-Commit-Position: refs/heads/master@{#309475}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Review URL: https://codereview.chromium.org/684513002 Cr-Commit-Position: refs/heads/master@{#301931}
* Remove brettw from some owners files.brettw2014-10-021-1/+0
| | | | | | | | TBR=cpu Review URL: https://codereview.chromium.org/626643002 Cr-Commit-Position: refs/heads/master@{#297923}
* Reusing the base::StringPairs in src/components/*kulkarni.a2014-09-301-1/+2
| | | | | | | | | | | Reusing the "base::StringPairs" insted of "std::vector<std::pair<std::string, std::string> >" same is defined in base/strings/string_split.h. BUG=412250 Review URL: https://codereview.chromium.org/593113002 Cr-Commit-Position: refs/heads/master@{#297387}
* Move ShouldHideTopVerbatimMatch to components/searchhashimoto@chromium.org2014-08-123-0/+45
| | | | | | | | | | | | To remove chrome/ dependency from AutocompleteResult BUG=388504 TEST=components_unittest --gtest_filter="ShouldHideTopVerbatimTest.*" Review URL: https://codereview.chromium.org/450663002 Cr-Commit-Position: refs/heads/master@{#288958} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288958 0039d316-1c4b-4281-b951-d872f2087c98
* Moves some functions in search.h to components.mukai@chromium.org2014-07-239-0/+425
These functions are simplistic and doesn't depend on chrome's feature, so there's no reason to be under chrome/browser. Moving to components/ would help further componentization task of autocomplete anad omnibox_field_trials. BUG=371538 R=brettw@chromium.org, pkasting@chromium.org, blundell@chromium.org TBR=tedchoc@chromium.org, jhawkins@chromium.org TEST=build Review URL: https://codereview.chromium.org/393173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284885 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-08-31 05:34:43 +0000