| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are many callers, so all could not be updated at once. The old version is renamed to JSONReader::DeprecatedRead, and a new version of JSONReader::Read that returns scoped_ptr takes its place.
Much of this patch was generated with sed. Some callsites of the form
scoped_ptr<Value> value(Read());
have been updated to
scoped_ptr<Value> value = Read();
but most Read() calls are simply converted to DeprecatedRead. Actually updating them is a TODO.
BUG=none
Review URL: https://codereview.chromium.org/1136643005
Cr-Commit-Position: refs/heads/master@{#331120}
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Previously, when revaliding a cached search provider's logo, the
mime_type of the image and the URL of the animated image to show (if
any) were dropped. This fixes those bugs and adds tests.
BUG=480090
Review URL: https://codereview.chromium.org/1088583005
Cr-Commit-Position: refs/heads/master@{#326664}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clients that already set the async parameter (in this case, with 'cta:1'), will
end up with query strings with two differeny async parameters, instead of a
comma delimited async param.
E.g. converts ?async=cta:1&async=es_dfp:123 -> ?async=cta:1,es_dfp:123
BUG=414528
Review URL: https://codereview.chromium.org/1066923002
Cr-Commit-Position: refs/heads/master@{#324174}
|
| |
|
|
|
|
|
|
| |
BUG=414528
Review URL: https://codereview.chromium.org/1054123002
Cr-Commit-Position: refs/heads/master@{#323754}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/599243002/)
Reason for revert:
The original revert was a mistake. Relanding this with no changed.
Original issue's description:
> Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/)
>
> Reason for revert:
> Caused test failure:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
>
> Original issue's description:
> > Fix doodle verification URL.
> >
> > When verifying that the cached doodle is still valid, we load the doodle
> > URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> > the ":" was being escape to "%3A", causing the server to respond with a
> > 400 error. This mollifies the server by keeping the colon unescaped.
> >
> > BUG=413845
> >
> > Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> > Cr-Commit-Position: refs/heads/master@{#296512}
>
> TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=413845
>
> Committed: https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051
> Cr-Commit-Position: refs/heads/master@{#296546}
TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,groby@chromium.org,jiayl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845
Review URL: https://codereview.chromium.org/606443004
Cr-Commit-Position: refs/heads/master@{#296556}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/587943003/)
Reason for revert:
Caused test failure:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
Original issue's description:
> Fix doodle verification URL.
>
> When verifying that the cached doodle is still valid, we load the doodle
> URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> the ":" was being escape to "%3A", causing the server to respond with a
> 400 error. This mollifies the server by keeping the colon unescaped.
>
> BUG=413845
>
> Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> Cr-Commit-Position: refs/heads/master@{#296512}
TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845
Review URL: https://codereview.chromium.org/599243002
Cr-Commit-Position: refs/heads/master@{#296546}
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When verifying that the cached doodle is still valid, we load the doodle
URL and append the query param "async=es_dfp:<fingerprint>". Previously,
the ":" was being escape to "%3A", causing the server to respond with a
400 error. This mollifies the server by keeping the colon unescaped.
BUG=413845
Review URL: https://codereview.chromium.org/587943003
Cr-Commit-Position: refs/heads/master@{#296512}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The LogoTracker keeps track of the logo for a search provider. The logo
is downloaded, cached on disk, and periodically revalidated.
This code lives inside a component (search_provider_logos) so it can be
used on both Android and iOS.
BUG=178922
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267314
Review URL: https://codereview.chromium.org/162373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267349 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add LogoTracker to fetch search providers' logos.
>
> The LogoTracker keeps track of the logo for a search provider. The logo
> is downloaded, cached on disk, and periodically revalidated.
>
> This code lives inside a component (search_provider_logos) so it can be
> used on both Android and iOS.
>
> BUG=178922
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/162373002
TBR=newt@chromium.org
Review URL: https://codereview.chromium.org/257363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
The LogoTracker keeps track of the logo for a search provider. The logo
is downloaded, cached on disk, and periodically revalidated.
This code lives inside a component (search_provider_logos) so it can be
used on both Android and iOS.
BUG=178922
NOTRY=true
Review URL: https://codereview.chromium.org/162373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267314 0039d316-1c4b-4281-b951-d872f2087c98
|
