summaryrefslogtreecommitdiffstats
path: root/components/signin
Commit message (Collapse)AuthorAgeFilesLines
* Componentize SigninInternalsUtil.blundell@chromium.org2014-03-243-0/+165
| | | | | | | | | | | | No work has to be done other than removing stale includes. This CL also removes stale includes from SigninManagerBase. BUG=334160 TBR=rsleevi Review URL: https://codereview.chromium.org/206753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258851 0039d316-1c4b-4281-b951-d872f2087c98
* Add blundell as temporary OWNER of signin code for refactoring purposes.blundell@google.com2014-03-211-1/+3
| | | | | | | | | BUG=332107 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/208353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258653 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ProfileOAuth2TokenServiceWrapper.blundell@chromium.org2014-03-212-4/+6
| | | | | | | | | | | | | | | | ProfileOAuth2TokenService can now directly be a KeyedService that is shared by iOS, so the wrapper is no longer needed. The two functions for building a FakeProfileOAuth2TokenService for a given BrowserContext are placed in a new fake_profile_oauth2_token_service_builder.* file, since fake_profile_oauth2_token_service will be componentized but those functions will not be. BUG=350709 TBR=thakis Review URL: https://codereview.chromium.org/201123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258616 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize (Mutable)ProfileOAuth2TokenService.blundell@chromium.org2014-03-207-2/+884
| | | | | | | | | | | | | | | | This CL componentizes the following: - ProfileOAuth2TokenService (obsolete references to Profile removed) - MutableProfileOAuth2TokenService (no changes required) - SigninErrorController (no changes required) BUG=334156,333993,334217 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258039 Review URL: https://codereview.chromium.org/201163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258317 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Componentize (Mutable)ProfileOAuth2TokenService. ↵weitaosu@chromium.org2014-03-197-884/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/201163002/) Reason for revert: GetUsageAndQuota fails consistently after this CL: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29 (view as text) SyncFileSystemApiTest.GetUsageAndQuota (run #1): [ RUN ] SyncFileSystemApiTest.GetUsageAndQuota [2716:1648:0319/155948:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined Actual: 0 Expected: 123456 Error at Object.\u003Canonymous> (extensions::test:208:18) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.handleRequest (extensions::binding:55:27) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.\u003Canonymous> (extensions::binding:318:32) at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at safeCallbackApply (extensions::sendRequest:21:15) at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) [2716:1648:0319/155948:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota") Actual: false Expected: true Failed 1 of 1 tests [ FAILED ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam = and GetParam() = (1266 ms) SyncFileSystemApiTest.GetUsageAndQuota (run #2): [ RUN ] SyncFileSystemApiTest.GetUsageAndQuota [4080:2344:0319/161628:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined Actual: 0 Expected: 123456 Error at Object.\u003Canonymous> (extensions::test:208:18) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.handleRequest (extensions::binding:55:27) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.\u003Canonymous> (extensions::binding:318:32) at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at safeCallbackApply (extensions::sendRequest:21:15) at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) [4080:2344:0319/161628:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota") Actual: false Expected: true Failed 1 of 1 tests [4080:2344:0319/161628:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated [4080:2344:0319/161628:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize [ FAILED ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam = and GetParam() = (1422 ms) SyncFileSystemApiTest.GetUsageAndQuota (run #3): [ RUN ] SyncFileSystemApiTest.GetUsageAndQuota [3040:2588:0319/161647:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined Actual: 0 Expected: 123456 Error at Object.\u003Canonymous> (extensions::test:208:18) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.handleRequest (extensions::binding:55:27) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.\u003Canonymous> (extensions::binding:318:32) at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at safeCallbackApply (extensions::sendRequest:21:15) at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) [3040:2588:0319/161647:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota") Actual: false Expected: true Failed 1 of 1 tests [ FAILED ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam = and GetParam() = (1156 ms) SyncFileSystemApiTest.GetUsageAndQuota (run #4): [ RUN ] SyncFileSystemApiTest.GetUsageAndQuota [1028:2272:0319/161650:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined Actual: 0 Expected: 123456 Error at Object.\u003Canonymous> (extensions::test:208:18) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.handleRequest (extensions::binding:55:27) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at Object.\u003Canonymous> (extensions::binding:318:32) at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17) at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) at safeCallbackApply (extensions::sendRequest:21:15) at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) [1028:2272:0319/161650:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0) c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota") Actual: false Expected: true Failed 1 of 1 tests [ FAILED ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam = and GetParam() = (1297 ms) Original issue's description: > Componentize (Mutable)ProfileOAuth2TokenService. > > This CL componentizes the following: > - ProfileOAuth2TokenService (obsolete references to Profile removed) > - MutableProfileOAuth2TokenService (no changes required) > - SigninErrorController (no changes required) > > BUG=334156,333993,334217 > TBR=jochen > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258039 TBR=rogerta@chromium.org,jochen@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=334156,333993,334217 Review URL: https://codereview.chromium.org/205703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258160 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize (Mutable)ProfileOAuth2TokenService.blundell@chromium.org2014-03-197-2/+884
| | | | | | | | | | | | | | This CL componentizes the following: - ProfileOAuth2TokenService (obsolete references to Profile removed) - MutableProfileOAuth2TokenService (no changes required) - SigninErrorController (no changes required) BUG=334156,333993,334217 TBR=jochen Review URL: https://codereview.chromium.org/201163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258039 0039d316-1c4b-4281-b951-d872f2087c98
* components: Rename encryptor directory to os_crypt.tfarina@chromium.org2014-03-182-2/+2
| | | | | | | | | | | | | | Joi suggested doing this rename in a follow up CL ( https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16). So here it is. BUG=341293 TEST=None, no functional changes. R=joi@chromium.org,thestig@chromium.org,bcwhite@chromium.org Review URL: https://codereview.chromium.org/200713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257573 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Profile knowledge from MutableProfileOAuth2TokenServiceblundell@chromium.org2014-03-121-0/+10
| | | | | | | | | | | | | | | | | | | | | This CL removes all remaining calls to profile() in MutableProfileOAuth2TokenService, changing them to be calls on the SigninClient. Concretely, it adds the following APIs to SigninClient: - CanRevokeCredentials() - GetURLRequestContext() Note that the latter is a BrowserContext-level API and thus could go in a driver within the Signin component. However, at the current time it does not appear that there will be any other reason that the Signin component should be a layered component; I would like to avoid adding the extra complexity in internal structure until there is a compelling need for introducing the layering. BUG=334184 Review URL: https://codereview.chromium.org/192373010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256438 0039d316-1c4b-4281-b951-d872f2087c98
* Have MutableProfileOAuth2TokenService get TokenWebData from SigninClientblundell@chromium.org2014-03-111-3/+6
| | | | | | | | | | | | | | | | | This CL starts the process of eliminating PO2TS's direct knowledge of Profile. It makes the following changes: - Adds a method to SigninClient to return the TokenWebData to use - Augments PO2TS::Initialize() to take in a SigninClient to use - Changes MO2TS to get the TokenWebData from the SigninClient rather than the Profile - [cleanup] Eliminates an unused method from the SigninClient interface BUG=334184 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/192323008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256184 0039d316-1c4b-4281-b951-d872f2087c98
* Rename SigninManagerDelegate to SigninClientblundell@chromium.org2014-03-101-7/+7
| | | | | | | | | | | | | | This renaming puts the Signin embedder interface in line with the agreed-upon convention wherein a component Foo's embedder interface should be named FooClient. ChromeSigninManagerDelegate is similarly renamed to ChromeSigninClient, and variable names are updated. BUG=334168 TBR=joi Review URL: https://codereview.chromium.org/192253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255903 0039d316-1c4b-4281-b951-d872f2087c98
* Rename components's Encryptor to OSEncrypt.tfarina@chromium.org2014-02-281-3/+3
| | | | | | | | | | | | | To avoid confusion with the Encryptor class that exists under crypto/. BUG=341293 TEST=None R=joi@chromium.org,bcwhite@chromium.org TBR=thestig Review URL: https://codereview.chromium.org/183953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254177 0039d316-1c4b-4281-b951-d872f2087c98
* Move encryptor API out of webdata.tfarina@chromium.org2014-02-212-2/+2
| | | | | | | | | | | | | | This justs moves encryptor out of components/webdata/encryptor one layer up to components/encryptor. BUG=341293 TEST=None R=thestig@chromium.org,joi@chromium.org,bcwhite@chromium.org TBR=rvargas Review URL: https://codereview.chromium.org/168993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252563 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize SigninManagerCookieHelper.blundell@chromium.org2014-01-212-0/+138
| | | | | | | | | | | | | This CL eliminates content::BrowserThread dependencies from SigninManagerCookieHelper by injecting the required threads. It additionally moves SigninManagerCookieHelper into //components/signin. BUG=334206 TBR=joi Review URL: https://codereview.chromium.org/135183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245955 0039d316-1c4b-4281-b951-d872f2087c98
* Move SigninManagerDelegate into the Signin component.blundell@chromium.org2014-01-101-0/+19
| | | | | | | | | | | | This interface is intended for embedders to supply to the Signin component. It had been created during an earlier aborted effort to componentize Signin. BUG=332107 TBR=joi Review URL: https://codereview.chromium.org/132083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244139 0039d316-1c4b-4281-b951-d872f2087c98
* Create signin component and componentize TokenWebData.blundell@chromium.org2014-01-098-0/+486
| | | | | | | | | | | | | | | | | | | | | | This CL creates the signin layered component. It additionally componentizes TokenWebData and moves it into the signin component. The refactorings performed on TokenWebData are identical to ones performed on AutofillWebDataService: - threads are injected rather than being obtained from content::BrowserThread - //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory instead of TokenWebData::FromBrowserContext. This CL is an unchanged reland of https://codereview.chromium.org/109783003/, which had been speculatively reverted to see if it was causing ChromeOS build failures. The speculative revert unfortunately stuck as it happened to land in the same run as the CL that actually fixed the (unrelated) ChromeOS build failures: https://codereview.chromium.org/129343003/. BUG=332107 TBR=noamsml Review URL: https://codereview.chromium.org/130813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/109783003/noamsml@chromium.org2014-01-088-486/+0
| | | | | | | | | | | | | | | | | | | | Reason for revert: ChromeOS bot failures, example http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19049 Failing lines: /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry [ FAILED ] /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',) /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry [ FAILED ] /tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',) TBR=joi@chromium.org,rogerta@chromium.org,tfarina@chromium.org,thakis@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=332107 Review URL: https://codereview.chromium.org/129253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243687 0039d316-1c4b-4281-b951-d872f2087c98
* Create signin component and componentize TokenWebData.blundell@chromium.org2014-01-088-0/+486
This CL creates the signin layered component. It additionally componentizes TokenWebData and moves it into the signin component. The refactorings performed on TokenWebData are identical to ones performed on AutofillWebDataService: - threads are injected rather than being obtained from content::BrowserThread - //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory instead of TokenWebData::FromBrowserContext. BUG=332107 TBR=thakis Review URL: https://codereview.chromium.org/109783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243564 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 03:32:54 +0000