summaryrefslogtreecommitdiffstats
path: root/components/signin
Commit message (Collapse)AuthorAgeFilesLines
* Fix WeakPtrFactory member in SSOAccessTokenFetcherdmichael2015-01-141-3/+3
| | | | | | | | | | | | | This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/827093006 Cr-Commit-Position: refs/heads/master@{#311408}
* Optimize reconcilor account change detection.rogerta2015-01-132-15/+7
| | | | | | | | | | Cleanup the way the reconcilor checks external connections. BUG=442395 Review URL: https://codereview.chromium.org/814003004 Cr-Commit-Position: refs/heads/master@{#311273}
* New Profile metric for Auth Errors.mlerman2015-01-093-0/+13
| | | | | | | | | | | | This will capture how many profiles are in an Auth Error state and which auth error the profiles are in. This is comparable with Profile.NumberOfProfiles and Profile.NumberOfSignedInProfiles. BUG=434829 Review URL: https://codereview.chromium.org/813133003 Cr-Commit-Position: refs/heads/master@{#310848}
* Make the SigninErrorController a PKS.mlerman2015-01-099-50/+61
| | | | | | | | | | This is a prelude to https://codereview.chromium.org/813133003/, which will introduce some dependencies between the SigninErrorController and some other PKSes. To make these cleaner, this is a yak shave to move the SigninErrorController out from being a member of the ProfileOAuth2TokenService (which is a ProfileKeyedService) and into its own PKS. BUG=434829 Review URL: https://codereview.chromium.org/809313009 Cr-Commit-Position: refs/heads/master@{#310774}
* AccountTrackerService needs to manually enable Network Fetches.mlerman2015-01-083-5/+65
| | | | | | | | | | | | AccountTrackerService, when instantiated during Profile startup, can attempt network calls before all services all ready. This is prevented by created a specific EnableNetworkFetches() method which is called by the Profile once KeyedServices are initialized. This is a re-land of https://codereview.chromium.org/805883002/ (which was reverted) with the addition that on Android the AccountTrackerService still only executes a fetch if there's no gaia-id. BUG=442011, 441399, 432286 Review URL: https://codereview.chromium.org/812413002 Cr-Commit-Position: refs/heads/master@{#310629}
* Enable webview-based sign-in to chrome.rogerta2015-01-073-6/+12
| | | | | | | | BUG=441821 Review URL: https://codereview.chromium.org/795873004 Cr-Commit-Position: refs/heads/master@{#310404}
* Make callers of CommandLine use it via the base:: namespace.avi2014-12-223-17/+16
| | | | | | | | | | | | Covers cloud_print/ and components/. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/818103002 Cr-Commit-Position: refs/heads/master@{#309475}
* replace COMPILE_ASSERT with static_assert in components/mostynb2014-12-221-2/+2
| | | | | | | | BUG=442514 Review URL: https://codereview.chromium.org/794683005 Cr-Commit-Position: refs/heads/master@{#309464}
* Controll RefreshTokenAnnotationRequest through Finch experimentpavely2014-12-184-12/+48
| | | | | | | | | | | | | In this change: - code to enable RefreshTokenAnnotationRequest through FinchExperiment - UMA historgam to measure success rate of request R=rogerta@chromium.org,isherman@chromium.org BUG=382968 Review URL: https://codereview.chromium.org/791743007 Cr-Commit-Position: refs/heads/master@{#308927}
* Clean up straggler classes to use embedded signin in page in the new ↵noms2014-12-172-0/+83
| | | | | | | | | | | | | | | | profiles world. (namely the Bookmarks/Extension promos, and the Apps page signin link) Unfortunately this lead to discovering that the old Signin histograms that tracked the source of the signin page were broken, since the signin source is now always the avatar menu. So I cleaned up that. BUG=378792 Review URL: https://codereview.chromium.org/777143003 Cr-Commit-Position: refs/heads/master@{#308871}
* Revert of AccountTrackerService needs to manually enable Network Fetches. ↵mlerman2014-12-173-65/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:100001 of https://codereview.chromium.org/805883002/) Reason for revert: Causes Clank Crashes. Original issue's description: > AccountTrackerService needs to manually enable Network Fetches. > > AccountTrackerService, when instantiated during Profile startup, can > attempt network calls before all services all ready. This is prevented > by created a specific EnableNetworkFetches() method which is called > by the Profile once KeyedServices are initialized. > > BUG=442011, 441399 > > Committed: https://crrev.com/2962ddd760bcd956b1459fc63099980569d257f4 > Cr-Commit-Position: refs/heads/master@{#308816} TBR=rogerta@chromium.org,noms@chromium.org NOTREECHECKS=true NOTRY=true BUG=442011, 441399 Review URL: https://codereview.chromium.org/808213002 Cr-Commit-Position: refs/heads/master@{#308858}
* AccountTrackerService needs to manually enable Network Fetches.mlerman2014-12-173-11/+65
| | | | | | | | | | | | | AccountTrackerService, when instantiated during Profile startup, can attempt network calls before all services all ready. This is prevented by created a specific EnableNetworkFetches() method which is called by the Profile once KeyedServices are initialized. BUG=442011, 441399 Review URL: https://codereview.chromium.org/805883002 Cr-Commit-Position: refs/heads/master@{#308816}
* Fix remaining WeakPtrFactory ordering problems in preparation for turning on ↵dmichael2014-12-122-4/+4
| | | | | | | | | | | | | | | the check. WeakPtrFactory members should always be last so that they invalidate WeakPtrs prior to other destructors running. These are mostly trivial/mechanical ones. (We'll also need https://codereview.chromium.org/795003003/, which I split out) BUG=303818 TBR=rockot,vitalybuka,cbentzel,shess,dmazzoni,stanisc,sky,tim,mathp,benjhayden,kinuko,scottmg,sergeyu,zork,ddorwin Review URL: https://codereview.chromium.org/780713002 Cr-Commit-Position: refs/heads/master@{#308137}
* Removing profiler instrumentations for task ↵vadimt2014-12-114-75/+0
| | | | | | | | | | | | | | | | WebDataRequestManager::RequestCompletedOnThread since the jank has been fixed. I'm doing this manually, so please review. Not reverting changes automatically, since the instrumentations sat in the code long enough (up to ~2 months), and there were totally 13 CLs with instrumentations, so reverting can easily become very messy. Please review. BUG=422460 Review URL: https://codereview.chromium.org/784613002 Cr-Commit-Position: refs/heads/master@{#307813}
* No UserInfo fetch on Android before ProfileInfo::DoFinalInit.Mike Lerman2014-12-091-0/+6
| | | | | | | | | BUG=440109,432286 R=rogerta@chromium.org Review URL: https://codereview.chromium.org/792633003 Cr-Commit-Position: refs/heads/master@{#307543}
* Send RefreshTokenAnnotationRequestpavely2014-12-0810-13/+373
| | | | | | | | | | | | | | | | | | | | This is needed to backfill device_ids for refresh tokens issued pre-M38. With this change chrome periodically sends request to IssueToken endpoint passing device_id to it. - Request is only sent for desktop platforms - Request is only sent when profile is opened - Average interval between requests is 10 days This functionality is currently disabled by default and controlled by command line parameter. In the future change it will be enabled by default and controlled by Finch experiment. R=rogerta@chromium.org BUG=382968 Review URL: https://codereview.chromium.org/785633002 Cr-Commit-Position: refs/heads/master@{#307357}
* Fix Memory - initialize variablesmlerman2014-12-071-1/+3
| | | | | | | | | | BUG=432286 TBR=rogerta@chromium.org NOTRY=TRUE Review URL: https://codereview.chromium.org/768633004 Cr-Commit-Position: refs/heads/master@{#307190}
* The Account Tracker now collects Hosted Domain information. The Signinmlerman2014-12-079-69/+209
| | | | | | | | | | | | | | | | | | Manager observes the Account Tracker, so that a new PostSignedIn method is called only after both OnSignedIn is done and the AccountTrackerService has called ClientInfo. This is used to save a hash of the user's password only when Profile Lock is available. The next CL will clean up the GAIAInfoUpdateService, ProfileDownloader and profile_window so that the hosted_domain is only acquired through the AccountTracker. (TBR of pavely@ and bartfab@ since their files only involve specifying fake signin factories for unit tests) BUG=432286 TBR=pavely@chromium.org, bartfab@chromium.org Review URL: https://codereview.chromium.org/753243003 Cr-Commit-Position: refs/heads/master@{#307188}
* Avoid checking that merge session helper is running when starting a reconcile.msarda2014-12-041-2/+3
| | | | | | | | | | | | This CL starts a reconcile operation even though the merge session helper is running. This ensures that if the merge session helper is in performing a logout operation, it will continue with a reconcile operation afterwards. BUG=438260 Review URL: https://codereview.chromium.org/775283002 Cr-Commit-Position: refs/heads/master@{#306815}
* gn format //componentsscottmg2014-12-032-4/+1
| | | | | | | | | | | No intended functionality change. R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/780633002 Cr-Commit-Position: refs/heads/master@{#306640}
* Early return in AboutSigninInternals::NotifyObservers if there are no observers.vadimt2014-12-021-0/+3
| | | | | | | | | | There is no need to run the code that calls AboutSigninInternals::SigninStatus::ToValue() if there is no one listening. BUG=422460 Review URL: https://codereview.chromium.org/766223003 Cr-Commit-Position: refs/heads/master@{#306397}
* Account tracker service should not run in supervised profiles.rogerta2014-11-281-0/+7
| | | | | | | | BUG=422145 Review URL: https://codereview.chromium.org/735773003 Cr-Commit-Position: refs/heads/master@{#306078}
* Instrumenting the loop inside AboutSigninInternals::SigninStatus.vadimt2014-11-261-0/+16
| | | | | | | | | | Prior instrumentations show that almost all jank is in side the loop (22.2 jph). BUG=422460 Review URL: https://codereview.chromium.org/746763005 Cr-Commit-Position: refs/heads/master@{#305909}
* Instrumenting signin internals.vadimt2014-11-241-1/+28
| | | | | | | | | | | | | | | | Earlier instrumentations showed that the jank happens in these lines inside AboutSigninInternals::NotifyObservers(): scoped_ptr<base::DictionaryValue> signin_status_value = signin_status_.ToValue(client_->GetProductVersion()); but outside other instrumentations, like in VersionInfo::GetVersionStringModifier. Instrumenting the code to learn more about the location of the jank. BUG=422460 Review URL: https://codereview.chromium.org/754113003 Cr-Commit-Position: refs/heads/master@{#305518}
* Adding instrumentation to locate the source of jankiness.vadimt2014-11-201-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior instrumentations showed that most of the jank for this bug comes from these lines in AboutSigninInternals::NotifyObservers scoped_ptr<base::DictionaryValue> signin_status_value = signin_status_.ToValue(client_->GetProductVersion()); Note that at least in Windows Canary, there are always 0 observers, and the value that we are calculating using a janky call is not used. I'm almost certain that the cause of jank is in VersionInfo::GetVersionStringModifier, but I'm adding this last instrumentation to be 100% sure. Reviewers, please feel free to stop me and start fixing the jank if you already know what's happening. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=422460 Review URL: https://codereview.chromium.org/740783004 Cr-Commit-Position: refs/heads/master@{#305049}
* Adding instrumentation to locate the source of jankiness.vadimt2014-11-131-0/+11
| | | | | | | | | | | | | | | | | | | | | | Prior instrumentations showed that invoking OnAccessTokenRequested observers in OAuth2TokenService::StartRequestForClientWithContext alone is responsible for 23.5 janks per hour in UI thread. I need to instrument the code inside it to find out which part causes jank. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=422460 Review URL: https://codereview.chromium.org/721523002 Cr-Commit-Position: refs/heads/master@{#304056}
* Disable new avatar menu when web-based signin is onguohui2014-11-121-2/+7
| | | | | | | | BUG=431866 Review URL: https://codereview.chromium.org/718793002 Cr-Commit-Position: refs/heads/master@{#303760}
* Seed the account tracker with gaia_id/email before performing sign in.rogerta2014-11-101-0/+4
| | | | | | | | | | | | | | | This CL is part of moving chrome to using gaia ids to unique identity google accounts internally instead of using email address, since the later can change over the life of an account and because there are different normalizations of the email, which makes comparisons difficult. When chrome finally switches over, it needs a way to map gaia ids to show in UI. For this reason, making sure the mapping exists before sign-in happens is important. This CL represents step 5 in my design doc for this migration: https://docs.google.com/a/google.com/document/d/1WIXhEalgwvp3ouG4uTLy8YQOeqxa_zPHsv6wtBu3kWQ/edit# BUG=341408 Review URL: https://codereview.chromium.org/705603004 Cr-Commit-Position: refs/heads/master@{#303475}
* Fix AboutSigninInternals::TokenInfo::LessThanwittman2014-11-081-1/+2
| | | | | | | | | | | | The existing logic produces inconsistent ordering under transpose of the arguments if a->consumer_id < b->consumer_id and b->scopes < a->scopes. BUG= Review URL: https://codereview.chromium.org/710753002 Cr-Commit-Position: refs/heads/master@{#303355}
* Cleanup: Remove unneeded path_service.h includes.thestig2014-11-061-1/+0
| | | | | | Review URL: https://codereview.chromium.org/689563002 Cr-Commit-Position: refs/heads/master@{#303095}
* Fix incorrect normalization of email address in hotdog menu, settings page,rogerta2014-11-062-5/+13
| | | | | | | | | | and reauth flow. BUG=426771 Review URL: https://codereview.chromium.org/704643002 Cr-Commit-Position: refs/heads/master@{#302958}
* A recent change to account reconcilor makes it execute more quickly, not ↵rogerta2014-11-064-13/+34
| | | | | | | | | | allowing enough time for checking connections to external websites. Change the reconcilor to do the check first and then proceed. BUG= Review URL: https://codereview.chromium.org/697403003 Cr-Commit-Position: refs/heads/master@{#302928}
* Account reconcilor: Use cookie store cookie changed subscription.msarda2014-11-047-36/+47
| | | | | | | | | | | | | | | | | | | This CL changes the account reconcilor to use the new cookie store API that allows clients to adds callback for cookie changed events. It adds logic to the chrome sign-in client to register for cookie changed events on the IO thread and call the cookie changed callback on the main thread. Note that in order to access the cookie store, we need to use the URL context which can only be used on the IO thread. Subscribing for cookie change events requires thus a thread jump to the IO thread on all platforms. BUG=NONE Review URL: https://codereview.chromium.org/695553002 Cr-Commit-Position: refs/heads/master@{#302639}
* Switching profiler instrumentations from ScopedProfile to ScopedTracker. ↵vadimt2014-10-293-9/+9
| | | | | | | | | | | | This will disable the instrumentations in all channels except Canary, and developer build. Instrumentations are only enabled in Browser process. This will prevent Stable from sending increased amounts of UMA logs. Also, this will let us observe "true" (untouched by instrumentations) jankiness numbers every week in Dev channel. BUG=401560 Review URL: https://codereview.chromium.org/686963002 Cr-Commit-Position: refs/heads/master@{#301950}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-294-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Review URL: https://codereview.chromium.org/684513002 Cr-Commit-Position: refs/heads/master@{#301931}
* Fix a typo in an OAuth2TokenService classnamejamescook2014-10-272-6/+6
| | | | | | | | | | | Also fix some linter errors. BUG=none TEST=compiles Review URL: https://codereview.chromium.org/681483003 Cr-Commit-Position: refs/heads/master@{#301378}
* Implement signin using webviewguohui2014-10-245-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL implements the Chrome signin on desktop using webview. Since the webview approach is significantly different than the current iframe one, thus I created a fork of some files instead of adding more logic to the existing over-complicated code. The feature is enabled under a flag --enable-webview-based-signin. Once the feature is fully launched on both dekstop and ChromeOS, the old files should be deleted. There are a few known issues. 1. Gaia needs to update their script to post credentials directly to chrome://chrome-signin instead of the gaia auth extension. Before the gaia code is updated, webview signin cannot scrape password and the checkbox value for choosing what to sync. 2. Webview currently only loads in a full tab, need to investigate why it doesn't work when embedded in the avatar menu. 3. Some webview apis are broken in an extension-less webui context. https://codereview.chromium.org/670173002/ fixes a few that are required for a minimum desktop signin flow. One important missing piece is the extension messaging api, and as a result Gnubby does not work with a webview, tracked in crbug/426016. 4. Some standard WebUI features are missing, such as zoom, find, print preview, need to decide whether it is worth to support them. 5. Webview is not fully accessibility proof. According to webview team, most accessibility bugs have been fixed by the accessibility team (crbug/330307, crbug/368298), need to confirm. 6. This CL only implements the desktop signin flow. The ChromeOS signin flow is a superset of the desktop one, and ChromeOS team needs to add extra logic to complete it for ChromeOS. BUG=364432 Review URL: https://codereview.chromium.org/646983008 Cr-Commit-Position: refs/heads/master@{#301130}
* Revert of Revert of Inline sign in extracts gaia id from HTTP header and ↵nkostylev2014-10-243-0/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | seeds account tracker (patchset #1 id:1 of https://codereview.chromium.org/671183002/) Reason for revert: White success page and no way to proceed only reproduces for use_athena=1 builds. This CL fixes that: https://codereview.chromium.org/642693003/ Re-landing. Original issue's description: > Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #46 id:1740001 of https://codereview.chromium.org/473153002/) > > Reason for revert: > This breaks Chrome OS GAIA login. > > After successful GAIA authentication uses sees blank white page and nothing happens. > > Please build chromeos=1 build and check that sign in as new user works fine before relanding this CL. Unfortunately autotests rely on fake gaia server and doesn't check this end-to-end sign in flow. > > Original issue's description: > > Inline login handler extracts gaia id from HTTP header and seeds account tracker > > service during sign in. > > > > BUG=341408 > > > > Committed: https://crrev.com/a8e7c94b1b79a0948d05a1fcfff53391d22ce37a > > Cr-Commit-Position: refs/heads/master@{#300750} > > TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=341408 > > Committed: https://crrev.com/bbaf207927765f4b7c7cae2a4af8db6c4c4a67ce > Cr-Commit-Position: refs/heads/master@{#300873} TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org NOTREECHECKS=true NOTRY=true BUG=341408 Review URL: https://codereview.chromium.org/677703002 Cr-Commit-Position: refs/heads/master@{#301099}
* Revert of Inline sign in extracts gaia id from HTTP header and seeds account ↵nkostylev2014-10-233-74/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | tracker (patchset #46 id:1740001 of https://codereview.chromium.org/473153002/) Reason for revert: This breaks Chrome OS GAIA login. After successful GAIA authentication uses sees blank white page and nothing happens. Please build chromeos=1 build and check that sign in as new user works fine before relanding this CL. Unfortunately autotests rely on fake gaia server and doesn't check this end-to-end sign in flow. Original issue's description: > Inline login handler extracts gaia id from HTTP header and seeds account tracker > service during sign in. > > BUG=341408 > > Committed: https://crrev.com/a8e7c94b1b79a0948d05a1fcfff53391d22ce37a > Cr-Commit-Position: refs/heads/master@{#300750} TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org NOTREECHECKS=true NOTRY=true BUG=341408 Review URL: https://codereview.chromium.org/671183002 Cr-Commit-Position: refs/heads/master@{#300873}
* Inline login handler extracts gaia id from HTTP header and seeds account trackerrogerta2014-10-223-0/+74
| | | | | | | | | | service during sign in. BUG=341408 Review URL: https://codereview.chromium.org/473153002 Cr-Commit-Position: refs/heads/master@{#300750}
* Standardize usage of virtual/override/final in components/dcheng2014-10-2121-167/+146
| | | | | | | | | BUG=417463 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/666133002 Cr-Commit-Position: refs/heads/master@{#300456}
* Adding instrumentation to locate the source of jankinessvadimt2014-10-202-0/+12
| | | | | | | | | | | | | | | Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. Landing as TBR since this is a mechanical, safe and temporary change. This CL instruments most popular OnRefreshTokenAvailable overrides. BUG=422460 TBR=jam@chromium.org, zelidrag@chromium.org, erikwright@chromium.org Review URL: https://codereview.chromium.org/643183003 Cr-Commit-Position: refs/heads/master@{#300361}
* Convert ARRAYSIZE_UNSAFE -> arraysize in components/.viettrungluu2014-10-161-2/+2
| | | | | | | | BUG=423134 Review URL: https://codereview.chromium.org/658993002 Cr-Commit-Position: refs/heads/master@{#299934}
* Mechanical change that adds instrumentation required to locate the source of ↵vadimt2014-10-101-0/+6
| | | | | | | | | | | | | | jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. Landing as TBR since this is a mechanical, safe and temporary change. BUG=422460 TBR=isherman@chromium.org, caitkp@chromium.org Review URL: https://codereview.chromium.org/647123002 Cr-Commit-Position: refs/heads/master@{#299198}
* Make sure GetAuthenticatedAccountId() returns a canonicalized id.rogerta2014-10-098-23/+66
| | | | | | | | | | | | This CL is a prerequisite for: https://codereview.chromium.org/473153002/ BUG=341408 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/617183003 Cr-Commit-Position: refs/heads/master@{#298996}
* Users with Web Login Required can still unlock with their password.mlerman2014-10-091-0/+1
| | | | | | | | | BUG=421512 TBR=dzhioev@chromium.org Review URL: https://codereview.chromium.org/634303002 Cr-Commit-Position: refs/heads/master@{#298964}
* change newly added OVERRIDE to override in components/mostynb2014-10-091-5/+5
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/640903002 Cr-Commit-Position: refs/heads/master@{#298870}
* Clear the password hash (used for unlock) upon signout.mlerman2014-10-074-5/+5
| | | | | | | | BUG=416865 Review URL: https://codereview.chromium.org/620093005 Cr-Commit-Position: refs/heads/master@{#298482}
* replace OVERRIDE and FINAL with override and final in components/mostynb2014-10-0623-128/+128
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623133002 Cr-Commit-Position: refs/heads/master@{#298237}
* Add OAuth2TokenServiceObserverBridge.msarda2014-10-033-0/+106
| | | | | | | | | | | This CL adds a C++ to Objective-C bridge for the OAuth2TokenService observers. BUG=NONE Review URL: https://codereview.chromium.org/620553013 Cr-Commit-Position: refs/heads/master@{#298035}
generated by cgit v1.1 at 2025-02-11 05:47:30 +0000