| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #16 id:320001 of https://codereview.chromium.org/1272113002/ )
Reason for revert:
Broken build.
http://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/17899/steps/compile/logs/stdio
Original issue's description:
> Allow url::SchemeHostPort to hold non-file scheme without port
>
> WebSockets use url::Origin to pass origin info between renderer and
> browser. Currently, it cannot hold an origin with non-file scheme and
> no port. Chrome extensions have been using such origins, so we need
> to keep the channel to convey origin info work for such origins.
>
> BUG=516971
> R=sleevi,brettw
>
> Committed: https://crrev.com/1ac9ec7bccd1b5178b18338b10149f36292f5fb6
> Cr-Commit-Position: refs/heads/master@{#343895}
TBR=rsleevi@chromium.org,mkwst@chromium.org,brettw@chromium.org,tyoshino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516971
Review URL: https://codereview.chromium.org/1301563003
Cr-Commit-Position: refs/heads/master@{#343898}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSockets use url::Origin to pass origin info between renderer and
browser. Currently, it cannot hold an origin with non-file scheme and
no port. Chrome extensions have been using such origins, so we need
to keep the channel to convey origin info work for such origins.
BUG=516971
R=sleevi,brettw
Review URL: https://codereview.chromium.org/1272113002
Cr-Commit-Position: refs/heads/master@{#343895}
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1287433002
Cr-Commit-Position: refs/heads/master@{#342911}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=479172,490221
TEST=covered by tests
R=fsamuel@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1280743004
Cr-Commit-Position: refs/heads/master@{#342642}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a frame is navigated we immediately swap it to remote and then
call Embed(). It's possible Embed() will callback to the same app, in
which case we need to convert the frame from remote to local. This
change does this.
The result of this change is that HTMLFrame implements FrameTreeClient
and forwards to HTMLFrameTreeManager. HTMLFrameTreeManager may end up
containing multiple local frames, each having it's own
connection. HTMLFrameTreeManager is destroyed only when the root is
destroyed, or there are no more local roots.
The code would likely be cleaner if the blink parts were separated
out and HTMLFrame* were effectively a client lib. I'll consider that
once I get everything working smoothly.
BUG=479172,490221
TEST=covered by tests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1254973006
Cr-Commit-Position: refs/heads/master@{#340954}
|
|
|
|
|
|
|
|
|
|
|
|
| |
AccountManager.
Based on http://crrev.com/1224643007
BUG=508054
Review URL: https://codereview.chromium.org/1231653007
Cr-Commit-Position: refs/heads/master@{#340774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The IO thread constructor reads preferences that are set from policies, so Chrome
should read the policies before the IO thread constructor is called.
Two parts to this:
1 - create a persistant policy cache and read it cache synchronously
2 - reorder various things so that the Android PolicyManager and PolicyProviders
are created earlier in startup.
Also merge (C++) PolicyProviderAndroid into PolicyManager and add Junit tests
for the Java PolicyManager.
TBR=nyquist
BUG=510813
Review URL: https://codereview.chromium.org/1239323002
Cr-Commit-Position: refs/heads/master@{#340265}
|
|
|
|
|
|
|
|
|
|
|
| |
When automatically generating a new search engine, convert keywords
and short names from punycode to unicode.
BUG=510832
Review URL: https://codereview.chromium.org/1238683003
Cr-Commit-Position: refs/heads/master@{#340053}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving test-code to a separete component, so that adding more test-only
dependencies does not affect non-test code.
BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jam@ for non-ui/gl/ changes, since trivial #include/gyp-gn updates
Review URL: https://codereview.chromium.org/1238443004
Cr-Commit-Position: refs/heads/master@{#339539}
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, the JSON sanitizer parses the untrusted JSON in Java and checks it for wellformedness before serializing it again. On desktop platforms it uses SafeJsonParser to parse the JSON out of process, then serializes it again.
Also, on Android (where JsonSanitizer is not implemented in terms of the SafeJsonParser) the SafeJsonParser now uses the JsonSanitizer to sanitize its input before parsing it directly in process, instead of starting a new process, which is very costly on Android.
BUG=501333
Review URL: https://codereview.chromium.org/1203083002
Cr-Commit-Position: refs/heads/master@{#338495}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patrick left the project in May 2014, and the last patch he landed was
in June 2014. https://codereview.chromium.org/1220543002/#msg17 is the
most recent example of someone being confused by the OWNERS file into
believing that he's still actively reviewing code.
R=vabr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1213163004
Cr-Commit-Position: refs/heads/master@{#336758}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm making the test code use mandoline/tab as that dramatically
simplifies things, and lets me test that code too.
I'm also creating a testing interface for HTMLViewer. It's only
available if a command line flag is supplied. For now it's simple, but
I'm going to add more to it (such as injecting JS).
BUG=479172,490221
TEST=mostly test change
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1210323002
Cr-Commit-Position: refs/heads/master@{#336668}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The invalidation component has dependencies due to specific
implementations of the inv_client, inv_service etc.
Consumers of invalidations do not need to depend on these.
This change exports the InvalidationHandler interface in a separate target
'invalidation_public' which only depends on //google/cacheinvalidation
Thus the signin component can implement to InvalidationHandler to refresh
account information without introducing a cyclic dependency.
The crux of the change is:
Move {components/invalidation/ => components/invalidation/public}:
-ack_handle.cc
-ack_handle.h
-ack_handler.cc
-ack_handler.h
-invalidation.cc
-invalidation.h
-invalidation_export.h
-invalidation_handler.cc
-invalidation_handler.h
-invalidation_service.h
-invalidation_util.cc
-invalidation_util.h
-invalidator_state.cc
-invalidator_state.h
-object_id_invalidation_map.cc
-object_id_invalidation_map.h
-single_object_invalidation_set.cc
-single_object_invalidation_set.h
Move {components/invalidation/ => components/invalidation/impl}:
other files
Thus the dependency chain is:
//chrome/browser/ -> //components/invalidation/impl -> components/invalidation/public
Now invalidation consumers can directly depend on //components/invalidation/public
which has only //google/cacheinvalidation has a dependency.
BUG=503131
Review URL: https://codereview.chromium.org/1191393008
Cr-Commit-Position: refs/heads/master@{#336413}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's used only for locale pack files now, so shouldn't require so much
attention.
This also removes the extraction args from
ComponentsBrowserTestsApplication.java, which don't appear to be
necessary
BUG=
Review URL: https://codereview.chromium.org/1181733004
Cr-Commit-Position: refs/heads/master@{#336020}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Optimized 57/75 files in 00:16:27s
Result: 312874 => 164569 bytes (148305 bytes: 47%)
BUG=503732
TBR=benwells@chromium.org,sdefresne@chromium.org
Review URL: https://codereview.chromium.org/1203993002
Cr-Commit-Position: refs/heads/master@{#335959}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
assets""
This reverts commit bd0057ca4ca5990173e099f5cdd5219c6ed72fd5.
Also adds a "setMandatoryPaksToExtract" overload to prevent breakage.
BUG=371610
TBR=Yaron, Torne, cjhopman, Jaekyun Seok, James Hawkins, gunsch, newt
Review URL: https://codereview.chromium.org/1198193006
Cr-Commit-Position: refs/heads/master@{#335538}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f30e04470453ccd7e6a9abf586185b991d174902.
This change breaks android TOT bot
TBR=yfriedman@chromium.org,torne@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,jhawkins@chromium.org,gunsch@chromium.org,newt@chromium.org,agrieve@chromium.org
BUG=371610
Review URL: https://codereview.chromium.org/1200583002
Cr-Commit-Position: refs/heads/master@{#335432}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix and suppress a bunch of lint warnings to be able to enable
lint build failing.
TBR=boliu@chromium.org,pauljensen@chromium.org,tedchoc@chromium.org,lambroslambrou@chromium.org,damienv@chromium.org
BUG=501471,241521,501591,501593,501900,502030
Review URL: https://codereview.chromium.org/1190103002
Cr-Commit-Position: refs/heads/master@{#335371}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite for having them live within APK splits.
Although pak files need to be renamed to be stored under res/raw,
ResourceExtractor restores their original name during extraction (so no
change to native code).
All sub-locales are stored and extracted together, just as before.
BUG=371610
Review URL: https://codereview.chromium.org/1158053005
Cr-Commit-Position: refs/heads/master@{#335350}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
start-up.
Also changes so that browser process caches a FD to the file rather than re-opening it for each child process.
We store icudtl.dat uncompressed in the apk now, increasing the apk size, but saving 6mb on-disk.
BUG=394502
Review URL: https://codereview.chromium.org/1147213004
Cr-Commit-Position: refs/heads/master@{#335261}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make TemplateURLFetcher test use the xml file from components/test/data/search_engines/
directory instead.
BUG=387985
TEST=python testing/xvfb.py out/Debug out/Debug/unit_tests
--gtest_filter=TemplateURLFetcherTest.*
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/1185953002
Cr-Commit-Position: refs/heads/master@{#335204}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1165523002/
BUG=472360
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1173363008
Cr-Commit-Position: refs/heads/master@{#334285}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1165523002/)
Reason for revert:
broke cronet_sample_test_apk compilation :(
Original issue's description:
> [Android] Refactor browser test execution.
>
> This change allows us to run multiple browser tests within a single
> invocation of an app. It does so by moving the test activity into its
> own process, running each test individually within that activity, and
> killing the process between each test.
>
> BUG=472360
>
> Committed: https://crrev.com/b049103fa4848e304102a24e78c6ba994130a535
> Cr-Commit-Position: refs/heads/master@{#334149}
TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,tedchoc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472360
Review URL: https://codereview.chromium.org/1186513002
Cr-Commit-Position: refs/heads/master@{#334151}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change allows us to run multiple browser tests within a single
invocation of an app. It does so by moving the test activity into its
own process, running each test individually within that activity, and
killing the process between each test.
BUG=472360
Review URL: https://codereview.chromium.org/1165523002
Cr-Commit-Position: refs/heads/master@{#334149}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes the 'view original' link and replaces it with
a button that currently navigates to the original article but will
eventually slide the view out of focus.
The feedback form and close button now span the full width of a page
while content is limited to 800px wide.
BUG=428533
Review URL: https://codereview.chromium.org/1160113004
Cr-Commit-Position: refs/heads/master@{#333759}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the semantics of Schema.Org article attribute so that the content
of the article is inside the itemscope div.
This blocks the following CL:
"Leverage semantic elements to find the main article"
https://codereview.chromium.org/1131793009/
Review URL: https://codereview.chromium.org/1163463002
Cr-Commit-Position: refs/heads/master@{#333192}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch has some substantive changes that are not just code deletion, mainly around syncing/merging behavior.
BUG=493856
TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/1143253012
Cr-Commit-Position: refs/heads/master@{#333155}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/1126543009/, which
broke gtests built by GN.
BUG=476410
Review URL: https://codereview.chromium.org/1143903002
Cr-Commit-Position: refs/heads/master@{#331056}
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes yandex by updating form.
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1143253002
Cr-Commit-Position: refs/heads/master@{#330745}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removes succesfull runs from debug output.
* Use named parameter in call to stopit.ThreadingTimeout, in order to
make it clear that it seconds.
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1143223002
Cr-Commit-Position: refs/heads/master@{#330743}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:120001 of https://codereview.chromium.org/1126543009/)
Reason for revert:
broke http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android
e.g. http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/1922
Original issue's description:
> [Android] Refactor the native test wrappers.
>
> BUG=476410
>
> Committed: https://crrev.com/581d25e509e4a2b1e8927c6d8accc0c90ea86090
> Cr-Commit-Position: refs/heads/master@{#330531}
TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,perezju@chromium.org,tedchoc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=476410
Review URL: https://codereview.chromium.org/1138993009
Cr-Commit-Position: refs/heads/master@{#330591}
|
|
|
|
|
|
|
|
| |
BUG=476410
Review URL: https://codereview.chromium.org/1126543009
Cr-Commit-Position: refs/heads/master@{#330531}
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes buzzfeed by introducing password_not_auto parameter.
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1138353003
Cr-Commit-Position: refs/heads/master@{#330502}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix error introduced while adressing comments in
https://codereview.chromium.org/1089383002/
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1134843005
Cr-Commit-Position: refs/heads/master@{#330501}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases selenium are unable to select frame, which give an
exception and prevents test running. Fix this by explicitly navigating
to desired frame.
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1147483003
Cr-Commit-Position: refs/heads/master@{#330491}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Logs test cases which will be run, which helps to catch cases when you
misspell config parameter name and run all test cases instead of
specified once.
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1142803002
Cr-Commit-Position: refs/heads/master@{#330353}
|
|
|
|
|
|
|
|
|
|
|
| |
Add code to cause failure at runtime if a resource-pack includes a
resource that is already present in another resource-pack.
BUG=471609
Review URL: https://codereview.chromium.org/1115033003
Cr-Commit-Position: refs/heads/master@{#329646}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove dependencies on //content & //chrome that are no longer needed
and move unit tests into //components/history/core/browser.
Rename incorrectly named HistoryBackendDBTest and cie. to avoid name
collision with HistoryBackendTest.
Cleanup ZeroSuggestProvider to not use TestingProfile::DestroyTopSites
as it is not needed since it is registering a fake TopSites that does
not have the limitation of TopSitesImpl of only one instance per path.
Remove methods CreateTopSites/DestroyTopSites/BlockUntilTopSitesLoaded
from TestingProfile as they are no longer used.
Introduce //components/history/core/test/thumbnail{.cc,_ios.mm} to
abstract dependency on JPEG loading and run the tests on iOS.
Move tests data to //components/test/data/history.
BUG=370850, 227969
Review URL: https://codereview.chromium.org/1121473002
Cr-Commit-Position: refs/heads/master@{#328358}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's used to fetch resources for mojo apps.
R=ben@chromium.org
Committed: https://crrev.com/6de67f80026697580ed4cefa11a72193243bd4a0
Cr-Commit-Position: refs/heads/master@{#328014}
Review URL: https://codereview.chromium.org/1108403008
Cr-Commit-Position: refs/heads/master@{#328064}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1108403008/)
Reason for revert:
Broke compile:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/853/steps/compile/logs/stdio#error1
Original issue's description:
> Adds resource_provider::ResourceProvider
>
> It's used to fetch resources for mojo apps.
>
> R=ben@chromium.org
>
> Committed: https://crrev.com/6de67f80026697580ed4cefa11a72193243bd4a0
> Cr-Commit-Position: refs/heads/master@{#328014}
TBR=ben@chromium.org,sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1113223003
Cr-Commit-Position: refs/heads/master@{#328021}
|
|
|
|
|
|
|
|
|
|
| |
It's used to fetch resources for mojo apps.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1108403008
Cr-Commit-Position: refs/heads/master@{#328014}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/ef4962f..68de407
Since BoringSSL's headers were tightened somewhat, this fixes code
in Chromium to include mem.h when relevant functions are used.
BUG=none
Review URL: https://codereview.chromium.org/1113533004
Cr-Commit-Position: refs/heads/master@{#327847}
|
|
|
|
|
|
|
|
|
|
| |
This follows the move of WebCrypto to //components.
BUG=476568
Review URL: https://codereview.chromium.org/1117133002
Cr-Commit-Position: refs/heads/master@{#327817}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split history_unittest.cc in three according to what is tested and on
the dependencies:
- content_history_backend_unittest.cc
- history_backend_unittest.cc
- history_service_unittest.cc
BUG=370850
Review URL: https://codereview.chromium.org/1101383002
Cr-Commit-Position: refs/heads/master@{#327677}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.
This patch was manually generated using a regex and a text editor.
BUG=417463
Review URL: https://codereview.chromium.org/1056633004
Cr-Commit-Position: refs/heads/master@{#327312}
|
|
|
|
|
|
|
|
|
|
| |
It contains information of how the user closed the "Save password?" bubble in the past. Basing on this data two different algorithms are to be implemented so the bubble isn't so annoying for the users.
BUG=431739
Review URL: https://codereview.chromium.org/1083293004
Cr-Commit-Position: refs/heads/master@{#326981}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When users pinch in Reader Mode, the page would zoom in or out as if it
is a normal web page allowing user-zoom. At the end of pinch gesture, the
page would do text reflow. These pinch-to-zoom and text reflow effects
are not native, but are emulated using CSS and JavaScript.
In order to achieve near-native zooming and panning frame rate, fake 3D
transform is used so that the layer doesn't repaint for each frame.
After the text reflow, the web content shown in the viewport should
roughly be the same paragraph before zooming.
The control point of font size is the html element, so that both "em" and
"rem" are adjusted. Accordingly, font size of body is no longer specified
in CSS in unit of pixel.
Some CSS styles and animations are updated to fix issues specific to
resizing.
BUG=445632
Review URL: https://codereview.chromium.org/1009703002
Cr-Commit-Position: refs/heads/master@{#326945}
|
|
|
|
|
|
|
|
|
|
|
| |
Adding back a line which seemed to have been droppped by accident in https://codereview.chromium.org/1084553003
R=melandory@chromium.org
BUG=369521
Review URL: https://codereview.chromium.org/1094453007
Cr-Commit-Position: refs/heads/master@{#326538}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactoring consists of following steps:
* test-case is runned for all websites, then another one for all websites.
* module |test| is now executing by importing and running its
function instead of running it as python script.
* platform independent timeout mechanism.
* parallel run using threads and threadpool alike solution to
distribute jobs between them.
BUG=369521
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1089383002
Cr-Commit-Position: refs/heads/master@{#326495}
|
|
|
|
|
|
|
|
| |
BUG=465351
Review URL: https://codereview.chromium.org/1075783002
Cr-Commit-Position: refs/heads/master@{#326449}
|