| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
| |
BUG=b/18275087
Review URL: https://codereview.chromium.org/1064903003
Cr-Commit-Position: refs/heads/master@{#324112}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/706993003/)
Reason for revert:
It looks like this broke tests the following tests on Linux Chromium OS:
AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired
AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired
Example output:
AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired (run #1):
[ RUN ] AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired
[11334:11334:0406/201742:404219967:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument
[11334:11334:0406/201742:404230154:FATAL:timer.cc(116)] Check failed: !user_task_.is_null().
AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired (run #1):
[ RUN ] AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired
[11382:11382:0406/201748:411022458:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument
../../components/timers/alarm_timer_unittest.cc:469: Failure
Value of: did_run
Actual: true
Expected: false
Example build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/996
Original issue's description:
> C++ readability review
>
> BUG=b/18275087
>
> Committed: https://crrev.com/05e4d854dca737cfb43cd967cd72d024f6b1625b
> Cr-Commit-Position: refs/heads/master@{#324004}
TBR=derat@chromium.org,gromer@google.com,zea@chromium.org,chirantan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/18275087
Review URL: https://codereview.chromium.org/1058693003
Cr-Commit-Position: refs/heads/master@{#324009}
|
| |
|
|
|
|
|
|
| |
BUG=b/18275087
Review URL: https://codereview.chromium.org/706993003
Cr-Commit-Position: refs/heads/master@{#324004}
|
|
|
This adds the AlarmTimer class to components, which is capable of waking
up the system from suspend on platforms that support this operation
(currently only Chrome OS with linux version 3.11 or higher). On all
other platforms, the AlarmTimer behaves exactly the same as a regular
Timer.
BUG=crosbug.com/p/32272
Review URL: https://codereview.chromium.org/641943002
Cr-Commit-Position: refs/heads/master@{#301175}
|
