| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This will enable using those classes on the iOS build.
BUG=271392
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/105573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function is called when a triangle mark in <input
list=...> is clicked, and it should show <datalist>
suggestions.
Unlike the normal autofill process, we'd like to skip prefix
matching for ease to replace the existing value without
keyboard operation, and make the behavior similar to <select> menu.
BUG=152375
Review URL: https://codereview.chromium.org/107353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Password fields aren't ever filled by the Autofill feature, so this just adds
confusion to the metrics.
BUG=none
TEST=none
R=gcasto@chromium.org
Review URL: https://codereview.chromium.org/112203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files were moved and the header was automatically updated to remove the
"(c)". However, this will make the presubmit scripts fail if a proto is updated.
BUG=271392
R=mnissler@chromium.org
Review URL: https://codereview.chromium.org/112893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org
BUG=326882
Review URL: https://codereview.chromium.org/99133006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JSONReader only accepts UTF-8 input strings and converts \uXXXX sequences
back into UTF-8. However, the JSONWriter converts all non-ASCII characters to
UTF-16 escape sequences. This round-tripping is sub-optimal, as noted in a
TODO from r54359.
One reason for this may be that JsonDoubleQuote(), used by JSONWriter, does not
handle UTF-8 bytes correctly, interpreting them as code points and writing them
out as \u00XX sequences. If this were read back through a RFC-compliant JSON
parser, the result would be an invalid encoding error. JsonDoubleQuote() does
handle UTF-16 correctly, though.
This rewrites the base/json/string_escape.h API and fixes the above UTF-8 issue
by dividing callers up into three groups:
1. Those that pass valid UTF-8 to be escaped. Prior to this change, very few
callers used this variant. Those that did were likely using ASCII, otherwise
the output would be mangled due to the above issue. Now, valid UTF-8 will be
passed through to the output unescaped. Invalid UTF-8 sequences are replaced
with U+FFFD.
2. Those that pass valid UTF-16 to be escaped. This function now validates that
the input is valid UTF-16, and then converts it to unescaped UTF-8 sequences
for the output.
3. Those that pass arbitrary byte arrays as std::string and expect a non-RFC-
compliant encoding of the binary data using \uXXXX escapes. This behavior is
now in the EscapeBytesAsInvalidJSONString() function. It is only used by
callers who want a "debug string" but do not expect to actually parse the
output as valid JSON, since it is not.
Additionally, this removes the JSONWriter::OPTIONS_DO_NOT_ESCAPE flag, since
the writer can now handle UTF-8 appropriately.
BUG=15466
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239800
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=240082
R=asanka@chromium.org, bauerb@chromium.org, mark@chromium.org, thakis@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/100823007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreatePluginReplacement take only a RenderFrame.
In two places I called the temporary method render_frame->GetRenderView() because ContentSettingsObserver still has to be switched to be a RenderFrameObserver.
BUG=304341
R=bauerb@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/106973012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moved chrome/browser/policy/proto/chromeos to
chrome/browser/chromeos/policy/proto, and chrome/browser/policy/proto/cloud to
components/policy/proto.
This enables the component code to use the cloud policy protobufs, so that iOS
can use cloud policy.
The old location is still kept temporarily until new git mirrors are set up
pointing to the new locations. A couple of PRESUBMIT scripts check that the
files are kept in sync.
BUG=271392, 327345
TBR=mnissler@chromium.org
Review URL: https://codereview.chromium.org/108563005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: This patchset breaks at least displayment of Russian localized strings on Chromeos login screen.
TBR=mark@chromium.org,jshin@chromium.org,thakis@chromium.org,asanka@chromium.org,zea@chromium.org,bauerb@chromium.org,rsesek@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/106793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PolicyHeaderService now generates a json-style header to send up with web requests sent to DMServer containing information about the current policy state. This allows DMServer to return policy information via SAML assertions to authorized service providers.
BUG=326799
TBR=jochen
Review URL: https://codereview.chromium.org/99433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*****************
Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess.
*****************
> Revert 239759 "The comment in base64.h implies that base::Base64..."
>
> > The comment in base64.h implies that base::Base64Encode() can return false, but
> > this cannot happen in practice. Fix the comment.
> >
> > The implementation of Base64Encode() attempts to check for the return value
> > MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> > value. Remove the check.
> >
> > Remove unneeded integer cast.
> >
> > Change the return type to void.
> >
> > BUG=323357
> > TEST=base_unittests, compile all
> > TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/86913002
>
> TBR=ricea@chromium.org
>
> Review URL: https://codereview.chromium.org/101113004
TBR=vadimt@chromium.org
Review URL: https://codereview.chromium.org/111883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=323641, 325875
Review URL: https://codereview.chromium.org/99473010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> The comment in base64.h implies that base::Base64Encode() can return false, but
> this cannot happen in practice. Fix the comment.
>
> The implementation of Base64Encode() attempts to check for the return value
> MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> value. Remove the check.
>
> Remove unneeded integer cast.
>
> Change the return type to void.
>
> BUG=323357
> TEST=base_unittests, compile all
> TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
>
> Review URL: https://codereview.chromium.org/86913002
TBR=ricea@chromium.org
Review URL: https://codereview.chromium.org/101113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserView layout occurs frequently with unchanged bounds.
(ex. when the page title changes Widget::UpdateWindowTitle)
Only update dialog positions on browser layout as needed.
(ie. when the browser's dialog hosting position changes)
(this happens very rarely, since most dialogs are modal)
Make the GetDialogPosition OVERRIDE public, matches decl.
BUG=305480
TEST=Modal dialogs do not flicker while dragging during tab load. Load a site that takes a few seconds to finish loading (cnn.com, youtube.com, etc.), open and drag the edit bookmark dialog or edit search engine dialog while the tab is loading, ensure the dialog does not flicker while dragging and is not automatically moved back to its starting position after dragging.
R=sky@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/111003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Rename playground2 namespace to sandbox.
The playground2 namespace is confusing and against the style guide.
We rename it to sandbox, like the rest of sandbox/linux/.
2. Rename the "Sandbox" class to "SandboxBPF".
BUG=325535
R=rsesek@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/101773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=302510
Review URL: https://codereview.chromium.org/98683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=320711
TBR=isherman@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/110963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
As this target generates a header, it must be a hard dependency.
Review URL: https://codereview.chromium.org/102073007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JSONReader only accepts UTF-8 input strings and converts \uXXXX sequences
back into UTF-8. However, the JSONWriter converts all non-ASCII characters to
UTF-16 escape sequences. This round-tripping is sub-optimal, as noted in a
TODO from r54359.
One reason for this may be that JsonDoubleQuote(), used by JSONWriter, does not
handle UTF-8 bytes correctly, interpreting them as code points and writing them
out as \u00XX sequences. If this were read back through a RFC-compliant JSON
parser, the result would be an invalid encoding error. JsonDoubleQuote() does
handle UTF-16 correctly, though.
This rewrites the base/json/string_escape.h API and fixes the above UTF-8 issue
by dividing callers up into three groups:
1. Those that pass valid UTF-8 to be escaped. Prior to this change, very few
callers used this variant. Those that did were likely using ASCII, otherwise
the output would be mangled due to the above issue. Now, valid UTF-8 will be
passed through to the output unescaped. Invalid UTF-8 sequences are replaced
with U+FFFD.
2. Those that pass valid UTF-16 to be escaped. This function now validates that
the input is valid UTF-16, and then converts it to unescaped UTF-8 sequences
for the output.
3. Those that pass arbitrary byte arrays as std::string and expect a non-RFC-
compliant encoding of the binary data using \uXXXX escapes. This behavior is
now in the EscapeBytesAsInvalidJSONString() function. It is only used by
callers who want a "debug string" but do not expect to actually parse the
output as valid JSON, since it is not.
Additionally, this removes the JSONWriter::OPTIONS_DO_NOT_ESCAPE flag, since
the writer can now handle UTF-8 appropriately.
BUG=15466
Review URL: https://codereview.chromium.org/100823007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this cannot happen in practice. Fix the comment.
The implementation of Base64Encode() attempts to check for the return value
MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
value. Remove the check.
Remove unneeded integer cast.
Change the return type to void.
BUG=323357
TEST=base_unittests, compile all
TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
Review URL: https://codereview.chromium.org/86913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Define an observer that allows clients to listen to article updates.
In a subsequent CL, I will hook the webui to observe article changes.
BUG=288015
Review URL: https://codereview.chromium.org/100463005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Data model changes only, in preparation for upcoming view changes.
BUG=299154
TEST=unit_tests
R=estade@chromium.org
Review URL: https://codereview.chromium.org/106233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate NaCl to the new BPF policies format.
BUG=325535, 267179
R=mseaborn@chromium.org, piman@chromium.org, rsesek@chromium.org
Review URL: https://codereview.chromium.org/110833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
seccomp-bpf policies are now the implementation of the interface that
lives in sandbox/linux/seccomp-bpf/sandbox_bpf_policy.h
Sandbox policies inside content/ will all derive from the SandboxBpfBasePolicy
(sandbox_bpf_base_policy.h) class.
We can now rely on real C++ inheritance to implement our policy hierarchy.
This is a first CL, part of a larger refactor. It should help minmize the risk
of error and facilitate review by keeping the general layout of the code similar.
In upcoming changes, we will:
1. Migrate NaCl and get rid of the compatibility / deprecated interfaces.
2. Extend the interface of SandboxBpfBasePolicy to be compatible with
starting a GPU sandbox and reflect all the steps.
3. Move all the policies to directories such as renderer/ and gpu/ and each
policy class will be able to live in its own file.
BUG=325535
R=creis@chromium.org, jorgelo@chromium.org, mseaborn@chromium.org, rsesek@chromium.org
Review URL: https://codereview.chromium.org/105673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extensions that support policies must declare those policies in a JSON
schema. All the policy providers get a mapping from components to their
schemas. This change makes the Windows policy provider use those schemas
when loading policies from GPO or the registry.
The previous behavior was to load the schema from GPO/the registry too;
this behavior is still used if the extension doesn't include a schema,
to support the Legacy Browser Support extension for the next releases.
BUG=108994, 108992
Review URL: https://codereview.chromium.org/102493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [breakpad] remove dependency on content_switches.cc
>
> https://codereview.chromium.org/104593008/
R=noms@chromium.org
TBR=joi@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/110113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nobody in components/autofill/core/browser is including from
chrome/common/, so this entry is not necessary anymore.
BUG=140037
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/100473007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSON schemas are used by extensions that support enterprise management,
to declare the policies that they support. The current parser rejects
schemas with unknown attributes; this CL lifts that restriction for 2 reasons:
- the JSON schema spec does not mandate this behavior for validators
- it restricts future extensions to this format
BUG=108992
Review URL: https://codereview.chromium.org/94043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke all bots 9_9
> Revert 239280 "Move more file_util functions to base namespace."
>
> dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32).
> This CL is the only in the intersection of CLs in the first failing build on
> the two builders, so giving a speculative revert a try (rlarocque already
> tried a clobber, it didn't help).
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544
>
>
> > Move more file_util functions to base namespace.
> >
> > TBR=sky
> >
> > Review URL: https://codereview.chromium.org/109043002
>
> TBR=brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/105823009
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/100923007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32).
This CL is the only in the intersection of CLs in the first failing build on
the two builders, so giving a speculative revert a try (rlarocque already
tried a clobber, it didn't help).
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544
> Move more file_util functions to base namespace.
>
> TBR=sky
>
> Review URL: https://codereview.chromium.org/109043002
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/105823009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code moved to component/policy can be included on iOS, but can't depend
on chrome/. This move includes an exception for the policy protobufs:
- the generic cloud policy protobufs will be moved into a new repository,
due to a dependency from a ChromeOS package
- the user cloud policy protobuf and its decoding will move into a new component
for user policy
BUG=271392
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/109743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(a) Add support for three new columns: street address, dependent locality, and
sorting code.
(b) Migrate data stored in the address_line_1 and address_line_2 columns into
the new street_address column, and drop the old columns.
(c) Drop two long deprecated columns: country (as opposed to country code) and
phone number type (fax vs. phone).
BUG=299154
TEST=unit_tests
R=estade@chromium.org
Review URL: https://codereview.chromium.org/101093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=323328
Review URL: https://codereview.chromium.org/90433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components_unittests target.
Recent changes from Blundell made it possible.
BUG=140037,181277
TEST=components_unittests
R=joi@chromium.org,thestig@chromium.org
Review URL: https://codereview.chromium.org/82353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/109043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=scottbyer@chromium.org
TBR=scottbyer
Review URL: https://codereview.chromium.org/107383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Failed on the waterfall ([ FAILED ] nacl_newlib.run_breakpad_crash_in_syscall_test (250 ms). This error also happened on the trybot.
TBR=scottmg@chromium.org,joi@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/101623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flag will be flipped back once the server is ready. For now it'll be
disabled on cloud policy. Note that policy for extensions is still loaded from
the platform policy providers.
BUG=108992
Review URL: https://codereview.chromium.org/107063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutofillDriverImpl.
This flow is not shared by iOS.
BUG=302481
Review URL: https://codereview.chromium.org/73193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=joi@chromium.org, scottmg@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/104593008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds functionality to trigger distillation of web pages from the
debug UI and also lists the current set of articles.
BUG=319881
Review URL: https://codereview.chromium.org/105623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
starting URLs.
The precache fetcher will now attempt to fetch manifests for the first |top_sites_count| starting URLs. Fetches of manifests for non-whitelisted URLs will fail and be skipped.
The reason for this change is so that the server side component can have a large whitelist of starting URLs, without forcing the client to download the entire list every time precaching is done.
BUG=306185
Review URL: https://codereview.chromium.org/83283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Facilitates policy componentization. Also add DEPS exceptions for ui
and grit includes.
BUG=271392
TBR=sky
Review URL: https://codereview.chromium.org/103263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of https://codereview.chromium.org/78603003/
BUG=271392
R=joaodasilva,jochen
Review URL: https://codereview.chromium.org/104373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Treat the concept of "how to get the DomDistillerService to use for the given
browsing context" as an embedder-level concept rather than a concept within the
dom_distiller component.
Review URL: https://codereview.chromium.org/100623006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=317837
Review URL: https://codereview.chromium.org/98493007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Initially implemented only to satisfy Networking Private Api browser_tests.
Moved hard-coded test data for NetworkingPrivateApiTest into fake_wifi_service.cc
BUG=267667
Review URL: https://codereview.chromium.org/100493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=306185, 309216
Review URL: https://codereview.chromium.org/27047003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename BCKBaseFactory::RegisterUserPrefsOnBrowserContext to BKCBaseFactory::RegisterUserPrefsOnBrowserContextForTest and make sure it is indeed only used in tests (the only non-test use of it to register something early in browser_prefs.cc was removed as it is no longer necessary now that registration is actually done early enough).
Rename methods/variables centered around calling RegisterUserPrefsOnBrowserContextForTest in BCKServiceFactory and its ref-counted twin to highlight the fact that those are test only and help justify calling test-only method RegisterUserPrefsOnBrowserContextForTest as a result of them being set.
This could be much simpler the day PrefService::DeprecatedGetPrefRegistry() is phased out and replaced by a better solution for tests, but currently this is the simplest we can do to achieve the desired product behavior without completely refactoring the test framework. Comments were added to reflect what could be simplified should it ever go away.
TBR=pkasting,rickcam (for unit_tests side-effects of suffixing a method with "ForTest")
BUG=324520
Review URL: https://codereview.chromium.org/97383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=245126
R=bauerb@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/104973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238799 0039d316-1c4b-4281-b951-d872f2087c98
|