| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=314976
R=isherman@chromium.org
Review URL: https://codereview.chromium.org/112663005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LanguageUsageMetrics is moved to its own component because it is used
both in the translate component and directly in the browser.
TranslateBrowserMetrics is moved to the translate component.
BUG=331509
TBR=jochen
Review URL: https://codereview.chromium.org/131203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some components of a 32 bit build of chrome for Windows need to be built
as Win64 Dlls. To allow those components to use base, we make a Win64
build of the base library even when building chrome 32 bit.
This is needed by the Chrome Desk Band code. crbug.com/327435.
https://codereview.chromium.org/79173004/
BUG=327435
Review URL: https://codereview.chromium.org/103333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/131593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/131553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
instead of TokenWebData::FromBrowserContext.
This CL is an unchanged reland of https://codereview.chromium.org/109783003/,
which had been speculatively reverted to see if it was causing ChromeOS build
failures. The speculative revert unfortunately stuck as it happened to land in
the same run as the CL that actually fixed the (unrelated) ChromeOS build
failures: https://codereview.chromium.org/129343003/.
BUG=332107
TBR=noamsml
Review URL: https://codereview.chromium.org/130813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=332675
R=bauerb@chromium.org,inferno@chromium.org
Review URL: https://codereview.chromium.org/131073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
there already is information in the autofill DB.
BUG=326679
Review URL: https://codereview.chromium.org/120343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=329978
TEST=none
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/98753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds two new policies that will allow to block all or some native
messaging hosts.
BUG=237882
Review URL: https://codereview.chromium.org/118253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Only disable it if there's no indication the user might be interested in US addresses. App locale is not taken into account because many international users set theirs to en-US.
BUG=323641
Review URL: https://codereview.chromium.org/106033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330084
Review URL: https://codereview.chromium.org/111853012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=331459
TBR=sehr@chromium.org
Review URL: https://codereview.chromium.org/126823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=332169
R=zea@chromium.org
Review URL: https://codereview.chromium.org/128193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: ChromeOS bot failures, example http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19049
Failing lines:
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry [ FAILED ]
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',)
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry [ FAILED ]
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',)
TBR=joi@chromium.org,rogerta@chromium.org,tfarina@chromium.org,thakis@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332107
Review URL: https://codereview.chromium.org/129253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297480
R=aa@chromium.org,bauerb@chromium.org
Review URL: https://codereview.chromium.org/116163008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used by the VariationsService to simulate newly
received variations seed, to evaluate whether there's sufficient
new changes to badge the UI to suggest a restart (similar to
what happens during auto updates).
This is the initial version of this class and still
has some missing pieces, left as TODOs.
BUG=315807
TEST=Unit tests.
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/41623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dependency path is
src/chrome/chrome.gyp:common ->
src/components/components.gyp:policy_component ->
src/components/components.gyp:user_prefs ->
src/content/content.gyp:content_browser
This was introduced in https://codereview.chromium.org/102973005. The issue is
that URLBlacklistManager::RegisterProfilePrefs() uses a PrefServiceSyncable
which comes from user_prefs, and user_prefs depends on content::BrowserContext.
This fix splits the policy/common files into a policy_component_common target
that does not depend on user_prefs. chrome.gyp:common now depends on
policy_component_common, and chrome.gyp:browser depends on policy_component.
BUG=332030
Review URL: https://codereview.chromium.org/124393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
instead of TokenWebData::FromBrowserContext.
BUG=332107
TBR=thakis
Review URL: https://codereview.chromium.org/109783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trace-viewer side change is here: https://codereview.appspot.com/39310043
Screenshot of the profiler: http://haraken.info/null/sampling_tracing.png
Design document: https://docs.google.com/a/google.com/document/d/1j39sbA9ECTwFFlxbhSD1EvJnGfYeS5EUJ05yxuku6VY/edit
TBR=phajdan.jr
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242671
Review URL: https://codereview.chromium.org/109933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Re-landing with fixes from https://codereview.chromium.org/112663007/ )
Activity in Native Client plugins results in IPC messages
sent to the BrowserPpapiHostImpl and routed to call
extensions::ProcessManager::KeepaliveImpulse.
Testing patch, builds on implementation:
https://codereview.chromium.org/61063003/
Design doc:
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit#
BUG=298339
No change to mseaborn owned file since last LGTM:
R=yzshen@chromium.org
TBR=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/125353006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves a few files to the translate component. It also layers the
structure of the component so that it is better suited for iOS.
BUG=331509
TBR=jochen, joi
Review URL: https://codereview.chromium.org/93603006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many dependencies weren't declared, resulting in files not being built with
Blink's direct_dependent_settings. This is needed for
https://codereview.chromium.org/123133006/ to land.
- password_form_conversion_utils.cc includes Blink headers, so depend
autofill_content_renderer on Blink.
- ppb_nacl_private_impl.cc includes Blink headers, so depend nacl_renderer on
Blink.
- render_view_test.h is a public content/ header with includes Blink headers,
so add Blink to test_support_content's export_dependent_settings.
- Test targets in chrome/ all depend on test_support_content via
test_support_common, so add test_support_content to test_support_common's
export_dependent_settings.
BUG=331386
TEST=builds
Review URL: https://codereview.chromium.org/101203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=322664
R=brettw@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/101143006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
concurrently anyway
BUG=327911
Review URL: https://codereview.chromium.org/123733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PpapiHostMsg_ChannelCreated is used for two purposes:
* Notifying the browser that a browser<->plugin channel has been created, and
* Notifying that browser that a renderer<->plugin channel has been created.
In this case renderer<->plugin channel is for NaCl-based plugins, and is
special because it does some inspection of message contents and passes on the
message to the untrusted side of the plugin.
I've changed this because I think it makes the code easier to read, and I'm
adding an additional renderer<->plugin channel anyway.
BUG=
TBR=mseaborn,jschuh
Review URL: https://codereview.chromium.org/98183012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces bare_metal_main, which contains the implementation for
Bare Metal Mode replacing nacl_secure_service, and ELF related utility.
Some codes are extracted from native_client/src/trusted/service_runtime
in order to separate Bare Metal related stuff completely from service runtime.
Some parts should be refactored and merged eventually, probably after we
convince ourselves that the Bare Metal is stable enough.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to load the elf binary with this loader, and made sure that the entry point is reached.
TBR=jln@chromium.org
Review URL: https://codereview.chromium.org/100373005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Broke XP bots: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/32520
TBR=yzshen@chromium.org,scheib@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=298339
Review URL: https://codereview.chromium.org/124313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=326882,331127
TEST=rac sign in works
Review URL: https://codereview.chromium.org/123363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CookieMonster::EnableFileScheme().
Also, in all modules that depend on content, replaces direct creation of new
net::CookieMonster() with content::CreateInMemoryCookieStore(). This creation
method knows how to respect the --enable-file-cookies flag. Makes webkit
layout tests work.
Relanding parts of https://chromiumcodereview.appspot.com/12546016
TBR=jam,rsleevi,boliu,esprehn
BUG=159193, 331424
Review URL: https://codereview.chromium.org/116293006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/118003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Re-landing with fixes from https://codereview.chromium.org/111563006/ )
Activity in Native Client plugins results in IPC messages
sent to the BrowserPpapiHostImpl and routed to call
extensions::ProcessManager::KeepaliveImpulse.
Testing patch, builds on implementation:
https://codereview.chromium.org/61063003/
Design doc:
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit#
BUG=298339
No change to mseaborn owned file since last LGTM:
TBR=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/112663007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PpapiHostMsg_CreateNaClChannel has a field for the renderer_id, but it's never
used.
I came across this when figuring out how to create two channels between the
renderer and plugin, one solely for communication with the "trusted" part of
the plugin.
BUG=
R=bbudge@chromium.org, dmichael@chromium.org
TBR=jschuh, mseaborn
Review URL: https://codereview.chromium.org/108383006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace, and clean up the header."
This is a speculative revert of r242414.
BUG=330681
TEST=as in bug
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/109673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates IPC for FileIO.Write, instead using the plugin's file descriptor.
Performs the file op on the plugin's thread if blocking, otherwise on the file
thread.
FileIOResources know their maximum written offset after they are opened.
They can thus calculate whether a Write or SetLength operation will extend
this max offset. If so, they call FileSystemResource::RequestQuota. This can
return synchronously or asynchronously, and either returns the requested
amount or 0 in case it can't be satisfied.
FileSystemResource will request a quota reservation from the host, queuing
up unsatisfied requests. The quota reservation will be at least 1MB with this
CL. The main point of a quota reservation is to reduce the number of times
we query the quota system.
Both the FileSystemResource and the host maintain a collection of open files
that are subject to quota. These are kept in sync. Maps that take PP_Resource
to resource or host are used to ensure good performance and make it easier
to keep the resource and host collections synced.
SetLength uses the plugin side machinery to request quota. When its request
is granted, it calls over to the host side as before. This is because of OS X
sandbox restrictions.
For trusted plugins, I assume that this plugin / host checking is sufficient. In
particular, SetLength is performed in the browser process without checking
the length against quota restrictions. We're essentially assuming trusted
plugins don't cheat.
For untrusted plugins, this approach isn't sufficient. NaClMessageScanner
audits the FIleSystem and FileIO message traffic to maintain a parallel
accounting of quota reservation and current file sizes. In addition, we wrap
the native file handle in a NaClDescQuota for files that need quota checking.
This NaClDescQuota uses NaClMessageScanner information to determine
whether or not to allow a Write. We must check at the descriptor level since
the untrusted plugin may bypass our proxy code and use the file handle
directly to Write. We must also fail any attempt to call ftruncate directly.
BUG=194304
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242659
Review URL: https://codereview.chromium.org/100703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Implement sampling profiler (chromium side change)
>
> Trace-viewer side change is here: https://codereview.appspot.com/39310043
>
> Screenshot of the profiler: http://haraken.info/null/sampling_tracing.png
>
> Design document: https://docs.google.com/a/google.com/document/d/1j39sbA9ECTwFFlxbhSD1EvJnGfYeS5EUJ05yxuku6VY/edit
>
> TBR=phajdan.jr
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/109933006
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/122053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trace-viewer side change is here: https://codereview.appspot.com/39310043
Screenshot of the profiler: http://haraken.info/null/sampling_tracing.png
Design document: https://docs.google.com/a/google.com/document/d/1j39sbA9ECTwFFlxbhSD1EvJnGfYeS5EUJ05yxuku6VY/edit
TBR=phajdan.jr
NOTRY=true
Review URL: https://codereview.chromium.org/109933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to have introduced a static initializer on Mac:
http://build.chromium.org/p/chromium/builders/Mac/builds/24153/steps/sizes/logs/stdio
It identifies one in:
../../components/nacl/loader/nacl_ipc_adapter.cc
/Volumes/data/b/build/slave/Mac/build/src/out/Release/libnacl.a(nacl.nacl_ipc_adapter.o)
> Do PPB_FileIO Write on the plugin side.
>
> This eliminates IPC for FileIO.Write, instead using the plugin's file descriptor.
> Performs the file op on the plugin's thread if blocking, otherwise on the file
> thread.
>
> FileIOResources know their maximum written offset after they are opened.
> They can thus calculate whether a Write or SetLength operation will extend
> this max offset. If so, they call FileSystemResource::RequestQuota. This can
> return synchronously or asynchronously, and either returns the requested
> amount or 0 in case it can't be satisfied.
>
> FileSystemResource will request a quota reservation from the host, queuing
> up unsatisfied requests. The quota reservation will be at least 1MB with this
> CL. The main point of a quota reservation is to reduce the number of times
> we query the quota system.
>
> Both the FileSystemResource and the host maintain a collection of open files
> that are subject to quota. These are kept in sync. Maps that take PP_Resource
> to resource or host are used to ensure good performance and make it easier
> to keep the resource and host collections synced.
>
> SetLength uses the plugin side machinery to request quota. When its request
> is granted, it calls over to the host side as before. This is because of OS X
> sandbox restrictions.
>
> For trusted plugins, I assume that this plugin / host checking is sufficient. In
> particular, SetLength is performed in the browser process without checking
> the length against quota restrictions. We're essentially assuming trusted
> plugins don't cheat.
>
> For untrusted plugins, this approach isn't sufficient. NaClMessageScanner
> audits the FIleSystem and FileIO message traffic to maintain a parallel
> accounting of quota reservation and current file sizes. In addition, we wrap
> the native file handle in a NaClDescQuota for files that need quota checking.
> This NaClDescQuota uses NaClMessageScanner information to determine
> whether or not to allow a Write. We must check at the descriptor level since
> the untrusted plugin may bypass our proxy code and use the file handle
> directly to Write. We must also fail any attempt to call ftruncate directly.
>
> BUG=194304
>
> Review URL: https://codereview.chromium.org/100703004
TBR=bbudge@chromium.org
Review URL: https://codereview.chromium.org/122013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which I reverted in r242660.
TBR=nasko
Review URL: https://codereview.chromium.org/120453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates IPC for FileIO.Write, instead using the plugin's file descriptor.
Performs the file op on the plugin's thread if blocking, otherwise on the file
thread.
FileIOResources know their maximum written offset after they are opened.
They can thus calculate whether a Write or SetLength operation will extend
this max offset. If so, they call FileSystemResource::RequestQuota. This can
return synchronously or asynchronously, and either returns the requested
amount or 0 in case it can't be satisfied.
FileSystemResource will request a quota reservation from the host, queuing
up unsatisfied requests. The quota reservation will be at least 1MB with this
CL. The main point of a quota reservation is to reduce the number of times
we query the quota system.
Both the FileSystemResource and the host maintain a collection of open files
that are subject to quota. These are kept in sync. Maps that take PP_Resource
to resource or host are used to ensure good performance and make it easier
to keep the resource and host collections synced.
SetLength uses the plugin side machinery to request quota. When its request
is granted, it calls over to the host side as before. This is because of OS X
sandbox restrictions.
For trusted plugins, I assume that this plugin / host checking is sufficient. In
particular, SetLength is performed in the browser process without checking
the length against quota restrictions. We're essentially assuming trusted
plugins don't cheat.
For untrusted plugins, this approach isn't sufficient. NaClMessageScanner
audits the FIleSystem and FileIO message traffic to maintain a parallel
accounting of quota reservation and current file sizes. In addition, we wrap
the native file handle in a NaClDescQuota for files that need quota checking.
This NaClDescQuota uses NaClMessageScanner information to determine
whether or not to allow a Write. We must check at the descriptor level since
the untrusted plugin may bypass our proxy code and use the file handle
directly to Write. We must also fail any attempt to call ftruncate directly.
BUG=194304
Review URL: https://codereview.chromium.org/100703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
InterceptNavigationResourceThrottle.
BUG=304341
Review URL: https://codereview.chromium.org/106203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds interfaces to OAuth2TokenService::Observer for observing access token request events. The token details section on about:signin-internal is repurposed to display account, token requester, request time and request status of access tokens.
BUG=309106,311414
TBR=benwells@chromium.org,brettw@chromium.org,rlarocque@chromium.org,gene@chromium.org,bauerb@chromium.org,ajwong@chromium.org,zea@chromium.org,ben@chromium.org,mnissler@chromium.org,nkostylev@chromium.org
Review URL: https://codereview.chromium.org/64853006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/102993018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=329295
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/113403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/112433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clean up the header.
BUG=none
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/100543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
use the base:: namespace.
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/108603005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on any thread from worker pool.
The thread safety is guaranteed by posting WiFiService calls using SequencedTaskRunner.
BUG=267667
Review URL: https://codereview.chromium.org/115193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/117323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242164 0039d316-1c4b-4281-b951-d872f2087c98
|