summaryrefslogtreecommitdiffstats
path: root/components
Commit message (Collapse)AuthorAgeFilesLines
* Remove dependency on Profile's IsOffTheRecord in favicon_handler.jif@chromium.org2014-04-091-0/+3
| | | | | | | | | | Have FaviconTabHelper supports IsOffTheRecord to move knowledge of Profile out of favicon_handler. BUG=359095 Review URL: https://codereview.chromium.org/227153007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262709 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262696 "Revert 262685 "Fix a forward declaration of Passw..."vabr@chromium.org2014-04-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 262685 "Fix a forward declaration of PasswordManagerClient" > > Compile still fails: > http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GTK%20Builder&number=2681 > ../../chrome/browser/ui/gtk/login_prompt_gtk.cc:70:7:error: 'PasswordManager' has not been declared > > > > Fix a forward declaration of PasswordManagerClient > > > > This went wrong with landing https://codereview.chromium.org/225093012 and https://codereview.chromium.org/216183008 too close from each other. > > > > BUG=347927,348523 > > R=blundell@chromium.org > > TBR=blundell@chromium.org > > > > Review URL: https://codereview.chromium.org/230883002 > > TBR=vabr@chromium.org > > Review URL: https://codereview.chromium.org/231043002 TBR=dmazzoni@google.com Review URL: https://codereview.chromium.org/231033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262697 "Revert 262680 "Put all in components/password_man..."vabr@chromium.org2014-04-0949-26/+236
| | | | | | | | | | | | | | | | | | | | | > Revert 262680 "Put all in components/password_manager in passwor..." > > > Put all in components/password_manager in password_manager namespace. > > > > BUG=348523 > > TBR=jochen@chromium.org > > > > Review URL: https://codereview.chromium.org/225093012 > > TBR=vabr@chromium.org > > Review URL: https://codereview.chromium.org/231113002 TBR=dmazzoni@google.com Review URL: https://codereview.chromium.org/231153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262699 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262680 "Put all in components/password_manager in passwor..."dmazzoni@google.com2014-04-0949-236/+26
| | | | | | | | | | | | | | | > Put all in components/password_manager in password_manager namespace. > > BUG=348523 > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/225093012 TBR=vabr@chromium.org Review URL: https://codereview.chromium.org/231113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262697 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262685 "Fix a forward declaration of PasswordManagerClient"dmazzoni@google.com2014-04-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Compile still fails: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GTK%20Builder&number=2681 ../../chrome/browser/ui/gtk/login_prompt_gtk.cc:70:7:error: 'PasswordManager' has not been declared > Fix a forward declaration of PasswordManagerClient > > This went wrong with landing https://codereview.chromium.org/225093012 and https://codereview.chromium.org/216183008 too close from each other. > > BUG=347927,348523 > R=blundell@chromium.org > TBR=blundell@chromium.org > > Review URL: https://codereview.chromium.org/230883002 TBR=vabr@chromium.org Review URL: https://codereview.chromium.org/231043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262696 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a forward declaration of PasswordManagerClientvabr@chromium.org2014-04-091-2/+2
| | | | | | | | | | | | This went wrong with landing https://codereview.chromium.org/225093012 and https://codereview.chromium.org/216183008 too close from each other. BUG=347927,348523 R=blundell@chromium.org TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/230883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262685 0039d316-1c4b-4281-b951-d872f2087c98
* Put all in components/password_manager in password_manager namespace.vabr@chromium.org2014-04-0949-26/+236
| | | | | | | | | BUG=348523 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/225093012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262680 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize TranslateManagerblundell@chromium.org2014-04-094-0/+503
| | | | | | | | | | | | | | | | This CL does the following: - Abstracts the loading of the translation detection error report URL in a new tab to go through the client - Removes knowledge of TranslateTabHelper from TranslateManager - Componentizes TranslateManager BUG=335078,360020 TBR=thakis Review URL: https://codereview.chromium.org/224723025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262676 0039d316-1c4b-4281-b951-d872f2087c98
* Password manager internals page: Introduce logger in browservabr@chromium.org2014-04-0912-13/+538
| | | | | | | | | | | | | | | | | | | | Password manager internals page serves as a debugging output from the process of observing submitted password forms and offering the user to save the password. The user will be able to grab the debugging info and pass it onto the Chrome developers to help investigate issues. This CL introduces: 1) SavePasswordProgressLogger, a collection of methods to easily format logs and scrub privacy sensitive information out of them. 2) BrowserSavePasswordProgressLogger, a specialization of the Logger for the browser part of the password management code. More context in the design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing Follow-up CLs will introduce the renderer specialization of the Logger, and actual logging calls. BUG=347927 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/216183008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262671 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IRT random for non-sfi NaCl.uekawa@chromium.org2014-04-096-5/+74
| | | | | | | | | | | | Because we are in the same process and file descriptor can be used, we will keep the file descriptor in a global variable before entering the seccomp-bpf sandbox. BUG=357976 Review URL: https://codereview.chromium.org/221653005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262659 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor around start up of the plugin.hidehiko@chromium.org2014-04-095-6/+12
| | | | | | | | | | | | | | | | | | | | | | This CL has some refactoring to prepare implementation of EmbedderService. 1) Moves irt_ppapi.c, plugin_main_irt.cc and plugin_main_irt.h to ppapi/nacl_irt. 2) Introduces irt_start.cc to handle startup of the plugin in SFI-mode. The file is extracted from irt_ppapi.cc. The main purpose of this separation is to avoid conflicting unistd.h. irt_ppapi.cc needs to include native_client/src/trusted/service_runtime/include/sys/unistd.h. However, start up code needs to include base/at_exit.h which indirectly include unistd.h. As a result they conflict, and NACL_ABI__SC_NACL_PNACL_MODE sometimes can be used, but sometimes not. 3) Moves AtExitManager, IOThread creation and global FD setting to irt_start.cc and plugin_startup.cc. TEST=Ran trybots BUG=358431 Review URL: https://codereview.chromium.org/225093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262649 0039d316-1c4b-4281-b951-d872f2087c98
* Make ContentExtractor more automatablecjhopman@chromium.org2014-04-092-13/+41
| | | | | | | | | | | | | | | | | | | | | | This adds three options to ContentExtractor --disable-dns disables dns. I figured that leaving the default at dns enabled would be good since that's probably what you want when manually running the content extractor (and it's easier for scripts/automation to pass extra flags than for humans to). --output-file writes output to a file instead of stdout. This makes it so automation doesn't have to parse the relevant output from all the other logging and test stuff that is printed. --output-binary writes a serialized protobuf instead of human-readable output. TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/214603009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262618 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/base/filename_util.h.sergeyu@chromium.org2014-04-091-1/+1
| | | | | | | | | | | | | | | Moved some filename-related functions from net_util.h to the new filename_util.h . BUG=276739 R=piman@chromium.org, rsleevi@chromium.org TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262487 Review URL: https://codereview.chromium.org/220253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262609 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the QuickCheckEnabled policy to WPADQuickCheckEnabled.joaodasilva@chromium.org2014-04-091-1/+1
| | | | | | | | | | | | | | The current name is too generic and the server team asked to have a more specific name. Usually it's not possible to rename policies, but this one hasn't gone to stable yet. This change must be merged to 35 or reverted. BUG=361257 Review URL: https://codereview.chromium.org/227383005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262562 0039d316-1c4b-4281-b951-d872f2087c98
* Domain Reliability: Add histograms.ttuttle@chromium.org2014-04-083-3/+37
| | | | | | | | | | | | Add a handful of histograms to DomainReliabilityContext to make sure uploads are occurring as expected and to validate the distribution of errors we receive on the server. BUG=356791 Review URL: https://codereview.chromium.org/226533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262556 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most content-level dependencies from TranslateManager.blundell@chromium.org2014-04-084-0/+76
| | | | | | | | | | | This CL introduces new TranslateDriver APIs to abstract calls to WebContents, NavigationController, and NavigationEntry. BUG=360027 Review URL: https://codereview.chromium.org/228483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262528 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262487 "Add net/base/filename_util.h."sergeyu@chromium.org2014-04-081-1/+1
| | | | | | | | | | | | | | | | | | | > Add net/base/filename_util.h. > > Moved some filename-related functions from net_util.h to the new > filename_util.h . > > BUG=276739 > R=piman@chromium.org, rsleevi@chromium.org > TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/220253002 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/228763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262498 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/base/filename_util.h.sergeyu@chromium.org2014-04-081-1/+1
| | | | | | | | | | | | | Moved some filename-related functions from net_util.h to the new filename_util.h . BUG=276739 R=piman@chromium.org, rsleevi@chromium.org TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/220253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262487 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Overload ReportLoadError for smaller calls.teravest@chromium.org2014-04-082-1/+7
| | | | | | | | | | | | | | It's tedious to repeat the error_message at call sites for ReportLoadError. This small change makes an overload for ReportLoadError() that only takes one argument instead of two, when the message reported to "lastError" and to the JS console is the same. BUG= R=dmichael@chromium.org Review URL: https://codereview.chromium.org/228873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262452 0039d316-1c4b-4281-b951-d872f2087c98
* Moved favicon_handler_delegate.h to a new component directory.jif@chromium.org2014-04-087-0/+72
| | | | | | | | BUG=359084 Review URL: https://codereview.chromium.org/226183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262443 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Move some reporting into StartPpapiProxy.teravest@chromium.org2014-04-083-5/+88
| | | | | | | | | | | Now that we're doing more error reporting and histogramming in NexeLoadManager, we can move some of that type of logic into PPB_NaCl_Private.StartPpapiProxy. BUG=239656 Review URL: https://codereview.chromium.org/226593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262433 0039d316-1c4b-4281-b951-d872f2087c98
* Move TranslateManager::IsTranslatableURL to be a client-level concept.blundell@chromium.org2014-04-081-0/+4
| | | | | | | | | | | | | | | | | The concept of whether a given URL is translatable is an embedder-level one. This CL does the following: - Moves TranslateManager::IsTranslatableURL to TranslateService and updates //chrome callers to call the latter. - Adds TranslateClient::IsTranslatableURL and has TranslateManager call that. - Moves TranslateManager unittest (only testing IsTranslatableURL) to be a unittest on TranslateService. BUG=360017 TBR=jochen Review URL: https://codereview.chromium.org/225263017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262427 0039d316-1c4b-4281-b951-d872f2087c98
* Generate the iOS policy Plist example when building on Mac.joaodasilva@chromium.org2014-04-083-20/+35
| | | | | | | | | | | | | | | | This change triggers the ios_plist generator in grit when building on the mac. This change also lets the 'dict' policy type map to any JSON structure (currently a dictionary or an array), so that the ManagedBookmarks policy can have correct examples generated by the templates generators. BUG=360508 Review URL: https://codereview.chromium.org/225303013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262392 0039d316-1c4b-4281-b951-d872f2087c98
* Allow for different error codes to be sent by the policy infrastructure.pastarmovj@chromium.org2014-04-082-4/+10
| | | | | | | | | | | | | | Needed for proper error messaging of the case when navigation is blocked before forced enrollment check completion. Second stage will be to add a new error message for that. BUG=360562 TEST=unit tests. Review URL: https://codereview.chromium.org/227683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262375 0039d316-1c4b-4281-b951-d872f2087c98
* Password bubble: Merge bubble and infobar response histogram.mkwst@chromium.org2014-04-082-0/+67
| | | | | | | | | | | | We can more easily evaluate the impact of the bubble UI on user behavior if we're evaluating the changes to a single histogram, rather than poking around at multiple in the hopes of understanding correlations. BUG=300149 Review URL: https://codereview.chromium.org/227613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262368 0039d316-1c4b-4281-b951-d872f2087c98
* Add regular expression support in policy schema.binjin@chromium.org2014-04-087-95/+446
| | | | | | | | | | This CL add "pattern" restriction to string type in schema, and "patternProperties" add variable properties name in an object type. Both of these features are based on regular expression and third_party/re2 is used in this implementation. BUG=348551 Review URL: https://codereview.chromium.org/205923004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262364 0039d316-1c4b-4281-b951-d872f2087c98
* Move translate's BUILD.gn file into its final location.tfarina@chromium.org2014-04-081-0/+61
| | | | | | | | | | | | | | tools/gn/secondary is just a mirror of the real source tree and as of now we can put BUILD.gn near their code. BUG=None TEST=None, no functional changes. R=brettw@chromium.org TBR=hajimehoshi@chromium.org Review URL: https://codereview.chromium.org/225263012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262349 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Chrome usages of WebFrame to WebLocalFrame.dcheng@chromium.org2014-04-0810-30/+34
| | | | | | | | | | | This is a mechanical change to followup on Blink and content changes to change parameter types to WebLocalFrame where appropriate. BUG=346764 Review URL: https://codereview.chromium.org/226093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262320 0039d316-1c4b-4281-b951-d872f2087c98
* Abstract TranslateTabHelper::ShowTranslateUI through TranslateClientblundell@chromium.org2014-04-071-0/+12
| | | | | | | | | | Straightforward abstraction of the method in question. BUG=360002 Review URL: https://codereview.chromium.org/224963011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262243 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate calls to BrowserContext::IsOffTheRecord in TranslateManagerblundell@chromium.org2014-04-074-0/+11
| | | | | | | | | | These calls are now abstracted through TranslateDriver. BUG=360008 Review URL: https://codereview.chromium.org/226043010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262235 0039d316-1c4b-4281-b951-d872f2087c98
* Use VLOG instead of vfprintf in PLUGIN_PRINTF.teravest@chromium.org2014-04-071-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The trusted plugin refactor will move code from ppapi/native_client to components/nacl/renderer. For consistency with the rest of Chrome, the refactored code will use VLOG intead of PLUGIN_PRINTF. However, moving log statements over piecemeal will make debugging difficult as multiple logfiles would need to be consulted when debugging. Instead, this changes the internals of PLUGIN_PRINTF to call VLOG instead of vfprintf for logging. Any users who wish to see these debug statements must then pass one of the following additional flags to Chrome: "--v=1" or "--vmodule=components/nacl/renderer*=1" in addition to setting NACL_PLUGIN_DEBUG. This change removes any effects of the environment variable "NACL_PLUGIN_LOG". Once this change is submitted, I'll update any NaCl debugging documentation as appropriate. Note that this change may introduce allocations on the logging path. I think it should be unlikely that PLUGIN_PRINTF will receive inputs larger than 512 characters, but truncating the output is worse than heap allocations. BUG=239656 Review URL: https://codereview.chromium.org/224933006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262150 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare Chromium for requestAutocomplete API changes.estade@chromium.org2014-04-072-5/+17
| | | | | | | | | | | See https://codereview.chromium.org/214823008 BUG=354897 R=isherman@chromium.org Review URL: https://codereview.chromium.org/215173004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262140 0039d316-1c4b-4281-b951-d872f2087c98
* Abstract TranslateManager IPC sends through TranslateDriver.blundell@chromium.org2014-04-074-0/+53
| | | | | | | | | | | | Adds APIs to TranslateDriver for TranslateManager to call instead of directly sending IPC. ContentTranslateDriver implements these APIs via the IPC sends that were previously in TranslateManager. BUG=360008 Review URL: https://codereview.chromium.org/225423006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262135 0039d316-1c4b-4281-b951-d872f2087c98
* Move TranslateStep enum into the Translate component core code.blundell@chromium.org2014-04-072-0/+23
| | | | | | | | | | | | | | | This enum will be needed by the core Translate code. This CL moves it out of TranslateTabHelper (which will stay in //chrome) into a standalone translate_step.h file within the Translate component core code. It also renames the enum values to be prefixed by TRANSLATE_STEP_ in accordance with naming conventions for standalone enums (i.e., enums not defined within a class). BUG=360002 TBR=jochen Review URL: https://codereview.chromium.org/227043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262109 0039d316-1c4b-4281-b951-d872f2087c98
* Password bubble: Display the bubble when the user blacklist prevents autofill.mkwst@chromium.org2014-04-072-0/+5
| | | | | | | | | | | | | This CL pipes a form's blacklist state down to the new password bubble UI. The icon is (obviously) a placeholder, and the bubble will just display "No passwords saved". Baby steps for reviewer sanity. :) BUG=357597 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/225953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262105 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Attempting to resolve a race condition with PowerMonitor ↵scottmg@chromium.org2014-04-052-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/179923006/) Reason for revert: Failing interactive_ui_tests dbg: http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20(dbg)/builds/47083/steps/interactive_ui_tests/logs/stdio Original issue's description: > Attempting to resolve a race condition with PowerMonitor. > > ThreadSanitizer caught multiple instances where PowerMonitor::Get or PowerMonitor::Add/RemoveObserver were being called concurrently with the PowerMonitor constructor in the main thread. These functions access a process-global PowerMontior instance (g_power_monitor), which was not thread safe. > > This change adds locks around PowerMonitor creation and deletion, and forces Add/RemoveObserver to be called in a threadsafe manner. It also removes the need to call PowerMonitor::Get. > > BUG=268924 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262018 TBR=mattm@chromium.org,jyasskin@chromium.org,kbr@chromium.org,bradnelson@chromium.org,brettw@chromium.org,bradchen@chromium.org,willchan@chromium.org,jam@chromium.org,jochen@chromium.org,timurrrr@chromium.org,glider@chromium.org,acolwell@chromium.org,scherkus@chromium.org,bajones@chromium.org NOTREECHECKS=true NOTRY=true BUG=268924 Review URL: https://codereview.chromium.org/226263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262026 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to resolve a race condition with PowerMonitor.bajones@chromium.org2014-04-052-2/+3
| | | | | | | | | | | | ThreadSanitizer caught multiple instances where PowerMonitor::Get or PowerMonitor::Add/RemoveObserver were being called concurrently with the PowerMonitor constructor in the main thread. These functions access a process-global PowerMontior instance (g_power_monitor), which was not thread safe. This change adds locks around PowerMonitor creation and deletion, and forces Add/RemoveObserver to be called in a threadsafe manner. It also removes the need to call PowerMonitor::Get. BUG=268924 Review URL: https://codereview.chromium.org/179923006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262018 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Move NexeDidCrash() to NexeLoadManager.teravest@chromium.org2014-04-053-54/+89
| | | | | | | | | | | | | | | | | | This change pulls more code out of ppapi/native_client to compnents/nacl/renderer. GetReadyTime() is removed from PPB_NaCl_Private here to simplify time management. I don't want to mix time math from Chrome and NaCl, so plugin.cc uses its own ready_time_ for some operations again, and SetReadyTime() stashes the current value of base::Time::Now in NexeLoadManager. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261820 Review URL: https://codereview.chromium.org/216103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261978 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Update revision in DEPS, r12952 -> r12992mseaborn@chromium.org2014-04-051-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix irt_clock.cc to compile after r12983. This pulls in the following Native Client changes: r12953: (mseaborn) Unsandboxed IRT: Implement getpid() r12954: (noelallen) Fix irt_syscalls.h dependency r12955: (dyen) Toolchains no longer download tar balls unnecessarily. r12956: (mseaborn) PNaCl driver scripts: Remove unused USE_BOOTSTRAP field r12957: (mseaborn) IRT interfaces: Clean up use of off_t by defining a nacl_irt_off_t type r12958: (noelallen) Fix roll r12959: (noelallen) Roll bionic toolchain. r12960: (noelallen) Update to builder output r12961: (mseaborn) PNaCl driver scripts: Fix various pyflakes warnings r12962: (dyen) Package archives now have their own json description files. r12963: (mseaborn) Fix #including of <irt_dev.h>, since nacl_io requires this to work r12964: (jvoung) Test that gdb tests work with the sandboxed translator. r12965: (mseaborn) PNaCl driver scripts: Remove use of "import *" r12966: (mseaborn) Unsandboxed IRT: Whitelist and convert mmap() flag values r12967: (bradnelson) Provide chrome the option of learning the debug stub port chosen by nacl. r12968: (dyen) Toolchain Build now stores package description files for final packages. r12969: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r12971: (mseaborn) pnacl-translate: Refactor selection of arch-specific flags r12972: (jvoung) Clean up spec2k scripts a bit. r12973: (dyen) buildbot scripts changes should trigger all trybots. r12974: (bradnelson) Adding environment variable on the bots to look for msvs2013. r12976: (bradnelson) Reducing egyptian cotton thread count for win32. r12977: (petarj) [MIPS] Make sure the function unfixed_code() ends up in the text section r12978: (dyen) Fixed an issue where closing a cygtar file doesn't close the file handle. r12979: (jvoung) Remove match awk.pass.cpp from known fails. Test got commented out. r12980: (jvoung) Add single-threaded translation variants to PNaCl spec2k bots. r12981: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r12982: (dyen) Uploads a package using package_version for all the toolchain builds *r12983: (mseaborn) IRT interfaces: Clean up use of clockid_t by defining nacl_irt_clockid_t r12984: (mseaborn) IRT interfaces: Move the dev_getpid interface into irt_dev.h for consistency r12985: (dyen) Fixed some issues with the toolchain build regarding buildbots. r12986: (jfb) Update TOOL_REVISIONS for PNaCl r12944->r12981 r12987: (dyen) Fixed some issues with the newlib and glibc buildbot. r12988: (dschuff) set svn:ignore on native_client/mingw32 directory r12989: (noelallen) Attempt to build cpu_features and desc library. r12990: (dschuff) Disable terminfo lib in LLVM cmake build r12991: (dyen) Buildbot scripts now use native python in win32 to avoid cygwin issues. r12992: (bradnelson) Only provide chrome the option of learning the debug stub port on windows. BUG=none TEST=browser_tests and nacl_integration Review URL: https://codereview.chromium.org/225283004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261927 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 261820 "Pepper: Move NexeDidCrash() to NexeLoadManager."scottmg@chromium.org2014-04-043-89/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Potentially causing failures (?) http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/509/steps/browser_tests/logs/BadNative [18,1263494912:20:15:11.094751] NaClAppRuntimeHostSetup: too late [18,1263494912:20:15:11.094843] NaClAppDescQuotaSetup: too late [18,1267164928:20:15:11.095246] NaClAppStartModule: error loading module [18,1267164928:20:15:11.095918] reap logs POST-ABORT: LOG_FATAL abort exit > Pepper: Move NexeDidCrash() to NexeLoadManager. > > This change pulls more code out of ppapi/native_client to > compnents/nacl/renderer. > > GetReadyTime() is removed from PPB_NaCl_Private here to simplify time > management. I don't want to mix time math from Chrome and NaCl, so plugin.cc > uses its own ready_time_ for some operations again, and SetReadyTime() stashes > the current value of base::Time::Now in NexeLoadManager. > > BUG=239656 > > Review URL: https://codereview.chromium.org/216103003 TBR=teravest@chromium.org, tommycli@chromium.org Review URL: https://codereview.chromium.org/226343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261860 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Move NexeDidCrash() to NexeLoadManager.teravest@chromium.org2014-04-043-54/+89
| | | | | | | | | | | | | | | | This change pulls more code out of ppapi/native_client to compnents/nacl/renderer. GetReadyTime() is removed from PPB_NaCl_Private here to simplify time management. I don't want to mix time math from Chrome and NaCl, so plugin.cc uses its own ready_time_ for some operations again, and SetReadyTime() stashes the current value of base::Time::Now in NexeLoadManager. BUG=239656 Review URL: https://codereview.chromium.org/216103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261820 0039d316-1c4b-4281-b951-d872f2087c98
* Stop doing unnecessary initialization in non-SFIhamaji@chromium.org2014-04-042-18/+28
| | | | | | | | | | | | | | | | | | | | We do not need to call NaClChromeMainInit for non-SFI NaCl. It seems the log module is initialized in other places, and SRPC module is initialized in nonsfi_main. Also set uses_irt=false for non-SFI NaCl. We do not need to send the unnecessary FD of IRT. With this patch, we will not call modify_ldt in non-SFI mode. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734 BUG=350487 TEST=out/Release/browser_tests --gtest_filter='NaCl*' TEST=Our app works without modify_ldt Review URL: https://codereview.chromium.org/218633011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261691 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for hooking up external feedback mechanism for DOM Distillernyquist@chromium.org2014-04-042-1/+30
| | | | | | | | | | | | | | | This adds support for injecting an external feedback reporting library for the DOM Distiller. By default, a no-op version is used. For feedback, it is reasonable to assume that the original URL which was distilled is needed, and this CL also adds support for retrieving that from Java. BUG=319881 Review URL: https://codereview.chromium.org/222883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261688 0039d316-1c4b-4281-b951-d872f2087c98
* Move Translate renderer messages to the Translate componentdroger@chromium.org2014-04-043-0/+132
| | | | | | | | | BUG=335082 TBR=thakis Review URL: https://codereview.chromium.org/219963007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261683 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor around ppb_nacl_private_impl and TrustedPluginChannel.hidehiko@chromium.org2014-04-043-48/+75
| | | | | | | | | | | | | | | | | | | | | | | | This is the preparation to add new IPC channel for EmbedderServiceChannel. This contains several small refactoring: 1) Introduces IsValidChannelHandle() to avoid copy-and-paste code. 2) Removes unnecessary "static" keywords. 3) Uses base::Callback instead of PP_CompletionCallback for TrustedPluginChannel. After we add EmbedderServiceChannel, it is necessary to wait that the channels are established in parallel. So, the callback needs to count the number of invocations. base::Callback makes it much easier than PP_CompletionCallback. 4) Removes unnecessary include directive from the header file. Instead, uses forward declaration. 5) Invokes connected_callback in dtor if it is not called yet. 6) Invokes completion_callback if trusted plugin channel is somehow accidentally not created to handle error properly. TEST=Ran trybots. BUG=358431 Review URL: https://codereview.chromium.org/224003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261675 0039d316-1c4b-4281-b951-d872f2087c98
* Moves ppapi/nacl_irt/{README,irt_ppapi.h} to ppapi/nacl_irt/public.hidehiko@chromium.org2014-04-042-2/+2
| | | | | | | | | | | | | This is preparation to add open_resource() irt for non-SFI mode. Some codes will be under ppapi/nacl_irt/src, so this CL moves the files directly under ppapi/nacl_irt to its public directory. TEST=Build the binary. Run trybot. BUG=358431 Review URL: https://codereview.chromium.org/214883007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261656 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI/NaCl: Move architecture histogram to NexeLoadManagerdmichael@chromium.org2014-04-031-0/+36
| | | | | | | | BUG=239656 Review URL: https://codereview.chromium.org/224143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261565 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize SigninTrackerblundell@chromium.org2014-04-033-0/+184
| | | | | | | | | | | This file can be moved as-is. BUG=334169 TBR=jochen Review URL: https://codereview.chromium.org/223593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261544 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Chromium builds shouldn't ask for access to Chrome's own secure data.mark@chromium.org2014-04-031-0/+5
| | | | | | | | | | | | | | | | The message that this presents is: Chromium wants to use your confidential information stored in “Chrome Safe Storage” in your keychain. Do you want to allow access to this item? Chromium shouldn't ask for access to Google Chrome's data, it should have its own Chromium Safe Storage item in the keychain. R=isherman@chromium.org Review URL: https://codereview.chromium.org/200623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261515 0039d316-1c4b-4281-b951-d872f2087c98
* Make DistillerPageWebContentsTest a real test that uses the distiller.yfriedman@chromium.org2014-04-035-42/+134
| | | | | | | | | | | | | | | Previously, the test used a hardcoded distiller template which didn't help test the distiller. Updates the test to use the real distiller and adds tests for relativization of images and anchors. In the process, attempts to handle a few failure modes of the distiller. BUG=353349,354737 TBR=blundell Review URL: https://codereview.chromium.org/211493008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261463 0039d316-1c4b-4281-b951-d872f2087c98