| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=288991
R=bradnelson@google.com
Reland of r245254
Review URL: https://codereview.chromium.org/141053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the dependencies of these policy handlers have already been moved into
the policy component, and they can now be moved as well. This enables their
usage on ios builds.
BUG=275292
Review URL: https://codereview.chromium.org/140803003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=275292
Review URL: https://codereview.chromium.org/140823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements nacl_irt_clock on non-sfi mode,
which is simply proxying to the glibc implementation.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.
Review URL: https://codereview.chromium.org/139303003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org,isherman@chromium.org,thakis@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/130433008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move into base/numerics subdirectory.
* Rename files for clarity.
* Add owners.
* Rename checked_numeric_cast to checked_cast.
* Fixup callsites and include paths.
BUG=332611
R=brettw@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/141113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change enables this code to be built on iOS and facilitates the eventual
componentization of //chrome-browser/sync. As with other Autofill unit
tests, componentization of the unit test will follow.
Review URL: https://codereview.chromium.org/129463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
FakeDB::EntryMap wasn't getting cleaned up in the test. Changed the API
to make it clearer that ownership isn't taken.
BUG=334682
Review URL: https://codereview.chromium.org/140113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/68853015/)
Reason for revert:
Broke Blink compile
Original issue's description:
> Convert the re2 GYP targets to be generated by GN.
>
> BUG=288991
> R=bradnelson@google.com
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245254
TBR=bradnelson@chromium.org,bradnelson@google.com
NOTREECHECKS=true
NOTRY=true
BUG=288991
Review URL: https://codereview.chromium.org/141063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=288991
R=bradnelson@google.com
Review URL: https://codereview.chromium.org/68853015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements nacl_irt_futex for non-sfi mode.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.
Review URL: https://codereview.chromium.org/139453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The policy protobufs were duplicated at chrome/browser/policy/proto
so that the protofiles ebuild of ChromeOS could still fetch them.
That ebuild has been fixed in a separate CL at:
https://chromium-review.googlesource.com/#/c/182300/
BUG=327345
Review URL: https://codereview.chromium.org/137903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements nacl_irt_thread and nacl_irt_tls.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.
Review URL: https://codereview.chromium.org/133683011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements nacl_irt_fdio for non-sfi mode.
Note that getdents is currently not supported because there is no good way to
implement it in a sane manner. Now it always returns ENOSYS.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.
TEST=Make sure lseek and fstat refer to lseek64 and __fxstat64.
Review URL: https://codereview.chromium.org/131133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Speeds up running grit on this step from 53s to 40s on my Mac.
BUG=
Review URL: https://codereview.chromium.org/137393007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pickled entries might contain inconsistent data and trigger the check in the
network stack.
BUG=334125
R=marja@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/137893006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=334082
R=bauerb@chromium.org,inferno@chromium.org
Review URL: https://codereview.chromium.org/134773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also default to sandbox when --reduce-security-for-testing is passed
BUG=332156
Review URL: https://codereview.chromium.org/132643003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For experimentation with the dom distiller component, this provides a minimal API wrapping the functions of DomDistillerService.
Sketch proposal:
https://docs.google.com/a/google.com/document/d/1zLTKNAOkTyFpgeJqWg3Jn17Ayc-sYafyftBE6KUldV4/edit
BUG=288015
TBR=joi
Review URL: https://codereview.chromium.org/116553005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directly to their owning class types.
Also does a little bit of other non-functional cleanup, mostly eliminating
unnecessary get() calls and fixing violations of the "don't handle DCHECK
failure" style rule.
BUG=303818
TEST=none
R=dmichael@chromium.org
Review URL: https://codereview.chromium.org/122543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I retained a couple of wrapper functions in content that post back to the UI thread if they are called from another thread. All existing code will continue to use these wrappers. The intent is that some code that I don't want to depend on content that only lives on the UI thread can now call //base/metrics code directly.
R=isherman@chromium.org, jam@chromium.org
http://crbug.com/332504
Review URL: https://codereview.chromium.org/129223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The AutoCleanUpStrategy policy can take on one of two values. Both should
be listed in the schema.
BUG=306334
TEST=None
Review URL: https://codereview.chromium.org/136633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=332675
R=bauerb@chromium.org,inferno@chromium.org
Review URL: https://codereview.chromium.org/135543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The callback is called both for the main and isolated worlds, the new
API indicates in which world the window object was cleared
BUG=none
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/133123008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creation.
This is part of relanding https://chromiumcodereview.appspot.com/12546016
Unifying the Cookiecreation interface makes the cookie store creation more
consistent. Having a config struct also enables the next refactor where we move
the cookie store creation enitrely into the content layer (the embedder will only
responsible for providing the correct configuration).
This also changes the lifetime of CookieCryptoDelegate so one object can be
shared amongst multiple cookie stores. Allows for easier lifetime semantics in
the CookieStoreConfig and also is slightly less wasteful of memory.
TBR=jam
BUG=159193
Review URL: https://codereview.chromium.org/110883017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces the TranslateDelegate to inject the required
dependencies in the translate component.
TranslateDelegate is a singleton for now, but this will need to be
revisited once the ownership model of TranslateManager is improved.
BUG=331509
Review URL: https://codereview.chromium.org/131463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/131573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the mechanism to pass an irt querying function to the plugin
process via AT_SYSINFO. Also, as the first step to implement many irt functions
for non-SFI mode, this CL introduces nacl_irt_basic.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.
Review URL: https://codereview.chromium.org/125533004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This interface is intended for embedders to supply to the Signin component.
It had been created during an earlier aborted effort to componentize Signin.
BUG=332107
TBR=joi
Review URL: https://codereview.chromium.org/132083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
passwords.
BUG=307308
TEST=browser_tests
R=gcasto@chromium.org
Review URL: https://codereview.chromium.org/119493004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Assigning the first NaCl module to load to port 4014, allowing other to be
dynamic, using a code path currently used for testing.
Expose the port used by each module in the Task Manager UI to make it available
to users debugging NaCl modules.
Follow on changes will add extension api fields to make debuggable modules
discoverable to a web based debugger.
NOTE: The debug stub port on windows is opened at a different layer (inside nacl, only availabled with --disable-sandbox). This will be exposed in a follow on change.
Reviewers:
yoshiki@chromium.org (for task_manager)
pkasting@chromium.org (for browser/ui)
brettw@chromium.org (for content)
noelallen@chromium.org (for nacl)
BUG=328714
TEST=trybots
R=yoshiki@chromium.org,pkasting@chromium.org,brettw@chromium.org,noelallen@chromium.org
Review URL: https://codereview.chromium.org/102073008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=314976
R=isherman@chromium.org
Review URL: https://codereview.chromium.org/112663005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LanguageUsageMetrics is moved to its own component because it is used
both in the translate component and directly in the browser.
TranslateBrowserMetrics is moved to the translate component.
BUG=331509
TBR=jochen
Review URL: https://codereview.chromium.org/131203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some components of a 32 bit build of chrome for Windows need to be built
as Win64 Dlls. To allow those components to use base, we make a Win64
build of the base library even when building chrome 32 bit.
This is needed by the Chrome Desk Band code. crbug.com/327435.
https://codereview.chromium.org/79173004/
BUG=327435
Review URL: https://codereview.chromium.org/103333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/131593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=317523
Review URL: https://codereview.chromium.org/131553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
instead of TokenWebData::FromBrowserContext.
This CL is an unchanged reland of https://codereview.chromium.org/109783003/,
which had been speculatively reverted to see if it was causing ChromeOS build
failures. The speculative revert unfortunately stuck as it happened to land in
the same run as the CL that actually fixed the (unrelated) ChromeOS build
failures: https://codereview.chromium.org/129343003/.
BUG=332107
TBR=noamsml
Review URL: https://codereview.chromium.org/130813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=332675
R=bauerb@chromium.org,inferno@chromium.org
Review URL: https://codereview.chromium.org/131073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
there already is information in the autofill DB.
BUG=326679
Review URL: https://codereview.chromium.org/120343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=329978
TEST=none
R=palmer@chromium.org
Review URL: https://codereview.chromium.org/98753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds two new policies that will allow to block all or some native
messaging hosts.
BUG=237882
Review URL: https://codereview.chromium.org/118253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Only disable it if there's no indication the user might be interested in US addresses. App locale is not taken into account because many international users set theirs to en-US.
BUG=323641
Review URL: https://codereview.chromium.org/106033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330084
Review URL: https://codereview.chromium.org/111853012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=331459
TBR=sehr@chromium.org
Review URL: https://codereview.chromium.org/126823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=332169
R=zea@chromium.org
Review URL: https://codereview.chromium.org/128193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: ChromeOS bot failures, example http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19049
Failing lines:
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry [ FAILED ]
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',)
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry [ FAILED ]
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',)
TBR=joi@chromium.org,rogerta@chromium.org,tfarina@chromium.org,thakis@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332107
Review URL: https://codereview.chromium.org/129253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297480
R=aa@chromium.org,bauerb@chromium.org
Review URL: https://codereview.chromium.org/116163008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used by the VariationsService to simulate newly
received variations seed, to evaluate whether there's sufficient
new changes to badge the UI to suggest a restart (similar to
what happens during auto updates).
This is the initial version of this class and still
has some missing pieces, left as TODOs.
BUG=315807
TEST=Unit tests.
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/41623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dependency path is
src/chrome/chrome.gyp:common ->
src/components/components.gyp:policy_component ->
src/components/components.gyp:user_prefs ->
src/content/content.gyp:content_browser
This was introduced in https://codereview.chromium.org/102973005. The issue is
that URLBlacklistManager::RegisterProfilePrefs() uses a PrefServiceSyncable
which comes from user_prefs, and user_prefs depends on content::BrowserContext.
This fix splits the policy/common files into a policy_component_common target
that does not depend on user_prefs. chrome.gyp:common now depends on
policy_component_common, and chrome.gyp:browser depends on policy_component.
BUG=332030
Review URL: https://codereview.chromium.org/124393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
instead of TokenWebData::FromBrowserContext.
BUG=332107
TBR=thakis
Review URL: https://codereview.chromium.org/109783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243564 0039d316-1c4b-4281-b951-d872f2087c98
|