summaryrefslogtreecommitdiffstats
path: root/components
Commit message (Collapse)AuthorAgeFilesLines
* Move a BrowserContextKeyedService-specific switchphajdan.jr@chromium.org2013-06-121-3/+7
| | | | | | | | | | | out of content and to the component. BUG=227219 R=jam@chromium.org Review URL: https://codereview.chromium.org/16362004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 205670 "Un-refcount AutofillWebData and TokenWebData"raymes@chromium.org2013-06-1210-91/+117
| | | | | | | | | | | | | | | | | | > Un-refcount AutofillWebData and TokenWebData > > depends on https://codereview.chromium.org/15927029/ > > BUG=230920 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205038 > > Review URL: https://chromiumcodereview.appspot.com/16154031 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/16347019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205685 0039d316-1c4b-4281-b951-d872f2087c98
* Un-refcount AutofillWebData and TokenWebDatacaitkp@chromium.org2013-06-1110-117/+91
| | | | | | | | | | | | depends on https://codereview.chromium.org/15927029/ BUG=230920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205038 Review URL: https://chromiumcodereview.appspot.com/16154031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205670 0039d316-1c4b-4281-b951-d872f2087c98
* Using form field errors from Wallet server.ahutter@chromium.org2013-06-118-47/+414
| | | | | | | | | | | | The Wallet server identifies validation errors when the client tries to save or update data to it. This utilizes the errors returned and displays them to the user. BUG=243853 Review URL: https://chromiumcodereview.appspot.com/14585016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205607 0039d316-1c4b-4281-b951-d872f2087c98
* Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"rsleevi@chromium.org2013-06-111-2/+2
| | | | | | | | | | | | | | | | | | | This upates calls to bound temporary objects to also use get(). While it has the same semantic equivalence to the existing code, this generally represents a dangerous pattern - indeed, part of the whole motivation for this change is to make this anti-pattern very visible to authors. This change simply updates all of the call sites, to allow the "operator T*" to be removed and preventing new instances. The existing instances will then be reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T> rather than T*, as appropriate. BUG=110610 TBR=darin Review URL: https://codereview.chromium.org/15984016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
* components: Move user_prefs into user_prefs namespace.tfarina@chromium.org2013-06-118-14/+14
| | | | | | | | | BUG=245050 R=joth@chromium.org,thestig@chromium.org,joi@chromium.org Review URL: https://chromiumcodereview.appspot.com/16625004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205517 0039d316-1c4b-4281-b951-d872f2087c98
* [Autofill] Fix popup delegate to show warnings correctly.isherman@chromium.org2013-06-112-7/+33
| | | | | | | | | | BUG=247880 TEST=out/Debug/unit_tests --gtest_filter=AutofillExternalDelegateUnitTest.AutofillWarnings R=csharp@chromium.org Review URL: https://chromiumcodereview.appspot.com/16344003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205502 0039d316-1c4b-4281-b951-d872f2087c98
* Autocheckout: click elements before/after fill the forms.benquan@chromium.org2013-06-118-13/+173
| | | | | | | | BUG=242394 Review URL: https://chromiumcodereview.appspot.com/16067006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205492 0039d316-1c4b-4281-b951-d872f2087c98
* Convert full state names to abbreviated state names for Wallet.estade@chromium.org2013-06-116-9/+67
| | | | | | | | | | also validate states. BUG=236082 Review URL: https://chromiumcodereview.appspot.com/16012011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205484 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in components/, part 1.avi@chromium.org2013-06-1149-56/+56
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16469004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205403 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in components/, part 2.avi@chromium.org2013-06-1155-61/+61
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16450003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205402 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency of WebData on notificationsdroger@chromium.org2013-06-106-22/+10
| | | | | | | | | | | The notification code was actually unused in WebData. This CL removes the code and enforces the lack of dependency. BUG=248049 Review URL: https://chromiumcodereview.appspot.com/16124006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205269 0039d316-1c4b-4281-b951-d872f2087c98
* In components/autofill, move browser/wallet/ to content/browser/wallet/blundell@chromium.org2013-06-1034-146/+146
| | | | | | | | | | | | | | This change is part of moving components/autofill into its eventual structure as a layered component. As part of this move, this CL renames the autofill_test_util target (which contains only util code for testing wallet) to autofill_content_test_util. TBR=joi, thakis BUG=247015 Review URL: https://chromiumcodereview.appspot.com/16579003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205259 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 205038 "Un-refcount AutofillWebData and TokenWebData"cpu@chromium.org2013-06-0810-91/+117
| | | | | | | | | | | | | | | | | | | | | | | Not sure if this is the culprit but lots of bots are red unittest runs in linux mac and chromeos are not completing (timeout) no output. Only for CL common to all, this is one. I'll unrevert if it does not help. > Un-refcount AutofillWebData and TokenWebData > > depends on https://codereview.chromium.org/15927029/ > > BUG=230920 > > Review URL: https://chromiumcodereview.appspot.com/16154031 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/15937020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205055 0039d316-1c4b-4281-b951-d872f2087c98
* add switches::kAutocheckoutWhitelistUrlbenquan@chromium.org2013-06-083-2/+14
| | | | | | | | BUG= Review URL: https://chromiumcodereview.appspot.com/16160021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205040 0039d316-1c4b-4281-b951-d872f2087c98
* Un-refcount AutofillWebData and TokenWebDatacaitkp@chromium.org2013-06-0810-117/+91
| | | | | | | | | | depends on https://codereview.chromium.org/15927029/ BUG=230920 Review URL: https://chromiumcodereview.appspot.com/16154031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205038 0039d316-1c4b-4281-b951-d872f2087c98
* [PasswordAutofill] Only autofill passwords into <input type="password"> fieldsgcasto@chromium.org2013-06-082-2/+10
| | | | | | | | BUG=247513 Review URL: https://chromiumcodereview.appspot.com/15848020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205022 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-06-081-4/+5
| | | | | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 Reland of 198820 and 298824 Original review = https://codereview.chromium.org/13165005 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/16392011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome_frame/, ↵avi@chromium.org2013-06-0777-77/+77
| | | | | | | | | | | | chromeos/, cloud_print/, components/, courgette/, device/, extensions/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16614002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204961 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 204916 "Autofil Dialog: Do not allow user input un suppor..."kuan@chromium.org2013-06-073-43/+24
| | | | | | | | | | | | | | > Autofil Dialog: Do not allow user input un supported card number in wallet mode. > > BUG=175900 > > Review URL: https://chromiumcodereview.appspot.com/16165002 TBR=benquan@chromium.org Review URL: https://codereview.chromium.org/16674003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204930 0039d316-1c4b-4281-b951-d872f2087c98
* Autofil Dialog: Do not allow user input un supported card number in wallet mode.benquan@chromium.org2013-06-073-24/+43
| | | | | | | | BUG=175900 Review URL: https://chromiumcodereview.appspot.com/16165002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204916 0039d316-1c4b-4281-b951-d872f2087c98
* Replace WebDatabaseObserver with callbackscaitkp@chromium.org2013-06-076-78/+75
| | | | | | | | | TBR=tim@chromium.org (sync/glue changes) BUG=230920 Review URL: https://chromiumcodereview.appspot.com/15927029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204894 0039d316-1c4b-4281-b951-d872f2087c98
* In components/autofill, move browser/risk/ to content/browser/risk/blundell@chromium.org2013-06-075-24/+125
| | | | | | | | | | | | | This change is part of moving components/autofill into its eventual structure as a layered component. This CL additionally creates the autofill_content_browser target and renames the autofill_risk_proto target to autofill_content_risk_proto. TBR=joi, darin, benm BUG=247015 Review URL: https://chromiumcodereview.appspot.com/16363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204842 0039d316-1c4b-4281-b951-d872f2087c98
* Depend on public/blink.gyp:blink to depend on Blink libraryjamesr@chromium.org2013-06-072-2/+2
| | | | | | | | | | | This way chromium code does not have to depend on the internal directory structure of blink to depend on the library. R=darin@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/16295027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204687 0039d316-1c4b-4281-b951-d872f2087c98
* In components/autofill, move renderer/ to content/rendererblundell@chromium.org2013-06-0616-74/+95
| | | | | | | | | | | | | | This change is part of moving components/autofill into its eventual structure as a layered component. This CL additionally adds a README in components/autofill that explains the project of making autofill into a layered component. TBR=thakis BUG=247015 Review URL: https://chromiumcodereview.appspot.com/15949025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204642 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the SiteInstance into CreateRenderProcessHostjyasskin@chromium.org2013-06-061-1/+2
| | | | | | | | | | | so that the RenderProcessHostFactory has as much information as the default branch. TBR=gbillock Review URL: https://chromiumcodereview.appspot.com/16490003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204613 0039d316-1c4b-4281-b951-d872f2087c98
* Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some ↵ajwong@chromium.org2013-06-069-194/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | unnecessary real threads. This CL creates a new class, TestBrowserThreadBundle, that creates a TestBrowserThread for the most commonly needed BrowserThreads. It also adds this thread bundle into RenderViewHostTestHarness because most tests that use this harness need these threads in order to run. To support TestBrowserThreadBundle, BrowserThreadImpl's test construction was also modified to understand a NULL message_loop. Aside from introducing the new class, this CL also removes: (1) unnecessary constructors in test (2) DISALLOW_COPY_AND_ASSIGNS in test fixtures* (3) now redundant TestBrowserThreads from tests (4) bad access-level changes for SetUp() and TearDown() (5) using declarations that root off the global scope (6) uses of MessageLoop's RunUntilIdle() and Quit() (7) as many real threads as possible There are also a changes to MediaCaptureDevicesDispatcher and OneClickSigninHelper that allow unittests to cut dependencies on IO thread activity. DesktopNotificationServiceTest (and a couple of others) were also made single threaded because the synchronization logic required for a non-flaky test meant the parallelism only really exercised the extra code in the test that forced the serialization. * DISALLOW_COPY_AND_ASSIGN does not serve much purpose in GTest fixture types. However, using it removes the compile-provided default constructor which forces the fixture writer to provide an empty default constructor. Since GTest recommends the default constructor as the preferred method to do setup for a test (as opposed to the SetUp() method), it's confusing to have bunch of classes with both SetUp() and a default constructor. It's simpler and uses less code to just remove the DISALLOW_COPY_AND_ASSIGN. An alternative would be to use the default constructor for initialization, but this is not possible because of our test harnesses are inheritance based which means it is impossible for a derived fixture to perform initialization before the harness if we use the GTest preferred default constructor initialization pattern. TBR=avi,battre,ben,benwells,brettw,dbeam,dimich,joi,joth,mad,marja,markusheintz,noelallen,phajdan,rdsmith,satorux,scherkus,sky,stevenjb,stuartmorgan,timsteele BUG=159193 Review URL: https://chromiumcodereview.appspot.com/14197014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204603 0039d316-1c4b-4281-b951-d872f2087c98
* rAc: fill in "shipping name" when the user has selected "same as billing"estade@chromium.org2013-06-061-1/+1
| | | | | | | | BUG=245493 Review URL: https://chromiumcodereview.appspot.com/16325023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204482 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill support for separate billing address phone numberdgwallinga@chromium.org2013-06-0610-30/+89
| | | | | | | | BUG=245105,244515 Review URL: https://chromiumcodereview.appspot.com/15925013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204462 0039d316-1c4b-4281-b951-d872f2087c98
* Handling CHOOSE_ANOTHER_INSTRUMENT_OR_ADDRESS by re-fetching WalletItems.dbeam@chromium.org2013-06-061-1/+1
| | | | | | | | | | BUG=246866 R=estade@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16082007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204447 0039d316-1c4b-4281-b951-d872f2087c98
* C++ readability review for ishermanisherman@chromium.org2013-06-052-75/+73
| | | | | | | | BUG=b/8759920 Review URL: https://chromiumcodereview.appspot.com/14621006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204281 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight fields we know to be invalid but have no way of locally checking.dbeam@chromium.org2013-06-042-0/+9
| | | | | | | | | | | | | In this specific case, expired Online Wallet instruments. R=groby@chromium.org,estade@chromium.org TBR=aruslan@chromium.org BUG=168680 TEST=unit_tests and manual Review URL: https://chromiumcodereview.appspot.com/15961007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204012 0039d316-1c4b-4281-b951-d872f2087c98
* Stop offering Autocheckout bubble on the forms of no interest to Autocheckout.ramankk@chromium.org2013-06-046-39/+139
| | | | | | | | BUG=243522 Review URL: https://chromiumcodereview.appspot.com/15942004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203923 0039d316-1c4b-4281-b951-d872f2087c98
* Display notification in rAc dialog when talking to other than production ↵dbeam@chromium.org2013-06-043-0/+25
| | | | | | | | | | | wallet servers. R=abodenha@chromium.org BUG=245492 Review URL: https://chromiumcodereview.appspot.com/16098003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203864 0039d316-1c4b-4281-b951-d872f2087c98
* Autocheckout: parse multiple clicks setting in autofill response.benquan@chromium.org2013-06-044-25/+125
| | | | | | | | BUG=242394 Review URL: https://chromiumcodereview.appspot.com/15487004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203854 0039d316-1c4b-4281-b951-d872f2087c98
* Carts are deprecated by the latest version of the serverahutter@chromium.org2013-06-047-129/+0
| | | | | | | | BUG= 240333 Review URL: https://chromiumcodereview.appspot.com/14836006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203852 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for googleurl. Second try.tfarina@chromium.org2013-06-033-4/+4
| | | | | | | | | | | | | | | - Update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. r184: Fix C++11 compilation on iOS r185: Forward includes to url/ BUG=229660 R=thestig@chromium.org,brettw@chromium.org TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/15421002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203672 0039d316-1c4b-4281-b951-d872f2087c98
* Update components/ to use scoped_refptr<T>::get() rather than implicit ↵rsleevi@chromium.org2013-06-0210-33/+33
| | | | | | | | | | | | | "operator T*" Linux fixes BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/15649019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203615 0039d316-1c4b-4281-b951-d872f2087c98
* Hang SyncableServices off AutofillBackend, since they are on the DB thread ↵caitkp@chromium.org2013-06-014-31/+42
| | | | | | | | | | | already. TBR=atwilson@chromium.org BUG=230920 Review URL: https://chromiumcodereview.appspot.com/15962011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203565 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill:rAc: Wrongly assumed that the is_minimal_address field is a json ↵ramankk@chromium.org2013-05-312-7/+7
| | | | | | | | | | string instead of boolean. Fixed it. BUG=173517 Review URL: https://chromiumcodereview.appspot.com/15772016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203465 0039d316-1c4b-4281-b951-d872f2087c98
* Add tracing to BrowserContextDependencyManager for analyzing startup ↵andrewhayden@chromium.org2013-05-311-0/+3
| | | | | | | | | | performance. BUG=222350 Review URL: https://chromiumcodereview.appspot.com/15853006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203428 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UI for possible username selection via Finch experiment.gcasto@chromium.org2013-05-316-11/+131
| | | | | | | | | | This feature will only be enabled on Dev/Beta until we collect stats proving it's worth. BUG=188908 Review URL: https://chromiumcodereview.appspot.com/13843015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203319 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::MessageLoop in more files.xhwang@chromium.org2013-05-302-5/+5
| | | | | | | | | | | These are either missed in the first pass, or added after the first pass. TBR=thestig@chromium.org BUG=236029 Review URL: https://codereview.chromium.org/16092013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203259 0039d316-1c4b-4281-b951-d872f2087c98
* Color Picker for <input type=color>paulnavin@google.com2013-05-301-4/+3
| | | | | | | | | | | | | | | | | | | Thanks for all the review comments! I think this is now ready. :-) I've replied to as many comments as possible, I hope my replies make sense. Thanks again, I'm learning a lot! :-) References: - The mockup I'm following is here: https://docs.google.com/a/google.com/file/d/0B2S_KwX0QwGFb2JVTlhPYlRqaEE/edit - There's an APK here: https://drive.google.com/a/google.com/folderview?id=0B8nL-JlqpL9nLURUVnJsdTFDYjQ BUG=135771 Review URL: https://chromiumcodereview.appspot.com/14170009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203195 0039d316-1c4b-4281-b951-d872f2087c98
* Determine card egilibility by card.status from server only.benquan@chromium.org2013-05-301-1/+2
| | | | | | | | | | | | Sugar server already set status when the card is not eligible for transaction, like UNSUPPORTED_COUNTRY, AMEX_NOT_SUPPORTED etc. This CL also enables BILLING_INCOMPLETE as we want it to be selectable and put it under edit mode when the user selects it. BUG=245006 Review URL: https://chromiumcodereview.appspot.com/16208002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203182 0039d316-1c4b-4281-b951-d872f2087c98
* Update references to Blink's Platform API headers (remaining)abarth@chromium.org2013-05-3013-20/+19
| | | | | | | | | | | | | | | These headers have moved from Source/Platform/chromium/public to public/platform. This CL updates the remaining references to the old location to point to the new location. After this CL lands, I'll remove the forwarding headers that are letting these references still work. TBR=darin@chromium.org BUG=239545 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15648012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203106 0039d316-1c4b-4281-b951-d872f2087c98
* [Autofill] Pass struct by const-reference.isherman@chromium.org2013-05-302-2/+2
| | | | | | | | | BUG=none R=estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/16077005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203094 0039d316-1c4b-4281-b951-d872f2087c98
* Make suggestions invalid when no phone number is attached to a Wallet ↵dbeam@chromium.org2013-05-301-1/+1
| | | | | | | | | | | | | | address/instrument. This is generally not applicable to autofill as we either filter out incomplete profiles or there's no associated phone number (in the case of credit cards). BUG=180149 R=estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/15892013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203068 0039d316-1c4b-4281-b951-d872f2087c98
* components: Move web_contents_delegate_android into ↵tfarina@chromium.org2013-05-298-16/+16
| | | | | | | | | | | web_contents_delegate_android namespace. BUG=238224 R=joi@chromium.org, joth@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/16073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202981 0039d316-1c4b-4281-b951-d872f2087c98
* Remember the initial checked state of {radiobutton|checkbox}. If autofill ↵ramankk@chromium.org2013-05-291-0/+1
| | | | | | | | | | flow is not autocheckout, autofilling a form should just use remembered values for checkable elements. BUG=244645 Review URL: https://chromiumcodereview.appspot.com/15659015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202965 0039d316-1c4b-4281-b951-d872f2087c98