summaryrefslogtreecommitdiffstats
path: root/components
Commit message (Collapse)AuthorAgeFilesLines
* Revert of Re-land: cc: Use worker context for one-copy tile initialization. ↵sky2015-08-181-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #29 id:560001 of https://codereview.chromium.org/1230203007/ ) Reason for revert: Sorry Dave. I'm reverting as this broke mandoline. To see the breakage build mandoline:all, and run with: mandoline --oopif-always-create-new-frame-tree http://phuang.github.io/iframe.html . We do have mandoline tests that run, but they run with the code path gfx::GLSurfaceTestSupport::InitializeOneOff(), which is why they likely still pass. I'll see about making the tests not run with that config. Original issue's description: > Re-land: cc: Use worker context for one-copy tile initialization. > > This moves management of staging resources to > OneCopyTileTaskWorkerPool class. This makes it possible > to use a worker context to issue and detect when copy > operations complete. > > BUG=490295 > TBR=jamesr@chromium.org, sky@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/af0ab609b53c64ce43172be42e20e7ca8beab497 > Cr-Commit-Position: refs/heads/master@{#343947} TBR=jamesr@chromium.org,kbr@chromium.org,piman@chromium.org,primiano@chromium.org,vmiura@chromium.org,vmpstr@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490295 Review URL: https://codereview.chromium.org/1298143003 Cr-Commit-Position: refs/heads/master@{#344042}
* Revert of [Android] Rewrite old new tab and welcome page URLs. (patchset #1 ↵rch2015-08-181-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1290663004/ ) Reason for revert: Looks like it caused this failure: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29666 Original issue's description: > [Android] Rewrite old new tab and welcome page URLs. > > When launching Chrome after an update from an old version, > chrome://newtab and chrome://welcome are now rewritten to > chrome-native://newtab. This gracefully replaces the old NTP and welcome > pages with the new NTP, so that users don't see a "page not found" error > after updating Chrome. > > Note: this only affects users who update from a version of Chrome prior > to M37, when the NTP and welcome pages were removed. > > BUG=516379 > > Committed: https://crrev.com/d34f9ac72e605bc08fa1ac4607e48eeb13d98907 > Cr-Commit-Position: refs/heads/master@{#343981} TBR=jochen@chromium.org,skuhne@chromium.org,newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516379 Review URL: https://codereview.chromium.org/1304483002 Cr-Commit-Position: refs/heads/master@{#344038}
* Sync GN tests with GYP build.brettw2015-08-186-6/+22
| | | | | | | | | | | | This updates GN's app_list_unittests, base_unittests, cast_unittests, cc_unittests, components_unittests, crypto_unittests, events_unittests, and gl_unittests to match the GYP build (with the exception of some NaCl-specific ones). The printing component is now hooked up to all components, and the printing names were fixed to be GN-style and to be source sets instead of shared libraries. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1295233003 Cr-Commit-Position: refs/heads/master@{#344024}
* Put components/error_page code in namespace error_page.thestig2015-08-185-405/+363
| | | | | | Review URL: https://codereview.chromium.org/1301733002 Cr-Commit-Position: refs/heads/master@{#344019}
* [Sync] Componentize typed_url_model_associator.maxbogue2015-08-189-0/+1117
| | | | | | | | | | This CL adds IsCryptographerReady and GetUserShare to SyncService. BUG=512460 Review URL: https://codereview.chromium.org/1277913004 Cr-Commit-Position: refs/heads/master@{#344018}
* Add missing keyword.sorin2015-08-181-1/+1
| | | | | | | | TBR=waffles Review URL: https://codereview.chromium.org/1291223003 Cr-Commit-Position: refs/heads/master@{#344012}
* Rename Net.DailyContentLength_DataReductionProxyEnabled_Unknown.kundaji2015-08-181-8/+9
| | | | | | | | | | | | Net.DailyContentLength_DataReductionProxyEnabled_Unknown is accidentally tracking 2 separate metrics in the same histogram. It clashes with the histogram generated by adding the "Unknown" suffix in Net.DailyContentLength_DataReductionProxyEnabled. Moving both histograms to a new name and deprecating the old histograms. Review URL: https://codereview.chromium.org/1298073002 Cr-Commit-Position: refs/heads/master@{#344000}
* Add stats collection for telemetry startup.warm.blank_page test.msw2015-08-1814-15/+297
| | | | | | | | | | | | | | | | | | | | | | | | | | | This attempts to mirror similar functionality in Chrome. Add StartupPerformance[Times|DataCollector] to mojo:metrics. Record times from the shell, mojo:browser, and mojo:html_viewer. Add the --enable-stats-collection-bindings flag for mandoline. Add StatsCollectionController to mojo:html_viewer. This registers and implements JS callbacks for perf testing. TODO: Record more appropriate times; sanity check values! TODO: Consolidate more code in startup_metric_utils. TODO: Serve histogram JSON, not times struct, from mojo:tracing? TODO: Refine mojo:tracing; combine with or use components/tracing? TODO: Use base::TimeTicks deltas (crbug.com/521164) TODO: Android support. BUG=513779,517622,521164 TEST="./tools/perf/run_benchmark --browser=mandoline-debug startup.warm.blank_page --also-run-disabled-tests" runs okay. R=yzshen@chromium.org,sky@chromium.org TBR=gab@chromium.org Review URL: https://codereview.chromium.org/1278673002 Cr-Commit-Position: refs/heads/master@{#343983}
* [Android] Rewrite old new tab and welcome page URLs.newt2015-08-181-0/+13
| | | | | | | | | | | | | | | | | When launching Chrome after an update from an old version, chrome://newtab and chrome://welcome are now rewritten to chrome-native://newtab. This gracefully replaces the old NTP and welcome pages with the new NTP, so that users don't see a "page not found" error after updating Chrome. Note: this only affects users who update from a version of Chrome prior to M37, when the NTP and welcome pages were removed. BUG=516379 Review URL: https://codereview.chromium.org/1290663004 Cr-Commit-Position: refs/heads/master@{#343981}
* Implement GetDeterministicMachineSpecificId() on Mac.rsesek2015-08-184-3/+47
| | | | | | | | | BUG=500085 TBR=bauerb@chromium.org Review URL: https://codereview.chromium.org/1294593003 Cr-Commit-Position: refs/heads/master@{#343972}
* Fix crash in chrome://proximity-auth when executing JS with uninitialized page.tengs2015-08-183-10/+21
| | | | | | | | | | | | This fix initializes members that cause JS to be executed only upon receiving a message from the page inidicating it is initialized. BUG=516625 TEST=manual Review URL: https://codereview.chromium.org/1299453002 Cr-Commit-Position: refs/heads/master@{#343965}
* Deferring creation of Bookmark.bak until first write.cmumford2015-08-184-3/+48
| | | | | | | | | BUG=514730 R=sky@chromium.org Review URL: https://codereview.chromium.org/1279883002 Cr-Commit-Position: refs/heads/master@{#343951}
* Re-land: cc: Use worker context for one-copy tile initialization.reveman2015-08-181-3/+7
| | | | | | | | | | | | | | | This moves management of staging resources to OneCopyTileTaskWorkerPool class. This makes it possible to use a worker context to issue and detect when copy operations complete. BUG=490295 TBR=jamesr@chromium.org, sky@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1230203007 Cr-Commit-Position: refs/heads/master@{#343947}
* Fixes couple of bugs related to embed rootssky2015-08-189-16/+75
| | | | | | | | | | | | | | | . Clients marked as embed roots weren't seeing views adds as descendants by other connections. . ViewManagerClientImpl was sending unnecessary hierarchy changes for views added by another connection. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/1299013002 Cr-Commit-Position: refs/heads/master@{#343945}
* Implemented showing update bubble pop-up when the user override password on ↵dvadym2015-08-183-9/+19
| | | | | | | | | | sign-in form. It prevents from accidentally changing password in the PasswordManager (crbug.com/400772). It's currently behind a flag, until launching change password support BUG=359315 Review URL: https://codereview.chromium.org/1297963002 Cr-Commit-Position: refs/heads/master@{#343915}
* Remove Content-Length: 0 from HEAD Requestcsharrison2015-08-181-2/+1
| | | | | | | | | | | | HEAD requests with Content-Length headers were causing erroneous behavior for some servers. This change removes the header from all HEAD requests, aligning Chrome's behavior with Firefox. BUG=455939 Review URL: https://codereview.chromium.org/1295173003 Cr-Commit-Position: refs/heads/master@{#343910}
* Revert of Allow url::SchemeHostPort to hold non-file scheme without port ↵msramek2015-08-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #16 id:320001 of https://codereview.chromium.org/1272113002/ ) Reason for revert: Broken build. http://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/17899/steps/compile/logs/stdio Original issue's description: > Allow url::SchemeHostPort to hold non-file scheme without port > > WebSockets use url::Origin to pass origin info between renderer and > browser. Currently, it cannot hold an origin with non-file scheme and > no port. Chrome extensions have been using such origins, so we need > to keep the channel to convey origin info work for such origins. > > BUG=516971 > R=sleevi,brettw > > Committed: https://crrev.com/1ac9ec7bccd1b5178b18338b10149f36292f5fb6 > Cr-Commit-Position: refs/heads/master@{#343895} TBR=rsleevi@chromium.org,mkwst@chromium.org,brettw@chromium.org,tyoshino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516971 Review URL: https://codereview.chromium.org/1301563003 Cr-Commit-Position: refs/heads/master@{#343898}
* Allow url::SchemeHostPort to hold non-file scheme without porttyoshino2015-08-181-4/+4
| | | | | | | | | | | | | | WebSockets use url::Origin to pass origin info between renderer and browser. Currently, it cannot hold an origin with non-file scheme and no port. Chrome extensions have been using such origins, so we need to keep the channel to convey origin info work for such origins. BUG=516971 R=sleevi,brettw Review URL: https://codereview.chromium.org/1272113002 Cr-Commit-Position: refs/heads/master@{#343895}
* Added policy to disable/enable a system log upload.pbond2015-08-181-1/+19
| | | | | | | | BUG=471888 Review URL: https://codereview.chromium.org/1280003004 Cr-Commit-Position: refs/heads/master@{#343861}
* Introduce (Chrome)VariationsServiceClientblundell2015-08-183-0/+26
| | | | | | | | | | | | | | | | | VariationsService is targeted for componentization in order to be shared with iOS. Towards that goal, this CL introduces VariationsServiceClient, which will serve to abstract the dependencies of VariationsService on its embedder (e.g., //chrome). Future CLs will complete the abstraction of VariationsService's //chrome-level dependencies through VariationsServiceClient. BUG=516678 TBR=asvitkine Review URL: https://codereview.chromium.org/1293113004 Cr-Commit-Position: refs/heads/master@{#343857}
* Move syncable/lossy properties of content settings into WebsiteSettingsRegistryraymes2015-08-1812-142/+125
| | | | | | | | | | | This moves the syncable/lossy properties of content settings into the WebsiteSettingsRegistry. BUG=512683 Review URL: https://codereview.chromium.org/1272583004 Cr-Commit-Position: refs/heads/master@{#343828}
* Non-SFI mode: Sandbox support for NaCl async-signals.lhchavez2015-08-183-3/+103
| | | | | | | | | | | | | | | | | | | In preparation for the async-signal support change in https://codereview.chromium.org/1212613002, this CL allows two new syscalls: * clone() with CLONE_PARENT_SETTID. * tgkill() with the current pid as tgid and SIGUSR1 as signal number. TEST=nacl_loader_unittests TEST=Ran bots TEST=ARC async-signals work BUG=nativeclient:4065 R=mseaborn@chromium.org Review URL: https://codereview.chromium.org/1295513003 Cr-Commit-Position: refs/heads/master@{#343807}
* [Sync] Add sync client and begin transition to use it for plumbingzea2015-08-186-0/+208
| | | | | | | | | | | | | | | | | | | The SyncClient will encapsulate any dependencies that the sync driver has on external components. Eventually it will replace the ProfileSyncComponentsFactory as the source of all injected dependencies. The ProfileSyncComponentsFactory at that point will be used only for creating SyncAPI specific components, and will replace the SyncAPIComponentFactory. Note: this change introduces some duplication of interfaces in an effort to minimize the amount of files touched. Follow up changes will clean things up and make the barrier between SynClient and SyncApiComponentFactory clearer. BUG=512768,512832 Review URL: https://codereview.chromium.org/1277243003 Cr-Commit-Position: refs/heads/master@{#343795}
* Always show the "Prevent this page from creating additional dialogs" checkbox.palmer2015-08-183-26/+37
| | | | | | | | | | | Some sites use alert() boxes to spam people, and they can easily avoid the previous time-based mitigation. So, always give people the option. BUG=517477 Review URL: https://codereview.chromium.org/1272633007 Cr-Commit-Position: refs/heads/master@{#343780}
* Plugin Power Saver: Fix WebViewPlugin crash caused by missing nullptr check.tommycli2015-08-171-1/+3
| | | | | | | | | | | | | | | In the OnZoomChanged observer function, WebViewPlugin does not check that container_ is non-null. container_ can be nullptr if the zoom changes before initialization, or during a phase of destruction. BUG=521013 NOTRY=true (because linux_chromium_rel_ng trybot acting up) Review URL: https://codereview.chromium.org/1295913002 Cr-Commit-Position: refs/heads/master@{#343773}
* mandoline: Reland "Sandbox mojo:browser and mojo:omnibox."erg2015-08-172-0/+18
| | | | | | | | | | | | | This is a straight reland of the previous patch; as the manual usage of icu was removed in https://codereview.chromium.org/1281343003/. BUG=492524 Previous Review URL: https://codereview.chromium.org/1282903002 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1286773002 Cr-Commit-Position: refs/heads/master@{#343765}
* Updating XTBs based on .GRDs from branch masterAlex Mineer2015-08-1752-988/+52
| | | | Cr-Commit-Position: refs/heads/master@{#343762}
* Make an application wrapper around the mandoline/tab stuff.ben2015-08-171-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1293933002 Cr-Commit-Position: refs/heads/master@{#343749}
* Updating XTBs based on .GRDs from branch masterKrishna Govind2015-08-17103-76285/+76285
| | | | Cr-Commit-Position: refs/heads/master@{#343737}
* Keyboard accessory icons for card scan and settings.rouslan2015-08-174-3/+15
| | | | | | | | BUG=428087 Review URL: https://codereview.chromium.org/1291703006 Cr-Commit-Position: refs/heads/master@{#343725}
* Convert components/tracing from static lib to componentruuda2015-08-176-5/+50
| | | | | | | | | | This is a prerequisite for https://crrev.com/1292583002. BUG=518823 Review URL: https://codereview.chromium.org/1298683002 Cr-Commit-Position: refs/heads/master@{#343700}
* Content settings clean-up: removing unused includelucinka.brozkova2015-08-171-1/+1
| | | | | | | | BUG=399895 Review URL: https://codereview.chromium.org/747953002 Cr-Commit-Position: refs/heads/master@{#343693}
* Componentize variations_request_scheduler*blundell2015-08-179-0/+466
| | | | | | | | | | | | These files are shared with iOS. They have no problematic dependencies, so componentization is straightforward. BUG=516660 TBR=phajdan.jr Review URL: https://codereview.chromium.org/1283443002 Cr-Commit-Position: refs/heads/master@{#343684}
* Mandoline: Enable Android software keyboard for the Omnibox.penghuang2015-08-175-108/+12
| | | | | | | | BUG=498624 Review URL: https://codereview.chromium.org/1286383003 Cr-Commit-Position: refs/heads/master@{#343679}
* Add dvadym to password manager OWNERSvabr2015-08-174-0/+4
| | | | | | | | | | | Vadym has worked on and understood the password manager code for some time now, he'll make a valuable owner. TBR=dvadym@chromium.org,sdefresne@chromium.org,isherman@chromium.org BUG=None Review URL: https://codereview.chromium.org/1299653002 Cr-Commit-Position: refs/heads/master@{#343678}
* Add GenericSharedMemoryId and use w/ GpuMemoryBufferericrk2015-08-172-2/+2
| | | | | | | | | | | | | | | | | | | | Adds a GenericSharedMemoryId type which will be used to track various types of shared memory (SharedBitmap, IOSurface, base::SharedMemory). Wire up GpuMemoryBufferManager so that GpuMemoryBufferId is just a typedef of this type, setting up for further integration in the future. Note regarding message changes - We needed a way for all GenericSharedMemoryIds used by a process to be unique. Currently a renderer process sometimes internally allocates shared memory and sometimes asks the browser process to do so. In order to allow for consistent naming, we cause the Renderer process to provide an ID to the browser when asking the browser to allocate on its behalf. +tsepez for message changes. +piman for content/gpu changes +danakj/reveman for other changes. TBR=sky@chromium.org BUG=512534 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1280513002 Cr-Commit-Position: refs/heads/master@{#343677}
* Let PasswordFormManagerTest have an instance of the TestPasswordManager as a ↵lucinka.brozkova2015-08-171-129/+112
| | | | | | | | | | | | | member Replace the repeated local creation of the same class over again. Also provide a non-null PasswordManager to every PasswordFormManager. This will be important in the coming CLs where calling SimulateMatchingPhase on a PasswordFormManager will be replaced with calling OnGetPasswordStoreResults, which dereferences the passed PasswordManager. BUG=520831 Review URL: https://codereview.chromium.org/1296823002 Cr-Commit-Position: refs/heads/master@{#343671}
* Componentize OmniboxMetricsProvider for sharing with iOSblundell2015-08-175-1/+218
| | | | | | | | | | | The class has no problematic dependencies, so componentization is straightforward. BUG=508022 Review URL: https://codereview.chromium.org/1274393002 Cr-Commit-Position: refs/heads/master@{#343668}
* Move variations prefs into the variations componentblundell2015-08-174-11/+52
| | | | | | | | | | | These prefs are used by variations code that is targeted for componentization. BUG=382865 TBR=thakis Review URL: https://codereview.chromium.org/1265423003 Cr-Commit-Position: refs/heads/master@{#343661}
* Clean up the mediastream migration pref.msramek2015-08-173-12/+8
| | | | | | | | | | We removed the mediastream->camera/mic migration code from content_settings::DefaultProvider, but didn't clean up the associated preference. BUG=443799 Review URL: https://codereview.chromium.org/1255243004 Cr-Commit-Position: refs/heads/master@{#343651}
* Update per-file password_manager* to match component OWNERSvabr2015-08-171-0/+2
| | | | | | | | | | The per-file password_manager* owners in //components/OWNERS should match //components/password_manager/OWNERS. BUG=None Review URL: https://codereview.chromium.org/1301553002 Cr-Commit-Position: refs/heads/master@{#343649}
* Open from clipboard: Support nil clipboardolivierrobin2015-08-171-10/+15
| | | | | | | | | | Starting with iOS9 beta 5, the clipboard string can be nil in some circonstances. Consider this as a temporary access error and not a pasteboard change. Review URL: https://codereview.chromium.org/1293693006 Cr-Commit-Position: refs/heads/master@{#343648}
* Include missing header in signin_header_helper.h.msarda2015-08-171-0/+2
| | | | | | | | | | | | | | | The struct ManageAccountsParams has different entries on iOS than on other platforms. This CL includes |build/build_config.h| to ensure that OS_IOS macro is correctly defined. The crash occurred because clients and implementation had a different view of the struct ManageAccountsParams. BUG=520957 Review URL: https://codereview.chromium.org/1287933004 Cr-Commit-Position: refs/heads/master@{#343643}
* Fixing BluetoothLowEnergyConnectionFinder reconnection bug.sacomoto2015-08-171-1/+0
| | | | | | | | | | | | We should not remove the |adapter_| observer when |HandleDeviceUpdated| is called. Otherwise, if the current connection fails, we don't try to connect again, as no |DeviceChanged| notification is fired. BUG= Review URL: https://codereview.chromium.org/1298433002 Cr-Commit-Position: refs/heads/master@{#343642}
* Add engedy@ to password manager OWNERSvabr2015-08-171-0/+1
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1287913003 Cr-Commit-Position: refs/heads/master@{#343637}
* Remove the array keyed off ContentSettingsType in PolicyProvider and replace ↵raymes2015-08-172-138/+87
| | | | | | | | | | | | | | | | | | | | | | | with a map The array of managed default prefs which is keyed to ContentSettingsType is fairly sparsely populated. Rather than have it keyed to ContentSettingsType, instead create an array which maps ContentSettingsType to the default policy pref name (similar to what we do for the Allowed/Blocked URL prefs). This means that when a new content setting is added, this array doesn't need to be updated. I did consider adding this to WebsiteSettingsInfo but it seems like the exception (rather than the rule) to add a new policy pref. Also there are some inconsistencies which make it hard to do this cleanly, e.g. the same mediastream pref is used for both camera and mic). I would rather leave this to a later cleanup. BUG=512683 Review URL: https://codereview.chromium.org/1276683004 Cr-Commit-Position: refs/heads/master@{#343627}
* Print stack traces in browser tests when any process crashes, or an assert ↵jam2015-08-172-7/+1
| | | | | | | | | | | | | | | | | | | | fires. The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from processes on all platforms and not just Linux (i.e. to be able to debug the large flakiness that occurred last week). This is disabled for official builds. Also make release (non-official) builds print the callstack on asserts, just like debug builds. This makes it easier to debug test failures on the CQ (for example, DCHECKs for non-threadsafe usage of pointers). Add a regression test that both renderer and browser process crashes print the callstack. BUG=517488,358267,521148 NOPRESUBMIT=true Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975 Cr-Commit-Position: refs/heads/master@{#343240} Review URL: https://codereview.chromium.org/1291553003 Cr-Commit-Position: refs/heads/master@{#343626}
* Use PasswordFormManagerTest::client instead of local client in testslucinka.brozkova2015-08-161-157/+96
| | | | | | | | | | Locally defined clients were the same as PasswordFormManagerTest::client BUG=520831 Review URL: https://codereview.chromium.org/1288553004 Cr-Commit-Position: refs/heads/master@{#343610}
* Replaced GetPendingCredentials with PasswordFormManager::pending_credentialslucinka.brozkova2015-08-161-47/+36
| | | | | | | | BUG=520831 Review URL: https://codereview.chromium.org/1294023002 Cr-Commit-Position: refs/heads/master@{#343609}
* Revert of Print stack traces in child processes when browser tests failed. ↵rockot2015-08-161-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:80001 of https://codereview.chromium.org/1291553003/ ) Reason for revert: This is unfortunately breaking Windows 10 in a major way. I did a local bisect and narrowed it down to this CL. BUG=521242 Original issue's description: > Print stack traces in child processes when browser tests failed. > > The functionality to do this opens up security holes. Currently this was working only for debug Linux builds. However our trybots are release builds, and we need to be able to see stack traces from child processes on all platforms (i.e. to be able to debug the large flakiness that occurred since last week). This is disabled for official builds. > > BUG=517488,358267 > > Committed: https://crrev.com/8ba532e170befc312e66d032587fa2ad04bac975 > Cr-Commit-Position: refs/heads/master@{#343240} TBR=scottmg@chromium.org,jln@chromium.org,wfh@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517488,358267 Review URL: https://codereview.chromium.org/1299583002 Cr-Commit-Position: refs/heads/master@{#343603}
generated by cgit v1.1 at 2024-10-31 04:40:35 +0000