| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
missing from uploaded crashes.
BUG=371817
Review URL: https://codereview.chromium.org/275213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=356791
Review URL: https://codereview.chromium.org/238863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=368034
Review URL: https://codereview.chromium.org/259863007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=362608
Review URL: https://codereview.chromium.org/274183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a BrowserContextKeyedService to collect logs from the PasswordManagerClient instances, and distribute them to PasswordManagerInternalsUI instances for display. The service will also ensure that nothing is logged in Incognito profiles, and that logs are flushed as soon as no one is displaying them.
Except for checking the incognito bit, the whole functionality is implemented in the LogRouter class inside the password_manager component, for easy code sharing across platforms.
The service inherits from LogRouter, and adds nothing except for leveraging the BrowserContextKeyedServiceFactory framework to keep the functionality from OTR profiles.
This CL only introduces the service, it does not put it to use (outside tests) yet.
For that there will be another CL (https://codereview.chromium.org/269513003, but WIP, not fit for (re)viewing yet).
Yet another CL deals with renaming PasswordManagerLogger to LogReceiver: https://codereview.chromium.org/264793010/
Design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing#heading=h.cqh4wuj8j4yl
BUG=347927
Review URL: https://codereview.chromium.org/262583007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=372069
Review URL: https://codereview.chromium.org/280063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=348531
Review URL: https://codereview.chromium.org/267703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UMA for the data reduction proxy was gated behind preprocessor
directives that resticted the logic to Android and iOS. This
change opens UMA calculations and collection up to all platforms.
BUG=369619
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026
Review URL: https://codereview.chromium.org/266033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure the monitor does not collect the proxy's address if one was used.
(In the process, refactor RequestInfo to contain the whole HttpResponseInfo,
tighten up OnRequestLegComplete, and poke at unittests a bit.)
Also, count network errors as well as HTTP errors as failures (!).
BUG=356791
Review URL: https://codereview.chromium.org/267633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add an explicit check for whitelisting pepper/nacl
permissions based on importing a shared module, so a shared
module can potentially limit allowing import of its resources
and permissions its allowed.
You can still use nonsfi mode for Linux or ChromeOS by
passing in --enable-nacl-nonsfi-mode, but it is on for a
whitelisted set of extensions for ChromeOS without flags.
BUG=355141
TEST=deploy_chrome to daisy, test app which includes whitelisted module
Review URL: https://codereview.chromium.org/264923011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is just a code clean-up. As long as it compiles, no change to the functionality.
BUG=348523
Review URL: https://codereview.chromium.org/271173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add baked-in Domain Reliability configs for {drive,mail}.google.com.
BUG=356791
Review URL: https://codereview.chromium.org/278773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Someone noticed that occasionally the uploader sent an empty upload. I
looked into the scheduler and found that it was clearing the "upload
pending" bit early, when the upload was scheduled. This meant that if a
beacon arrived between scheduling and starting the upload, the bit was
still set on its behalf, despite it being included in the upload. Once
the upload finished, the scheduler would see the bit still set and
schedule another.
This patch adds a couple of unittests for interesting interleavings
(beacons that arrive between scheduling and starting the upload, and
between starting and finishing the upload), and clears the upload
pending bit in the right place.
BUG=356791
Review URL: https://codereview.chromium.org/272773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=359299
TEST=valgrind unittests
TBR=zork@chromium.org
Review URL: https://codereview.chromium.org/273623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the use of a static initializer and makes it possible
for clients to pass a key without owning the memory where the
key is stored (as would be the case if passed to a static const char*).
BUG=371626, 371204
Review URL: https://codereview.chromium.org/279633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Uses ScopedTempDir to remove dependency on TestingProfile.
- Uses test::TestBookmarkClient to remove dependency on MessageLoop,
BookmarkModelFactory, TestingProfile, TestBrowserThreadBundle
BUG=367836
Review URL: https://codereview.chromium.org/273663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason to provide default implementations for these methods
is that so an embedder that wants to use bookmarks and doesn't need/want
favicons or omnibox-related methods doesn't even have to think about what
to provide as implementations for them.
BUG=367707
Review URL: https://codereview.chromium.org/274063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/277893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also revert the temporary change for the sandbox test framework,
which allows fork() with threads.
https://codereview.chromium.org/242383003
TEST=nacl_loader_unittests, components_unittests, and trybots
BUG=364751
Review URL: https://codereview.chromium.org/273623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/277563002/)
Reason for revert:
check_licenses failure: http://build.chromium.org/p/chromium/builders/Linux/builds/49667
Original issue's description:
> Update DomDistillerJsUpdater and Roll DomDistillerJs
>
> The update script should build `ant package` and copy the entire
> out/package directory.
>
> This moves the path to domdistiller.js to .../package/js so update
> that reference.
>
> The old (non-proto) API is still supported, so this keeps using that.
>
> Picked up changes:
> fdb023d Fix Proto module's path
> 44e9366 This adds two simple protoc plugins.
>
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269485
TBR=yfriedman@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/278143003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=366947
Review URL: https://codereview.chromium.org/269813012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On mac/linux the debug stub port is allocated chrome side and provided to
Native Client. On Windows (where socket handles cannot be passed between
processes), the debug port must be allocated by the nacl process (which can
only happen when the outer sandbox is disable).
Propagate the debug port selected by the nacl side to the task manager to make
it available to the user and debugging extensions.
Depends on this nacl side change:
https://codereview.chromium.org/206493005
BUG=328714
TEST=None
R=mseaborn@chromium.org,jschuh@chromium.org
Review URL: https://codereview.chromium.org/198083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/270833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The update script should build `ant package` and copy the entire
out/package directory.
This moves the path to domdistiller.js to .../package/js so update
that reference.
The old (non-proto) API is still supported, so this keeps using that.
Picked up changes:
fdb023d Fix Proto module's path
44e9366 This adds two simple protoc plugins.
NOTRY=true
Review URL: https://codereview.chromium.org/277563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to reorganize the sync attachment code so that in the future
attachment code can include stuff it needs (like src/net/) without
loosening the DEPS rules for the rest of sync.
Replace internal_api's coarse grained dep on net/ with finer grained
deps.
sync/api/attachments - Home to attachment code that's needed by both
sync itself and users of sync.
sync/internal_api/public/attachments - Home to attachment headers needed
by sync/api/attachments.
sync/internal_api/attachments - Home to attachment code that's private
to sync.
TBR=mef,erikwright,phajdan.jr
BUG=
Review URL: https://codereview.chromium.org/270633005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first effort at moving some of the ReverseService logic out of the
trusted plugin. I'd like to move these over soon since the tangled callback is
pretty nasty, and hidehiko@ has run into the ugliness while adding features for
Bare Metal Mode.
This one is pretty easy since it's stateless.
BUG=239656
Review URL: https://codereview.chromium.org/268793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves some files from chrome/browser/invalidation to
components/invalidation. The files moved in this CL are those that do
not have dependencies on chrome/, so they can be moved without
significant refactoring.
This refactoring touches a lot of files, but none of the changes are
meaningful. Most of it inovlves changing #include paths, updating DEPS,
changing header guards, and other trivial changes.
One part of this change that is significant is that it creates two new
static libraries and moves some of the symbols formerly defined in
chrome/browser/invalidation into those libraries. There is some risk of
linker errors if this was done wrong.
TBR=bartfab,blundell
BUG=336571
Review URL: https://codereview.chromium.org/255273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change some trivial stuff so sleevi can do more security review.
Also, add rdsmith as an OWNER.
BUG=356791
Review URL: https://codereview.chromium.org/252613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies NexeLoadManager, which is getting pretty big. This also removes
an unused field from ProgressEvent, and adds a convenience function for posting
a task to dispatch a progress event from the main thread, which is often
necessary to ensure that progress events are posted to the DOM after other
state changes.
Review URL: https://codereview.chromium.org/270453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
listens to both token service changes and gaia cookie changes.
BUG=359700
Review URL: https://codereview.chromium.org/270733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unit tests should be placed near the code that they test. In this case,
bookmark_index_unittest.cc is the test driver for bookmark_index.cc
which lives in components/bookmarks/core/browser, so this patch
moves it back to components/bookmarks/core/browser from
components/bookmarks/core/test.
This happend in r268917 - https://codereview.chromium.org/270153005
BUG=367833
TEST=components_unittests
R=blundell@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/271023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=365848
For components/wifi fixes for tests:
R=pneubeck@chromium.org
TBR=mef@chromium.org
Review URL: https://codereview.chromium.org/267433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Force-installed extensions are not subject to the blacklist policy.
Fix the documentation to that effect.
BUG=chromium:371050
TEST=None
Review URL: https://codereview.chromium.org/276673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The CL modifies the presubmit script to acknowledge that some policy test cases could have a suffix added to it.
BUG=371277
Review URL: https://codereview.chromium.org/271863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*Added a personal URL type
*move delete url to base struct to the Result instead o SuggestResult
*The personal URL suggestion will be handled same as navigation suggestion, as it will support delete.
BUG=367746
Review URL: https://codereview.chromium.org/256093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The motivation is to reuse the Widevine keysystem registration logic in Android Webview.
BUG=322395
Review URL: https://codereview.chromium.org/253593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is used for window.orientation but we can now use the OnResize IPC
to detect a screen orientation change.
BUG=162827
Review URL: https://codereview.chromium.org/270173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This per-profile key is an extra input into the hashing that NaCl's
validation cache does.
Hiding this key means that even if we did accidentally expose
SetKnownToValidate() to Non-SFI nexes, the nexe wouldn't be able to
create a hole in the SFI NaCl sandbox.
We should hide this key to reduce the attacker's ability to generate
collisions in hash-based caching.
Also hide some other startup parameters that aren't relevant to Non-SFI
mode.
BUG=367263
TEST=browser_tests
R=jln@chromium.org
Review URL: https://codereview.chromium.org/275513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
each WebContentsObserver first NULLs its web_contents_ pointer and
performs cleanup code after that.
This could work if we guaranteed that every WebContentsObserver doesn't
directly or indirectly affect any other WebContentsObserver. But
actually WebContentsObservers can do anything and also affect each
other. And if one WebContentsObserver already NULLed its web_contents_
pointer (e.g. ZoomController) other WebContentsObserver
(e.g. InterstitialPageImpl) calls it (indirectly in this case) we have
problems and result depends on ordering of WebContentsObservers in the
list of observers.
The solution splits that process into two phases. First we let each
WebContentsObserver to perform their cleanup code and at that point they
can freely call each other, we completely don't care about the ordering.
We can call this phase as untrusted phase because we deal with some cleanup
code that can do anything. After that we make second pass and NULL each
web_contents_ pointer and this phase is trusted because we call only private
implementation of WebContentsObserver that we definitely can trust.
BUG=363564
Review URL: https://codereview.chromium.org/257153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not to slow down open_resource IRT call on Chrome OS (and on Chrome
with multiple profiles).
The function should use a profile associated with the renderer rather
than the one created in chrome/browser/chrome_browser_main.cc. Otherwise,
MapUrlToLocalFilePath may see an invalid set of extensions and may
return false when it should return true.
For example, on Chrome OS, the profile created in chrome_browser_main.cc
is basically only for the login screen except a few minor cases (e.g.
browser crash recovery), and therefore is not suitable for the use in
MapUrlToLocalFilePath.
This fix allows NaCl apps, both in SFI and non-SFI mode, to open a NaCl
resource file with the fast __nacl_irt_open_resource path (see the bug
for more details).
BUG=360277
TEST=Manually tested. Add two CHECK() calls to DoOpenNaClExecutableOnThreadPool()
and OnLaunchNaCl() so that Chrome will crash if MapUrlToLocalFilePath()
returns false, build Chrome for Chrome OS, copy it to Chromebook, reboot
it, sign in, and then try to load a dynamically linked NaCl app. Confirm
that Chrome does not crash.
Review URL: https://codereview.chromium.org/277463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=357855
Review URL: https://codereview.chromium.org/262003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restrict clone() by defaulting to the baseline policy. This means that
fork() will EPERM and only the flags used by pthread_create() will be allowed.
BUG=367986
R=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/272083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=359299
TEST=build works
Review URL: https://codereview.chromium.org/225183018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*Moves ActivateDataType call to DataTypeManagerImpl via BackendDataTypeConfigurer. Removed from PSS.
*Pass UserShare directly to Connect instead of PSS.
*Paves the way for moving SCP to sync_driver.
Note that previously, ActivateDataType was called from model-safe thread, whereas it is now invoked on the UI for non-control types. Because model-association only happens when the syncer is in configuration mode (until StartSyncingWithServer is called), this should be safe to do from the UI thread before telling the syncer to start.
BUG=339726
Review URL: https://codereview.chromium.org/267713009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Always restrict clone() to thread creation in the baseline policy.
This CL does the following
- Extend RestrictCloneToThreadsAndEPERMFork to support Android.
- Always EPERM anything that looks like fork()
- Add unit tests to the baseline policy related to clone() and fork().
This CL also modifies any other BPF policy so that if clone() was not
restricted before, it remains so. That is, only renderers and PPAPI
processes have clone() restrictions applied to them, as before.
BUG=367986
R=jorgelo@chromium.org, mdempsky@chromium.org
Review URL: https://codereview.chromium.org/270613008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are many ways to get it wrong.
BUG=none
TBR=darin (for base/)
TBR=sky (for chrome/ and ui/)
TBR=dconnelly (for components/policy/)
TBR=tommi (for media/audio/)
TBR=asvitkine (for tools/metrics/)
TBR=mad (for win8)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268203
Review URL: https://codereview.chromium.org/261293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new policy sets the existing enable-web-based-signin flag.
See the attached bug for details.
BUG=368801
R=asvitkine@chromium.org, atwilson@chromium.org, joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/268593011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/266033002/)
Reason for revert:
Causes a sizes regression, starting in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64712
+# data_reduction_proxy_settings.cc data_reduction_proxy::DataReductionProxySettings::key_
+# data_reduction_proxy_settings.cc __cxa_atexit@plt [registers a dtor to run at exit]
+# data_reduction_proxy_settings.cc __init_array_end+0x3868
+# data_reduction_proxy_settings.cc __init_array_end+0x3b88
+# data_reduction_proxy_settings.cc __init_array_end+0x530
Original issue's description:
> Collect data reduction proxy UMA on all platforms
>
> UMA for the data reduction proxy was gated behind preprocessor
> directives that resticted the logic to Android and iOS. This
> change opens UMA calculations and collection up to all platforms.
>
> BUG=369619
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026
TBR=mef@chromium.org,marq@chromium.org,bengr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=369619
Review URL: https://codereview.chromium.org/274453011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UMA for the data reduction proxy was gated behind preprocessor
directives that resticted the logic to Android and iOS. This
change opens UMA calculations and collection up to all platforms.
BUG=369619
Review URL: https://codereview.chromium.org/266033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This severs all remaining link-time dependencies on source
modules in //chrome, with the exception of some generated
resources.
BUG=349042,359656
Review URL: https://codereview.chromium.org/268363007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269017 0039d316-1c4b-4281-b951-d872f2087c98
|