| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.
BUG=246708
Review URL: https://codereview.chromium.org/157023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
std::vector was used without \#include <vector>. This broke libc++ builds.
TBR=isherman@chromium.org
BUG=318770
Review URL: https://codereview.chromium.org/151483006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebNodeCollection
Update components/autofill code to use WebElementCollection instead of WebNodeCollection.
After Blink r166411 and r166500, WebNodeCollection is renamed to
WebElementCollection and its API returns WebElements instead of WebNodes.
Review URL: https://codereview.chromium.org/145393004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eventually we want to restrict to #including from
native_client/src/public. Until then, restrict the include_rules to
more specific files and directories to prevent inadvertent creep in
what Chromium depends on from NaCl.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
TEST=run checkdeps
R=bradnelson@google.com, teravest@chromium.org
Review URL: https://codereview.chromium.org/144003024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=340719
Review URL: https://codereview.chromium.org/155893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://codereview.chromium.org/157673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SchemaValidatingPolicyHandler is just like TypeCheckingPolicyHandler but based
on schema instead of single type.
BUG=258339
Review URL: https://codereview.chromium.org/130263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=334647
TBR=thakis
Review URL: https://codereview.chromium.org/156713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The production DMServer does not yet generate the correct signatures, so we
will stop verifying signatures by default. We will revert this CL once the
signature verification vs DMServer in the final format is fully working.
BUG=275291
Review URL: https://codereview.chromium.org/156723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves the following into the PasswordManager component:
- PasswordStoreConsumer
- PasswordStoreChange
- PasswordStore
- PasswordStoreDefault
- TestPasswordStore
Other than elimination of stale includes, no refactorings were required to
perform these moves. MockPasswordStore is left for followup work as some
refactoring is still required there.
BUG=334656,334657,334658,334659,334664
TBR=thakis
Review URL: https://codereview.chromium.org/139443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=275291
Review URL: https://codereview.chromium.org/132803009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the TranslateScript class and the translate.js script.
A new translate_resources target is created.
BUG=335074
TBR=jochen
Review URL: https://codereview.chromium.org/138933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=340704
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/155923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=joi@chromium.org,gcasto@chromium.org,shess@chromium.org,jschuh@chromium.org
BUG=335145
Review URL: https://codereview.chromium.org/156053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the preparation of the irt_ppapi implementation for non-SFI mode.
Currently (on SFI mode), the IPC channel between the plugin and the renderer
is created in the CreateNaClChannel message handled by NaClIPCAdapter.
However, we won't need nor use NaClIPCAdapter, and it causes the circular
dependency of plugin initialization.
To split the dependency, create the IPC channels for the browser process and
the renderer process at once (in NaClListener::OnStart()).
Note that we cannot remove CreateNaClChannel message, because it is only way
to pass the initialization argument from the browser to plugin. So, it is just
kept with renaming.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Ran trybot.
Review URL: https://codereview.chromium.org/150713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
normal and restored synced navigations.
BUG=340464
Review URL: https://codereview.chromium.org/152233003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=317027
Review URL: https://codereview.chromium.org/156483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
preset in json, but can be empty.
Added Dpi::IsValid().
Review URL: https://codereview.chromium.org/138613005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
Review URL: https://codereview.chromium.org/137623018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Function to find paper by size.
BUG=317027
Review URL: https://codereview.chromium.org/154563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializing the bubble
Called TranslateManager::GetLanguage at GetTranslateLanguages of
translate_bubble_view.cc. Apparently, TranslateManager::GetLanguage is
used not only for the chrome locale but also for any language codes, so
I renamed the argument name.
BUG=336732
TEST=manual
Review URL: https://codereview.chromium.org/141763005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fix address input validation of street address (we were failing to copy the street address into the AddressData struct before validating).
BUG=340905
Review URL: https://codereview.chromium.org/154423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=326799
Review URL: https://codereview.chromium.org/151183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome schema is necessary to be accessible in policy::BuildHandlerList() since some of the handlers will be migrated to a new policy handler based on schema(as defined in policy_templates.json).
This CL changed the signature of BuildHandlerList() and thus modification to constructor of BrowserPolicyConncector was made, taking callback to BuildHandlerList instead of the result returned by it, and postponed the generation of policy handler list.
BUG=258339
Review URL: https://codereview.chromium.org/147033004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=334662
R=blundell@chromium.org, gcasto@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/155873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=258339
Review URL: https://codereview.chromium.org/144363008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=334662
R=blundell@chromium.org
TBR=gcasto@chromium.org
Review URL: https://codereview.chromium.org/149743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A lot of static methods from TranslateManager are moved to
TranslateDownloadManager, as they are related to the management of the
TranslateLanguageList.
The observer interface for translate events has been moved from
TranslateManager to TranslateLanguageList. It also has been changed into a
callback list rather than an observer list, since observers with a single method
are generally discouraged.
The SetSupportedLanguages() method in TranslateLanguageList has been moved
from the anonymous namespace as it needs to invoke the callbacks for
translate events.
Finally, this CL fixes a bug where the TranslateList was not listening to
ResourceRequestNotifications.
BUG=335077, 335085, 339508
R=blundell@chromium.org, jochen@chromium.org, joi@chromium.org, mad@chromium.org
TBR=jochen, joi, sky
Review URL: https://codereview.chromium.org/143003020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose is to drop the dependency of psl_matching_helper.* on chrome.
BUG=334662
R=blundell@chromium.org, gcasto@chromium.org
TBR=joi@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/153803004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For now this only handles force-installed extensions that are not coming
from the Chrome Web Store directly.
BUG=none
Review URL: https://codereview.chromium.org/153633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a flag that says otherwise.
(Recommit after original commit reverted in https://codereview.chromium.org/130183003 due to unit test memory leak.)
BUG=177288
Review URL: https://codereview.chromium.org/146023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for distilling multiple pages, currently support is really
basic and just distills pages sequentially.
BUG=288015
TEST=included
NOTRY=true
R=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/146843010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
R=joi@chromium.org
Review URL: https://codereview.chromium.org/135163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Printer description and print job ticket formats.
BUG=317027
Review URL: https://codereview.chromium.org/150993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves files that depend on the now-componentized data_type_controller.h
and data_type_manager.h into the sync_driver component. For the most part these
files are moved as-is. The only exception is sync_model_association_manager,
which had a DCHECK about being on BrowserThread::UI; this DCHECK is removed.
BUG=339726
TBR=joi
Review URL: https://codereview.chromium.org/133503011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update WebNode::getElementsByTagName() callers to use a WebNodeCollection
instead of a WebNodeList. The WebNode::getElementsByTagName() public API was
updated in Blink r166263 to return a WebNodeCollection instead of a
WebNodeList.
Callers need to be updated so that we can get rid of the current workaround
allowing a WebNodeList to be implicitly converted into a WebNodeCollection.
BUG=235008
Review URL: https://codereview.chromium.org/152133004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) hide bubble after fixing a missing month or year
2) CVC validity should be based on card type best guess
3) cross-field validation shouldn't override single-field validation, but fields that are validly individually shouldn't skip cross-field validation just because their partner field is invalid (necessary for \#2)
BUG=336998
Review URL: https://codereview.chromium.org/141843005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This policy provider allows overridding Local State using user cloud policy.
This isn't yet used on iOS, so it can be removed until it's needed.
It also ties the global browser state with a single Profile; if multiprofiles
are ever supported on iOS then there must be a solution to which one overrides
Local State. This code shouldn't be enabled until that is clarified.
BUG=275292
Review URL: https://codereview.chromium.org/140613008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=dbeam (for wallet_items.cc)
Review URL: https://codereview.chromium.org/147903006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PolicyFetchRequests on desktop now request signed policy blobs. Also added
plumbing for injecting a google-supplied key to verify the blob signing keys to
protect against local tampering.
BUG=275291
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/116273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One more step towards removing src/webkit/
BUG=265753
TEST=content_shell and content_unittests
R=jochen@chromium.org,jam@chromium.org
TBR=darin
Review URL: https://codereview.chromium.org/151023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=317839
R=estade@chromium.org
Based on https://codereview.chromium.org/105823007/ by Evan Stade <estade@chromium.org>.
Review URL: https://codereview.chromium.org/145553009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces key icon and associated bubble with autofill style dropdown. Changes include
- Update PasswordGenerationAgentTest
- Add interactive_uitest for new UI.
- Sync edits to confirmation password field(s).
- Update UMA stats to more accurately reflect user choices.
Updating the generation popup to match the latest mocks and implement the
editing popup will come in a later CL.
This reverts r248119 and fixes a use-after-free in
PasswordGenerationPopupControllerImpl::PossiblyAcceptPassword()
R=asvitkine@chromium.org, estade@chromium.org
TBR=kenrb@chromium.org, sky@chromium.org, torne@chromium.org
BUG=318977
Review URL: https://codereview.chromium.org/151503006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The result of content::URLDataSource::GetSource() is used as a key to the
content::URLDataManagerBackend for when looking up sources.
Previously, this has always been the hostname of the URL used to access the
data source, but after r247187 landed, this source name was also used for a
scheme (chrome-distiller://).
This CL adds a requirement for the source name to include "://" as a suffix
for the return value from GetSource() for scheme-based sources,
so for chrome-distiller it becomes
"chrome-distiller://".
BUG=338997
Review URL: https://codereview.chromium.org/135273013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following:
- Changes DataTypeController to take in an error callback that it calls on
unrecoverable errors rather than calling ChromeReportUnrecoverableError
directly.
- Changes DataTypeController to be deleted on a passed-in MessageLoopProxy
rather than deleted on a content::BrowserThread.
- Moves DataTypeController into the sync_driver component.
- Moves DataTypeManager (which depends only on DataTypeController) into the
sync_driver component.
- Moves associated fakes and mocks into the sync_driver component.
BUG=339726
TBR=thakis
Review URL: https://codereview.chromium.org/137893027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't free the backend if it is in the process of being initialized.
BUG=339498
Review URL: https://codereview.chromium.org/133503006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates the sync_driver component and moves files with no problematic
dependencies from //chrome/browser/sync and //chrome/browser/sync/glue into it.
This is a first step toward componentization of //chrome/browser/sync.
BUG=339727
Review URL: https://codereview.chromium.org/133343007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Password manager now ignores autocomplete='off' by default; user may specify a flag that says otherwise.
>
> NOTRY=true
> BUG=177288
>
> Review URL: https://codereview.chromium.org/146023002
This introduced leaks reportied by asan bots. See bug for more details.
TBR=jww@chromium.org
Review URL: https://codereview.chromium.org/130183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks linux asan bot test.
See http://crbug.com/318977 for detail log.
> [Password Generation] Enable new UI
>
> Replaces key icon and associated bubble with autofill style dropdown. Changes include
>
> - Update PasswordGenerationAgentTest
> - Add interactive_uitest for new UI.
> - Sync edits to confirmation password field(s).
> - Update UMA stats to more accurately reflect user choices.
>
> Updating the generation popup to match the latest mocks and implement the
> editing popup will come in a later CL.
>
> BUG=318977
>
> Review URL: https://codereview.chromium.org/148993002
TBR=gcasto@chromium.org
Review URL: https://codereview.chromium.org/151093004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a flag that says otherwise.
NOTRY=true
BUG=177288
Review URL: https://codereview.chromium.org/146023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248117 0039d316-1c4b-4281-b951-d872f2087c98
|