| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://codereview.chromium.org/12853004/
TBR=tim@chromium.org,sky@chromium.org
(tim@ for sync, sky@ for seach_engines)
COLLABORATOR=joi@chromium.org
COLLABORATOR=kaiwang@chromium.org
BUG=181277
Review URL: https://chromiumcodereview.appspot.com/12695015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used by //components/autofill, //chrome/browser and (soon) //components/webdata itself.
Looking at [ git blame ], dhollowa@ and thestig@ seemed like the most likely candidates for the OWNERS. Let me know if you disagree.
This seems small enough not to warrant a dynamic lib, and it doesn't
have any singletons or such that would require it to be one (since it
is used by multiple other components in the components build), so I
made it a static library.
TBR=ben@chromium.org
BUG=181277
Review URL: https://codereview.chromium.org/12902030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166596
Review URL: https://chromiumcodereview.appspot.com/12973007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12760006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=223213
Review URL: https://chromiumcodereview.appspot.com/12751011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166596
Review URL: https://chromiumcodereview.appspot.com/12621014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 223153
Review URL: https://chromiumcodereview.appspot.com/12676020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The cause of the timeout is clear now, so the logging isn't necessary.
BUG=174296
Review URL: https://chromiumcodereview.appspot.com/12544028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to COMDAT folding.
BUG=none
Review URL: https://codereview.chromium.org/12529029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=180104
TEST=tests pass, less regressions, we all sleep better at night.
Review URL: https://chromiumcodereview.appspot.com/12706027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=155525
R=joi@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/12789006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure tests give WDS time to shutdown its DB.
TBR=atwilson@chromium.org
(for Signin changes)
R=joi@chromium.org
BUG=222363
Review URL: https://chromiumcodereview.appspot.com/12847010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=165570
Review URL: https://chromiumcodereview.appspot.com/12946002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on: https://codereview.chromium.org/12871006/ and
https://codereview.chromium.org/12491017/
Unfortunately, until we fix ownership issues, this base has to be ref-counted, which means that AutofillWebDataService has to be refcounted too in order to inherit from it. Blah.
TBR=ben@chromium.org
COLLABORATOR=joi@chromium.org
TEST=unit_tests
BUG=181277
Patch originally by caitkp@chromium.org
Review URL: https://codereview.chromium.org/12851008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org,akalin@chromium.org
(sky@ for testing_profile changes, akalin@ for sync).
BUG=181277
COLLABORATOR=joi@chromium.org
Patch originally by caitkp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12491017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12440048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Enables test depending on IsCheckable, which is now committed.
2. Remove the comment which is no-op.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12438031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CVC length varies depending on the card issuer.
BUG=179253
Review URL: https://chromiumcodereview.appspot.com/12519013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org
BUG=177913
Review URL: https://chromiumcodereview.appspot.com/12573010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=180148
Review URL: https://chromiumcodereview.appspot.com/12869004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
negative whitelist check for the first page.
This cl also changes autocheckout::WhitelistManager to be a ProfileKeyedService.
BUG=179942,182322
Review URL: https://chromiumcodereview.appspot.com/12669002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
password. This will support fields like CVV which are created as password fields by some sites.
BUG=187267
Review URL: https://chromiumcodereview.appspot.com/12721004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org
BUG=179253
Review URL: https://chromiumcodereview.appspot.com/12640002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(ignoring 3 element limit in autofill@browser process).
This CL addresses two issues:
1. Enabling sending all the forms with one or more elements to Autofill Server (As against having >3 requirement for general Autofill).
2. AutofillAgent@Renderer process, assumes that its form_elements_ are ordered same as the order of elements in AutofillManager@browser's form_structures, this assumption is broken if a form has <3 fields or if it has user specified autofill type.
BUG=191242
Review URL: https://chromiumcodereview.appspot.com/12852003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
He was an OWNER of some; now all.
NOTRY=true
Review URL: https://codereview.chromium.org/12672006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use of StringPrintf now requires prefixing with base:: or a per-scope using directive
TBR'd:
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android
NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=187506
Review URL: https://chromiumcodereview.appspot.com/12408013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=none (yet)
TEST=unit_tests --gtest_filter="*Wrapper*"
Review URL: https://chromiumcodereview.appspot.com/12869003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/12554011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=176135
Review URL: https://chromiumcodereview.appspot.com/12550013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Replace with a simple AutofillManagerTestDelegate
BUG=140037
Review URL: https://chromiumcodereview.appspot.com/12848002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164410
Review URL: https://chromiumcodereview.appspot.com/12545037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org
BUG=163504
Review URL: https://chromiumcodereview.appspot.com/12576010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds functionality, not the final formatting of CC and Address data.
BUG=181286
Review URL: https://chromiumcodereview.appspot.com/12755019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fronting card).
R=estade@chromium.org
BUG=163504
TEST=none, yet
Review URL: https://chromiumcodereview.appspot.com/12815002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
TBR=ben, brettw, jamesr, joi, satorux, piman, wez
Review URL: https://chromiumcodereview.appspot.com/12813004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add metrics identifying the type of user interacting with the autocomplete
dialog. Users are categorized according to three parameters:
(1) Are they signed in?
(2) For signed in users, do they have any data saved in Wallet?
(3) For all users without data saved in Wallet, do they have any data saved in
local Autofill?
BUG=165570
Review URL: https://chromiumcodereview.appspot.com/12588002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, rename WalletClientObserver -> WalletClientDelegate, and add some getters
to the interface.
BUG=165570
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12758007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=165570
Review URL: https://chromiumcodereview.appspot.com/12604008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
TBR=ben@chromium.org
BUG=181628
Review URL: https://chromiumcodereview.appspot.com/12858002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert calls to WebDataServiceFactory::GetForProfile to WebDataService::FromBrowserContext in order to remove dependency on ProfileKeyedService from WebDataService and WebDatabaseService (for componentization).
TBR=ben@chromium.org
Test=unit_tests
BUG=181277
Review URL: https://chromiumcodereview.appspot.com/12566017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 187498
Review URL: https://chromiumcodereview.appspot.com/12717008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12557007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use a less verbose method name.
* Decompose out a helper function to get the "Autocheckout"
vs. "requestAutocomplete" prefix.
BUG=165570
Review URL: https://chromiumcodereview.appspot.com/12529010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12604007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=177781
Review URL: https://chromiumcodereview.appspot.com/12472011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Enable clicking on proceed element even on the last page of the autofill flow.
BUG=181615
Review URL: https://chromiumcodereview.appspot.com/12638023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=140037
Review URL: https://chromiumcodereview.appspot.com/12440024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds accessors to CreditCard's int expiration_month_ and expiration_year_ members to avoid transcoding back and forth between string16 and int.
Adds a new constructor to wallet::Instrument to be created from CreditCard, CVC (string16), and AutofillProfile. Also adds a way to map from CreditCard::type() to wallet::Instrument::FormOfPayment.
Allows copy constructors on wallet::Address and adds a new constructor to be created from an AutofillProfile.
Adds a fake risk params to WalletClient to avoid server issues and updates tests.
Adds Online Wallet submit flow to AutofillDialogControllerImpl. This includes:
- members:
- string active_instrument_id_: the instrument ID used for a transaction.
- string active_address_id_: the address ID used for a transaction.
- full_wallet_: the most recently received FullWallet from Online Wallet.
- methods:
- IsManuallyEditingSection(): whether a section is all new data.
- GetFullWallet(): get a fronting (proxy) card for a user from Online Wallet.
- FinishSubmit(): fill out |form_structure_| and pass this data to the page.
- other misc. constants and helper functions
BUG=163505
Review URL: https://chromiumcodereview.appspot.com/12326145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187514 0039d316-1c4b-4281-b951-d872f2087c98
|