| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
USE_NSS is confusing because it's not actually the analog of USE_OPENSSL; it's
the analog to USE_OPENSSL_CERTS. This is in preparation for the chimera build
which will set USE_OPENSSL and USE_NSS(_CERTS).
This CL was partially done automatically by the following command:
git grep -l USE_NSS | xargs sed -i -e 's/defined(USE_NSS)/defined(USE_NSS_CERTS)/'
The remaining were caught by the following command and fixed manually:
git grep 'USE_NSS\([^_]\|$\)'
Finally, the following command verified nothing in a separate repository was
sensitive to this change:
find . -name '*.cc' -o -name '*.h' | xargs grep 'USE_NSS\([^_]\|$\)'
For now, the old name is still defined, but not used within Chromium.
A follow-up CL will remove deprecated use_nss and USE_NSS #defines
together which will then cause downstream churn. Though from a grep
of known downstreams, the churn seems to be fairly minimal. The
removal is split from this CL so that, if we need to revert, the
CL to revert is small.
TBR=pneubeck@chromium.org
BUG=462040
Review URL: https://codereview.chromium.org/1082123003
Cr-Commit-Position: refs/heads/master@{#325710}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Exporting of ETW events can be turned on using --trace-export-events-to-etw.
BUG=
Committed: https://crrev.com/1cc86c4f686869f32dfede093a07828c73563892
Cr-Commit-Position: refs/heads/master@{#324982}
Review URL: https://codereview.chromium.org/1038453002
Cr-Commit-Position: refs/heads/master@{#325408}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1cc86c4f686869f32dfede093a07828c73563892 due to
a compile failures on windows. For more information, see crbug.com/476806.
TBR=thakis
BUG=476806
Review URL: https://codereview.chromium.org/1087733002
Cr-Commit-Position: refs/heads/master@{#325002}
|
|
|
|
|
|
|
|
|
|
| |
- Exporting of ETW events can be turned on using --trace-export-events-to-etw.
BUG=
Review URL: https://codereview.chromium.org/1038453002
Cr-Commit-Position: refs/heads/master@{#324982}
|
|
|
|
|
|
|
|
|
|
| |
files via file descriptor
BUG=466917
Review URL: https://codereview.chromium.org/1071173002
Cr-Commit-Position: refs/heads/master@{#324600}
|
|
|
|
|
|
|
|
|
|
| |
isolate_holder.h is public and used by blink and therefore cannot refer to types from base. As part of porting this to other platforms we needed to load snapshots from BaseFile descriptors.
BUG=421063
Review URL: https://codereview.chromium.org/1011133006
Cr-Commit-Position: refs/heads/master@{#323886}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/944913002 wrongly assumes that
non empty --type means a child process.
This is a quick fix for merging into Chrome 42. We need better solution for 43. Content does not know about "service" process and does not include "service" constant from chrome.
BUG=466917
Review URL: https://codereview.chromium.org/1055413002
Cr-Commit-Position: refs/heads/master@{#323758}
|
|
|
|
|
|
|
|
|
|
| |
Profiler recording is enabled right after command line is initialized. (We need command line to be initialized because we need get channel info first to determine whether or not to enable profiling). function is added inside ChromeMainDelegate and will be called from content.
BUG=453640
Review URL: https://codereview.chromium.org/999883002
Cr-Commit-Position: refs/heads/master@{#321166}
|
|
|
|
|
|
|
|
| |
BUG=394842
Review URL: https://codereview.chromium.org/962753002
Cr-Commit-Position: refs/heads/master@{#320118}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An update on Chrome could replace the V8 snapshot files with newer version.
For zygoted processes this is OK because the zygote will have already mapped
the V8 snapshot and thus child processes will use the correct version of the
snapshot. However, for processes which don't use the zygote (such as
unsandboxed plugin processes) base::LaunchProcess will launch the old
version of he Chrome binary (via /proc/self/exe on Linux), but the child will
read the new version of the V8 snapshot, thus causing a crash due to a
version mismatch.
The fix is to load V8 snapshot file in the browser and pass a file descriptor to
the child processes (much like Android already did, but for different reasons).
This ensures that the child process always sees the correct version of the
snapshot file.
BUG=457656,461057
Review URL: https://codereview.chromium.org/944913002
Cr-Commit-Position: refs/heads/master@{#317790}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this is all broken and has been for a while. Since then, 2012 to 2013
other, sytem-specific systems have been used.
Note that there is a v8 test that is using the stats table. Hoping to sort this now.
BUG=149742
Review URL: https://codereview.chromium.org/899753002
Cr-Commit-Position: refs/heads/master@{#315890}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last stage of the trace_event directory restructuring.
This is part of a set of 3 CLs which is moving tracing clients to use
the new base::trace_event namespace.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
TBR=jam@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/892213004
Cr-Commit-Position: refs/heads/master@{#315310}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This causes crashes if the shutdown path is used on iOS, because on
iOS there's already a higher-level autorelease pool by the time this
code can be run.
BUG=None
Review URL: https://codereview.chromium.org/891843002
Cr-Commit-Position: refs/heads/master@{#314021}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/872363004
Cr-Commit-Position: refs/heads/master@{#313437}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently only crashes on new and new[]. With the change it will also
crash when there is no memory for malloc as well.
BUG=434397
TEST=none.
Committed: https://crrev.com/22d64abdc792516fd0f4895b26ae3a73c85239e0
Cr-Commit-Position: refs/heads/master@{#310320}
Review URL: https://codereview.chromium.org/836733006
Cr-Commit-Position: refs/heads/master@{#313307}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to mmap the V8 snapshot and ICU data file
directly from the WebView APK.
Doing so makes it possible to remove the android_webview_telemetry_build
flag which in turns means we can build the WebView with the same
set of flags that Chrome on Android uses.
BUG=442338
Review URL: https://codereview.chromium.org/812393002
Cr-Commit-Position: refs/heads/master@{#310765}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the snapshot.
Adds code which generates a SHA256 fingerprint of the external V8 snapshot
blob files during the build process, and embeds these values into the
binary. During startup the SHA256 hash of the snapshot blobs are compared
against these fingerprints and Chrome will fail to load if they differ.
BUG=421063,439661
Review URL: https://codereview.chromium.org/832393003
Cr-Commit-Position: refs/heads/master@{#310755}
|
|
|
|
|
|
|
|
|
|
|
|
| |
files as opposed to being statically linked to the binary.
This is not currently supported on any architecture.
BUG=421063
Review URL: https://codereview.chromium.org/594603003
Cr-Commit-Position: refs/heads/master@{#301595}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unnecessary wrapper.
TBR=jam@chromium.org
R=sky@chromium.org
BUG=143619
Review URL: https://codereview.chromium.org/672583003
Cr-Commit-Position: refs/heads/master@{#300923}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/671663002
Cr-Commit-Position: refs/heads/master@{#300461}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/625263003
Cr-Commit-Position: refs/heads/master@{#298305}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed recently with the change to query the device scale factor to see if it needs to be scaled back to 1.0 for
display scales equal to or under 125%. user32/gdi32 API's crash or fail with the Win32K lockdown process mitigation.
Fix is to ensure that the device scale factor is queried from the one set via the command line. The other change is to move
the code in ContentMainRunner::Initialize which sets the global device scale factor for the process to before the content client
initialization. This is because the ShellContentRendererClient in its ctor calls the ShouldUseDirectWrite function which relies on
the GetDPIScale function to decide whether or not directwrite should be enabled. This causes a DCHECK in content_browsertests.
To ensure that the win32k lockdown does not regress I added a simple content browsertest RendererWin32KLockdownNavigationTest which runs
this on Windows 8+.
The accessibility fixes are to get the browser tests to run
on Windows 8. There were special cases to always enable
accessibility on Windows 8 for historical reasons. These are
no longer necessary as we don't rely on accessibility to display the virtual keyboard.
BUG=417147
Review URL: https://codereview.chromium.org/600263002
Cr-Commit-Position: refs/heads/master@{#296859}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HighResNowWrapper in case High Res is supported
https://codereview.chromium.org/446203002/
The reland avoids using a static initializer for now_function, it initializes the function pointer on the first call instead.
I incorporated maruel@'s suggestions.
jam for
chrome/browser/
content/app/
willchan,maruel for
base/time/
BUG=400627
R=cpu@chromium.org, jam@chromium.org, maruel@chromium.org, thakis@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/a7c8e5e3411d6a3d32f4e1a61f8baa3e438fee52
Review URL: https://codereview.chromium.org/530293002
Cr-Commit-Position: refs/heads/master@{#293555}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Res is supported (patchset #7 of https://codereview.chromium.org/446203002/)
Reason for revert:
It causes a Canary crash
https://code.google.com/p/chromium/issues/detail?id=408354
The added static initializer causes a crash in libpeerconnetion used by WebRTC
Fix to reland: remove static initializer.
Original issue's description:
> We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots
> https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
>
> It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
> This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
>
> By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
>
> BUG=158234
>
> Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430
TBR=jar@chromium.org,willchan@chromium.org,maruel@chromium.org,thakis@chromium.org,jam@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=158234
Review URL: https://codereview.chromium.org/516693002
Cr-Commit-Position: refs/heads/master@{#292288}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generation steps
* Fixed in this version: dependencies for *_api_registration on *_api.
Split bundle generation steps so that API registration is generated in browser, not common.
We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.
Fix a couple of dangling gyp issues also.
BUG=405226
TBR=scottmg@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/513633002
Cr-Commit-Position: refs/heads/master@{#292090}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in browser, not common."
Causing build failure in Android due to failed include for extensions/common/api/runtime.h.
This reverts commit 3b70ef14be986a3252428cc6d9553bf2c69deb70.
BUG=none
TBR=yoz
Review URL: https://codereview.chromium.org/506253003
Cr-Commit-Position: refs/heads/master@{#292059}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser, not common.
We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.
Fix a couple of dangling gyp issues also.
BUG=405226
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/489153003
Cr-Commit-Position: refs/heads/master@{#292057}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regression on the perf bots
https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
BUG=158234
Review URL: https://codereview.chromium.org/446203002
Cr-Commit-Position: refs/heads/master@{#291974}
|
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/456513002
Cr-Commit-Position: refs/heads/master@{#288787}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the options for tracing were passed around with different ad hoc
systems. Strings in some places, base::debug::TraceOptions enum in others,
and a content::TraceOptions in yet another. There were two separate ad-hoc
string formats. Similar messes were present with category filters: sometimes
we passed strings, sometimes the CategoryFilter.
This patch though enormous looking simply consolidates all this ad-hockery
into base::debug::TraceOptions. It may look like the call sites have gotten
more verbose,
but the end result of this is a consistent understanding of TraceOptions.
There is one exception to this consolidation: devtools has to maintain its own
mapping of string->TraceOptions encoding. This is because DevTools makes
guarantees about backward compatibility: if base changes its mind about the
string form of a TraceOption, devtools needs to keep supporting the old form.
BUG=396081
TBR=cevans@chromium.org
Review URL: https://codereview.chromium.org/425593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a parameter, in order to defer calculating the value until after the AtExitManager is initialized.
BUG=398747
Review URL: https://codereview.chromium.org/434533005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding simonjam@'s CL https://codereview.chromium.org/41953002/ to enable QPC.
This may result in perf changes, the perf changes may only be in the measurements and not actual regressions.
BUG=158234
Review URL: https://codereview.chromium.org/429053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=395259
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/421203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the contribution of this feature to missing crash reports.
Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.
BUG=394842
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284100
Review URL: https://codereview.chromium.org/402723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
codes.
BUG=327256
Review URL: https://codereview.chromium.org/411283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
measure the contribution of this… (https://codereview.chromium.org/402723002/)
Reason for revert:
Crashes chromium.perf bots.
ChildEBP RetAddr
0052f9f4 6a47d2ff chrome_69f00000!base::debug::BreakDebugger+0x10
0052fa64 6a47df08 chrome_69f00000!CheckIsChromeSxSProcess+0x26
0052fa68 6a47e664 chrome_69f00000!InstallUtil::IsChromeSxSProcess+0x16
0052fa70 6a47e53b chrome_69f00000!BrowserDistribution::GetSpecificDistribution+0x3b
0052fa78 6a47bb77 chrome_69f00000!BrowserDistribution::GetDistribution+0x7
0052fb64 6a47bb2e chrome_69f00000!`anonymous namespace'::GetChromeChannelInternal+0x2c
0052fb7c 6a2d03f8 chrome_69f00000!GoogleUpdateSettings::GetChromeChannel+0x21
0052fbe8 6a2cd0d8 chrome_69f00000!chrome::VersionInfo::GetChannel+0x60
0052fbec 6a2cd1ab chrome_69f00000!`anonymous namespace'::GetBeaconKeyPath+0x5
0052fc08 6a2cc624 chrome_69f00000!ShouldExperimentallyDisableTerminateOnHeapCorruption+0xe
0052fc50 0020720b chrome_69f00000!ChromeMain+0x42
0052fce0 00206c36 chrome!MainDllLoader::Launch+0x15f
0052fd24 00228c9e chrome!wWinMain+0x5a
0052fd70 766e338a chrome!__tmainCRTStartup+0xfd
WARNING: Stack unwind information not available. Following frames may be wrong.
0052fd7c 76f99f72 kernel32!BaseThreadInitThunk+0x12
0052fdbc 76f99f45 ntdll!RtlInitializeExceptionChain+0x63
0052fdd4 00000000 ntdll!RtlInitializeExceptionChain+0x36
Original issue's description:
> Experimentally disable termination on heap corruption in order to measure the contribution of this feature to missing crash reports.
>
> Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.
>
> BUG=394842
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284100
TBR=jochen@chromium.org,brettw@chromium.org,jhawkins@chromium.org,wfh@chromium.org,erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394842
Review URL: https://codereview.chromium.org/401913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the contribution of this feature to missing crash reports.
Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.
BUG=394842
Review URL: https://codereview.chromium.org/402723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=325893
Review URL: https://codereview.chromium.org/333823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, Mojo applications that link against mojo_environment_chromium
do not need to instantiate mojo::Environment. We rely on AtExitManager for all
finalization of singleton objects. This frees us up to use the familiar
base::Singleton and base::LazyInstance for any such state. Tests can use
ShadowingAtExitManager to clean the environment between test runs.
It becomes a link error to use mojo::Environment if you are not linking against
mojo_environment_standalone. I plan to follow this up with a change that buries
mojo::Environment for the case where you are linking against
mojo_environment_standalone. Ideally, this means no one will ever need to think
about mojo::Environment again.
Review URL: https://codereview.chromium.org/281353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The _Module object is used by ATL COM classes to lock the module, like so
_pAtlModule->Lock();
For example when CreateInstance is called:
BrowserAccessibility* BrowserAccessibility::Create() {
CComObject<BrowserAccessibilityWin>* instance;
HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance);
We need to get rid of WTL so we can get rid of ATL since it
causes many problems. See bug for details.
BUG=5027
TEST=chrome runs. Accessibility works.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275987
Review URL: https://codereview.chromium.org/323723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of reading icudtl.dat from app_chrome directory,
use a file descriptor passed from the browser process.
This allows us to tight permissions on data directory.
BUG=378381
R=avi@chromium.org, jshin@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/317833006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/323723002/)
Reason for revert:
Speculative revert for breaking TestAccessibleHWND unit test.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/14186
Original issue's description:
> Removing WTL from content runner.
>
> The _Module object is used by ATL COM classes to lock the module, like so
>
> _pAtlModule->Lock();
>
> For example when CreateInstance is called:
>
> BrowserAccessibility* BrowserAccessibility::Create() {
> CComObject<BrowserAccessibilityWin>* instance;
> HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance);
>
> We need to get rid of WTL so we can get rid of ATL since it
> causes many problems. See bug for details.
>
> BUG=5027
> TEST=chrome runs. Accessibility works.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275987
TBR=jam@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=5027
Review URL: https://codereview.chromium.org/323003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The _Module object is used by ATL COM classes to lock the module, like so
_pAtlModule->Lock();
For example when CreateInstance is called:
BrowserAccessibility* BrowserAccessibility::Create() {
CComObject<BrowserAccessibilityWin>* instance;
HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance);
We need to get rid of WTL so we can get rid of ATL since it
causes many problems. See bug for details.
BUG=5027
TEST=chrome runs. Accessibility works.
Review URL: https://codereview.chromium.org/323723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure that we don't use GDI to query the device scale factor in renderer processes.
This is in preparation for setting the MITIGATION_WIN32K_DISABLE policy on renderer processes, which
will lock them out from making user32/gdi32 calls which enter win32k.sys.
BUG=365160
Review URL: https://codereview.chromium.org/308003020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused layout tests (when run with check-sys-deps) to hang on Windows
with a stuck content_shell process. See Issue 376929.
BUG=376929
> Mojo: nuke EnvironmentData
>
> With this change, Mojo applications that link against mojo_environment_chromium
> do not need to instantiate mojo::Environment. We rely on AtExitManager for all
> finalization of singleton objects. This frees us up to use the familiar
> base::Singleton and base::LazyInstance for any such state. Tests can use
> ShadowingAtExitManager to clean the environment between test runs.
>
> It becomes a link error to use mojo::Environment if you are not linking against
> mojo_environment_standalone. I plan to follow this up with a change that buries
> mojo::Environment for the case where you are linking against
> mojo_environment_standalone. Ideally, this means no one will ever need to think
> about mojo::Environment again.
>
> Review URL: https://codereview.chromium.org/281353005
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/299263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, Mojo applications that link against mojo_environment_chromium
do not need to instantiate mojo::Environment. We rely on AtExitManager for all
finalization of singleton objects. This frees us up to use the familiar
base::Singleton and base::LazyInstance for any such state. Tests can use
ShadowingAtExitManager to clean the environment between test runs.
It becomes a link error to use mojo::Environment if you are not linking against
mojo_environment_standalone. I plan to follow this up with a change that buries
mojo::Environment for the case where you are linking against
mojo_environment_standalone. Ideally, this means no one will ever need to think
about mojo::Environment again.
Review URL: https://codereview.chromium.org/281353005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No functional changes yet, just preparation for splitting NaCl's fork
delegate into two different implementations.
BUG=364945
Review URL: https://codereview.chromium.org/269413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces two new content classes:
- MojoApplicationHost encapsulates what's needed to host a Mojo App using Chrome IPC to bootstrap.
- MojoApplication represents what's needed to be a Mojo App using Chrome IPC to bootstrap.
The RenderProcess and RenderProcessHost interfaces are replaced with WebUISetup and WebUISetupClient interfaces. This way the interface is more specific to the service of setting up WebUI.
WebUISetupClient is empty and uninteresting. RenderProcessHostImpl no longer deals with WebUI setup. That is all done directly by RenderViewHostImpl by talking to the WebUISetup service.
Service names get defined in content/common/mojo/mojo_service_names.{h,cc}.
TBR=sky@chromium.org, tsepez@chromium.org
Originally reviewed at https://codereview.chromium.org/236813002/
Review URL: https://codereview.chromium.org/256403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've investigated and can't find a use for this code post aura.
It's also a blocker for disabling win32 in the sandbox.
dmazzoni@ + kochi@ - You're added as a heads-up in case anything
breaks with accessibility or IME.
BUG=365160
R=jam@chromium.org,dmazzoni@chromium.org,kochi@chromium.org
Review URL: https://codereview.chromium.org/244543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
they're only called inside content.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/241353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264628 0039d316-1c4b-4281-b951-d872f2087c98
|