| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This wires up the ChildProcessLauncher and SandboxedProcessLauncherDelegate.
No restrictive policies are currently registered or enforced, i.e. renderers
should not be locked down. However, to keep NPAPI plugins working, an allow-by-
default policy exists.
BUG=367863
R=jam@chromium.org
Review URL: https://codereview.chromium.org/303293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We already do this in Chrome, and it would be useful for layout tests that create a lot of layers.
BUG=
Review URL: https://codereview.chromium.org/252903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch implements the browser side bits needed for the
Battery Status API. It includes a message filter, a singleton
service which owns and controls the platform-specific battery
status manager. Updates are implemented using callbacks and
async IPCs between the browser and the renderer.
A unit test for the service using a fake battery status manager
and callbacks is also provided.
Corresponding renderer-side patch:
https://codereview.chromium.org/252113006/
BUG=122593, 360068
Review URL: https://codereview.chromium.org/278043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way when creating the Compositor we can supply the ContextFactory
from the thread local Env to it. This is part of making aura thread
safe.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/296053009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Most code uses PLOG with the same effect.
TBR=bradchen
NOTRY=true
Review URL: https://codereview.chromium.org/281223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the ozone subsystems don't need to be initialized in the GPU
process (e.g. events). So let the ozone-platform know what process the
platform is being initialized for, and initialize only the subsystems
that make sense for that process.
The changes include:
* Remove SetInstance() from EventFactoryOzone, SurfaceFactoryOzone and
CursorFactoryOzone. Instead, set the instance from the constructor.
* Require the platforms to provide one explicit constructor for the UI
and GPU processes through the OzonePlatform interface.
* Do not initialize any of the sub-systems in InitializeGPU() in all
platforms.
* Move the initialization of ozone-platform into aura::Env::Init.
* Move the creation of udev-monitor in DeviceManagerUdev from the
constructor to ScanDevices(), since it needs the message-loop, and the
message-loop is constructed later.
* Update EventFactoryEvdev to set the ui_task_runner_ from
OnDispatcherListChanged(), since this too is created before the
message-loop.
BUG=361137
R=piman@chromium.org
TBR=spang@chromium.org
Review URL: https://codereview.chromium.org/291473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of requiring the client to tell the evdev event-factory about
the file thread, always use the worker-pool to attach to/detach from
an input device.
BUG=none
R=sky@chromium.org, spang@chromium.org
Review URL: https://codereview.chromium.org/285953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch, pixels appear on screen and tab capture works.
Add a OnNativeSurfaceBuffersSwapped mechanism to display
an IOSurface to an NSView. This is wired up to the existing
CompositingIOSurfaceMac. In a future refactoring, something
much more light-weight than CompositingIOSurfaceMac will
be used (CompositingIOSurfaceMac has capture code, etc, in
it).
Add a DelegatedFrameHost to RenderWidgetHostViewMac, and
hookup the DelegatedFrameHostClient implementation. Create
the DelegatedFrameHost when a delegated frame is received, and
use its existence to determine which mode is active.
BUG=314190
Review URL: https://codereview.chromium.org/267073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we use RecvMsgWithPid to find the PIDs for zygote children,
we no longer need to plumb the chrome-sandbox path down into and
through the renderer host code.
BUG=357670
NOTRY=true
Review URL: https://codereview.chromium.org/276763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently mojo runs all services in the same process. We have separate
services that manage the display and one that runs aura. The display
one needs to create PlatformEventSource (as it gets events). The
service running aura doesn't need a PlatformEventSource as it gets
events from the display one. This means I need the ability to create
aura::Env without a PlatformEventSource.
I believe the long term plan is to move some services out of
process. When this happens this boolean shouldn't be needed.
BUG=365012
TEST=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/262883011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
zone changes.
On Mac, this listens for NSSystemTimeZoneDidChangeNotification notifications.
The Mac implementation also contains a sandbox hole to allow time zone
information (/etc/localtime and /usr/share/zoneinfo) to be read from within
sandboxed renderer processes.
On Windows, this listens for WM_TIMECHANGE messages.
On Linux (but not Chrome OS or Android), this watches for changes to
/etc/localtime, /etc/timezone, and /etc/TZ. There isn't a better standard for
watching for time zone changes on Linux. The actual mechanism is
libc-specific, but this should work with common libc implementations. Time
zone watching is suppressed if the TZ environment variable is set. Linux
(including Chrome OS and Android) already contains a sandbox workaround
(ProxyLocaltimeCallToBrowser) that allows renderer processes to get time zone
information from the browser.
On Android, this uses a Java bridge to listen for
Intent.ACTION_TIMEZONE_CHANGED.
This unifies the existing time zone change notification from Chrome OS with
the other platform implementations.
On Mac, Linux, Chrome OS, and Android renderers should pick up the new time
zone name and UTC offset. On Windows, renderers may only be able to pick up
the new UTC offset only, and the sandbox may blocks them from picking up the
new time zone name, although in my test on Windows Server 2012, they were able
to pick up both the UTC offset and the time zone name upon change.
This is a continuation of https://codereview.chromium.org/183763041/ (Mac) and
https://codereview.chromium.org/193763002/ (Windows).
BUG=288697
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
and then click "recheck" to ensure that the renderer picks up the new
time zone. Don't reload the page, which is likely to give you a new
renderer process, use the "recheck" link on the page.
R=bulach@chromium.org, cpu@chromium.org, jeremy@chromium.org, jln@chromium.org, jochen@chromium.org, pastarmovj@chromium.org, rsesek@chromium.org
Review URL: https://codereview.chromium.org/251613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Chrome OS, it is possible for chrome to start without the X11
server (e.g. X server has crashed, and hasn't restarted since). In
such cases, Chrome ends up causing a crash. So instead of the crash,
abort the startup sequence if the toolkit initialization step fails.
BUG=364929
R=jam@chromium.org
Review URL: https://codereview.chromium.org/250723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces two new content classes:
- MojoApplicationHost encapsulates what's needed to host a Mojo App using Chrome IPC to bootstrap.
- MojoApplication represents what's needed to be a Mojo App using Chrome IPC to bootstrap.
The RenderProcess and RenderProcessHost interfaces are replaced with WebUISetup and WebUISetupClient interfaces. This way the interface is more specific to the service of setting up WebUI.
WebUISetupClient is empty and uninteresting. RenderProcessHostImpl no longer deals with WebUI setup. That is all done directly by RenderViewHostImpl by talking to the WebUISetup service.
Service names get defined in content/common/mojo/mojo_service_names.{h,cc}.
TBR=sky@chromium.org, tsepez@chromium.org
Originally reviewed at https://codereview.chromium.org/236813002/
Review URL: https://codereview.chromium.org/256403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize the aura environment as part of initializing the toolkit in
BrowserMainLoop::InitializeToolkit. Change all the other places that
tries to initialize aura::Env to instead assert that aura::Env has
already been initialized. With this change, the initialization of
aura::Env happens in the same place on all aura platforms.
BUG=365947
R=jochen@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/248503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/{renderer, common, browser}/device_orientation ->
content/{renderer, common, browser}/device_sensors.
Rename DeviceMotionAndOrientation.java -> DeviceSensors.java
Fix the ifdef include guards
Fix Linting nits complained by cpplint.py
This change is needed to add DeviceLight api.
I will add DeviceLight related changes after https://codereview.chromium.org/143823004/
is added in Blink.
BUG=336424
Review URL: https://codereview.chromium.org/236833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build
TBR=sky
NOTRY=true
Review URL: https://codereview.chromium.org/246433009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop honoring the flag and remove IsForceCompositingEnabled
from content/. Now only WebkitTestRunner checks for the
presence of the flag.
R=piman@chromium.org, miu@chromium.org, darin@chromium.org
TBR=darin
BUG=363772
Review URL: https://codereview.chromium.org/240183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297026
R=ben@chromium.org, brettw@chromium.org
Review URL: https://codereview.chromium.org/238633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r264517 to r264538 from terry@google.com
BUG=none
TEST=none
NOTRY=true
NOTREECHECKS=true
TBR=terry@google.com
Review URL: https://codereview.chromium.org/239993009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=314190
Review URL: https://codereview.chromium.org/224883007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9643,97293
Review URL: https://codereview.chromium.org/236193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the code that finds the setuid sandbox binary to
the SetuidSandboxClient class.
BUG=358733
R=mdempsky@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/238153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remaining use of the X11 mesage-pump was opening the connection to the
X11 server. This patch moves that out of the message-pump, into gfx. This
allows us to remove the X11 message-pump, and just use the base Glib-based
message-pump on Linux and ChromeOS.
BUG=354062
R=darin@chromium.org, sky@chromium.org
Previously landed in r263726, but reverted in r263733 to allow reverting another CL.
Review URL: https://codereview.chromium.org/235043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: along with 263718 blamed for
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/45298
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29956
> x11: Remove X11 message-pump.
>
> The remaining use of the X11 mesage-pump was opening the connection to the
> X11 server. This patch moves that out of the message-pump, into gfx. This
> allows us to remove the X11 message-pump, and just use the base Glib-based
> message-pump on Linux and ChromeOS.
>
> BUG=354062
> R=darin@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/235043005
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/238093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The remaining use of the X11 mesage-pump was opening the connection to the
X11 server. This patch moves that out of the message-pump, into gfx. This
allows us to remove the X11 message-pump, and just use the base Glib-based
message-pump on Linux and ChromeOS.
BUG=354062
R=darin@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/235043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LOG(INFO) -> VLOG(0)
R=piman@chromium.org
Review URL: https://codereview.chromium.org/235403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Putting chrometrace.log in the current working directory is not
useful on Android. Generate a filepath on the sdcard instead the
same way we do it for intent triggered tracing.
R=piman@chromium.org, wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/232053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297026
R=ben@chromium.org
Review URL: https://codereview.chromium.org/231733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/179923006/)
Reason for revert:
Failing interactive_ui_tests dbg:
http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20(dbg)/builds/47083/steps/interactive_ui_tests/logs/stdio
Original issue's description:
> Attempting to resolve a race condition with PowerMonitor.
>
> ThreadSanitizer caught multiple instances where PowerMonitor::Get or PowerMonitor::Add/RemoveObserver were being called concurrently with the PowerMonitor constructor in the main thread. These functions access a process-global PowerMontior instance (g_power_monitor), which was not thread safe.
>
> This change adds locks around PowerMonitor creation and deletion, and forces Add/RemoveObserver to be called in a threadsafe manner. It also removes the need to call PowerMonitor::Get.
>
> BUG=268924
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262018
TBR=mattm@chromium.org,jyasskin@chromium.org,kbr@chromium.org,bradnelson@chromium.org,brettw@chromium.org,bradchen@chromium.org,willchan@chromium.org,jam@chromium.org,jochen@chromium.org,timurrrr@chromium.org,glider@chromium.org,acolwell@chromium.org,scherkus@chromium.org,bajones@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=268924
Review URL: https://codereview.chromium.org/226263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ThreadSanitizer caught multiple instances where PowerMonitor::Get or PowerMonitor::Add/RemoveObserver were being called concurrently with the PowerMonitor constructor in the main thread. These functions access a process-global PowerMontior instance (g_power_monitor), which was not thread safe.
This change adds locks around PowerMonitor creation and deletion, and forces Add/RemoveObserver to be called in a threadsafe manner. It also removes the need to call PowerMonitor::Get.
BUG=268924
Review URL: https://codereview.chromium.org/179923006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A follow up to https://codereview.chromium.org/212603006/ to fix the
initialization of the variable. We removed a command line flag that will
now be always false for existance, but that should make the variable
always true.
R=piman@chromium.org, sievers@chromium.org
BUG=356876
Review URL: https://codereview.chromium.org/218683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests that depend on this flag actually fail since the UI compositor
creates an OutputSurface which makes the GPU process launch before
the test body gets to run.
Since this flag doesn't really make sense with a UI compositor present,
we should move these tests to not be browser tests. Since they just
pass by early-out right now, remove the early outs and disable them.
R=jbauman@chromium.org, piman@chromium.org
BUG=356876
Review URL: https://codereview.chromium.org/212603006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InitStartupTracing posts a task to end the startup tracing so it
should only be called after the main message loop is started
(PostMainMessageLoopStart()). Otherwise the browser will crash
when MessagePumpForUI::ScheduleWork() is called before
MessagePumpForUI::Start().
BUG=352223
Review URL: https://codereview.chromium.org/198713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose of this change is to remove a layering violation: Code in content/browser/renderer_host should not depend on content/browser/web_contents. As a secondary benefit, the code modules have been consolidated into a more-appropriate location, with cleaner DEPS/OWNERS files.
There are NO CODE CHANGES being made here, other than include's and ifdef guards in .h files.
BUG=178495
R=fbarchard@chromium.org, jam@chromium.org, scherkus@chromium.org
Review URL: https://codereview.chromium.org/172003004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initializing devices added to the system should be offloaded from the UI
thread. Let's inject a handle to the browser file thread from content and
run the device management code on that thread.
Device attach is split into two parts: the file thread part and the UI
thread part. All of the ioctls run on the file thread, and the device is
handed off to the UI thread at the last minute before we start reading
events. Input events are processed on the UI thread as usual.
EventFactoryEvdev gets a weak factory so it can invalidate
callbacks used on the file thread when it is destroyed.
BUG=340465
TEST=embedded content_shell on link
Review URL: https://codereview.chromium.org/148283014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now TSF-related code is completely consolidated into the metro_driver process. We can safely revert the following CLs:
- r155589 : Call TSF-based UI message pump APIs by introducing an injection mechanism into MessageLoopForUI.
- r151669 : Introduce base::win::IsTSFAwareRequired() which indicates if TSF-awareness is required or not.
BUG=319122, 330735
TEST=manually done on Windows 8.1
Review URL: https://codereview.chromium.org/141773009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Naming cleanup based on following rules:
- MidiFooBar ... use this style to be consistent with chromium
- WebMIDIFooBar ... Web API name related things, or names in blink
- MIDIFooBar ... APIs and structures defined by each operating systems
Other cleanup:
- Modify some TODO(crogers) to TODO(toyoshim)
- Add some crbug links.
- Remove some obsolete UI TODOs related to infobars
BUG=none
TEST=build for all platforms
Review URL: https://codereview.chromium.org/151343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently tests initialize GL by calling into methods that should be
internal to the gl bindings code. Instead, everyone should go through
GLSurface::InitializeOneOff.
Also GLSurface::InitializeOneOff early outs if it was already called,
leading to a pattern of initializing GL all over the place just in case
and not having a clear idea of where it should be set up. Instead, DCHECK
that it is not called more than once, and move calls to this method to
be during process startup for unit test suites instead of mid-test.
This adds two test variants of InitializeOneOff for tests to call, that
set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
R=ben@chromium.org, piman@chromium.org, sievers@chromium.org, piman, sievers
BUG=270918
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247793
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248049
Review URL: https://codereview.chromium.org/135213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/150083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused content_gl_tests to start failing on all Mac Release GPU bots.
See Issue 339658 for details.
> Ensure GL initialization only happens once, and provide common init path
>
> Currently tests initialize GL by calling into methods that should be
> internal to the gl bindings code. Instead, everyone should go through
> GLSurface::InitializeOneOff.
>
> Also GLSurface::InitializeOneOff early outs if it was already called,
> leading to a pattern of initializing GL all over the place just in case
> and not having a clear idea of where it should be set up. Instead, DCHECK
> that it is not called more than once, and move calls to this method to
> be during process startup for unit test suites instead of mid-test.
>
> This adds two test variants of InitializeOneOff for tests to call, that
> set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
>
> R=piman, sievers
> BUG=270918
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247793
>
> Review URL: https://codereview.chromium.org/135213003
TBR=danakj@chromium.org
BUG=270918,339658
Review URL: https://codereview.chromium.org/151003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently tests initialize GL by calling into methods that should be
internal to the gl bindings code. Instead, everyone should go through
GLSurface::InitializeOneOff.
Also GLSurface::InitializeOneOff early outs if it was already called,
leading to a pattern of initializing GL all over the place just in case
and not having a clear idea of where it should be set up. Instead, DCHECK
that it is not called more than once, and move calls to this method to
be during process startup for unit test suites instead of mid-test.
This adds two test variants of InitializeOneOff for tests to call, that
set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
R=piman, sievers
BUG=270918
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247793
Review URL: https://codereview.chromium.org/135213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
due to new static initializers in gl_bindings_autogen_gl.cc
> Ensure GL initialization only happens once, and provide common init path
>
> Currently tests initialize GL by calling into methods that should be
> internal to the gl bindings code. Instead, everyone should go through
> GLSurface::InitializeOneOff.
>
> Also GLSurface::InitializeOneOff early outs if it was already called,
> leading to a pattern of initializing GL all over the place just in case
> and not having a clear idea of where it should be set up. Instead, DCHECK
> that it is not called more than once, and move calls to this method to
> be during process startup for unit test suites instead of mid-test.
>
> This adds two test variants of InitializeOneOff for tests to call, that
> set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
>
> R=piman, sievers
> BUG=270918
>
> Review URL: https://codereview.chromium.org/135213003
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/149953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently tests initialize GL by calling into methods that should be
internal to the gl bindings code. Instead, everyone should go through
GLSurface::InitializeOneOff.
Also GLSurface::InitializeOneOff early outs if it was already called,
leading to a pattern of initializing GL all over the place just in case
and not having a clear idea of where it should be set up. Instead, DCHECK
that it is not called more than once, and move calls to this method to
be during process startup for unit test suites instead of mid-test.
This adds two test variants of InitializeOneOff for tests to call, that
set up OSMesa or Mock GL bindings, via GLSurface::InitializeOneOff.
R=piman, sievers
BUG=270918
Review URL: https://codereview.chromium.org/135213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In BrowserMainLoop::ShutdownThreadsAndCleanUp(), we explicitly call
a new ZygoteHostImpl::TearDownAfterLastChild API to notify the Zygote
to exit after its last child died.
The notification is to simply close the IPC channel to the Zygote.
Before this patch, this would happen implicitly when the browser process
died.
To implement this, we add a lightweight child tracking mechanism to ZygoteHostImpl.
BUG=334345
R=piman@chromium.org
Review URL: https://codereview.chromium.org/148443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow us to enable overscroll by default on one platform only.
BUG=None
TEST=None
R=jam@chromium.org
Review URL: https://codereview.chromium.org/137203012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser, 2 of 3.
This adds the preference observer to the browser and starts sending the
parameter to the renderer over IPC when it changes. Blink will not use this
until part 3 lands.
BUG=306348
Review URL: https://codereview.chromium.org/136443008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we assume we're in startup tracing if the TraceLog has been enabled.
But, in the case of ECHO_TO_CONSOLE we will have started the trace log but we
don't want the startup tracing code to automatically shut down our console
tracing.
This CL makes the is_tracing_start_ flag depend on both IsTracing and that
ECHO_TO_CONSOLE is not enabled.
BUG=trace-viewer:516
Review URL: https://codereview.chromium.org/134183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of removing the MessageLoop::Type enum.
BUG=none
TEST=none
R=darin@chromium.org
Review URL: https://codereview.chromium.org/141683005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the bulk of the files in content/browser/aura to
content/browser/compositor, since they're not aura-specific.
Build all of those files in the Mac build, and add ui/compositor
to the dependencies of the Mac build. These files will soon only
be excluded from the Android build.
BUG=314190
> Originally submitted:
> https://codereview.chromium.org/137893007
> Then reverted:
> https://codereview.chromium.org/137853019 (bug 335083)
This submission has the failing test disabled.
TBR=piman,danakj
Review URL: https://codereview.chromium.org/140753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245352 0039d316-1c4b-4281-b951-d872f2087c98
|