summaryrefslogtreecommitdiffstats
path: root/content/browser/browser_main_runner.cc
Commit message (Collapse)AuthorAgeFilesLines
* clang/win: Try to fix 64-bit build more after ↵Nico Weber2015-08-081-0/+2
| | | | | | | | | | | https://codereview.chromium.org/1261953003. BUG=505316 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1273963003. Cr-Commit-Position: refs/heads/master@{#342542}
* Better organize content::BrowserMainLoop.thestig2015-05-271-0/+2
| | | | | | | | | | - Split MainMessageLoopStart() into 3 sections. - Fix documentation for member initialization. - Fix misc nits. Review URL: https://codereview.chromium.org/1148733004 Cr-Commit-Position: refs/heads/master@{#331664}
* Instrument some potentially expensive functions called from ↵yiyaoliu2015-04-231-3/+3
| | | | | | | | | | | | BrowserMainRunnerImpl::Initialize. There can be more places to instrument, this does not intend to build a full instrumentation list. The plan is to add more based on the result. BUG=453640 Review URL: https://codereview.chromium.org/1069403004 Cr-Commit-Position: refs/heads/master@{#326661}
* Profiler-instrumentation of the startup time.yiyaoliu2015-03-181-0/+9
| | | | | | | | | | Profiler recording is enabled right after command line is initialized. (We need command line to be initialized because we need get channel info first to determine whether or not to enable profiling). function is added inside ChromeMainDelegate and will be called from content. BUG=453640 Review URL: https://codereview.chromium.org/999883002 Cr-Commit-Position: refs/heads/master@{#321166}
* Revert of Profiler-instrumentation of the startup time (patchset #2 id:20001 ↵oysteine2015-02-021-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/866403008/) Reason for revert: Reverting due to https://crbug.com/454534 Original issue's description: > Profiler-instrumentation of the startup time. > > Before the instrumentation, startup time wasn't reported in profiler data. > > Profiling it will allow the genre of detailed analysis of the startup time via jankiness investigations. > > This change requires temporarily initializing tracking earlier than usual. Thie will either removed once the investigations complete, or will be officially converted to permanent code. > > BUG=453640 > > Committed: https://crrev.com/1ebb11710e08d51fa99836190edc3db28dffc136 > Cr-Commit-Position: refs/heads/master@{#314179} TBR=asvitkine@chromium.org,isherman@chromium.org,cpu@chromium.org,vadimt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453640 Review URL: https://codereview.chromium.org/864273003 Cr-Commit-Position: refs/heads/master@{#314204}
* Profiler-instrumentation of the startup time.vadimt2015-02-021-0/+9
| | | | | | | | | | | | | | Before the instrumentation, startup time wasn't reported in profiler data. Profiling it will allow the genre of detailed analysis of the startup time via jankiness investigations. This change requires temporarily initializing tracking earlier than usual. Thie will either removed once the investigations complete, or will be officially converted to permanent code. BUG=453640 Review URL: https://codereview.chromium.org/866403008 Cr-Commit-Position: refs/heads/master@{#314179}
* Mechanical rename of tracing includes for /content [1/3]ssid2015-01-281-1/+1
| | | | | | | | | | | | This is just a mechanical rename of tracing includes. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/866803003 Cr-Commit-Position: refs/heads/master@{#313421}
* Restore the allocator shim on Windows. Add 2Gb limit on allocations via the ↵wfh2015-01-131-9/+0
| | | | | | | | | | | | | | shim. Remove tcmalloc from Windows. Restore working tcmalloc_unittests on Linux and allocator_unittests on other platforms. Add Death tests to base_unittests SecurityTests. Fix prep_libc.py to actually strip the objects correctly. BUG=169327,434397 TEST=base_unittests --gtest_filter=SecurityTest.* TEST=allocator_unittests, tcmalloc_unittest Review URL: https://codereview.chromium.org/774683003 Cr-Commit-Position: refs/heads/master@{#311194}
* Enable subpixel positioning for UIckocagil2014-12-021-44/+1
| | | | | | | | | BUG=389649,434860,434843 R=ananta,msw,derat,jam,eae,sky Review URL: https://codereview.chromium.org/738363002 Cr-Commit-Position: refs/heads/master@{#306346}
* Reland attempt to fix a DirectWrite metrics retrieval browser crasher in Canary.dcheng2014-11-251-6/+16
| | | | | | | | | | | | | | | | | | | | | The crash occurs because the IDWriteFactory::GetSystemFontCollection method returns E_INVALIDARG. From some analysis of the crash dumps it appears that the crashes are mostly coming from Windows 7 version 6.1.7600.* and dwrite version 6.1.7600.16972. We tried the same version of dwrite locally in a VM where things work correctly though. In any case the fix attempted here is to check the return from the SkFontMgr_New_DirectWrite call. If we get back a NULL factory then it probably means that the skia factory init failed. There is code in the SkFontMgr_New_DirectWrite function to get the system font collection. If that call fails the function returns NULL. We should not attempt to use DW in that case. The other change is to use a ScopedComPtr for the IDWriteFactory interface in the MaybeEnableDirectWriteFontRendering function. Will see how this plays in tomorrows canary. BUG=436146 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/752353002 Cr-Commit-Position: refs/heads/master@{#305586}
* Revert of Attempt to fix a DirectWrite metrics retrieval browser crasher in ↵rlp2014-11-251-16/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Canary. (patchset #1 id:1 of https://codereview.chromium.org/744463004/) Reason for revert: Causes a compile error on WebKit Win x64 Builder (dbg): FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\content\browser\content.browser_main_runner.obj.rsp /c ..\..\content\browser\browser_main_runner.cc /Foobj\content\browser\content.browser_main_runner.obj /Fdobj\content\content.cc.pdb c:\b\build\slave\webkit-win-latest-dbg-x64\build\src\content\browser\browser_main_runner.cc(150) : error C2664: 'SkFontMgr *SkFontMgr_New_DirectWrite(IDWriteFactory *)' : cannot convert argument 1 from 'base::win::ScopedComPtr<IDWriteFactory,& _GUID_b859ee5a_d838_4b5b_a2e8_1adc7d93db48>' to 'IDWriteFactory *' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called c:\b\build\slave\webkit-win-latest-dbg-x64\build\src\content\browser\browser_main_runner.cc(153) : error C2664: 'void gfx::PlatformFontWin::SetDirectWriteFactory(IDWriteFactory *)' : cannot convert argument 1 from 'base::win::ScopedComPtr<IDWriteFactory,& _GUID_b859ee5a_d838_4b5b_a2e8_1adc7d93db48>' to 'IDWriteFactory *' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called ninja: build stopped: subcommand failed. Original issue's description: > Attempt to fix a DirectWrite metrics retrieval browser crasher in Canary. > > The crash occurs because the IDWriteFactory::GetSystemFontCollection method returns E_INVALIDARG. From some analysis of > the crash dumps it appears that the crashes are mostly coming from Windows 7 version 6.1.7600.* and dwrite version 6.1.7600.16972. > We tried the same version of dwrite locally in a VM where things work correctly though. > > In any case the fix attempted here is to check the return from the SkFontMgr_New_DirectWrite call. If we get back a NULL factory then > it probably means that the skia factory init failed. There is code in the SkFontMgr_New_DirectWrite function to get the system font collection. > If that call fails the function returns NULL. We should not attempt to use DW in that case. > > The other change is to use a ScopedComPtr for the IDWriteFactory interface in the MaybeEnableDirectWriteFontRendering function. > > Will see how this plays in tomorrows canary. > > BUG=436146 > > Committed: https://crrev.com/5f617d4e5cd396000457acd0c71c603aa45d6fd3 > Cr-Commit-Position: refs/heads/master@{#305566} TBR=cpu@chromium.org,ananta@chromium.org NOTREECHECKS=true NOTRY=true BUG=436146 Review URL: https://codereview.chromium.org/755063002 Cr-Commit-Position: refs/heads/master@{#305568}
* Attempt to fix a DirectWrite metrics retrieval browser crasher in Canary.ananta2014-11-251-6/+16
| | | | | | | | | | | | | | | | | | | | The crash occurs because the IDWriteFactory::GetSystemFontCollection method returns E_INVALIDARG. From some analysis of the crash dumps it appears that the crashes are mostly coming from Windows 7 version 6.1.7600.* and dwrite version 6.1.7600.16972. We tried the same version of dwrite locally in a VM where things work correctly though. In any case the fix attempted here is to check the return from the SkFontMgr_New_DirectWrite call. If we get back a NULL factory then it probably means that the skia factory init failed. There is code in the SkFontMgr_New_DirectWrite function to get the system font collection. If that call fails the function returns NULL. We should not attempt to use DW in that case. The other change is to use a ScopedComPtr for the IDWriteFactory interface in the MaybeEnableDirectWriteFontRendering function. Will see how this plays in tomorrows canary. BUG=436146 Review URL: https://codereview.chromium.org/744463004 Cr-Commit-Position: refs/heads/master@{#305566}
* Do not start RunLoop of MessagePumpForUI in NestedMessagePumpAndroidjaekyun2014-11-191-1/+2
| | | | | | | | | | | | | | | MessagePumpForUI starts one RunLoop in Start(), and so all other RunLoops attached to NestedMessagePumpAndroid become nested to the first one. This CL modifies NestedMessagePumpAndroid not to call methods of MessagePumpForUI including Start(). And a quit request to finish the first RunLoop of MessagePumpForUI will be ignored when it wasn't started. BUG=432737 Review URL: https://codereview.chromium.org/733533002 Cr-Commit-Position: refs/heads/master@{#304709}
* Enable DirectWrite for font metrics and font rendering in Chrome UI on ↵ananta2014-11-171-2/+2
| | | | | | | | | | | | Windows by default. We have a switch --disable-directwrite-for-ui to switch back to GDI. BUG=389649 Review URL: https://codereview.chromium.org/726893005 Cr-Commit-Position: refs/heads/master@{#304487}
* Fixed font metrics calculations if DirectWrite font rendering is enabled in ↵ananta2014-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | the browser. Fixes as below:- 1. The current code in the PlatformFontWin::CreateHFontRefFromSkia function was ceiling the ascent and descent before calculating the height of the font. We now use std::round(Descent - ascent) to mirror the logic in skia and RenderTextHarfBuzz. 2. Skia does not return all metrics we need like the capHeight which indicates the height of capital letters. This information is returned by DirectWrite. I added code to retrieve the font metrics from DirectWrite in the CreateFontRefFromSkia function and used this to calculate the cap height. The rest of the metrics are retrieved from skia as before. 3. We use the capHeight calculated in step 2 to calculate the internal leading value which is the leading space in the bounds for the glyph. The internal leading value is not returned by DirectWrite. We use this to calculate the font size which ensures that characters now show up in the desired size instead of giant size as seen today. 4. I removed the set_use_skia_for_font_metrics function from PlatformFontWin and added a new function SetDirectWriteFactory which is used to pass in the global directwrite factory by content. We use the factory to retrieve metrics from DirectWrite. BUG=432086, 431377, 432105 Review URL: https://codereview.chromium.org/721163003 Cr-Commit-Position: refs/heads/master@{#304293}
* Retrieve font metrics from skia if DirectWrite is enabled for font metrics ↵ananta2014-11-041-1/+2
| | | | | | | | | | | | | | | | | | | | calculations in the chrome browser UI. The previous patch for getting the correct font metrics from DirectWrite https://codereview.chromium.org/692633003/ was wrong as it did not return the correct font metrics in all cases. Getting the metrics from skia ensures that we get the same font metrics which would be used by skia for rendering. Changes in this patch are as below:- 1. Removed DirectWrite factory code from PlatformFontWin. The PlatformFontWin::ConvertGDIFontToDirectWriteFont function has been replaced by the CreateHFontRefFromSkia function. This function is called if DirectWrite is enabled in the browser which sets a static bool on the PlatformFontWin class. BUG=428645,427804,427802 Review URL: https://codereview.chromium.org/696913002 Cr-Commit-Position: refs/heads/master@{#302547}
* Use the correct font metrics in base PlatformFontWin if DirectWrite is used ↵ananta2014-10-301-3/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in the browser for font metrics. The PlatformFontWin class uses GDI for creating fonts and their metrics. If DirectWrite is used for font metrics then the metrics returned by GDI for the fonts and those calculated by skia using DirectWrite differ leading to text getting clipped etc. DirectWrite provides an interface IDWriteGdiInterop for interoperability with GDI. Converting the GDI font to a DirectWrite font face object (IDWriteFontFace) and then converting this back to a GDI font gives us the correct metrics. The other option could be to create a PlatformFontSkia class on the same lines as PlatformFontWin and use skia to get the font metrics. The amount of work needed there is unkown. We could look at this as a possible alternative in case the above approach does not work. Changes in this patch are as below:- 1. We use DirectWrite to create a IDWriteFactory interface in content browser. This is passed down to skia as the default factory. 2. The factory created in step 1 is also passsed via a static setter function to the PlatformFontWin class. The presence of a non NULL IDWriteFactory interface is used by this class to create a DirectWrite metrics compatible GDI font. 3. HarfBuzz text rendering is enabled by default in the browser. The MaybeEnableDirectWriteFontRendering function now checks for the disable harfbuzz text rendering switch instead. BUG=427804,427802 Review URL: https://codereview.chromium.org/692633003 Cr-Commit-Position: refs/heads/master@{#301987}
* Standardize usage of virtual/override/final in content/browser/dcheng2014-10-211-4/+4
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/667943003 Cr-Commit-Position: refs/heads/master@{#300469}
* Add support for enabling DirectWrite for font rendering in Chrome UI.ananta2014-10-151-0/+17
| | | | | | | | | | | | | | This is enabled if Harf Buzz text rendering is enabled and if the enable-directwrite-for-ui switch is passed in the command line. To enable DirectWrite we use the SkFontMgr_New_DirectWrite function in skia which sets up skia to use DirectWrite for font rendering. This is done once during startup. BUG=389649 Review URL: https://codereview.chromium.org/655613003 Cr-Commit-Position: refs/heads/master@{#299612}
* Replace FINAL and OVERRIDE with their C++11 counterparts in contentmohan.reddy2014-10-091-3/+3
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/637183002 Cr-Commit-Position: refs/heads/master@{#298804}
* Use sidestep to detour CertVerifyCertificateSignatureEx on Windows versions ↵rsleevi2014-09-241-0/+87
| | | | | | | | | | | | | | earlier than Vista (excluding XP SP3), adding in SHA-256 support by deferring to NSS. The canonical path to supporting SHA-256 is to install XP SP3 or the appropriate hotfixes for XP x64 / Windows Server 2003. However, as not all users may do so, and there's enough of a usability hurdle, provide an interception hook until we fully drop support for these systems. XP is already outside of MSFT EOL (April 2014). Windows Server 2003 is EOL'd July 2015. BUG=401365 Review URL: https://codereview.chromium.org/561613002 Cr-Commit-Position: refs/heads/master@{#296335}
* Add base:: qualification to some COmmandLine references in content.brettw@chromium.org2014-08-111-1/+2
| | | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/456513002 Cr-Commit-Position: refs/heads/master@{#288787} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288787 0039d316-1c4b-4281-b951-d872f2087c98
* Store unsaved trace data on exit.alemate@chromium.org2014-07-021-3/+18
| | | | | | | | | | | | | This CL enables chromeos chrome startup trace when chrome in restarted on user log in: startup trace should be saved to disk on process exit if "trace-startup-duration" period has not ended yet. BUG=346913 TEST=manual Review URL: https://codereview.chromium.org/359473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281061 0039d316-1c4b-4281-b951-d872f2087c98
* Calling Shutdown() for Android content_browsertests. Removed webrtc test hack.starodub@google.com2014-06-181-1/+6
| | | | | | | | | | | | | | Should be landed after: https://codereview.chromium.org/323513003/ https://codereview.chromium.org/314293004/ which fix related shutdown issues. BUG=367409,373249 Review URL: https://codereview.chromium.org/319053006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277998 0039d316-1c4b-4281-b951-d872f2087c98
* content: Terminate early if the toolkit initialization fails.sadrul@chromium.org2014-04-251-1/+2
| | | | | | | | | | | | | | On Chrome OS, it is possible for chrome to start without the X11 server (e.g. X server has crashed, and hasn't restarted since). In such cases, Chrome ends up causing a crash. So instead of the crash, abort the startup sequence if the toolkit initialization step fails. BUG=364929 R=jam@chromium.org Review URL: https://codereview.chromium.org/250723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266231 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r156303 as non-Aura Metro mode is goneyukawa@chromium.org2014-02-031-8/+3
| | | | | | | | | | | | | | | We no longer need to support TSF in the browser code. Now TSF-related code is completely consolidated into the metro_driver process and the browser process doesn't need to know about TSF any more. Note: TSF-related code remaining in base/win/metro.{cc, h} and content/browser/browser_main_runner.{h, cc} will be reverted by subsequent CLs. BUG=319122, 330735 Review URL: https://codereview.chromium.org/137493006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248475 0039d316-1c4b-4281-b951-d872f2087c98
* Invoke LeakSanitizer in BrowserMainRunnerImpl::Shutdown().earthdok@chromium.org2013-11-201-0/+9
| | | | | | | | | | | | | | We call LeakSanitizer in BrowserProcessImpl::ReleaseModule to avoid shutdown-only leaks, but this doesn't work for processes that never create a BrowserProcess object (e.g. in content_browsertests). Add another call to LSan to cover this case. BUG=307043 R=sky@chromium.org Review URL: https://codereview.chromium.org/78053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236310 0039d316-1c4b-4281-b951-d872f2087c98
* Adding shutdown tracing capabilitiesskuhne@chromium.org2013-09-061-9/+22
| | | | | | | | | | | | | | | use "--trace-shutdown" to enable the feature to start profiling when the user has pressed "shutdown" and specify "--trace-shutdown-file=<name>" to specify the file where you want to dump to. Additionally you can specify which modules to trace with e.g. "--trace-shutdown=base,net". That said: NOTE that the dumping will cost time since it has to be done after the shutdown of Chrome is finished. As such it takes time and will make it impossible to get a correct reading of time from shutdown till a new startup is finished. Note: This is similar to the trace-startup - with the exception that upon shutdown it is not possible to rely on threads for IO anymore. BUG=281524 TEST=visual tests Review URL: https://chromiumcodereview.appspot.com/23691025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221631 0039d316-1c4b-4281-b951-d872f2087c98
* Allow overlapping sync and async startup requestsaberent@chromium.org2013-08-271-47/+54
| | | | | | | | | | | | | | | On Android we can get a second request to start the browser while the an asynchronous request is in progress. Since the second request may be synchronous, we may have switch to completing initialization synchronously. This patch handles this by tracking which initialization tasks have been run, and running the remaining initialization tasks. BUG=260574 Review URL: https://chromiumcodereview.appspot.com/22691002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 218551 "Reland 217049 "Make sure unexpected exit paths ge..."rvargas@google.com2013-08-211-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Reland 217049 "Make sure unexpected exit paths ge..." > > ... to be reverted after Tomorrow's canary. > > > Revert 217049 "Make sure unexpected exit paths generate crash du..." > > > > (this will be merged on a dedicated canary) > > > > > Make sure unexpected exit paths generate crash dumps for the browser. > > > > > > Right now it is possible for some random code to directly terminate the > > > browser process without generating a crash dump. This CL should fix that. > > > > > > BUG=275818 > > > TEST=none > > > R=jam@chromium.org > > > > > > Review URL: https://codereview.chromium.org/22264015 > > > > TBR=rvargas@chromium.org > > > > Review URL: https://codereview.chromium.org/22877003 > > TBR=rvargas@google.com > > Review URL: https://codereview.chromium.org/23054010 TBR=rvargas@google.com Review URL: https://codereview.chromium.org/23383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218774 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 217049 "Make sure unexpected exit paths ge..."rvargas@google.com2013-08-201-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... to be reverted after Tomorrow's canary. > Revert 217049 "Make sure unexpected exit paths generate crash du..." > > (this will be merged on a dedicated canary) > > > Make sure unexpected exit paths generate crash dumps for the browser. > > > > Right now it is possible for some random code to directly terminate the > > browser process without generating a crash dump. This CL should fix that. > > > > BUG=275818 > > TEST=none > > R=jam@chromium.org > > > > Review URL: https://codereview.chromium.org/22264015 > > TBR=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/22877003 TBR=rvargas@google.com Review URL: https://codereview.chromium.org/23054010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218551 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 217049 "Make sure unexpected exit paths generate crash du..."rvargas@google.com2013-08-121-12/+0
| | | | | | | | | | | | | | | | | | | | | (this will be merged on a dedicated canary) > Make sure unexpected exit paths generate crash dumps for the browser. > > Right now it is possible for some random code to directly terminate the > browser process without generating a crash dump. This CL should fix that. > > BUG=none > TEST=none > R=jam@chromium.org > > Review URL: https://codereview.chromium.org/22264015 TBR=rvargas@chromium.org Review URL: https://codereview.chromium.org/22877003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217053 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure unexpected exit paths generate crash dumps for the browser.rvargas@chromium.org2013-08-121-0/+12
| | | | | | | | | | | | | Right now it is possible for some random code to directly terminate the browser process without generating a crash dump. This CL should fix that. BUG=none TEST=none R=jam@chromium.org Review URL: https://codereview.chromium.org/22264015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217049 0039d316-1c4b-4281-b951-d872f2087c98
* Run the later parts of startup as UI thread tasksaberent@chromium.org2013-08-011-12/+3
| | | | | | | | | | | | | | | This CL splits the later parts of startup, from thread creation onwards, into multiple UI thread tasks. Depending on the StartupTaskRunner passed to CreateThreads the tasks are all run immediately, or are queued one at a time on the UI thread. This, on platforms where the UI is already running, allows the UI to remain interactive while Chrome is initialized. BUG=231856 Review URL: https://chromiumcodereview.appspot.com/19957002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix --wait-for-debugger.mkosiba@chromium.org2013-06-171-0/+5
| | | | | | | | | | | | The shared --wait-for-debugger check was removed in r204569, this adds the check back. BUG=None R=scottmg@chromium.org Review URL: https://chromiumcodereview.appspot.com/17031007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206781 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform-neutral initialize/shutdown functions for IMEYukawa@chromium.org2013-06-121-8/+4
| | | | | | | | | | | This patch set replaces platform-specific initialize/shutdown functions for IME with platform-neutral ones. BUG=246534 Review URL: https://chromiumcodereview.appspot.com/16258007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205801 0039d316-1c4b-4281-b951-d872f2087c98
* Enable TsfBridge to re-initializeYukawa@chromium.org2013-06-101-1/+1
| | | | | | | | | | | | | | | Currently we cannot re-initialize TsfBridge once TsfBridge::Shutdown is called. This patch set gets rid of such limitation. This is mainly for unit test, where TsfBridge::Initialize is called in its Setup function. BUG=246534 TEST=Manually done with GoogleJapaneseInput. Review URL: https://chromiumcodereview.appspot.com/16648002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205271 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of child-only code from content/common to content/childscottmg@chromium.org2013-06-061-10/+1
| | | | | | | | | | | | Was just trying to move content/common/resource_dispatcher.{cc,h}, but that ends up needing a lot of other things to move. TBR=jam@chromium.org BUG=246357 Review URL: https://codereview.chromium.org/16328003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204569 0039d316-1c4b-4281-b951-d872f2087c98
* [Chromium] Add tracing to startup process, particularly for Androidandrewhayden@chromium.org2013-05-031-0/+1
| | | | | | | | BUG=222350 Review URL: https://chromiumcodereview.appspot.com/13820011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198078 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, content/ edition.rsleevi@chromium.org2013-02-121-1/+1
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12210030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181822 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize Ole before message pump so that TSF module can interact with ↵Yukawa@chromium.org2013-01-151-1/+7
| | | | | | | | | | | | | | message pump. This is a preparation change to fix Google Drive (Google Document) compatibility issue. The main part of the fix is moved to https://codereview.chromium.org/11889008 BUG=168993 TEST=Manually done with --enable-text-services-framework command-line flag on Windows 8. Review URL: https://chromiumcodereview.appspot.com/11778081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176783 0039d316-1c4b-4281-b951-d872f2087c98
* Add a quick fix against crash, for Windows XP/Office 2003 users.Yukawa@chromium.org2012-11-151-0/+11
| | | | | | | | | | | | | | A user who is using Office 2003 without applying SP3 on Windows XP where "Extend support of advanced text services to all programs" (a.k.a. CUAS) is enabled cannot use Chrome because Chrome crashes just after launched. This crash happens inside Ink modules (TSF-based handwriting modules) and I guess we need to disable TSF on XP. I kept this patchset as simple as possible so that merge request can be safe. For the consistency, I'm planning to add a high-level wrapper for ImmDisableTextFrameService API instead of calling it directly. BUG=160914 TEST=Manually tested on Windows XP Review URL: https://chromiumcodereview.appspot.com/11359206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167806 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Initialize the DataFetcherImplAndroiddfalcantara@chromium.org2012-11-101-10/+0
| | | | | | | | | | | | Upstreaming changes to run the initialization; it doesn't seem to be called anywhere in chromium at the moment. BUG=159063 Review URL: https://chromiumcodereview.appspot.com/11312130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167039 0039d316-1c4b-4281-b951-d872f2087c98
* Clean Up: TSF related stuffnona@chromium.org2012-11-021-5/+5
| | | | | | | | | | | | | | | This clean up CL contains: 1. Rename TSF acronym from Tsf to TSF based on 11141019. 2. Use STDMETHOD_ instead of STDMETHODIMP suggested on 11235023. 3. Use override comment suggested on 11235023 BUG=None TBR=mark@chromium.org TEST=checked on Windows 8 and try bots Review URL: https://chromiumcodereview.appspot.com/11341036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 165430 - fix win_aura not getting swap_ack (Suspect this revision ↵kbr@chromium.org2012-11-021-5/+0
| | | | | | | | | | | | | | | | | | introduced renderer hangs with threaded compositor on non-Aura Windows builds.) (hangs win aura rendering on startup) Regressed at https://chromiumcodereview.appspot.com/11341033/ R=vangelis@chromium.org, jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/11363018 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/11359041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165693 0039d316-1c4b-4281-b951-d872f2087c98
* fix win_aura not getting swap_ackscottmg@chromium.org2012-11-011-0/+5
| | | | | | | | | | | | | (hangs win aura rendering on startup) Regressed at https://chromiumcodereview.appspot.com/11341033/ R=vangelis@chromium.org, jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/11363018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165430 0039d316-1c4b-4281-b951-d872f2087c98
* Move remaining files in content\browser to the content namespace.jam@chromium.org2012-10-301-16/+8
| | | | | | Review URL: https://codereview.chromium.org/11340029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164828 0039d316-1c4b-4281-b951-d872f2087c98
* content/browser: Move notification_service_impl into content namespace.tfarina@chromium.org2012-10-301-0/+1
| | | | | | | | R=jam@chromium.org Review URL: https://codereview.chromium.org/11340018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164793 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 164120 - content/browser: Move more files into the content namespace.sail@chromium.org2012-10-251-7/+9
| | | | | | | | | | | | | | | Fixed most of the files found with the following command line: $ git grep --files-without-match --name-only "namespace content {" -- content/browser/{*.cc,*.h.*.mm} R=jam@chromium.org Review URL: https://codereview.chromium.org/11274038 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/11273049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164122 0039d316-1c4b-4281-b951-d872f2087c98
* content/browser: Move more files into the content namespace.tfarina@chromium.org2012-10-251-9/+7
| | | | | | | | | | | | Fixed most of the files found with the following command line: $ git grep --files-without-match --name-only "namespace content {" -- content/browser/{*.cc,*.h.*.mm} R=jam@chromium.org Review URL: https://codereview.chromium.org/11274038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164120 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-23 10:18:24 +0000