summaryrefslogtreecommitdiffstats
path: root/content/browser/child_process_launcher.cc
Commit message (Collapse)AuthorAgeFilesLines
...
* Synchronize the parent and child processes during launch, ensuring that themark@chromium.org2011-09-011-23/+27
| | | | | | | | | | | | | | | | | | | | | child doesn't try to check in with the Mach broker before the parent is ready. This resolves a race between the browser and its child processes. base::LaunchOptions gets a new member, synchronize, currently Mac-only although there's nothing Mac-specific about the implementation. When set, it allows base::LaunchProcess clients to request that the child process block until released by the new base::LaunchSynchronize call. When creating child processes, the child process launcher now requests this new synchronization behavior to give it a chance to set up the Mach broker to expect the child before the child tries to check in with it. BUG=94295 TEST=Chrome should work. You see fewer of this logged: Unknown process (pid) is sending Mach IPC messages! But you still might see some of these due to bug 94543. Review URL: http://codereview.chromium.org/7740036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99245 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup code used to diagnose and fix bug 81449.apatrick@chromium.org2011-08-191-11/+0
| | | | | | | | | | I think it is unlikely that CloseHandle was the function that was being hooked because it is called from so many other places without problems. I am assuming that TerminateProcess was being hooked. If the symptoms of 81449 return when this is landed, this patch can be reverted. BUG=81449 Review URL: http://codereview.chromium.org/7624052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97407 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug that caused Task Manager to display defunct GPU processes after they ↵jbates@chromium.org2011-07-251-5/+19
| | | | | | | | | | | | | were killed. This change makes it OK to call GetChildTerminationStatus after the process handle has been nulled out. Previously, the process kill notification was never getting sent out because of the check for a null handle. Also verified that the related bug fix (http://code.google.com/p/chromium/issues/detail?id=88769) is still fixed. BUG=89488 TEST=open CSS Poster Circle page; open Task Manager; kill GPU process; verify there are not two GPU processes in the Task Manager. Review URL: http://codereview.chromium.org/7466013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93927 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at splitting result codes between content and chrome.dpranke@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | content/common/result_codes.h contains only the codes defined in content. chrome/common/chrome_result_codes.h contains the codes defined in chrome and also includes (for convenience) the content header. R=jam@chromium.org BUG=76699 TEST=everything compiles Review URL: http://codereview.chromium.org/7397004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93082 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the Chrome Linux zygote to support a ZygoteForkHelper for flexiblebradchen@google.com2011-07-181-3/+3
| | | | | | | | | | | | | fork implementations. BUG=nativeclient:480 TEST=existing zygote tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92787 Review URL: http://codereview.chromium.org/7397003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92858 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 92787 - Modify the Chrome Linux zygote to support a ZygoteForkHelper ↵rsleevi@chromium.org2011-07-161-3/+3
| | | | | | | | | | | | | | | | | | | | | for flexible fork implementations. BUG=nativeclient:480 TEST=existing zygote tests Review URL: http://codereview.chromium.org/7397003 TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7400014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92789 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the Chrome Linux zygote to support a ZygoteForkHelper for flexiblebradchen@google.com2011-07-161-3/+3
| | | | | | | | | | | | | | | | fork implementations. BUG=nativeclient:480 TEST=existing zygote tests Review URL: http://codereview.chromium.org/7397003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92787 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r92730, r92731, r92732 ... will land again once I ensure the win ↵dpranke@chromium.org2011-07-151-1/+1
| | | | | | | | | | | | | builds compile. TBR=jam@chromium.org BUG=none TEST= Review URL: http://codereview.chromium.org/7400002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92733 0039d316-1c4b-4281-b951-d872f2087c98
* This change will split the result codes between content and chrome.dpranke@chromium.org2011-07-151-1/+1
| | | | | | | | | | | | | | | This adds a new file into chrome/common and does a lot of renaming. The current version is just a sketch of the headers, and nothing will compile. R=jam@chromium.org BUG=76699 TEST=everything still compiles and runs Review URL: http://codereview.chromium.org/7377010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92730 0039d316-1c4b-4281-b951-d872f2087c98
* Change base::LaunchProcess API slightlyevan@chromium.org2011-07-151-2/+1
| | | | | | | | | | | Rather than passing the out param process handle via the options, take it as a function argument. This simplifies many callers. BUG=88990 Review URL: http://codereview.chromium.org/7377012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-121-4/+9
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7258005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92200 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90805 - I am submitting this with LGTMs from agl@ and evanm@. I'm ↵fischman@chromium.org2011-06-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | marking this as TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7230057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90813 0039d316-1c4b-4281-b951-d872f2087c98
* I am submitting this with LGTMs from agl@ and evanm@. I'm marking this as ↵bradchen@google.com2011-06-281-3/+3
| | | | | | | | | | | | | | | | | | | | TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90805 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90681 - New NaCl zygote implementation 2, in which Chrome zygote ↵fischman@chromium.org2011-06-281-3/+3
| | | | | | | | | | | | | | | | forks a NaCl helper. This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 TBR=bradchen@google.com Review URL: http://codereview.chromium.org/7274011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90682 0039d316-1c4b-4281-b951-d872f2087c98
* New NaCl zygote implementation 2, in which Chrome zygote forks a NaCl helper.bradchen@google.com2011-06-271-3/+3
| | | | | | | | | | | This patch can launch earth_c.html with and without the SUID sandbox. It is enabled with the environment variable NACL_NEW_ZYGOTE. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS Review URL: http://codereview.chromium.org/6995121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90681 0039d316-1c4b-4281-b951-d872f2087c98
* Move MachBroker to content.jam@chromium.org2011-06-231-1/+1
| | | | | | | BUG=76697 Review URL: http://codereview.chromium.org/7232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90236 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flag to print the handles held by a child process when it shuts down.cdn@chromium.org2011-06-091-0/+15
| | | | | | | | | This will allow us to make tests that audit for extra handles and permissions being added to sandboxed processes. BUG=85212 Review URL: http://codereview.chromium.org/7054080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88602 0039d316-1c4b-4281-b951-d872f2087c98
* Replace OS_LINUX ifdefs with OS_POSIX & !OS_MACOSX, TOOLKIT_USES_GTK, ortony@chromium.org2011-05-311-18/+16
| | | | | | | | | | | USE_X11 where possible. An earlier version of this patch was used to build Chromium on FreeBSD, OpenBSD, and Solaris. Patch by ruben (chromium@hybridsource.org) Review URL: http://codereview.chromium.org/7006006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87382 0039d316-1c4b-4281-b951-d872f2087c98
* Move sandbox_policy to content.jam@chromium.org2011-05-281-1/+1
| | | | | | | BUG=76697 Review URL: http://codereview.chromium.org/7084010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87183 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of content dependency from sandbox_policy.hjam@chromium.org2011-05-271-1/+1
| | | | | | | BUG=76697 Review URL: http://codereview.chromium.org/7074025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87093 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off optimization for ChildProcessLauncher::Context::TerminateInternal.apatrick@chromium.org2011-05-271-0/+11
| | | | | | | | | This is to try and get more information about a crash. BUG=81449 Review URL: http://codereview.chromium.org/6976042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87052 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86532 - Revert 86517 - Don't terminate plugin processes from the ↵ananta@chromium.org2011-05-251-1/+19
| | | | | | | | | | | | | | | | | | | | | browser during browser shutdown. This is to allow the plugins to shutdown gracefully, i.e. NP_Shutdown gets called. To ensure that we handle the case of a hung plugin, we handle the OnChannelError notification in the IPC message filter implementation in the plugin process and post a delayed task to kill the process. Fixes bug http://code.google.com/p/chromium/issues/detail?id=48178 BUG=48178 Review URL: http://codereview.chromium.org/6992006 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/7065048 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/7053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86554 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86517 - Don't terminate plugin processes from the browser during ↵nsylvain@chromium.org2011-05-251-19/+1
| | | | | | | | | | | | | | | | | | browser shutdown. This is to allow the plugins to shutdown gracefully, i.e. NP_Shutdown gets called. To ensure that we handle the case of a hung plugin, we handle the OnChannelError notification in the IPC message filter implementation in the plugin process and post a delayed task to kill the process. Fixes bug http://code.google.com/p/chromium/issues/detail?id=48178 BUG=48178 Review URL: http://codereview.chromium.org/6992006 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/7065048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86532 0039d316-1c4b-4281-b951-d872f2087c98
* Don't terminate plugin processes from the browser during browser shutdown. ↵ananta@chromium.org2011-05-241-1/+19
| | | | | | | | | | | | | | | This is to allow the plugins to shutdown gracefully, i.e. NP_Shutdown gets called. To ensure that we handle the case of a hung plugin, we handle the OnChannelError notification in the IPC message filter implementation in the plugin process and post a delayed task to kill the process. Fixes bug http://code.google.com/p/chromium/issues/detail?id=48178 BUG=48178 Review URL: http://codereview.chromium.org/6992006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86517 0039d316-1c4b-4281-b951-d872f2087c98
* Remove safe_browsing code from BrowserRenderProcessHost. Also remove crash ↵jam@chromium.org2011-05-021-21/+4
| | | | | | | | | reporting glue in content. BUG=77089,77093 Review URL: http://codereview.chromium.org/6901137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83734 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash reporting for ppapipiman@google.com2011-04-151-31/+26
| | | | | | | | | BUG=chromium-os:13952 TEST=run chrome with CHROME_HEADLESS=1 and pepper flash, kill -11 the ppapi process, check that a report gets written to disk Review URL: http://codereview.chromium.org/6864005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81813 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the cgroups config we have in chromeosdavemoore@chromium.org2011-03-241-3/+12
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6713089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79308 0039d316-1c4b-4281-b951-d872f2087c98
* Move the renderer_web* files to content.jam@chromium.org2011-03-181-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6713024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78643 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-171-2/+2
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the temporary headers left behind in chrome\browser. I've left ↵jam@chromium.org2011-03-011-2/+2
| | | | | | | | | browser_thread.h for another change, since 450 files include it. TBR=avi Review URL: http://codereview.chromium.org/6596060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76326 0039d316-1c4b-4281-b951-d872f2087c98
* Move core pieces of chrome\browser. I've only gone up to "g", will do the ↵jam@chromium.org2011-02-221-0/+348
rest in another cl. TBR=avi Review URL: http://codereview.chromium.org/6538100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75652 0039d316-1c4b-4281-b951-d872f2087c98